mlb_stats_api 0.2.5 → 0.4.0

data/lib/mlb_stats_api/leagues.rb

@@ -2,7 +2,6 @@
 
 module MLBStatsAPI
   # Operations pertaining to leagues
-  # @see https://statsapi.mlb.com/docs/#tag/league
   module Leagues
     LEAGUES = {
       american: 103,
@@ -24,37 +23,31 @@ module MLBStatsAPI
     }.freeze
 
     # View league information.
-    # @see https://statsapi.mlb.com/docs/#operation/league
-    def leagues(options = {})
-      unless options[:sportId] || options[:leagueIds]
-        raise ArgumentError, '#leagues requires a sportId or leagueIds'
-      end
+    def leagues(**options)
+      raise ArgumentError, '#leagues requires a sportId or leagueIds' unless options[:sportId] || options[:leagueIds]
 
-      get '/league', options
+      get '/league', **options
     end
 
     # View All-Star Ballots per league.
-    # @see https://statsapi.mlb.com/docs/#operation/allStarBallot
-    def all_star_ballot(league_id, season = nil, options = {})
+    def all_star_ballot(league_id, season = nil, **options)
       options[:season] = season || Time.now.year
 
-      get "/league/#{league_id}/allStarBallot", options
+      get "/league/#{league_id}/allStarBallot", **options
     end
 
     # View All-Star Write-ins per league.
-    # @see https://statsapi.mlb.com/docs/#operation/allStarWriteIns
-    def all_star_write_ins(league_id, season = nil, options = {})
+    def all_star_write_ins(league_id, season = nil, **options)
       options[:season] = season || Time.now.year
 
-      get "/league/#{league_id}/allStarWriteIns", options
+      get "/league/#{league_id}/allStarWriteIns", **options
     end
 
     # View All-Star Final Vote per league.
-    # @see https://statsapi.mlb.com/docs/#operation/allStarFinalVote
-    def all_star_final_vote(league_id, season = nil, options = {})
+    def all_star_final_vote(league_id, season = nil, **options)
       options[:season] = season || Time.now.year
 
-      get "/league/#{league_id}/allStarFinalVote", options
+      get "/league/#{league_id}/allStarFinalVote", **options
     end
   end
 end

data/lib/mlb_stats_api/live_feed.rb

@@ -5,48 +5,31 @@ module MLBStatsAPI
     attr_reader :id
 
     def initialize(api, data)
+      super(data)
+
       @api = api
-      @data = data
 
       # If we need to nuke and start over, keep this piece
       @id = data['gamePk']
     end
 
-    def boxscore
-      @data['liveData']['boxscore']
-    end
+    def game_data = @data['gameData']
 
-    def decisions
-      @data['liveData']['decisions']
-    end
+    def live_data = @data['liveData']
 
-    def leaders
-      @data['liveData']['leaders']
-    end
+    def metadata = @data['metaData']
 
-    def linescore
-      @data['liveData']['linescore']
-    end
+    def boxscore = @data.dig('liveData', 'boxscore')
 
-    def plays
-      @data['liveData']['plays']
-    end
+    def decisions = @data.dig('liveData', 'decisions')
 
-    def game_data
-      @data['gameData']
-    end
+    def leaders = @data.dig('liveData', 'leaders')
 
-    def live_data
-      @data['liveData']
-    end
+    def linescore = @data.dig('liveData', 'linescore')
 
-    def metadata
-      @data['metaData']
-    end
+    def plays = @data.dig('liveData', 'plays')
 
-    def timestamps
-      @api.live_feed_timestamps(@id)
-    end
+    def timestamps = @api.live_feed_timestamps(@id)
 
     def reload!
       @data = @api.get("/game/#{@id}/feed/live", version: '1.1')
@@ -61,7 +44,7 @@ module MLBStatsAPI
 
       diffs = @api.live_feed_diff(
         @data['gamePk'],
-        timecode: @data['metaData']['timeStamp']
+        timecode: @data.dig('metaData', 'timeStamp')
       )
 
       return process_diffs(diffs) if diffs.is_a?(Array)

data/lib/mlb_stats_api/people.rb

@@ -2,14 +2,12 @@
 
 module MLBStatsAPI
   # Operations pertaining to players, umpires, and coaches
-  # @see https://statsapi.mlb.com/docs/#tag/person
   module People
     # View one or more person's stats and biographical information.
-    # @see https://statsapi.mlb.com/docs/#operation/person
-    def person(person_ids, options = {})
+    def person(person_ids, **options)
       ids = Array(person_ids)
 
-      result = get('/people', options.merge(personIds: ids)).dig('people')
+      result = get('/people', **options.merge(personIds: ids))['people']
 
       return result.first if ids.length == 1
 
@@ -18,11 +16,10 @@ module MLBStatsAPI
     alias people person
 
     # View a player's stats for a specific game.
-    # @see https://statsapi.mlb.com/docs/#operation/currentGameStats
-    def person_game_stats(person_id, options = {})
+    def person_game_stats(person_id, **options)
       game = options.delete(:gamePk) || 'current'
 
-      get("/people/#{person_id}/stats/game/#{game}", options).dig('stats')
+      get("/people/#{person_id}/stats/game/#{game}", **options)['stats']
     end
   end
 end

data/lib/mlb_stats_api/schedules.rb

@@ -10,15 +10,12 @@ module MLBStatsAPI
       tune_in: '/schedule/postseason/tuneIn'
     }.freeze
 
-    def schedule(type = :default, options = {})
-      if type.is_a?(Hash) && options.empty?
-        options = type
-        type = :default
-      end
+    def schedule(**options)
+      endpoint = SCHEDULE_TYPES[options.delete(:type) || :default]
 
-      raise ArgumentError, 'invalid schedule type' unless SCHEDULE_TYPES[type]
+      raise ArgumentError, 'Invalid schedule type.' unless endpoint
 
-      get SCHEDULE_TYPES[type], { sportId: 1 }.merge(options)
+      get endpoint, **{ sportId: 1 }.merge(options)
     end
   end
 end

data/lib/mlb_stats_api/seasons.rb

@@ -2,18 +2,11 @@
 
 module MLBStatsAPI
   # Operations pertaining to seasons
-  # @see https://statsapi.mlb.com/docs/#tag/season
   module Seasons
     # View current season info.
-    # @see https://statsapi.mlb.com/docs/#operation/seasons
-    def seasons(options = {})
-      get '/seasons', { sportId: 1 }.merge(options)
-    end
+    def seasons(**options) = get('/seasons', **{ sportId: 1 }.merge(options))
 
     # View information on an individual season.
-    # @see https://statsapi.mlb.com/docs/#operation/seasons
-    def season(year, options = {})
-      get "/seasons/#{year}", { sportId: 1 }.merge(options)
-    end
+    def season(year, **options) = get("/seasons/#{year}", **{ sportId: 1 }.merge(options))
   end
 end

data/lib/mlb_stats_api/sports.rb

@@ -2,26 +2,14 @@
 
 module MLBStatsAPI
   # Operations pertaining to sports
-  # @see https://statsapi.mlb.com/docs/#tag/sports
   module Sports
-    # View information for all sportIds.
-    # @see https://statsapi.mlb.com/docs/#operation/sports
-    def sports
-      get '/sports'
-    end
+    # View information for all sports.
+    def sports = get('/sports')
 
-    # View information for any given sportId.
-    # @see https://statsapi.mlb.com/docs/#operation/sports
-    def sport(sport_id, options = {})
-      get "/sports/#{sport_id}", options
-    end
+    # View information for any given sport ID.
+    def sport(sport_id, **options) = get("/sports/#{sport_id}", **options)
 
-    # View information on a players for a given sportId.
-    # @see https://statsapi.mlb.com/docs/#operation/sportPlayers
-    def sport_players(sport_id, season, options = {})
-      options[:season] = season
-
-      get "/sports/#{sport_id}/players", options
-    end
+    # View information on all players for a given sport ID, optionally filtered by season.
+    def sport_players(sport_id, season, **options) = get("/sports/#{sport_id}/players", **options.merge(season:))
   end
 end

data/lib/mlb_stats_api/standings.rb

@@ -2,11 +2,9 @@
 
 module MLBStatsAPI
   # Operations pertaining to standings
-  # @see https://statsapi.mlb.com/docs/#tag/standings
   module Standings
     # View standings for a league.
-    # @see https://statsapi.mlb.com/docs/#operation/standings
-    def standings(options = {})
+    def standings(**options)
       options[:hydrate] = 'team' unless options.key?(:hydrate)
 
       if options[:leagues] && !options[:leagueId]
@@ -17,7 +15,7 @@ module MLBStatsAPI
 
       options[:leagueId] = [103, 104] unless Array(options[:leagueId])&.any?
 
-      get '/standings', options
+      get '/standings', **options
     end
   end
 end

data/lib/mlb_stats_api/stats.rb

@@ -2,25 +2,20 @@
 
 module MLBStatsAPI
   # Operations pertaining to stats
-  # @see https://statsapi.mlb.com/docs/#tag/stats
   module Stats
     # View statistics based on statType, group, season, and organization.
-    # @see https://statsapi.mlb.com/docs/#operation/stats
-    def stats(options = {})
+    def stats(**options)
       raise ArgumentError, '#stats requires a stats arg' unless options[:stats]
       raise ArgumentError, '#stats requires a group arg' unless options[:group]
 
-      get '/stats', options
+      get '/stats', **options
     end
 
     # View leaders for a statistic.
-    # @see https://statsapi.mlb.com/docs/#operation/leaders
-    def stats_leaders(options = {})
-      unless options[:leaderCategories]
-        raise ArgumentError, '#stats_leaders requires a leaderCategories arg'
-      end
+    def stats_leaders(**options)
+      raise ArgumentError, '#stats_leaders requires a leaderCategories arg' unless options[:leaderCategories]
 
-      get '/stats/leaders', options
+      get '/stats/leaders', **options
     end
   end
 end

data/lib/mlb_stats_api/team.rb

@@ -2,46 +2,26 @@
 
 module MLBStatsAPI
   class Team < Base
-    def id
-      @data['id']
-    end
+    def id = @data['id']
 
-    def name
-      @data['teamName']
-    end
+    def name = @data['teamName']
 
-    def location
-      @data['locationName']
-    end
+    def location = @data['locationName']
 
-    def abbreviation
-      @data['abbreviation']
-    end
+    def abbreviation = @data['abbreviation']
     alias code abbreviation
 
-    def file_code
-      @data['fileCode']
-    end
+    def file_code = @data['fileCode']
 
-    def short_name
-      @data['shortName']
-    end
+    def short_name = @data['shortName']
 
-    def league_id
-      @data.dig('league', 'id')
-    end
+    def league_id = @data.dig('league', 'id')
 
-    def division_id
-      @data.dig('division', 'id')
-    end
+    def division_id = @data.dig('division', 'id')
 
-    def full_name
-      @data['name']
-    end
+    def full_name = @data['name']
 
     # So we don't get huge printouts
-    def inspect
-      %(#<MLBGameday::Team @name="#{name}">)
-    end
+    def inspect = %(#<MLBGameday::Team @name="#{name}">)
   end
 end

data/lib/mlb_stats_api/teams.rb

@@ -26,36 +26,24 @@ module MLBStatsAPI
       teams.concat load_teams_by_id(ids)
     end
 
-    def affiliates(team_id, season: nil)
-      get "/teams/#{team_id}/affiliates", season: season
-    end
-
-    def coaches(team_id, date: nil)
-      date ||= Date.today
+    def affiliates(team_id, season: nil) = get("/teams/#{team_id}/affiliates", season:)
 
-      get "/teams/#{team_id}/coaches", date: date.strftime('%m/%d/%Y')
-    end
+    def coaches(team_id, date: nil) = get("/teams/#{team_id}/coaches", date: (date || Date.today).strftime('%m/%d/%Y'))
 
-    # def leaders(team_id)
-    #   get("/teams/#{team_id}/leaders")
-    # end
+    # def leaders(team_id) = get("/teams/#{team_id}/leaders")
 
-    def roster(team_id, type:, date: nil)
-      get "/teams/#{team_id}/roster/#{type}", date: date.strftime('%m/%d/%Y')
-    end
+    def roster(team_id, type:, date: nil) = get("/teams/#{team_id}/roster/#{type}", date: date.strftime('%m/%d/%Y'))
 
     protected
 
     def load_teams_by_id(ids)
       return [] if ids.none?
 
-      get('/teams', teamId: ids.join(','), hydrate: 'venue(timezone)')
-        .dig('teams')
-        .map do |data|
-          @cache.store("mlb_stats_api:teams:#{data['id']}", data)
+      get('/teams', teamId: ids.join(','), hydrate: 'venue(timezone)')['teams'].map do |data|
+        @cache.store("mlb_stats_api:teams:#{data['id']}", data)
 
-          MLBStatsAPI::Team.new(data)
-        end
+        MLBStatsAPI::Team.new(data)
+      end
     end
   end
 end

data/lib/mlb_stats_api/venues.rb

@@ -2,12 +2,8 @@
 
 module MLBStatsAPI
   # Operations pertaining to venues
-  # @see https://statsapi.mlb.com/docs/#tag/venue
   module Venues
-    # View information for a venue based on venueId.
-    # @see https://statsapi.mlb.com/docs/#operation/venues
-    def venue(venue_id)
-      get("/venues/#{venue_id}").dig('venues', 0)
-    end
+    # View information for a venue based on venue ID.
+    def venue(venue_id) = get("/venues/#{venue_id}").dig('venues', 0)
   end
 end

data/lib/mlb_stats_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MLBStatsAPI
-  VERSION = '0.2.5'
+  VERSION = '0.4.0'
 end

data/mlb_stats_api.gemspec

@@ -9,24 +9,27 @@ Gem::Specification.new do |spec|
   spec.version = MLBStatsAPI::VERSION
   spec.authors = ['Steven Hoffman']
   spec.email = ['git@fustrate.com']
+  spec.metadata = {
+    'rubygems_mfa_required' => 'true'
+  }
 
   spec.summary = %(MLB has a new Stats API!)
   spec.homepage = 'http://github.com/fustrate/mlb_stats_api'
   spec.license = 'MIT'
+  spec.required_ruby_version = '>= 3.1.0'
 
-  spec.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(test|spec|features)/})
-  end
+  spec.files = `git ls-files -z`.split("\x0").reject { _1.match(%r{^(test|spec|features)/}) }
   spec.bindir = 'exe'
-  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables = spec.files.grep(%r{^exe/}) { File.basename(_1) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '> 1.16'
-  spec.add_development_dependency 'rake', '> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.8'
-  spec.add_development_dependency 'webmock', '~> 3.4'
+  spec.add_development_dependency 'bundler', '> 2.3'
+  spec.add_development_dependency 'rake', '> 13.0'
+  spec.add_development_dependency 'rspec', '~> 3.11'
+  spec.add_development_dependency 'rubocop', '~> 1.37'
+  spec.add_development_dependency 'webmock', '~> 3.18'
 
   spec.add_dependency 'hana', '~> 1.3'
-  spec.add_dependency 'httparty', '~> 0.16'
-  spec.add_dependency 'moneta', '~> 1.0'
+  spec.add_dependency 'httparty', '~> 0.20'
+  spec.add_dependency 'moneta', '~> 1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mlb_stats_api
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.4.0
 platform: ruby
 authors:
 - Steven Hoffman
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-03-28 00:00:00.000000000 Z
+date: 2022-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,56 +16,70 @@ dependencies:
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.11'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.37'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.37'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.18'
 - !ruby/object:Gem::Dependency
   name: hana
   requirement: !ruby/object:Gem::Requirement
@@ -86,38 +100,39 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.20'
 - !ruby/object:Gem::Dependency
   name: moneta
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-description: 
+        version: '1.5'
+description:
 email:
 - git@fustrate.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rspec.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".vscode/settings.json"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -152,8 +167,9 @@ files:
 homepage: http://github.com/fustrate/mlb_stats_api
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -161,15 +177,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.23
+signing_key:
 specification_version: 4
 summary: MLB has a new Stats API!
 test_files: []

data/.travis.yml

@@ -1,6 +0,0 @@
-sudo: false
-language: ruby
-script: bundle exec rake
-rvm:
-  - 2.5.1
-before_install: gem install bundler -v 1.16.6