mlb_gd2 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 451f0d0d4e7e2d2a679f770c9947ca73954c2a34
-  data.tar.gz: b951fdc9d2f34164ace157c46b8ce6fbc3495c6c
+  metadata.gz: b41f7e49bc5202d26ab922b5ac7db4d9381e3546
+  data.tar.gz: 40bd6864d0ac255e73111225fe7a4840995c1468
 SHA512:
-  metadata.gz: 254765e777b468fa155acd428131f3a4d579cd9d5d3b14fb452653134459a51a011652ebb27f59520a5d974b5b0d7e957f33106b628037e0a9ac44b18db2f395
-  data.tar.gz: c3f475bf07c57290bccc64918c6c5929967b143cd3f6fb137d5c3f11ea3bc47c9bf3cdbe9f17a4b0eae38b2bd969136a606206fb65975d39ddb2c41b9129807e
+  metadata.gz: 65efc088f49a55c0b10d6a64c5de0fa1e09c7796a9f3c7ddc7094b50b3972c70c18e69bc8228065f1f7ba096b6a97044d461f03587d2f35072e9064a889081d4
+  data.tar.gz: df5cd2efb5bd7208b3038a5a11a16f8b69d80e849237326c454eb5b4a49a07e47629e60955fc420a2f8ce2ba2a473426bb9d3c8e523dedb5cbc9ae867128368e

data/lib/mlb_gd2/game.rb

@@ -1,11 +1,14 @@
 require "net/http"
 require "nokogiri"
+require_relative "./helpers"
 
 class Game
 
+  include Helpers
+
   def initialize(url)
     @url = url
-    @boxscore = GamedayUrlBuilder.generate_nokogiri_xml(url + 'boxscore.xml').xpath("//boxscore").first
+    @boxscore = generate_nokogiri_xml(url + 'boxscore.xml').xpath("//boxscore").first
   end
 
   def teams

data/lib/mlb_gd2/gameday.rb

@@ -1,17 +1,23 @@
 require "net/http"
 require "nokogiri"
+require_relative "./helpers"
 
 class Gameday
 
+  include Helpers
+
   attr_reader :games, :date
 
   def initialize(year, month, day)
     date_time = Time.new(year, month, day)
-    base_url = GamedayUrlBuilder.build_base_url(date_time)
+    base_url = build_base_url(date_time)
 
-    @games = GamedayUrlBuilder.generate_nokogiri_html(base_url).search('a[href^="gid"]').map do |link|
+    @games = []
+    generate_nokogiri_html(base_url).search('a[href^="gid"]').each do |link|
       gid = link.attributes["href"].value
-      Game.new(base_url + gid)
+      if valid_game?(base_url + gid)
+        @games << Game.new(base_url + gid)
+      end
     end
     @date = date_time.strftime("%B %-d, %Y")
   end

data/lib/mlb_gd2/{gameday_helpers.rb → helpers.rb}

@@ -1,20 +1,24 @@
 require "net/http"
 require "nokogiri"
 
-class GamedayUrlBuilder
+module Helpers
 
   GD2_MLB_BASE = "http://gd2.mlb.com/components/game/mlb"
 
-  def self.build_base_url(date)
+  def build_base_url(date)
     GD2_MLB_BASE + date.strftime("/year_%Y/month_%m/day_%d/")
   end
 
-  def self.generate_nokogiri_html(url)
+  def generate_nokogiri_html(url)
     Nokogiri::HTML(Net::HTTP.get(URI(url)))
   end
 
-  def self.generate_nokogiri_xml(url)
+  def generate_nokogiri_xml(url)
     Nokogiri::XML(Net::HTTP.get(URI(url)))
   end
 
+  def valid_game?(url)
+    generate_nokogiri_xml(url).xpath('//a').map { |link| link.attribute('href').value }.include? "boxscore.xml"
+  end
+
 end

data/lib/mlb_gd2.rb

@@ -1,3 +1,2 @@
 require 'mlb_gd2/game'
-require 'mlb_gd2/gameday'
-require 'mlb_gd2/gameday_helpers'
+require 'mlb_gd2/gameday'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mlb_gd2
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Henry Firth
@@ -33,7 +33,7 @@ files:
 - lib/mlb_gd2.rb
 - lib/mlb_gd2/game.rb
 - lib/mlb_gd2/gameday.rb
-- lib/mlb_gd2/gameday_helpers.rb
+- lib/mlb_gd2/helpers.rb
 homepage: http://rubygems.org/gems/mlb_gd2
 licenses:
 - MIT