mjml-rb 0.3.5 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5eb69fb3fdaed9855a8fa7f791aecf11332bc08dbf5415237e792b48debaf00a
-  data.tar.gz: 15926b8c8af6b74f69ce4d579909fc9059a56b07cdd9fbe6d6007a375caf38c4
+  metadata.gz: 414eb19865bc6fe6432e0ed0576001365e2c7fcc9e6133005bf4f4cefc89f35b
+  data.tar.gz: 420df02142daf9807af8fa96d2ad0ca5ca13f68ffa737781c4c38a85c176d29b
 SHA512:
-  metadata.gz: ea326cf19e80f7fb403e8d2fa32b5ec8d7383538cde6d8ca2062e01ffbd3ffd8ffa0db116215dd16f70134ade1b759458e8c35ca46ba3224b56ec5f7810757d3
-  data.tar.gz: 1c46e6d13a3c0d7c77313f5e2c8a8cbf3bf3a6cc250dc09e08f806a220c2b8fb1dc276f99c5db22f3210b928f01769893265d95d73d6ccb32ea509da9d507404
+  metadata.gz: 77e7e40b344e0560b75ec58d1a5e0364f2b8c148f985cba18c77cc678114381416157709db251ef6e3762886a286b2da2d8bb7e38cbfaed07006ed9161c1d0fe
+  data.tar.gz: 2511e7880dcb3dccb36dd97228f1e49b9384b0e2f31ed0c51b91db1287d56bd9c5a40f81637dc30cfb783fbd743129523fffcb93e19cab220227f3e6cd836745

data/README.md

@@ -1,16 +1,13 @@
 # MJML Ruby Implementation
 
-> **⚠️ EXPERIMENTAL — USE AT YOUR OWN RISK**
->
-> This is an **unofficial, experimental** Ruby port of the MJML email framework.
-> It is **not affiliated with or endorsed by the MJML team**.
-> The output HTML may differ from the reference `mjml` npm package in subtle ways,
-> and not all components or attributes are fully implemented yet.
-> **Do not use in production without thorough testing of every template against
-> the official npm renderer.** API and output format may change without notice.
-> This is a **fully open source project**, and help is welcome:
-> feedback, bug reports, test cases, optimizations, proposals, and pull requests.
-> No warranty of any kind is provided.
+> **Note:** This is an unofficial Ruby port of the MJML email framework,
+> not affiliated with or endorsed by the MJML team.
+> All 22 MJML v4 components are implemented and tested against npm MJML v4.18.0.
+> Output may differ from the npm renderer in cosmetic ways (whitespace, attribute ordering)
+> but renders identically across email clients.
+> We recommend testing your templates when migrating from the npm renderer.
+> This is a **fully open source project** — feedback, bug reports, test cases,
+> and pull requests are welcome!
 
 This gem provides a Ruby-first implementation of the main MJML tooling:
 
@@ -20,6 +17,8 @@ This gem provides a Ruby-first implementation of the main MJML tooling:
 - pure Ruby parser, AST, validator, and renderer
 - no Node.js runtime and no shelling out to the official npm renderer
 
+Remaining parity work is tracked in [npm ↔ Ruby Parity Audit](docs/PARITY_AUDIT.md).
+
 ## Compatibility
 
 This project targets **MJML v4 only**.
@@ -205,5 +204,3 @@ If you want the full internal walkthrough, see [docs/ARCHITECTURE.md](docs/ARCHI
 > plain Ruby project and render MJML templates the same way you render ERB — no
 > extra runtime, no
 > `package.json`, no `node_modules`.
-
-Remaining parity work is tracked in [npm ↔ Ruby Parity Audit](docs/PARITY_AUDIT.md).

data/lib/mjml-rb/components/carousel_image.rb

@@ -92,7 +92,7 @@ module MjmlRb
         <<~HTML.chomp
           <a#{html_attrs(link_attrs)}>
             <label#{html_attrs(label_attrs)}>
-              #{build_img_tag(image_attrs)}
+              <img#{html_attrs(image_attrs)} />
             </label>
           </a>
         HTML
@@ -117,7 +117,7 @@ module MjmlRb
           "width" => container_width.to_i.to_s,
           "border" => "0"
         }
-        image_tag = build_img_tag(img_attrs)
+        image_tag = "<img#{html_attrs(img_attrs)} />"
 
         content = if a["href"]
                     link_attrs = {
@@ -146,17 +146,6 @@ module MjmlRb
         classes.split(/\s+/).map { |klass| "#{klass}-#{suffix}" }.join(" ")
       end
 
-      def build_img_tag(attrs)
-        ordered_keys = %w[title src alt style width border]
-        rendered = ordered_keys.filter_map do |key|
-          next unless attrs.key?(key)
-          next if attrs[key].nil?
-
-          %(#{key}="#{escape_attr(attrs[key].to_s)}")
-        end
-
-        "<img #{rendered.join(' ')} />"
-      end
     end
   end
 end

data/lib/mjml-rb/components/social.rb

@@ -304,11 +304,16 @@ module MjmlRb
           "display"       => "block"
         )
 
-        # alt must always be rendered (even as alt=""), so build img tag manually
-        img_tag = build_img_tag(
-          alt: alt_val, title: title_val, src: src,
-          style: img_style, width: icon_width, sizes: sizes_attr, srcset: srcset
-        )
+        img_attrs = {
+          "alt" => alt_val,
+          "title" => title_val,
+          "src" => src,
+          "style" => img_style.empty? ? nil : img_style,
+          "width" => icon_width,
+          "sizes" => sizes_attr,
+          "srcset" => srcset
+        }
+        img_tag = "<img#{html_attrs(img_attrs)} />"
 
         if has_link
           link_attrs_str = html_attrs({ "href" => final_href, "rel" => rel_val, "target" => target_val })
@@ -360,17 +365,6 @@ module MjmlRb
         %(<tr#{tr_class}>#{cells}</tr>)
       end
 
-      # Build an <img> tag — nil attributes are omitted, empty strings preserved.
-      def build_img_tag(alt:, title:, src:, style:, width:, sizes:, srcset:)
-        parts = [%( alt="#{escape_attr(alt.to_s)}")]
-        parts << %( title="#{escape_attr(title)}") unless title.nil?
-        parts << %( src="#{escape_attr(src)}") unless src.nil?
-        parts << %( style="#{style}") unless style.nil? || style.empty?
-        parts << %( width="#{escape_attr(width)}") unless width.nil?
-        parts << %( sizes="#{escape_attr(sizes)}") unless sizes.nil?
-        parts << %( srcset="#{escape_attr(srcset)}") unless srcset.nil?
-        "<img#{parts.join} />"
-      end
     end
   end
 end

data/lib/mjml-rb/version.rb

@@ -1,3 +1,3 @@
 module MjmlRb
-  VERSION = "0.3.5".freeze
+  VERSION = "0.3.7".freeze
 end

data/mjml-rb.gemspec

@@ -18,6 +18,6 @@ Gem::Specification.new do |spec|
   spec.bindir = "bin"
   spec.executables = ["mjml"]
   spec.require_paths = ["lib"]
-  spec.add_dependency "nokogiri"
-  spec.add_dependency "rexml"
+  spec.add_dependency "nokogiri", ">= 1.13"
+  spec.add_dependency "rexml", ">= 3.2.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mjml-rb
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.7
 platform: ruby
 authors:
 - Andrei Andriichuk
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: rexml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.5
 description: Ruby-first MJML compiler API and CLI with compatibility-focused behavior.
 email:
 - andreiandriichuk@gmail.com