mjml-rb 0.3.4 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c87c74bfccdb5ffe347fba7099a9f17855e1c42446b1edd0d013dbfa08fe5c67
-  data.tar.gz: b18e8124ded52ecc49a7d43f00da55ff902068f3b1593d195aaecb95e042346f
+  metadata.gz: 8416ab91e9a9d1c4addbbed2368136715d3726b5524e3cce2f27865c5522b6f2
+  data.tar.gz: 576c18c2307ca32b30012e2e91450b2888e1f6cf13c9398bd0c7da7ef616bb7d
 SHA512:
-  metadata.gz: 0e4714a86a42c8270a6ec66a8b7d50bc21f54ea9d0aebb8cbf5424fac2af621de1ab8fa79d8b51cdc92954b615e8c66dd55e499593dec4861a65052b6c7eacab
-  data.tar.gz: 80f36f9bea2094a8a13b8bffea1b8b3c3f62b67bfefb44a540ecdc96b479dc50366f7ca182f5f601387f31e8dc44cebf6c9c60c0f8761dfa530ad27aca9e6419
+  metadata.gz: c3ed81729d5550ae8611f0b4fd17545373b8c4041fc286f655c6c975be42182aab441a8c11d07e7a15578a55a6d83849e33e4507f99f45d925ea81212e04607c
+  data.tar.gz: e407a972325006108bce56759035dfa0b00f93d1917c162d04c2c2ad3d299c0bb03f15a36d3f49c6a26d3d3e2ee058f45fbf29c96a016034c85372af87db4404

data/README.md

@@ -20,6 +20,8 @@ This gem provides a Ruby-first implementation of the main MJML tooling:
 - pure Ruby parser, AST, validator, and renderer
 - no Node.js runtime and no shelling out to the official npm renderer
 
+Remaining parity work is tracked in [npm ↔ Ruby Parity Audit](docs/PARITY_AUDIT.md).
+
 ## Compatibility
 
 This project targets **MJML v4 only**.
@@ -205,5 +207,3 @@ If you want the full internal walkthrough, see [docs/ARCHITECTURE.md](docs/ARCHI
 > plain Ruby project and render MJML templates the same way you render ERB — no
 > extra runtime, no
 > `package.json`, no `node_modules`.
-
-Remaining parity work is tracked in [npm ↔ Ruby Parity Audit](docs/PARITY_AUDIT.md).

data/lib/mjml-rb/components/carousel_image.rb

@@ -92,7 +92,7 @@ module MjmlRb
         <<~HTML.chomp
           <a#{html_attrs(link_attrs)}>
             <label#{html_attrs(label_attrs)}>
-              #{build_img_tag(image_attrs)}
+              <img#{html_attrs(image_attrs)} />
             </label>
           </a>
         HTML
@@ -117,7 +117,7 @@ module MjmlRb
           "width" => container_width.to_i.to_s,
           "border" => "0"
         }
-        image_tag = build_img_tag(img_attrs)
+        image_tag = "<img#{html_attrs(img_attrs)} />"
 
         content = if a["href"]
                     link_attrs = {
@@ -146,17 +146,6 @@ module MjmlRb
         classes.split(/\s+/).map { |klass| "#{klass}-#{suffix}" }.join(" ")
       end
 
-      def build_img_tag(attrs)
-        ordered_keys = %w[title src alt style width border]
-        rendered = ordered_keys.filter_map do |key|
-          next unless attrs.key?(key)
-          next if key != "alt" && (attrs[key].nil? || attrs[key].to_s.empty?)
-
-          %(#{key}="#{escape_attr(attrs[key].to_s)}")
-        end
-
-        "<img #{rendered.join(' ')} />"
-      end
     end
   end
 end

data/lib/mjml-rb/components/social.rb

@@ -304,11 +304,16 @@ module MjmlRb
           "display"       => "block"
         )
 
-        # alt must always be rendered (even as alt=""), so build img tag manually
-        img_tag = build_img_tag(
-          alt: alt_val, title: title_val, src: src,
-          style: img_style, width: icon_width, sizes: sizes_attr, srcset: srcset
-        )
+        img_attrs = {
+          "alt" => alt_val,
+          "title" => title_val,
+          "src" => src,
+          "style" => img_style.empty? ? nil : img_style,
+          "width" => icon_width,
+          "sizes" => sizes_attr,
+          "srcset" => srcset
+        }
+        img_tag = "<img#{html_attrs(img_attrs)} />"
 
         if has_link
           link_attrs_str = html_attrs({ "href" => final_href, "rel" => rel_val, "target" => target_val })
@@ -360,17 +365,6 @@ module MjmlRb
         %(<tr#{tr_class}>#{cells}</tr>)
       end
 
-      # Build an <img> tag where alt is always rendered (even as alt="")
-      def build_img_tag(alt:, title:, src:, style:, width:, sizes:, srcset:)
-        parts = [%( alt="#{escape_attr(alt.to_s)}")]
-        parts << %( title="#{escape_attr(title)}") unless title.nil? || title.to_s.empty?
-        parts << %( src="#{escape_attr(src)}") unless src.nil? || src.to_s.empty?
-        parts << %( style="#{style}") unless style.nil? || style.empty?
-        parts << %( width="#{escape_attr(width)}") unless width.nil? || width.to_s.empty?
-        parts << %( sizes="#{escape_attr(sizes)}") unless sizes.nil? || sizes.to_s.empty?
-        parts << %( srcset="#{escape_attr(srcset)}") unless srcset.nil? || srcset.to_s.empty?
-        "<img#{parts.join} />"
-      end
     end
   end
 end

data/lib/mjml-rb/renderer.rb

@@ -830,16 +830,13 @@ module MjmlRb
       CGI.escapeHTML(value.to_s)
     end
 
-    # HTML attributes that are meaningful even when empty.
-    # `alt=""` signals a decorative image to browsers, suppressing the
-    # broken-image placeholder icon.
-    KEEP_WHEN_EMPTY = Set.new(%w[alt]).freeze
-
+    # Match npm MJML behaviour: omit only nil/undefined attributes.
+    # lodash `omitBy(attributes, isNil)` keeps empty strings, so we do the same.
+    # This preserves semantically meaningful empty values like `alt=""`.
     def html_attrs(hash)
       attrs = hash.each_with_object([]) do |(key, value), memo|
-        if value.nil? || value.to_s.empty?
-          next unless KEEP_WHEN_EMPTY.include?(key) && !value.nil?
-        end
+        next if value.nil?
+
         memo << %(#{key}="#{escape_attr(value)}")
       end
       return "" if attrs.empty?

data/lib/mjml-rb/version.rb

@@ -1,3 +1,3 @@
 module MjmlRb
-  VERSION = "0.3.4".freeze
+  VERSION = "0.3.6".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mjml-rb
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.6
 platform: ruby
 authors:
 - Andrei Andriichuk