mjml-rb 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c87c74bfccdb5ffe347fba7099a9f17855e1c42446b1edd0d013dbfa08fe5c67
-  data.tar.gz: b18e8124ded52ecc49a7d43f00da55ff902068f3b1593d195aaecb95e042346f
+  metadata.gz: 5eb69fb3fdaed9855a8fa7f791aecf11332bc08dbf5415237e792b48debaf00a
+  data.tar.gz: 15926b8c8af6b74f69ce4d579909fc9059a56b07cdd9fbe6d6007a375caf38c4
 SHA512:
-  metadata.gz: 0e4714a86a42c8270a6ec66a8b7d50bc21f54ea9d0aebb8cbf5424fac2af621de1ab8fa79d8b51cdc92954b615e8c66dd55e499593dec4861a65052b6c7eacab
-  data.tar.gz: 80f36f9bea2094a8a13b8bffea1b8b3c3f62b67bfefb44a540ecdc96b479dc50366f7ca182f5f601387f31e8dc44cebf6c9c60c0f8761dfa530ad27aca9e6419
+  metadata.gz: ea326cf19e80f7fb403e8d2fa32b5ec8d7383538cde6d8ca2062e01ffbd3ffd8ffa0db116215dd16f70134ade1b759458e8c35ca46ba3224b56ec5f7810757d3
+  data.tar.gz: 1c46e6d13a3c0d7c77313f5e2c8a8cbf3bf3a6cc250dc09e08f806a220c2b8fb1dc276f99c5db22f3210b928f01769893265d95d73d6ccb32ea509da9d507404

data/lib/mjml-rb/components/carousel_image.rb

@@ -150,7 +150,7 @@ module MjmlRb
         ordered_keys = %w[title src alt style width border]
         rendered = ordered_keys.filter_map do |key|
           next unless attrs.key?(key)
-          next if key != "alt" && (attrs[key].nil? || attrs[key].to_s.empty?)
+          next if attrs[key].nil?
 
           %(#{key}="#{escape_attr(attrs[key].to_s)}")
         end

data/lib/mjml-rb/components/social.rb

@@ -360,15 +360,15 @@ module MjmlRb
         %(<tr#{tr_class}>#{cells}</tr>)
       end
 
-      # Build an <img> tag where alt is always rendered (even as alt="")
+      # Build an <img> tag — nil attributes are omitted, empty strings preserved.
       def build_img_tag(alt:, title:, src:, style:, width:, sizes:, srcset:)
         parts = [%( alt="#{escape_attr(alt.to_s)}")]
-        parts << %( title="#{escape_attr(title)}") unless title.nil? || title.to_s.empty?
-        parts << %( src="#{escape_attr(src)}") unless src.nil? || src.to_s.empty?
+        parts << %( title="#{escape_attr(title)}") unless title.nil?
+        parts << %( src="#{escape_attr(src)}") unless src.nil?
         parts << %( style="#{style}") unless style.nil? || style.empty?
-        parts << %( width="#{escape_attr(width)}") unless width.nil? || width.to_s.empty?
-        parts << %( sizes="#{escape_attr(sizes)}") unless sizes.nil? || sizes.to_s.empty?
-        parts << %( srcset="#{escape_attr(srcset)}") unless srcset.nil? || srcset.to_s.empty?
+        parts << %( width="#{escape_attr(width)}") unless width.nil?
+        parts << %( sizes="#{escape_attr(sizes)}") unless sizes.nil?
+        parts << %( srcset="#{escape_attr(srcset)}") unless srcset.nil?
         "<img#{parts.join} />"
       end
     end

data/lib/mjml-rb/renderer.rb

@@ -830,16 +830,13 @@ module MjmlRb
       CGI.escapeHTML(value.to_s)
     end
 
-    # HTML attributes that are meaningful even when empty.
-    # `alt=""` signals a decorative image to browsers, suppressing the
-    # broken-image placeholder icon.
-    KEEP_WHEN_EMPTY = Set.new(%w[alt]).freeze
-
+    # Match npm MJML behaviour: omit only nil/undefined attributes.
+    # lodash `omitBy(attributes, isNil)` keeps empty strings, so we do the same.
+    # This preserves semantically meaningful empty values like `alt=""`.
     def html_attrs(hash)
       attrs = hash.each_with_object([]) do |(key, value), memo|
-        if value.nil? || value.to_s.empty?
-          next unless KEEP_WHEN_EMPTY.include?(key) && !value.nil?
-        end
+        next if value.nil?
+
         memo << %(#{key}="#{escape_attr(value)}")
       end
       return "" if attrs.empty?

data/lib/mjml-rb/version.rb

@@ -1,3 +1,3 @@
 module MjmlRb
-  VERSION = "0.3.4".freeze
+  VERSION = "0.3.5".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mjml-rb
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Andrei Andriichuk