mjml-rb 0.3.2 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a961ff4aa96b2bc79520f261eb233c0e8b77f363afa3d7e0c670fa622359ab7
-  data.tar.gz: 295a1289237c408dbcd2752c26bc45c9b16dd80edfe00933bcec864bf250bebf
+  metadata.gz: c87c74bfccdb5ffe347fba7099a9f17855e1c42446b1edd0d013dbfa08fe5c67
+  data.tar.gz: b18e8124ded52ecc49a7d43f00da55ff902068f3b1593d195aaecb95e042346f
 SHA512:
-  metadata.gz: e544b134c2db7296c58cd9a5c6235b5780448a3673618ae5392ca6eeada84cafa67d88ad7cf1e8aab99aa41ab92feabcc3255ec7eb30ccdbd386b52cc73515ba
-  data.tar.gz: 3751e0e61fcfd95378c03d1024caa4dcc4ccc0e7dd1f92a08108afe98c5858cff3d2c31e8a551185a145c44e36e96d7d934fcfc4cd86168fad8ec74650192661
+  metadata.gz: 0e4714a86a42c8270a6ec66a8b7d50bc21f54ea9d0aebb8cbf5424fac2af621de1ab8fa79d8b51cdc92954b615e8c66dd55e499593dec4861a65052b6c7eacab
+  data.tar.gz: 80f36f9bea2094a8a13b8bffea1b8b3c3f62b67bfefb44a540ecdc96b479dc50366f7ca182f5f601387f31e8dc44cebf6c9c60c0f8761dfa530ad27aca9e6419

data/lib/mjml-rb/renderer.rb

@@ -1,5 +1,6 @@
 require "cgi"
 require "nokogiri"
+require "set"
 require_relative "components/accordion"
 require_relative "components/attributes"
 require_relative "components/body"
@@ -539,6 +540,7 @@ module MjmlRb
         existing[property] = merged
       end
       normalize_background_fallbacks!(node, existing)
+      sync_html_attributes!(node, existing)
       node["style"] = serialize_css_declarations(existing)
     end
 
@@ -552,12 +554,59 @@ module MjmlRb
           important: declarations.fetch("background-color", {}).fetch(:important, false)
         }
       end
+    end
+
+    # Sync HTML attributes from inlined CSS declarations.
+    # Mirrors Juice's attribute syncing: width/height on TABLE/TD/TH/IMG,
+    # and style-to-attribute mappings (bgcolor, background, align, valign)
+    # on table-related elements.
+    # See: https://github.com/Automattic/juice/blob/master/lib/inline.js
+    WIDTH_HEIGHT_ELEMENTS = Set.new(%w[table td th img]).freeze
+    TABLE_ELEMENTS = Set.new(%w[table th tr td caption colgroup col thead tbody tfoot]).freeze
+    STYLE_TO_ATTRIBUTE = {
+      "background-color" => "bgcolor",
+      "background-image" => "background",
+      "text-align" => "align",
+      "vertical-align" => "valign"
+    }.freeze
+
+    def sync_html_attributes!(node, declarations)
+      tag = node.name.downcase
 
-      return unless node.name == "td"
-      return unless node["bgcolor"]
-      return if %w[none transparent].include?(background_color.downcase)
+      # Sync width/height on TABLE, TD, TH, IMG
+      if WIDTH_HEIGHT_ELEMENTS.include?(tag)
+        %w[width height].each do |prop|
+          css_value = declaration_value(declarations[prop])
+          next if css_value.nil? || css_value.empty?
+
+          # Convert CSS px values to plain numbers for HTML attributes;
+          # keep other values (auto, %) as-is.
+          html_value = css_value.sub(/px\z/i, "")
+          node[prop] = html_value
+        end
+      end
 
-      node["bgcolor"] = background_color
+      # Sync style-to-attribute mappings on table elements
+      if TABLE_ELEMENTS.include?(tag)
+        STYLE_TO_ATTRIBUTE.each do |css_prop, html_attr|
+          css_value = declaration_value(declarations[css_prop])
+          next if css_value.nil? || css_value.empty?
+
+          case html_attr
+          when "bgcolor"
+            next if %w[none transparent].include?(css_value.downcase)
+            node[html_attr] = css_value
+          when "background"
+            # Extract url(...) from background-image
+            url = css_value[/url\(['"]?([^'")]+)['"]?\)/i, 1]
+            node[html_attr] = url if url
+          when "align"
+            node[html_attr] = css_value
+          when "valign"
+            node[html_attr] = css_value
+          end
+        end
+      end
     end
 
     def syncable_background?(value)
@@ -781,9 +830,16 @@ module MjmlRb
       CGI.escapeHTML(value.to_s)
     end
 
+    # HTML attributes that are meaningful even when empty.
+    # `alt=""` signals a decorative image to browsers, suppressing the
+    # broken-image placeholder icon.
+    KEEP_WHEN_EMPTY = Set.new(%w[alt]).freeze
+
     def html_attrs(hash)
       attrs = hash.each_with_object([]) do |(key, value), memo|
-        next if value.nil? || value.to_s.empty?
+        if value.nil? || value.to_s.empty?
+          next unless KEEP_WHEN_EMPTY.include?(key) && !value.nil?
+        end
         memo << %(#{key}="#{escape_attr(value)}")
       end
       return "" if attrs.empty?

data/lib/mjml-rb/version.rb

@@ -1,3 +1,3 @@
 module MjmlRb
-  VERSION = "0.3.2".freeze
+  VERSION = "0.3.4".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mjml-rb
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.4
 platform: ruby
 authors:
 - Andrei Andriichuk