mjml-rails 4.7.1 → 4.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ebd64fc82073044b83d2bd5096e1355b090787801ad1fb6c9b23249e231bd45f
-  data.tar.gz: 886fdabc4294dfe23a5f6d19d1540461b167a6842fff7ea857c5e11439a5ea08
+  metadata.gz: 79d635939113a77bdcfa96934cafa71e52a13c71171eb36c138250952e0df2de
+  data.tar.gz: 5943d70d89ef0d1ce8ba63c32dd72e6837982938b4fbe59e6e4cf5088f04b16b
 SHA512:
-  metadata.gz: d51cfa58a1add61294b64065073896162198037a31866f0642cf2b7203cbcdb29809ae1e02d2f7b307b0a1741b539c1d7d88162739de1105cc8ab70a32c45417
-  data.tar.gz: 6f5ea97fbf1e47526fbf5c205ab72ef0cb91c567a44b64d8db62755056a2be4c699b951e49c9668ec6fbe18fd73cbb2947eaed6b423416d3fb0cb25326d5b3d5
+  metadata.gz: 00a5e9270464c12f16f0b7b8f3e32dc9c0c20413d34063c33c4b86bec08eb7df1c2d5ae20beb61d9f708242203c6c33b663652a207e135ef658cc6636497dcec
+  data.tar.gz: bab11c714982bca667864e180e9c6066c4a22221dff010a19ffd179b25f79dff8a9de4809af5217ec82d62291835aecf231d79b6ecd255f5bd71e4ba3829365e

data/lib/mjml/parser.rb

@@ -41,7 +41,12 @@ module Mjml
         command = "-r #{in_tmp_file} -o #{out_tmp_file.path} " \
                   "--config.beautify #{beautify} --config.minify #{minify} --config.validationLevel #{validation_level}"
         _, stderr, status = Mjml.run_mjml(command)
-        raise ParseError, stderr.chomp unless status.success?
+
+        unless status.success?
+          # The process status ist quite helpful in case of dying processes without STDERR output.
+          # Node exit codes are documented here: https://node.readthedocs.io/en/latest/api/process/#exit-codes
+          raise ParseError, "#{stderr.chomp}\n(process status: #{status})"
+        end
 
         Mjml.logger.warn(stderr.chomp) if stderr.present?
         out_tmp_file.read

data/lib/mjml/version.rb

@@ -2,5 +2,5 @@
 
 module Mjml
   # Version number no longer matches MJML.io version
-  VERSION = '4.7.1'
+  VERSION = '4.8.0'
 end

data/lib/mjml.rb

@@ -71,9 +71,9 @@ module Mjml
 
   def self.check_for_yarn_mjml_binary
     yarn_bin = `which yarn`.chomp
-    return if yarn_bin.blank?
+    return unless yarn_bin.present? && (installer_path = bin_path_from(yarn_bin)).present?
 
-    mjml_bin = "#{yarn_bin} run mjml"
+    mjml_bin = File.join(installer_path, 'mjml')
     return mjml_bin if check_version(mjml_bin)
   end
 

data/test/parser_test.rb

@@ -66,9 +66,16 @@ describe Mjml::Parser do
 
   describe '#run' do
     describe 'when shell command failed' do
+      let(:error_msg) do
+        expect { parser.run '/tmp/non_existent_file.mjml' }.must_raise(Mjml::Parser::ParseError).message
+      end
+
       it 'raises exception' do
-        err = expect { parser.run '/tmp/non_existent_file.mjml' }.must_raise(Mjml::Parser::ParseError)
-        expect(err.message).must_include 'Command line error'
+        expect(error_msg).must_include 'Command line error'
+      end
+
+      it 'includes process status' do
+        expect(error_msg).must_match(/\(process status: .+\)/)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mjml-rails
 version: !ruby/object:Gem::Version
-  version: 4.7.1
+  version: 4.8.0
 platform: ruby
 authors:
 - Simon Loffler
@@ -35,7 +35,7 @@ cert_chain:
   R9NsaxhBfawJEJcYoPZflGkLjJU8pjSuvIW5+rNgAiqY8D37hTtZMu/n2Fz8Qp24
   7EZetZmcvBzARf8vQSJjga3y0Bftk8u7LmblOEWddzE=
   -----END CERTIFICATE-----
-date: 2021-12-21 00:00:00.000000000 Z
+date: 2022-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug