mixpal 0.4.0 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70923329c62f76ee4d6b0796547cdd2e367038940c30d8f5ccb10b044f506d36
-  data.tar.gz: 492801097fa1ac2fb85f4600273b2db3fc6e0e8383c9b17112e0302100fc9020
+  metadata.gz: 9a28fcdf5ca00ceb1a7abed59a6f90d8dcd7d7216c204ad76a87497a656dd4a7
+  data.tar.gz: 7c510ab982f230147a03bab655c8a7fb8da373310b817ead61fc6ea06d77f358
 SHA512:
-  metadata.gz: b8dbd5bd3051e8edf9ab7b130c0cd6a5af876d52c8fb6992e82c4ae3b22b58eeb726591bffc67368c9cc3c40e60faa2a1f5d5090a3392fe5fc96f374dde1af6e
-  data.tar.gz: e32c5e8e487ea31dc875df217e26f962c634978cd07b1d036b97a10f3e7eaa0fb8d446b0e8c00d89c4a5eacce591012400d01e3b541bd98238114a4ea1785aaf
+  metadata.gz: fd6c7aa7a15bdec83398610de7431f0d185f9650522a614204b7bb63bcaa7470147faa7ed301f3cbd9c5967164ab2d92ebaa90a5b8e4445947e2073864261f72
+  data.tar.gz: ec9c80f83fe4b8e20735c61c359306d68dbf0a60b7d9ba74515dcb60be7d7f5f237ab14a1d1e7951e75280158ea8c78f42f886c497decc5416159b04713533fa

data/lib/mixpal/integration.rb

@@ -32,7 +32,7 @@ module Mixpal
     private
 
     def store_mixpanel_if_redirecting
-      mixpanel.store!(session) if status == 302
+      mixpanel.store!(session) if (300..399).cover?(status)
     end
   end
 end

data/lib/mixpal/util.rb

@@ -5,12 +5,22 @@ module Mixpal
         hash.reject! { |_, v| v.nil? }
 
         contents = hash.map do |k, v|
-          js_value = v.is_a?(String) || v.is_a?(Time) ? "\"#{v}\"" : v
-          "\"#{k}\": #{js_value}"
+          "\"#{k}\": #{escape_js_object_value(v)}"
         end.join(',').html_safe
 
         "{#{contents}}"
       end
+
+      def escape_js_object_value(value)
+        case value
+        when String
+          value.dump
+        when Time
+          "\"#{value}\""
+        else
+          value
+        end
+      end
     end
   end
 end

data/lib/mixpal/version.rb

@@ -1,3 +1,3 @@
 module Mixpal
-  VERSION = '0.4.0'
+  VERSION = '0.4.2'
 end

data/spec/lib/mixpal/util_spec.rb

@@ -24,5 +24,10 @@ describe Mixpal::Util do
       expect(subject.hash_to_js_object_string(age: 21, gender: nil))
         .to eq '{"age": 21}'
     end
+
+    it 'escapes double quotes in values' do
+      expect(subject.hash_to_js_object_string(key: 'value "with" quotes'))
+        .to eq '{"key": "value \"with\" quotes"}'
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mixpal
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.2
 platform: ruby
 authors:
 - patbenatar
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-20 00:00:00.000000000 Z
+date: 2023-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler