mixlib-versioning 1.0.0 → 1.1.0

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -38,6 +38,6 @@ RSpec.configure do |config|
 
   # specify metadata with symobls only (ie no '=> true' required)
   config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.filter_run :focus => true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end

data/spec/support/shared_examples/basic_semver.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,27 +16,25 @@
 # limitations under the License.
 #
 
-shared_examples "Basic SemVer" do
-
-  it_has_behavior "parses valid version strings", {
-    "1.2.3" => {
-      :major => 1,
-      :minor => 2,
-      :patch => 3,
-      :prerelease => nil,
-      :build => nil,
-      :release? => true,
-      :prerelease? => false,
-      :build? => false,
-      :release_build? => false,
-      :prerelease_build? => false
-    }
+shared_examples 'Basic SemVer' do
+  it_has_behavior 'parses valid version strings', {
+    '1.2.3' => {
+      major: 1,
+      minor: 2,
+      patch: 3,
+      prerelease: nil,
+      build: nil,
+      release?: true,
+      prerelease?: false,
+      build?: false,
+      release_build?: false,
+      prerelease_build?: false,
+    },
   }
 
-  it_has_behavior "rejects invalid version strings", {
-    "a.1.1" => "non-numeric MAJOR",
-    "1.a.1" => "non-numeric MINOR",
-    "1.1.a" => "non-numeric PATCH"
+  it_has_behavior 'rejects invalid version strings', {
+    'a.1.1' => 'non-numeric MAJOR',
+    '1.a.1' => 'non-numeric MINOR',
+    '1.1.a' => 'non-numeric PATCH',
   }
-
 end

data/spec/support/shared_examples/behaviors/comparable.rb

@@ -0,0 +1,80 @@
+#
+# Author:: Krzysztof Wilczynski (<kwilczynski@chef.io>)
+# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+shared_examples 'comparable' do |version_matrix|
+  describe '#<' do
+    version_matrix.each_slice(2) do |a, b|
+      it "confirms that #{a} is less-than #{b}" do
+        expect(described_class.new(a) < b).to be true
+        expect(described_class.new(a) > b).to be false
+      end
+    end
+  end
+
+  describe '#<=' do
+    version_matrix.each_slice(2) do |a, b|
+      it "confirms that #{a} less-than or equal to #{b}" do
+        expect(described_class.new(a) <= b).to be true
+        expect(described_class.new(a) <= a).to be true
+        expect(described_class.new(a) > b).to be false
+        expect(described_class.new(a) == b).to be false
+      end
+    end
+  end
+
+  describe '#==' do
+    version_matrix.each do |v|
+      it "confirms that #{v} is equal to #{v}" do
+        expect(described_class.new(v) == v).to be true
+        expect(described_class.new(v) < v).to be false
+        expect(described_class.new(v) > v).to be false
+      end
+    end
+  end
+
+  describe '#>' do
+    version_matrix.reverse.each_slice(2) do |a, b|
+      it "confirms that #{a} is greather-than #{b}" do
+        expect(described_class.new(a) > b).to be true
+        expect(described_class.new(a) < b).to be false
+      end
+    end
+  end
+
+  describe '#>=' do
+    version_matrix.reverse.each_slice(2) do |a, b|
+      it "confirms that #{a} greater-than or equal to #{b}" do
+        expect(described_class.new(a) >= b).to be true
+        expect(described_class.new(a) >= a).to be true
+        expect(described_class.new(a) < b).to be false
+        expect(described_class.new(a) == b).to be false
+      end
+    end
+  end
+
+  describe '#between?' do
+    let(:versions) { version_matrix.map { |v| described_class.new(v) }.sort }
+
+    it 'comfirms that a version is between the oldest and latest release' do
+      min, max = versions.minmax.map(&:to_s)
+      middle = versions[versions.size / 2].to_s
+      expect(described_class.new(middle).between?(min, max)).to be true
+      expect(described_class.new(middle).between?(max, min)).to be false
+    end
+  end
+end

data/spec/support/shared_examples/behaviors/filterable.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,51 +16,39 @@
 # limitations under the License.
 #
 
-shared_examples "filterable" do
-
+shared_examples 'filterable' do
   let(:unsorted_versions) do
-    unsorted_version_strings.map{ |v| described_class.new(v) }
+    unsorted_version_strings.map { |v| described_class.new(v) }
   end
 
   # this should/will be overriden by calling spec
-  let(:release_versions){[]}
-  let(:prerelease_versions){[]}
-  let(:build_versions){[]}
-  let(:release_build_versions){[]}
-  let(:prerelease_build_versions){[]}
-
-  it "filters by release versions only" do
-    unsorted_versions.select(&:release?).should eq(release_versions.map{|v|
-      described_class.new(v)
-    })
+  let(:release_versions) { [] }
+  let(:prerelease_versions) { [] }
+  let(:build_versions) { [] }
+  let(:release_build_versions) { [] }
+  let(:prerelease_build_versions) { [] }
+
+  it 'filters by release versions only' do
+    unsorted_versions.select(&:release?).should eq(release_versions.map { |v| described_class.new(v) })
   end # it
 
-  it "filters by pre-release versions only" do
+  it 'filters by pre-release versions only' do
     filtered = unsorted_versions.select(&:prerelease?)
-    filtered.should eq(prerelease_versions.map{|v|
-      described_class.new(v)
-    })
+    filtered.should eq(prerelease_versions.map { |v| described_class.new(v) })
   end # it
 
-  it "filters by build versions only" do
+  it 'filters by build versions only' do
     filtered = unsorted_versions.select(&:build?)
-    filtered.should eq(build_versions.map{|v|
-      described_class.new(v)
-    })
+    filtered.should eq(build_versions.map { |v| described_class.new(v) })
   end # it
 
-  it "filters by release build versions only" do
+  it 'filters by release build versions only' do
     filtered = unsorted_versions.select(&:release_build?)
-    filtered.should eq(release_build_versions.map{|v|
-      described_class.new(v)
-    })
+    filtered.should eq(release_build_versions.map { |v| described_class.new(v) })
   end # it
 
-  it "filters by pre-release build versions only" do
+  it 'filters by pre-release build versions only' do
     filtered = unsorted_versions.select(&:prerelease_build?)
-    filtered.should eq(prerelease_build_versions.map{|v|
-      described_class.new(v)
-    })
+    filtered.should eq(prerelease_build_versions.map { |v| described_class.new(v) })
   end # it
-
 end # shared_examples

data/spec/support/shared_examples/behaviors/parses_valid_version_strings.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,17 +16,14 @@
 # limitations under the License.
 #
 
-shared_examples "parses valid version strings" do |valid_examples|
-
+shared_examples 'parses valid version strings' do |valid_examples|
   valid_examples.each do |version, options|
-
     context version do
-      let(:version_string){ version }
+      let(:version_string) { version }
 
       options.each_pair do |name, value|
-        its(name){ should eq value}
+        its(name) { should eq value }
       end
-
     end # context
   end # valid_examples
 end # shared_examples

data/spec/support/shared_examples/behaviors/rejects_invalid_version_strings.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,17 +16,14 @@
 # limitations under the License.
 #
 
-shared_examples "rejects invalid version strings" do |invalid_examples|
-
+shared_examples 'rejects invalid version strings' do |invalid_examples|
   invalid_examples.each_pair do |version, reason|
-
     context version do
-      let(:version_string){ version }
+      let(:version_string) { version }
 
       it "fails because: #{reason}" do
         expect { subject }.to raise_error(Mixlib::Versioning::ParseError)
       end
-
     end # context
   end # invalid_examples
 end # shared_examples

data/spec/support/shared_examples/behaviors/serializable.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,9 +16,8 @@
 # limitations under the License.
 #
 
-shared_examples "serializable" do |version_strings|
-
-  describe "#to_s" do
+shared_examples 'serializable' do |version_strings|
+  describe '#to_s' do
     version_strings.each do |v|
       it "reconstructs the initial input for #{v}" do
         described_class.new(v).to_s.should == v
@@ -26,7 +25,7 @@ shared_examples "serializable" do |version_strings|
     end # version_strings
   end # describe
 
-  describe "#to_semver_string" do
+  describe '#to_semver_string' do
     version_strings.each do |v|
       it "generates a semver version string for #{v}" do
         subject = described_class.new(v)
@@ -37,7 +36,7 @@ shared_examples "serializable" do |version_strings|
     end # version_strings
   end # describe
 
-  describe "#to_rubygems_string" do
+  describe '#to_rubygems_string' do
     version_strings.each do |v|
       it "generates a rubygems version string for #{v}" do
         subject = described_class.new(v)
@@ -47,5 +46,4 @@ shared_examples "serializable" do |version_strings|
       end # it
     end # version_strings
   end # describe
-
 end # shared_examples

data/spec/support/shared_examples/behaviors/sortable.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -16,30 +16,28 @@
 # limitations under the License.
 #
 
-shared_examples "sortable" do
-
+shared_examples 'sortable' do
   let(:unsorted_versions) do
-    unsorted_version_strings.map{ |v| described_class.new(v) }
+    unsorted_version_strings.map { |v| described_class.new(v) }
   end
 
   let(:sorted_versions) do
-    sorted_version_strings.map{ |v| described_class.new(v) }
+    sorted_version_strings.map { |v| described_class.new(v) }
   end
 
   it 'responds to <=>' do
     described_class.should respond_to(:<=>)
   end
 
-  it "sorts all properly" do
+  it 'sorts all properly' do
     unsorted_versions.sort.should eq sorted_versions
   end
 
-  it "finds the min" do
+  it 'finds the min' do
     unsorted_versions.min.should eq described_class.new(min)
   end
 
-  it "finds the max" do
+  it 'finds the max' do
     unsorted_versions.max.should eq described_class.new(max)
   end
-
 end # shared_examples

data/spec/support/shared_examples/semver.rb

@@ -1,5 +1,5 @@
 #
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
+# Author:: Seth Chisamore (<schisamo@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
 # License:: Apache License, Version 2.0
 #
@@ -19,87 +19,99 @@
 require 'mixlib/versioning'
 
 shared_examples Mixlib::Versioning::Format::SemVer do
+  it_should_behave_like 'Basic SemVer'
 
-  it_should_behave_like "Basic SemVer"
-
-  it_has_behavior "parses valid version strings", {
-    "1.0.0-alpha.1" => {
-      :major => 1,
-      :minor => 0,
-      :patch => 0,
-      :prerelease => "alpha.1",
-      :build => nil,
-      :release? => false,
-      :prerelease? => true,
-      :build? => false,
-      :release_build? => false,
-      :prerelease_build? => false
+  it_has_behavior 'parses valid version strings', {
+    '1.0.0-alpha.1' => {
+      major: 1,
+      minor: 0,
+      patch: 0,
+      prerelease: 'alpha.1',
+      build: nil,
+      release?: false,
+      prerelease?: true,
+      build?: false,
+      release_build?: false,
+      prerelease_build?: false,
+    },
+    '1.0.0+20130308110833' => {
+      major: 1,
+      minor: 0,
+      patch: 0,
+      prerelease: nil,
+      build: '20130308110833',
+      release?: false,
+      prerelease?: false,
+      build?: true,
+      release_build?: true,
+      prerelease_build?: false,
     },
-    "1.0.0+20130308110833" => {
-      :major => 1,
-      :minor => 0,
-      :patch => 0,
-      :prerelease => nil,
-      :build => "20130308110833",
-      :release? => false,
-      :prerelease? => false,
-      :build? => true,
-      :release_build? => true,
-      :prerelease_build? => false
+    '1.0.0-beta.3+20130308110833' => {
+      major: 1,
+      minor: 0,
+      patch: 0,
+      prerelease: 'beta.3',
+      build: '20130308110833',
+      release?: false,
+      prerelease?: false,
+      build?: true,
+      release_build?: false,
+      prerelease_build?: true,
     },
-    "1.0.0-beta.3+20130308110833" => {
-      :major => 1,
-      :minor => 0,
-      :patch => 0,
-      :prerelease => "beta.3",
-      :build => "20130308110833",
-      :release? => false,
-      :prerelease? => false,
-      :build? => true,
-      :release_build? => false,
-      :prerelease_build? => true
-    }
   }
 
-  it_has_behavior "rejects invalid version strings", {
-    "8.8.8.8" => "too many segments: MAJOR.MINOR.PATCH.EXTRA"
+  it_has_behavior 'rejects invalid version strings', {
+    '8.8.8.8' => 'too many segments: MAJOR.MINOR.PATCH.EXTRA',
+    '01.1.1' => 'leading zero invalid',
+    '1.01.1' => 'leading zero invalid',
+    '1.1.01' => 'leading zero invalid',
+    '1.0.0-' => 'empty prerelease identifier',
+    '1.0.0-alpha..' => 'empty prerelease identifier',
+    '1.0.0-01.02.03' => 'leading zero invalid',
+    '1.0.0-alpha.01' => 'leading zero invalid',
+    '6.3.1+' => 'empty build identifier',
+    '6.4.8-alpha.1.2.3+build.' => 'empty build identifier',
+    '4.0.000000000002-alpha.1' => 'leading zero invalid',
+    '007.2.3-rc.1+build.16' => 'leading zero invalid',
+    '12.0005.1-alpha.12' => 'leading zero invalid',
+    '12.2.10-beta.00000017' => 'leading zero invalid',
   }
 
-  describe "build qualification" do
-    context "release version" do
-      let(:version_string){"1.0.0"}
-      its(:release?){ should be_true }
-      its(:prerelease?){ should be_false }
-      its(:build?){ should be_false }
-      its(:release_build?){ should be_false }
-      its(:prerelease_build?){ should be_false }
+  describe 'build qualification' do
+    context 'release version' do
+      let(:version_string) { '1.0.0' }
+      its(:release?) { should be_true }
+      its(:prerelease?) { should be_false }
+      its(:build?) { should be_false }
+      its(:release_build?) { should be_false }
+      its(:prerelease_build?) { should be_false }
     end
 
-    context "pre-release version" do
-      let(:version_string){"1.0.0-alpha.1"}
-      its(:release?){ should be_false }
-      its(:prerelease?){ should be_true }
-      its(:build?){ should be_false }
-      its(:release_build?){ should be_false }
-      its(:prerelease_build?){ should be_false }
+    context 'pre-release version' do
+      let(:version_string) { '1.0.0-alpha.1' }
+      its(:release?) { should be_false }
+      its(:prerelease?) { should be_true }
+      its(:build?) { should be_false }
+      its(:release_build?) { should be_false }
+      its(:prerelease_build?) { should be_false }
     end
 
-    context "pre-release build version" do
-      let(:version_string){"1.0.0-alpha.1+20130308110833"}
-      its(:release?){ should be_false }
-      its(:prerelease?){ should be_false }
-      its(:build?){ should be_true }
-      its(:release_build?){ should be_false }
-      its(:prerelease_build?){ should be_true }
+    context 'pre-release build version' do
+      let(:version_string) { '1.0.0-alpha.1+20130308110833' }
+      its(:release?) { should be_false }
+      its(:prerelease?) { should be_false }
+      its(:build?) { should be_true }
+      its(:release_build?) { should be_false }
+      its(:prerelease_build?) { should be_true }
     end
 
-    context "release build version" do
-      let(:version_string){"1.0.0+20130308110833"}
-      its(:release?){ should be_false }
-      its(:prerelease?){ should be_false }
-      its(:build?){ should be_true }
-      its(:release_build?){ should be_true }
-      its(:prerelease_build?){ should be_false }
+    context 'release build version' do
+      let(:version_string) { '1.0.0+20130308110833' }
+      its(:release?) { should be_false }
+      its(:prerelease?) { should be_false }
+      its(:build?) { should be_true }
+      its(:release_build?) { should be_true }
+      its(:prerelease_build?) { should be_false }
     end
   end
 end