mixlib-shellout 3.2.8 → 3.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a15c2e90bbfd59704b7937e4b28cb46579f55b1f98a28a2b752002f9e8d05f2a
-  data.tar.gz: ceddbac62cc7505044d34310ec89c0c9cc5e663a6681d34d7a2bee50ef49f4e2
+  metadata.gz: 49b9ac59dc9b686824b628b2cc5e616cdcca707ec3d60dc87b025fb8ae18d4dd
+  data.tar.gz: 18d6456f265caa913d37a8ffedc2c66514e381e090cc0a1c8d32b5cf8c4adee3
 SHA512:
-  metadata.gz: 5d53cd0b6d622eb4aac19f3cdb140b4de04b65786499653771245578baf007641c999e04cfd9468348dcf5a97ed7840a7cbba3a83e4911171d0aea918cda3dad
-  data.tar.gz: 130c34af750fc00204641001a3375735fba96cd956b65cc6e7ec402c46d2473f531f9602ff09aab560ae21aed7bb63951c44928fcb63d2d01c77c2488b0c2c60
+  metadata.gz: 1b24be2169c4086dd2de0d26c54b89ffae4474513b2ec55f9957fb446aa2ce0f03a4464f3e735869c35820a91b6d7e3823fa5780e11efe4e7947ea2820ab448c
+  data.tar.gz: 8e683c0a522719a7b3ede0e9d33f93906ba58cacf79d4b4d834a225815c762f2492c41b99ed3577b326728b6386ac949b7a25da694def49aacae0f1d1e34830a

data/lib/mixlib/shellout/helper.rb

@@ -141,9 +141,39 @@ module Mixlib
         args.flatten.compact.map(&:to_s)
       end
 
+      # Join arguments into a string.
+      #
+      # Strips leading/trailing spaces from each argument. If an argument contains
+      # a space, it is quoted. Join into a single string with spaces between each argument.
+      #
+      # @param args [String] variable number of string arguments
+      # @return [String] merged string
+      #
+      def __join_whitespace(*args)
+        args.flatten.map do |arg|
+          arg.strip!
+          arg.include?(" ") ? sprintf('"%s"', arg) : arg
+        end.join(" ")
+      end
+
       def __shell_out_command(*args, **options)
         if __transport_connection
-          FakeShellOut.new(args, options, __transport_connection.run_command(args.join(" "))) # FIXME: train should accept run_command(*args)
+          command = __join_whitespace(args)
+          unless ChefUtils.windows?
+            if options[:cwd]
+              # as `timeout` is used, commands need to be executed in a subshell
+              command = "sh -c 'cd #{options[:cwd]}; #{command}'"
+            end
+
+            if options[:input]
+              command.concat "<<'COMMANDINPUT'\n"
+              command.concat __join_whitespace(options[:input])
+              command.concat "COMMANDINPUT\n"
+            end
+          end
+
+          # FIXME: train should accept run_command(*args)
+          FakeShellOut.new(args, options, __transport_connection.run_command(command, options))
         else
           cmd = if options.empty?
                   Mixlib::ShellOut.new(*args)
@@ -181,15 +211,16 @@ module Mixlib
           @stdout = result.stdout
           @stderr = result.stderr
           @exitstatus = result.exit_status
-          @status = OpenStruct.new(success?: ( exitstatus == 0 ))
+          @valid_exit_codes = Array(options[:returns] || 0)
+          @status = OpenStruct.new(success?: (@valid_exit_codes.include? exitstatus))
         end
 
         def error?
-          exitstatus != 0
+          @valid_exit_codes.none?(exitstatus)
         end
 
         def error!
-          raise Mixlib::ShellOut::ShellCommandFailed, "Unexpected exit status of #{exitstatus} running #{@args}" if error?
+          raise Mixlib::ShellOut::ShellCommandFailed, "Unexpected exit status of #{exitstatus} running #{@args}: #{stderr}" if error?
         end
       end
     end

data/lib/mixlib/shellout/unix.rb

@@ -20,11 +20,6 @@ module Mixlib
   class ShellOut
     module Unix
 
-      # "1.8.7" as a frozen string. We use this with a hack that disables GC to
-      # avoid segfaults on Ruby 1.8.7, so we need to allocate the fewest
-      # objects we possibly can.
-      ONE_DOT_EIGHT_DOT_SEVEN = "1.8.7".freeze
-
       # Option validation that is unix specific
       def validate_options(opts)
         if opts[:elevated]
@@ -99,12 +94,6 @@ module Mixlib
 
         configure_parent_process_file_descriptors
 
-        # Ruby 1.8.7 and 1.8.6 from mid 2009 try to allocate objects during GC
-        # when calling IO.select and IO#read. Disabling GC works around the
-        # segfault, but obviously it's a bad workaround. We no longer support
-        # 1.8.6 so we only need this hack for 1.8.7.
-        GC.disable if RUBY_VERSION == ONE_DOT_EIGHT_DOT_SEVEN
-
         # CHEF-3390: Marshall.load on Ruby < 1.8.7p369 also has a GC bug related
         # to Marshall.load, so try disabling GC first.
         propagate_pre_exec_failure

data/lib/mixlib/shellout/version.rb

@@ -1,5 +1,5 @@
 module Mixlib
   class ShellOut
-    VERSION = "3.2.8".freeze
+    VERSION = "3.3.4".freeze
   end
 end

data/lib/mixlib/shellout/windows.rb

@@ -60,6 +60,7 @@ module Mixlib
         stderr_read, stderr_write = IO.pipe
         stdin_read, stdin_write = IO.pipe
         open_streams = [ stdout_read, stderr_read ]
+        @execution_time = 0
 
         begin
 
@@ -105,6 +106,8 @@ module Mixlib
               wait_status = WaitForSingleObject(process.process_handle, 0)
               case wait_status
               when WAIT_OBJECT_0
+                # Save the execution time
+                @execution_time = Time.now - start_wait
                 # Get process exit code
                 exit_code = [0].pack("l")
                 unless GetExitCodeProcess(process.process_handle, exit_code)
@@ -127,6 +130,9 @@ module Mixlib
                     logger&.warn("Failed to kill timed out process #{process.process_id}")
                   end
 
+                  # Save the execution time
+                  @execution_time = Time.now - start_wait
+
                   raise Mixlib::ShellOut::CommandTimeout, [
                     "command timed out:",
                     format_for_exception,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mixlib-shellout
 version: !ruby/object:Gem::Version
-  version: 3.2.8
+  version: 3.3.4
 platform: ruby
 authors:
 - Chef Software Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-06-08 00:00:00.000000000 Z
+date: 2024-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-utils