mixlib-shellout 1.4.0.rc.0 → 1.4.0.rc.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: abc0fcb2fac6bbaa656ec5986083c3e6d9f80137
-  data.tar.gz: bed2f4cda27c43e7f4a8bd1265089bf7b8016065
+  metadata.gz: cdcad8407f8158cacdc7118e4c2b046bf59f68e3
+  data.tar.gz: 1a27d08ae83ffca194ba8b61a6c23824b248b2bd
 SHA512:
-  metadata.gz: c580694c90a79f7ef01b3e4b7930e954a77ece31f3a16e0b6d10ef02ea24d73e26f4de316f5fdd0cb4ca0162fbde9a303e763c992acf6bffef65ca2bb99dddd3
-  data.tar.gz: 5c7af3ef8b2bb9f5e7ef9e36dce50f94afc0d3ce56702ac6e6bd45343cc367fe057ea7ad8b04881e6d0aaaebcaffd45ae95f9d69bf3e36ea385127f2f023b61b
+  metadata.gz: b5e1eac1c26c3b3d5e94c810e6a17a066470a034be3b5c8c1d08b8766a3618b08cebe3191b21f9ec6a2b3d0e250a36b45e0739e5e58df0d0649644ea38cae9f0
+  data.tar.gz: 557b314096cbe7f16aae32919d51b266c0bed4f44d20bc75b343d042add8c9ba79b6915d7be8b1ee5625573b2a867569f0e0de1f97e1e52dd096aee61d662a4e

data/lib/mixlib/shellout/unix.rb

@@ -63,7 +63,7 @@ module Mixlib
         # CHEF-3390: Marshall.load on Ruby < 1.8.7p369 also has a GC bug related
         # to Marshall.load, so try disabling GC first.
         propagate_pre_exec_failure
-        @child_pgid = -Process.getpgid(@child_pid)
+        get_child_pgid
 
         @result = nil
         @execution_time = 0
@@ -107,6 +107,18 @@ module Mixlib
 
       private
 
+      def get_child_pgid
+        # The behavior of Process.getpgid (see also getpgid(2) ) when the
+        # argument is the pid of a zombie isn't well specified. On Linux it
+        # works, on OS X it returns ESRCH (which ruby turns into Errno::ESRCH).
+        #
+        # If the child dies very quickly, @child_pid may be a zombie, so handle
+        # ESRCH here.
+        @child_pgid = -Process.getpgid(@child_pid)
+      rescue Errno::ESRCH
+        @child_pgid = nil
+      end
+
       def set_user
         if user
           Process.euid = uid
@@ -137,6 +149,10 @@ module Mixlib
 
       # Process group id of the child. Returned as a negative value so you can
       # put it directly in arguments to kill, wait, etc.
+      #
+      # This may be nil if the child dies before the parent can query the
+      # system for its pgid (on some systems it is an error to get the pgid of
+      # a zombie).
       def child_pgid
         @child_pgid
       end

data/lib/mixlib/shellout/version.rb

@@ -1,5 +1,5 @@
 module Mixlib
   class ShellOut
-    VERSION = "1.4.0.rc.0"
+    VERSION = "1.4.0.rc.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mixlib-shellout
 version: !ruby/object:Gem::Version
-  version: 1.4.0.rc.0
+  version: 1.4.0.rc.1
 platform: ruby
 authors:
 - Opscode
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-30 00:00:00.000000000 Z
+date: 2014-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec