mitake_sms 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce3a09712c7955800b5008e576ca2bc515bee3eb2ef9f8e4f4fa19be4dcc7f39
-  data.tar.gz: cc5b846bb58eb1cddfd71b565f448784e9e3acaa3639bb308caf1db8f8bdb6d9
+  metadata.gz: ed3ca4ddde2280f9eaf8eab941bc8dd7cce15e286961626c02b969c13c1c039c
+  data.tar.gz: f5f8b5dcef17f97f029f05c29a24f87904a3d7a13b8a42e850f769a5978858af
 SHA512:
-  metadata.gz: ad51be7878326be0c89a6d1ac81bb66e6e7f9c666375a6b98bac224074a4c599f03f4043a2ff75f9b6e6985a9412a4a9a397f16d6807ea59f223e6bdb390d061
-  data.tar.gz: 51c0c4eece86ad4a532e410b8b890ebbc23d5d90b5ea3afe960df86da110054d4d4c5542da7a11a847d8879e0a7f9728d21c6e45a0bb89dc33472b833db6b444
+  metadata.gz: 679340eb268bf398b4e3971eb042ff983e941ba422b4112a1cb6c27c5fa91d920f6050d220c7ee945359bdb6cc1df1147d424077246192bd5fd0d791ab049450
+  data.tar.gz: 318696e9d93e918b13b1e2ef98bad3d14f35818b32240f35c82ea6ad4f98e967c69613bccb96f77a7915348afed27e14d71da6d41a1aa2c76648279610277839

data/CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.5.2] - 2025-05-25
+### Changed
+- Modified `send_sms` method to keep only `CharsetURL` in query string and put all other parameters in POST body
+- Updated tests to match the new parameter structure
+
 ## [1.5.1] - 2025-05-25
 ### Fixed
 - Updated the API URL from `smsapi.mitake.com.tw` to `smsb2c.mitake.com.tw` to match the correct Mitake SMS API endpoint

data/lib/mitake_sms/client.rb

@@ -29,7 +29,7 @@ module MitakeSms
     # @return [MitakeSms::Response] response object
     def send_sms(to:, text:, response_url: nil, client_id: nil, charset: 'UTF8', **options)
       require 'uri'
-      
+
       # Create options hash with only non-nil values
       param_options = {}
       param_options[:response_url] = response_url if response_url
@@ -39,24 +39,27 @@ module MitakeSms
       # This is required by the Mitake API to represent line breaks
       processed_text = text.to_s.gsub("\n", 6.chr)
 
-      # Prepare query parameters - all parameters are now sent as query parameters
+      # Prepare query parameters - only CharsetURL is sent as query parameter
       query_params = {
+        CharsetURL: charset
+      }
+
+      # Prepare form parameters - all other parameters are sent in the POST body
+      form_params = {
         username: @config.username,
         password: @config.password,
         dstaddr: to,
-        smbody: processed_text,
-        CharsetURL: charset
+        smbody: processed_text
       }.merge(param_options).merge(options)
-  
+
       # Construct the endpoint URL
       endpoint = "SmSend"
-  
+
       response = @connection.post(endpoint) do |req|
         req.params = query_params
-        # Empty body since all parameters are in the query string
-        req.body = {}
+        req.body = form_params
       end
-      
+
       handle_response(response)
     end
 
@@ -149,7 +152,7 @@ module MitakeSms
     # @return [MitakeSms::Response] response object
     def send_batch(batch, charset = 'UTF8', options = {})
       require 'uri'
-      
+
       # Prepare the batch message content
       smbody = batch.map do |msg|
         to = msg[:to]
@@ -160,7 +163,7 @@ module MitakeSms
 
         "#{to}:#{processed_text}"
       end.join("\n")
-      
+
       # All parameters should be sent as query string parameters
       query_params = {
         username: @config.username,
@@ -168,13 +171,13 @@ module MitakeSms
         smbody: smbody,
         Encoding_PostIn: charset
       }
-      
+
       # Use empty body with all parameters in query string
       response = @connection.post('SmBulkSend') do |req|
         req.params = query_params
         req.body = {}
       end
-      
+
       handle_response(response)
     end
 
@@ -185,7 +188,7 @@ module MitakeSms
     # @return [MitakeSms::Response] response object
     def send_advanced_batch(batch, charset = 'UTF8', options = {})
       require 'uri'
-      
+
       # Format each message according to the advanced format
       # ClientID $$ dstaddr $$ dlvtime $$ vldtime $$ destname $$ response $$ smbody
       data = batch.map do |msg|
@@ -201,11 +204,11 @@ module MitakeSms
         vldtime = msg[:vldtime] || ''
         dest_name = msg[:dest_name] || ''
         response_url = msg[:response] || ''
-        
+
         # Replace any newline characters in the message text with ASCII code 6 (ACK)
         # This is required by the Mitake API to represent line breaks within message content
         processed_text = msg[:text].to_s.gsub("\n", 6.chr)
-        
+
         [client_id, to, dlvtime, vldtime, dest_name, response_url, processed_text].join('$$')
       end.join("\n")
 
@@ -222,7 +225,7 @@ module MitakeSms
         req.params = query_params
         req.body = {}
       end
-      
+
       handle_response(response)
     end
 

data/lib/mitake_sms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MitakeSms
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mitake_sms
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Zac