mitake_sms 1.2.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46484a48ae04607708212f2512b21b7a941a365f3282783beca9f695a79c0fc6
-  data.tar.gz: 446cc3b004842cede09f38f6516a5a03ada342a50d0d79e840a7eefdbc6ba398
+  metadata.gz: bc6252ee1a0e46b2d3b81d7ac1522a97414d9f923836887e3347909b7136d1a7
+  data.tar.gz: 7feece9cd7334075d6c6c23d5235c272245f656301d6bd3318db87753d5ac70d
 SHA512:
-  metadata.gz: e1fcbca7044f634e710b7fc34afbf19f576529bd1b155d212b1d4be158ea31cee05e950c5089517ae4112a9c63251af462f8df7213ccde4c517a622b4fa4b214
-  data.tar.gz: c3a4955cd4c9b4476bc36bf032b3af9effc002ccd2646db04d3df195d116ca885e76bb03c6f8a5ce1c7fe423a01fa33510774938729040b5d8d7a6da8ef7dff4
+  metadata.gz: 118431e6c6b70bd7bcbb964b0d8953914def6b4b542e5101f89a4e3c19eddf2e07f930455975f4e9756462b3899f3e3df2d3b252d5abca87c28ad38b6f6a6b55
+  data.tar.gz: c252b2d7da8b4bf21a63081790582dd3f8e0bf4a956b7d6a4cf9c0f12f1f64ed1164c34186223a1c3206e3d56f797712ee187ebf2cf2e4a6972ec30cc586912f

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.4.0] - 2025-05-25
+### Changed
+- Modified all batch SMS parameters to be sent as query string parameters instead of in the POST body
+- Updated `send_batch` and `send_advanced_batch` methods to use query string parameters
+- Modified tests to verify query string parameter handling for batch SMS
+
+## [1.3.1] - 2025-05-25
+### Changed
+- Modified `CharsetURL` parameter to be sent as a query string parameter instead of a form parameter
+- Updated tests to verify query string parameter handling
+
+## [1.3.0] - 2025-05-25
+### Changed
+- Removed automatic URL encoding of message content
+- Simplified message handling by only converting newlines to ASCII code 6
+- Modified tests to match the updated implementation
+
 ## [1.2.0] - 2025-05-25
 ### Added
 - Added proper handling of newlines in message text (converts to ASCII code 6)

data/README.md

@@ -1,6 +1,8 @@
 # MitakeSms
 
 [![codecov](https://codecov.io/gh/7a6163/mitake_sms/graph/badge.svg?token=QNRP1N3TOP)](https://codecov.io/gh/7a6163/mitake_sms)
+![Gem Version](https://img.shields.io/gem/v/mitake_sms)
+
 
 A Ruby client for the Mitake SMS API, providing a simple and efficient way to send SMS messages through the Mitake SMS service.
 

data/lib/mitake_sms/client.rb

@@ -31,24 +31,29 @@ module MitakeSms
     def send_sms(to, text, options = {})
       require 'uri'
       charset = options.delete(:charset) || 'UTF8'
-      
+
       # Replace any newline characters with ASCII code 6 (ACK)
       # This is required by the Mitake API to represent line breaks
       processed_text = text.to_s.gsub("\n", 6.chr)
-      
-      # URL encode the message content to handle special characters like '&'
-      # This is required by the Mitake API
-      message_text = URI.encode_www_form_component(processed_text)
 
-      params = {
+      # Prepare query parameters - all parameters are now sent as query parameters
+      query_params = {
         username: @config.username,
         password: @config.password,
         dstaddr: to,
-        smbody: message_text,
+        smbody: processed_text,
         CharsetURL: charset
       }.merge(options.slice(:from, :response_url, :client_id))
-
-      response = @connection.post('SmSend', params)
+  
+      # Construct the endpoint URL
+      endpoint = "SmSend"
+  
+      response = @connection.post(endpoint) do |req|
+        req.params = query_params
+        # Empty body since all parameters are in the query string
+        req.body = {}
+      end
+      
       handle_response(response)
     end
 
@@ -142,26 +147,31 @@ module MitakeSms
     def send_batch(batch, charset = 'UTF8', options = {})
       require 'uri'
       
-      params = {
+      # Prepare the batch message content
+      smbody = batch.map do |msg|
+        to = msg[:to]
+
+        # Replace any newline characters with ASCII code 6 (ACK)
+        # This is required by the Mitake API to represent line breaks
+        processed_text = msg[:text].to_s.gsub("\n", 6.chr)
+
+        "#{to}:#{processed_text}"
+      end.join("\n")
+      
+      # All parameters should be sent as query string parameters
+      query_params = {
         username: @config.username,
         password: @config.password,
-        smbody: batch.map do |msg|
-          to = msg[:to]
-          
-          # Replace any newline characters with ASCII code 6 (ACK)
-          # This is required by the Mitake API to represent line breaks
-          processed_text = msg[:text].to_s.gsub("\n", 6.chr)
-          
-          # URL encode the message content to handle special characters like '&'
-          # This is required by the Mitake API
-          message_text = URI.encode_www_form_component(processed_text)
-          
-          "#{to}:#{message_text}"
-        end.join("\n"),
+        smbody: smbody,
         Encoding_PostIn: charset
       }
       
-      response = @connection.post('SmBulkSend', params)
+      # Use empty body with all parameters in query string
+      response = @connection.post('SmBulkSend') do |req|
+        req.params = query_params
+        req.body = {}
+      end
+      
       handle_response(response)
     end
 
@@ -175,7 +185,7 @@ module MitakeSms
       
       # Format each message according to the advanced format
       # ClientID $$ dstaddr $$ dlvtime $$ vldtime $$ destname $$ response $$ smbody
-      body = batch.map do |msg|
+      data = batch.map do |msg|
         # ClientID is required and must be unique
         # If not provided, generate a unique ID
         client_id = msg[:client_id]
@@ -193,21 +203,23 @@ module MitakeSms
         # This is required by the Mitake API to represent line breaks within message content
         processed_text = msg[:text].to_s.gsub("\n", 6.chr)
         
-        # URL encode the message content to handle special characters like '&'
-        # This is required by the Mitake API
-        text = URI.encode_www_form_component(processed_text)
-
-        [client_id, to, dlvtime, vldtime, dest_name, response_url, text].join('$$')
+        [client_id, to, dlvtime, vldtime, dest_name, response_url, processed_text].join('$$')
       end.join("\n")
 
-      params = {
+      # All parameters should be sent as query string parameters
+      query_params = {
         username: @config.username,
         password: @config.password,
-        data: body,
+        data: data,
         Encoding_PostIn: charset
       }
 
-      response = @connection.post('SmPost', params)
+      # Use empty body with all parameters in query string
+      response = @connection.post('SmPost') do |req|
+        req.params = query_params
+        req.body = {}
+      end
+      
       handle_response(response)
     end
 

data/lib/mitake_sms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MitakeSms
-  VERSION = "1.2.0"
+  VERSION = "1.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mitake_sms
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Zac