mitake_sms 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46484a48ae04607708212f2512b21b7a941a365f3282783beca9f695a79c0fc6
-  data.tar.gz: 446cc3b004842cede09f38f6516a5a03ada342a50d0d79e840a7eefdbc6ba398
+  metadata.gz: 42774c4aed1ba07e126a7023b8e2baedf85dc25e53bbeafc4739cff39765d0b3
+  data.tar.gz: 978e2c9b36e5cc2a2b79ad6f05b90f360f49c8930f50c5131851eb170a10aaf3
 SHA512:
-  metadata.gz: e1fcbca7044f634e710b7fc34afbf19f576529bd1b155d212b1d4be158ea31cee05e950c5089517ae4112a9c63251af462f8df7213ccde4c517a622b4fa4b214
-  data.tar.gz: c3a4955cd4c9b4476bc36bf032b3af9effc002ccd2646db04d3df195d116ca885e76bb03c6f8a5ce1c7fe423a01fa33510774938729040b5d8d7a6da8ef7dff4
+  metadata.gz: '0859b813573741a6ff71f8339c1a56bb4c625a6acdb0f861b1f2407a5981fce7619cd70580301558b0bac4e682350ccbb6ffb9e35b7a8ff30f45f3f6e80c4992'
+  data.tar.gz: 350a37d091491be985e03b736b39ea999e28edf7a90eb5edc378a0119719a343eb3aeb6f4d558a17e1ea9bdb233d886e8aba585f38f1894b62d46f8500c03b30

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.3.0] - 2025-05-25
+### Changed
+- Removed automatic URL encoding of message content
+- Simplified message handling by only converting newlines to ASCII code 6
+- Modified tests to match the updated implementation
+
 ## [1.2.0] - 2025-05-25
 ### Added
 - Added proper handling of newlines in message text (converts to ASCII code 6)

data/lib/mitake_sms/client.rb

@@ -31,20 +31,16 @@ module MitakeSms
     def send_sms(to, text, options = {})
       require 'uri'
       charset = options.delete(:charset) || 'UTF8'
-      
+
       # Replace any newline characters with ASCII code 6 (ACK)
       # This is required by the Mitake API to represent line breaks
       processed_text = text.to_s.gsub("\n", 6.chr)
-      
-      # URL encode the message content to handle special characters like '&'
-      # This is required by the Mitake API
-      message_text = URI.encode_www_form_component(processed_text)
 
       params = {
         username: @config.username,
         password: @config.password,
         dstaddr: to,
-        smbody: message_text,
+        smbody: processed_text,
         CharsetURL: charset
       }.merge(options.slice(:from, :response_url, :client_id))
 
@@ -141,26 +137,22 @@ module MitakeSms
     # @return [MitakeSms::Response] response object
     def send_batch(batch, charset = 'UTF8', options = {})
       require 'uri'
-      
+
       params = {
         username: @config.username,
         password: @config.password,
         smbody: batch.map do |msg|
           to = msg[:to]
-          
+
           # Replace any newline characters with ASCII code 6 (ACK)
           # This is required by the Mitake API to represent line breaks
           processed_text = msg[:text].to_s.gsub("\n", 6.chr)
-          
-          # URL encode the message content to handle special characters like '&'
-          # This is required by the Mitake API
-          message_text = URI.encode_www_form_component(processed_text)
-          
-          "#{to}:#{message_text}"
+
+          "#{to}:#{processed_text}"
         end.join("\n"),
         Encoding_PostIn: charset
       }
-      
+
       response = @connection.post('SmBulkSend', params)
       handle_response(response)
     end
@@ -172,7 +164,7 @@ module MitakeSms
     # @return [MitakeSms::Response] response object
     def send_advanced_batch(batch, charset = 'UTF8', options = {})
       require 'uri'
-      
+
       # Format each message according to the advanced format
       # ClientID $$ dstaddr $$ dlvtime $$ vldtime $$ destname $$ response $$ smbody
       body = batch.map do |msg|
@@ -188,16 +180,12 @@ module MitakeSms
         vldtime = msg[:vldtime] || ''
         dest_name = msg[:dest_name] || ''
         response_url = msg[:response] || ''
-        
+
         # Replace any newline characters in the message text with ASCII code 6 (ACK)
         # This is required by the Mitake API to represent line breaks within message content
         processed_text = msg[:text].to_s.gsub("\n", 6.chr)
-        
-        # URL encode the message content to handle special characters like '&'
-        # This is required by the Mitake API
-        text = URI.encode_www_form_component(processed_text)
 
-        [client_id, to, dlvtime, vldtime, dest_name, response_url, text].join('$$')
+        [client_id, to, dlvtime, vldtime, dest_name, response_url, processed_text].join('$$')
       end.join("\n")
 
       params = {

data/lib/mitake_sms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MitakeSms
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mitake_sms
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Zac