mistral_client 1.3.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae1d66612f62ddd3348a8f87e3a54e63751f5a34f7d47482c3df7dff3ce38a9f
-  data.tar.gz: 784c972293a9fb51b5ba960401260dc0f2e973eb80a0c322fe89218b85b48c0d
+  metadata.gz: 90addb71051ae5cbbb705a0fe9854e1886679dc13925b11d50ea30e099c76642
+  data.tar.gz: c2f00c0eceec0bf3e36c69869d88cd828b6a358fb75abafa6394b86bff15fae3
 SHA512:
-  metadata.gz: 6d909cc3677e550fe94be9a79796ee687697171729d845d7d27020cb69344d0c10a59a71862f401fef7008ada5cb7f8110f0e7428cb74ec34c3194fb54715381
-  data.tar.gz: 63f228bc0f7e2e469209de5dd94c14d8221e1728f554e30f6674ea053e74267a3b9b6dd4a3a69df8d2c5335ebd252a36c09fcb830d085af4bebb933e005c5b60
+  metadata.gz: f0a9877af1fec3a8dbe35eac14106303d943b3a19961957cfc0bf275efe69847f4cb1c9f235232925496d68d8b15da18dec67987f7daa674920e3b98ef5e89fe
+  data.tar.gz: 225f79f8b62fc39c86101d2200f2c7ebc639b05a91c1f91d1d58bfd8b12d8149fe406e30cd3268a0efd2734574d7b8ab3f701ee18de573d0ba028795939c42ac

data/.rspec

@@ -1 +1,2 @@
 --color
+--warnings

data/.rubocop.yml

@@ -1,5 +1,7 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 3.1
+  NewCops: disable
+  SuggestExtensions: false
 
 Style/Documentation:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.6.6
+3.1.4

data/.travis.yml

@@ -1,12 +1,7 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.3.8
-  - 2.4.10
-  - 2.5.8
-  - 2.6.6
+  - 3.1.4
+  - 3.2.2
 before_install:
   - gem install bundler
-branches:
-  only:
-    - master

data/CHANGELOG.md

@@ -5,6 +5,22 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [2.0.0] - 2021-02-09
+
+### Added
+- Added Ruby 2.7 and 3.0 to the Travis build matrix
+
+### Changed
+- Bumped the Ruby version for development to 3.0.0
+- Fixed deprecation warnings around positional and keyword arguments from ruby 2.7.0
+- Updated rubocop to v1.9.1, and fixed rubocop violations
+- Configured rspec to emit warnings, and fix them
+- Re-recorded the spec cassettes
+- Fixed broken links in the README
+
+### Removed
+- Removed Ruby 2.3 and 2.4 from the Travis build matrix
+
 ## [1.3.0] - 2020-04-20
 
 ### Changed
@@ -34,6 +50,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 * Initial Release
 
-[Unreleased]: https://github.com/civisanalytics/mistral_client/compare/v1.2.0...HEAD
+[Unreleased]: https://github.com/civisanalytics/mistral_client/compare/v2.0.0...HEAD
+[2.0.0]: https://github.com/civisanalytics/mistral_client/compare/v1.3.0...v2.0.0
+[1.3.0]: https://github.com/civisanalytics/mistral_client/compare/v1.2.1...v1.3.0
+[1.2.1]: https://github.com/civisanalytics/mistral_client/compare/v1.2.0...v1.2.1
 [1.2.0]: https://github.com/civisanalytics/mistral_client/compare/v1.1.0...v1.2.0
 [1.1.0]: https://github.com/civisanalytics/mistral_client/compare/v1.0.0...v1.1.0

data/README.md

@@ -1,14 +1,13 @@
 # MistralClient
 
-[![Build Status](https://travis-ci.org/civisanalytics/mistral_client.svg?branch=master)](https://travis-ci.org/civisanalytics/mistral_client)
+[![Build Status](https://travis-ci.com/civisanalytics/mistral_client.svg?branch=master)](https://travis-ci.com/civisanalytics/mistral_client)
 [![Gem Version](https://badge.fury.io/rb/mistral_client.svg)](http://badge.fury.io/rb/mistral_client)
-[![Dependency Status](https://gemnasium.com/civisanalytics/mistral_client.svg)](https://gemnasium.com/civisanalytics/mistral_client)
 
 MistralClient provides a Ruby interface to a limited subset of
 the [Mistral] [API].
 
-[Mistral]: https://wiki.openstack.org/wiki/Mistral
-[API]: https://docs.openstack.org/mistral/latest/api/v2.html
+[Mistral]: https://docs.openstack.org/mistral/latest/
+[API]: https://docs.openstack.org/mistral/latest/user/rest_api_v2.html
 
 ## Installation
 

data/lib/mistral_client/action_execution.rb

@@ -18,6 +18,7 @@ module MistralClient
     include MistralClient::Mixins::MistralObject
 
     def initialize(server, id: nil)
+      super()
       @server = server
       @path = 'action_executions'
       @id = id

data/lib/mistral_client/client.rb

@@ -38,9 +38,13 @@ module MistralClient
       }
     end
 
-    def method_missing(name, *args, &block)
+    def method_missing(name, *args, **kwargs, &block)
       if self.class.resources.keys.include?(name)
-        self.class.resources[name].new(self, *args)
+        if kwargs.nil? || kwargs.empty?
+          self.class.resources[name].new(self, *args)
+        else
+          self.class.resources[name].new(self, *args, **kwargs)
+        end
       else
         super
       end
@@ -60,7 +64,7 @@ module MistralClient
                 else
                   { 'Content-Type' => 'text/plain' }
                 end
-      options = @http_options.merge(headers: headers, body: body)
+      options = @http_options.merge(headers:, body:)
       resp = HTTParty.send(verb, "#{@base}/#{path}", options)
       check_for_error(resp)
       JSON.parse(resp.body)
@@ -68,9 +72,7 @@ module MistralClient
 
     def check_for_error(resp)
       return if resp.code >= 200 && resp.code < 300
-      if resp.code == 404
-        raise MissingObjectError, JSON.parse(resp.body)['faultstring']
-      end
+      raise MissingObjectError, JSON.parse(resp.body)['faultstring'] if resp.code == 404
 
       raise MistralResponseError.new(resp),
             "Could not perform the requested operation:\n#{resp.body}"

data/lib/mistral_client/environment.rb

@@ -8,8 +8,9 @@ module MistralClient
     include MistralClient::Mixins::Definable
 
     def initialize(server, definition = nil, name: nil)
+      super()
       @server = server
-      @definition = parse_definition(definition) if definition
+      @definition = definition ? parse_definition(definition) : nil
       @name = name
       if @name
         reload
@@ -38,9 +39,7 @@ module MistralClient
     end
 
     def massage_definition(definition)
-      if definition['variables'].is_a? Hash
-        definition['variables'] = definition['variables'].to_json
-      end
+      definition['variables'] = definition['variables'].to_json if definition['variables'].is_a? Hash
       definition
     end
   end

data/lib/mistral_client/error.rb

@@ -2,7 +2,9 @@ module MistralClient
   class MistralError < StandardError; end
 
   class ConfigurationError < MistralError; end
+
   class MissingObjectError < MistralError; end
+
   class MistralResponseError < MistralError
     attr_reader :response
 

data/lib/mistral_client/execution.rb

@@ -21,6 +21,7 @@ module MistralClient
     # rubocop:disable Metrics/ParameterLists
     def initialize(server, workflow_id: nil, env: nil, task_name: nil,
                    id: nil, input: nil)
+      super()
       set_attributes(server, workflow_id, env, task_name, id, input)
       if @id
         reload
@@ -34,7 +35,7 @@ module MistralClient
       body = {}
       body[:description] = description unless description.nil?
       body[:state] = state if state
-      body[:params] = { env: env } if env
+      body[:params] = { env: } if env
 
       return if body.empty?
 

data/lib/mistral_client/health.rb

@@ -3,6 +3,7 @@ module MistralClient
     PATH = ''.freeze
 
     def initialize(server)
+      super()
       @server = server
     end
 

data/lib/mistral_client/mixins/definable.rb

@@ -3,13 +3,11 @@ module MistralClient
     module Definable
       # rubocop:disable Metrics/MethodLength
       def parse_definition(definition)
-        if definition.is_a?(Hash) || definition.is_a?(Array)
-          return YAML.dump(definition)
-        end
+        return YAML.dump(definition) if definition.is_a?(Hash) || definition.is_a?(Array)
 
         definition = File.read(definition) if File.exist?(definition)
         # Called outside the if/else to validate the YAML.
-        parsed = YAML.safe_load(definition, [], [], true)
+        parsed = YAML.safe_load(definition, aliases: true)
         if defined? massage_definition
           massage_definition(parsed)
         else

data/lib/mistral_client/mixins/mistral_object.rb

@@ -17,7 +17,7 @@ module MistralClient
         self
       end
 
-      def list(params = {})
+      def list(**params)
         resp = @server.get("#{self.class::PATH}?#{URI.encode_www_form(params)}")
         resp[self.class::PATH].map do |t|
           task = self.class.new(@server)
@@ -27,7 +27,9 @@ module MistralClient
       end
 
       # rubocop:disable Metrics/AbcSize
+      # rubocop:disable Metrics/CyclomaticComplexity
       # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/PerceivedComplexity
       def ivars_from_response(resp)
         klass = self.class
         @id = resp['id']
@@ -38,15 +40,15 @@ module MistralClient
           instance_variable_set("@#{var}", resp[var]) if resp.key? var
         end
         klass::DATE_FIELDS.each do |var|
-          if resp[var]
-            instance_variable_set("@#{var}", DateTime.parse(resp[var]))
-          end
+          instance_variable_set("@#{var}", DateTime.parse(resp[var])) if resp[var]
         end
         klass::JSON_FIELDS.each do |var|
           instance_variable_set("@#{var}", JSON.parse(resp[var])) if resp[var]
         end
       end
+      # rubocop:enable Metrics/PerceivedComplexity
       # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/CyclomaticComplexity
       # rubocop:enable Metrics/AbcSize
     end
   end

data/lib/mistral_client/task.rb

@@ -20,6 +20,7 @@ module MistralClient
     include MistralClient::Mixins::MistralObject
 
     def initialize(server, id: nil)
+      super()
       @server = server
       @path = 'tasks'
       @id = id

data/lib/mistral_client/version.rb

@@ -1,3 +1,3 @@
 module MistralClient
-  VERSION = '1.3.0'.freeze
+  VERSION = '3.0.0'.freeze
 end

data/lib/mistral_client/workflow.rb

@@ -11,6 +11,7 @@ module MistralClient
     include MistralClient::Mixins::Deletable
 
     def initialize(server, definition = nil, id: nil, name: nil)
+      super()
       @server = server
       if definition
         @definition = parse_definition(definition)
@@ -24,9 +25,9 @@ module MistralClient
     def execute!(env: nil, task_name: nil, input: nil)
       Execution.new(@server,
                     workflow_id: @id,
-                    env: env,
-                    task_name: task_name,
-                    input: input)
+                    env:,
+                    task_name:,
+                    input:)
     end
 
     def valid?(definition)

data/mistral_client.gemspec

@@ -10,11 +10,11 @@ Gem::Specification.new do |spec|
 
   spec.summary       = 'Ruby client for Mistral.'
   spec.description   = "A Ruby client for OpenStack's Mistral " \
-                       '<https://wiki.openstack.org/wiki/Mistral>.'
+                       '<https://docs.openstack.org/mistral/latest/>.'
   spec.homepage      = 'https://github.com/civisanalytics/mistral_client'
-  spec.license       = 'BSD 3-Clause'
+  spec.license       = 'BSD-3-Clause'
 
-  spec.required_ruby_version = '~> 2.3'
+  spec.required_ruby_version = ['>= 3.1', '< 4']
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
@@ -22,12 +22,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'httparty', '~> 0.15'
-  spec.add_development_dependency 'bundler', '~> 2.1'
-  spec.add_development_dependency 'pry', '~> 0.13.1'
+  spec.add_dependency 'httparty', '~> 0.21.0'
+  spec.add_development_dependency 'bundler', '~> 2.5.7'
+  spec.add_development_dependency 'pry', '~> 0.14.2'
   spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rspec', '~> 3.9'
-  spec.add_development_dependency 'rubocop', '~> 0.81.0'
-  spec.add_development_dependency 'vcr', '~> 5.1'
-  spec.add_development_dependency 'webmock', '~> 3.8'
+  spec.add_development_dependency 'rspec', '~> 3.13.0'
+  spec.add_development_dependency 'rubocop', '~> 1.62.1'
+  spec.add_development_dependency 'vcr', '~> 6.2'
+  spec.add_development_dependency 'webmock', '~> 3.23'
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: mistral_client
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Matt Brennan
 - Jeff Cousens
 - Mike Saelim
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-04-21 00:00:00.000000000 Z
+date: 2024-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -18,42 +18,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.15'
+        version: 0.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.15'
+        version: 0.21.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: 2.5.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: 2.5.7
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.1
+        version: 0.14.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.1
+        version: 0.14.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -74,57 +74,57 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: 3.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: 3.13.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.81.0
+        version: 1.62.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.81.0
+        version: 1.62.1
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.23'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
-description: A Ruby client for OpenStack's Mistral <https://wiki.openstack.org/wiki/Mistral>.
+        version: '3.23'
+description: A Ruby client for OpenStack's Mistral <https://docs.openstack.org/mistral/latest/>.
 email:
 - opensource@civisanalytics.com
 executables: []
@@ -162,25 +162,28 @@ files:
 - mistral_client.gemspec
 homepage: https://github.com/civisanalytics/mistral_client
 licenses:
-- BSD 3-Clause
+- BSD-3-Clause
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '3.1'
+  - - "<"
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Ruby client for Mistral.
 test_files: []