mission_control-servers 0.3.2 → 0.4.0

data/app/controllers/mission_control/servers/dashboards/request_charts_controller.rb

@@ -0,0 +1,16 @@
+module MissionControl::Servers
+  class Dashboards::RequestChartsController < ApplicationController
+    def show
+      @project = MissionControl::Servers::Project.find_by(token: params[:project_id])
+      @hostname = params[:hostname]
+      recent_requests = @project.requests.recent_totals(@project, @hostname)
+      @summary_hash = {
+        sum_2xx: recent_requests.sum(:sum_2xx).to_i,
+        sum_3xx: recent_requests.sum(:sum_3xx).to_i,
+        sum_4xx: recent_requests.sum(:sum_4xx).to_i,
+        sum_5xx: recent_requests.sum(:sum_5xx).to_i,
+        unknown: recent_requests.sum(:unknown).to_i
+      }
+    end
+  end
+end

data/app/controllers/mission_control/servers/dashboards/request_totals_controller.rb

@@ -0,0 +1,15 @@
+module MissionControl::Servers
+  class Dashboards::RequestTotalsController < ApplicationController
+    def show
+      @project = Project.find_by(token: params[:project_id])
+      @hostname = params[:hostname]
+      recent_requests = @project.requests.recent_totals(@project, @hostname)
+      @total_sum = recent_requests.sum(:sum_2xx).to_i +
+        recent_requests.sum(:sum_3xx).to_i +
+        recent_requests.sum(:sum_4xx).to_i +
+        recent_requests.sum(:sum_5xx).to_i +
+        recent_requests.sum(:unknown).to_i
+
+    end
+  end
+end

data/app/controllers/mission_control/servers/ingresses_controller.rb

@@ -5,8 +5,8 @@ module MissionControl::Servers
 
     def create
       ingress = @project.services.new(ingress_params)
-
-      if ingress.save
+      request = @project.requests.new(tally_params)
+      if ingress.save && request.save
         head :ok
       else
         head :unprocessable_entity
@@ -22,5 +22,9 @@ module MissionControl::Servers
       def ingress_params
         params.require(:service).permit(:hostname, :cpu, :mem_used, :mem_free, :disk_free)
       end
+
+      def tally_params
+        params.require(:tally).permit(:hostname, :'sum_2xx', :'sum_3xx', :'sum_4xx', :'sum_5xx', :unknown)
+      end
   end
 end

data/app/controllers/mission_control/servers/service_settings_controller.rb

@@ -5,6 +5,7 @@ module MissionControl::Servers
       @service_setting = @project.service_settings.find_or_initialize_by(hostname: params[:id])
       @service_setting.label = params[:id] if @service_setting.new_record?
       @service_setting.save # To limit having to have a create action
+      @requests = @project.requests.select(:hostname).distinct.pluck(:hostname)
     end
 
     def update
@@ -21,7 +22,7 @@ module MissionControl::Servers
     end
 
     def label
-      params.require(:service_setting).permit(:label)
+      params.require(:service_setting).permit(:label, :hostname, :request_hostname)
     end
   end
 end

data/app/javascript/mission_control/servers/controllers/hostname_select_controller.js

@@ -0,0 +1,19 @@
+import { Controller } from "@hotwired/stimulus"
+
+export default class extends Controller {
+  static targets = ["input"]
+
+  connect() {
+    console.log("Hostname select controller connected");
+  }
+
+  copy(event) {
+    event.preventDefault();
+
+    const hostnameElement = event.target.closest('li').querySelector('[data-target="hostname"]');
+
+    if (hostnameElement) {
+      this.inputTarget.value = hostnameElement.textContent.trim();
+    }
+  }
+}

data/app/javascript/mission_control/servers/controllers/status_chart_controller.js

@@ -0,0 +1,97 @@
+import { Controller } from "@hotwired/stimulus"
+
+export default class extends Controller {
+  static values = {
+    data: String,
+    darkBorderColor: "rgb(255, 255, 255, 0.1)",
+    lightBorderColor: "rgb(0, 0, 0, 0.1)"
+  }
+
+  connect() {
+    this.observeHtmlClassChanges()
+    this.values = JSON.parse(this.dataValue)
+    this.displayChart()
+  }
+
+  observeHtmlClassChanges() {
+    const observer = new MutationObserver(mutations => {
+      mutations.forEach(mutation => {
+        if (mutation.type === "attributes" && mutation.attributeName === "class") {
+          this.updateChartColors()
+        }
+      })
+    })
+    observer.observe(document.documentElement, { attributes: true })
+  }
+
+  updateChartColors() {
+    const isDarkMode = document.documentElement.classList.contains('dark')
+    const borderColor = isDarkMode ? this.darkBorderColorValue : this.lightBorderColorValue
+    const backgroundColors = isDarkMode ? this.darkModeBackgroundColors() : this.lightModeBackgroundColors()
+
+    this.chart.data.datasets.forEach(dataset => {
+      dataset.borderColor = borderColor
+      dataset.backgroundColor = backgroundColors
+    })
+    this.chart.update()
+  }
+
+  darkModeBackgroundColors() {
+    return [
+      "rgb(45, 167, 167)",
+      "rgb(204, 175, 55)",
+      "rgb(204, 85, 0)",
+      "rgb(150, 75, 75)",
+      "rgb(85, 85, 255)"
+    ]
+  }
+
+  lightModeBackgroundColors() {
+    return [
+      "rgb(75, 192, 192)",
+      "rgb(255, 159, 64)",
+      "rgb(255, 99, 132)",
+      "rgb(153, 102, 255)",
+      "rgb(54, 162, 235)"
+    ]
+  }
+
+
+  displayChart() {
+    const isDarkMode = document.documentElement.classList.contains('dark')
+    const backgroundColors = isDarkMode ? this.darkModeBackgroundColors() : this.lightModeBackgroundColors()
+    const borderColor = isDarkMode ? this.darkBorderColorValue : this.lightBorderColorValue
+
+    this.chart = new Chart(this.element, {
+      type: 'doughnut',
+      data: {
+        labels: ['2xx', '3xx', '4xx', '5xx', 'Unknown'],
+        datasets: [{
+          data: [
+            this.values.sum_2xx,
+            this.values.sum_3xx,
+            this.values.sum_4xx,
+            this.values.sum_5xx,
+            this.values.unknown
+          ],
+          backgroundColor: backgroundColors,
+          borderColor: borderColor,
+          borderWidth: 1,
+          hoverOffset: 4
+        }]
+      },
+      options: {
+        responsive: true,
+        plugins: {
+          legend: {
+            position: 'top',
+          },
+          title: {
+            display: true,
+            text: 'HTTP Status Codes Distribution'
+          }
+        }
+      }
+    })
+  }
+}

data/app/models/mission_control/servers/project.rb

@@ -1,6 +1,7 @@
 module MissionControl::Servers
   class Project < ApplicationRecord
     has_many :services, dependent: :destroy
+    has_many :requests, dependent: :destroy
     has_many :service_settings, dependent: :destroy
     has_many :public_projects, dependent: :destroy
     has_secure_token :token

data/app/models/mission_control/servers/request.rb

@@ -0,0 +1,29 @@
+module MissionControl::Servers
+  class Request < ApplicationRecord
+    belongs_to :project
+    after_create :trim_old_requests
+
+    class << self
+      def recent_totals(project, hostname)
+        recent_requests(project, hostname)
+      end
+
+      def recent_requests(project, hostname)
+        where(
+          hostname: [service_setting(project, hostname), hostname].compact.uniq,
+          created_at: 1.minute.ago..
+        )
+      end
+
+      def service_setting(project, hostname)
+        project.service_settings.find_by(hostname: hostname)&.request_hostname
+      end
+    end
+
+    private
+
+      def trim_old_requests
+        project.requests.where(hostname: hostname).where(created_at: ..1.hour.ago).delete_all
+      end
+  end
+end

data/app/models/mission_control/servers/service.rb

@@ -6,83 +6,87 @@ module MissionControl::Servers
 
     scope :ordered, -> { order(created_at: :desc) }
 
-    def self.combo_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
-      timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
-      grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
-
-      cpu_usages = []
-      memory_usages = []
-      created_at_times = []
-
-      timestamps.each do |timestamp|
-        relevant_services = grouped_services[timestamp] || []
-        max_cpu_service = relevant_services.max_by(&:cpu)
-        max_memory_service = relevant_services.max_by do |service|
-          return 0 if service.mem_used.to_f + service.mem_free.to_f == 0.0
-          service.mem_used.to_f / (service.mem_used.to_f + service.mem_free.to_f)
+    class << self
+      def combo_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
+        timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
+        grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
+
+        cpu_usages = []
+        memory_usages = []
+        created_at_times = []
+
+        timestamps.each do |timestamp|
+          relevant_services = grouped_services[timestamp] || []
+          max_cpu_service = relevant_services.max_by(&:cpu)
+          max_memory_service = relevant_services.max_by do |service|
+            return 0 if service.mem_used.to_f + service.mem_free.to_f == 0.0
+            service.mem_used.to_f / (service.mem_used.to_f + service.mem_free.to_f)
+          end
+          cpu_usages << (max_cpu_service&.cpu || 0).to_f
+          if max_memory_service
+            total_memory = max_memory_service.mem_used.to_f + max_memory_service.mem_free.to_f
+            percentage_memory_used = (max_memory_service.mem_used.to_f / total_memory) * 100
+            memory_usages << percentage_memory_used.to_i
+          else
+            memory_usages << 0.0
+          end
+          created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
         end
-        cpu_usages << (max_cpu_service&.cpu || 0).to_f
-        if max_memory_service
-          total_memory = max_memory_service.mem_used.to_f + max_memory_service.mem_free.to_f
-          percentage_memory_used = (max_memory_service.mem_used.to_f / total_memory) * 100
-          memory_usages << percentage_memory_used.to_i
-        else
-          memory_usages << 0.0
-        end
-        created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
+
+        data = [
+          {
+            label: 'CPU Usage',
+            data: cpu_usages,
+            fill: true,
+            borderColor: "rgb(54, 162, 235)",
+            tension: 0.25
+          },
+          {
+            label: 'Memory Usage',
+            data: memory_usages,
+            fill: true,
+            borderColor: "rgb(235, 127, 54)",
+            tension: 0.25
+          }
+        ]
+        { created_at_times: created_at_times, data: data }
       end
 
-      data = [
-        {
-          label: 'CPU Usage',
-          data: cpu_usages,
-          fill: true,
-          borderColor: "rgb(54, 162, 235)",
-          tension: 0.25
-        },
-        {
-          label: 'Memory Usage',
-          data: memory_usages,
-          fill: true,
-          borderColor: "rgb(235, 127, 54)",
-          tension: 0.25
-        }
-      ]
-      { created_at_times: created_at_times, data: data }
-    end
 
-    def self.cpu_usage_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
-      timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
-      grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
+      def cpu_usage_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
+        timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
+        grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
 
-      cpu_usages = []
-      created_at_times = []
+        cpu_usages = []
+        created_at_times = []
+
+        timestamps.each do |timestamp|
+          relevant_services = grouped_services[timestamp] || []
+          max_cpu_service = relevant_services.max_by(&:cpu)
+          cpu_usages << (max_cpu_service&.cpu || 0).to_f
+          created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
+        end
 
-      timestamps.each do |timestamp|
-        relevant_services = grouped_services[timestamp] || []
-        max_cpu_service = relevant_services.max_by(&:cpu)
-        cpu_usages << (max_cpu_service&.cpu || 0).to_f
-        created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
+        { cpu_usages: cpu_usages, created_at_times: created_at_times }
       end
 
-      { cpu_usages: cpu_usages, created_at_times: created_at_times }
-    end
 
-    def self.memory_usage_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
-      timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
-      grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
+      def memory_usage_history(services, start_time: 1.hour.ago, end_time: Time.now.utc)
+        timestamps = (start_time.to_i..end_time.to_i).step(60).map { |t| Time.at(t).utc.change(sec: 0).to_i }
+        grouped_services = services.group_by { |service| service.created_at.utc.change(sec: 0).to_i }
 
-      memory_usages = []
-      created_at_times = []
+        memory_usages = []
+        created_at_times = []
 
-      timestamps.each do |timestamp|
-        relevant_services = grouped_services[timestamp] || []
-        max_memory_service = relevant_services.max_by(&:mem_used)
-        memory_usages << (max_memory_service&.mem_used || 0).to_f
-        created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
-      end
+        timestamps.each do |timestamp|
+          relevant_services = grouped_services[timestamp] || []
+          max_memory_service = relevant_services.max_by(&:mem_used)
+          memory_usages << (max_memory_service&.mem_used || 0).to_f
+          created_at_times << Time.at(timestamp).utc.strftime('%H:%M%p')
+        end
 
-      { memory_usages: memory_usages, created_at_times: created_at_times }
+        { memory_usages: memory_usages, created_at_times: created_at_times }
+      end
     end
 
     def mem_percent

data/app/models/mission_control/servers/service_setting.rb

@@ -1,5 +1,12 @@
 module MissionControl::Servers
   class ServiceSetting < ApplicationRecord
     belongs_to :project
+    before_create :set_request_hostname
+
+    private
+
+    def set_request_hostname
+      self.request_hostname ||= hostname
+    end
   end
 end

data/app/views/mission_control/servers/dashboards/request_charts/show.html.erb

@@ -0,0 +1,15 @@
+<%= turbo_frame_tag dom_id(@project, [@hostname, :request_chart].join('-')) do %>
+  <div class="progress-bar" style="height: 5px; width: 100%;">
+    <div class="progress" data-refresh-target="progressBar" style="height: 100%; width: 100%;"></div>
+  </div>
+  <div class="flex flex-col items-center justify-center bg-gray-400/5 p-8">
+    <dt class="pie-chart">
+      <canvas class="chart"
+        data-controller="status-chart"
+        data-status-chart-data-value="<%= @summary_hash.to_json %>"></canvas>
+    </dt>
+    <dd class="card-heading">
+      Response Codes
+    </dd>
+  </div>
+<% end %>

data/app/views/mission_control/servers/dashboards/request_totals/show.html.erb

@@ -0,0 +1,13 @@
+<%= turbo_frame_tag dom_id(@project, [@hostname, :request_total].join('-')) do %>
+  <div class="progress-bar bg-gray-300" style="height: 5px; width: 100%;">
+    <div class="progress bg-blue-500" data-refresh-target="progressBar" style="height: 100%; width: 100%;"></div>
+  </div>
+  <div class="flex flex-col bg-gray-400/5 p-8">
+    <dd class="card-heading">
+      Total Requests
+    </dd>
+    <dt class="stat-chart">
+      <%= number_with_delimiter @total_sum %>
+    </dt>
+  </div>
+<% end %>

data/app/views/mission_control/servers/projects/_panels.html.erb

@@ -1,7 +1,7 @@
 <%= tag.div id: [hostname, "tab-content"].join("-"), class: "py-4 sm:py-8 tab-content", "data-target": hostname, "data-tabs-target": "content" do %>
-  <div class="mx-auto max-w-7xl px-6 lg:px-8">
-    <div class="mx-auto max-w-2xl lg:max-w-none">
-      <dl class="grid grid-cols-1 gap-0.5 overflow-hidden rounded-2xl text-center sm:grid-cols-2 lg:grid-cols-4">
+  <div class="mx-auto  px-6 lg:px-8">
+    <div class="mx-auto  lg:max-w-none">
+      <dl class="grid grid-cols-1 gap-0.5 overflow-hidden rounded-2xl text-center sm:grid-cols-2 lg:grid-cols-6">
         <%= turbo_frame_tag dom_id(project, [hostname, :cpu_usage].join('-')),
           src: project_dashboards_cpu_usage_path(project_id: project.token, hostname: hostname),
           "data-controller": "refresh",
@@ -25,6 +25,18 @@
           "data-controller": "refresh",
           "data-refresh-src-value": project_dashboards_last_seen_path(project_id: project.token, hostname: hostname),
           "data-refresh-interval-value": 60000 %>
+
+        <%= turbo_frame_tag dom_id(project, [hostname, :request_total].join('-')),
+          src: project_dashboards_request_total_path(project_id: project.token, hostname: hostname),
+          "data-controller": "refresh",
+          "data-refresh-src-value": project_dashboards_request_total_path(project_id: project.token, hostname: hostname),
+          "data-refresh-interval-value": 60000 %>
+
+        <%= turbo_frame_tag dom_id(project, [hostname, :request_chart].join('-')),
+          src: project_dashboards_request_chart_path(project_id: project.token, hostname: hostname),
+          "data-controller": "refresh",
+          "data-refresh-src-value": project_dashboards_request_chart_path(project_id: project.token, hostname: hostname),
+          "data-refresh-interval-value": 60000 %>
       </dl>
       <% if params[:combo] == "false" %>
         <dl class="mt-8 grid grid-cols-1 gap-0.5 overflow-hidden rounded-2xl text-center sm:grid-cols-1 lg:grid-cols-2">

data/app/views/mission_control/servers/service_settings/edit.html.erb

@@ -7,13 +7,45 @@
   </div>
 </div>
 
-<div class="max-w-4xl mx-auto px-4 sm:px-6 lg:px-8 my-10">
+<div class="max-w-4xl mx-auto px-4 sm:px-6 lg:px-8 my-10" data-controller="hostname-select">
   <h1 class="text-2xl text-center font-semibold text-gray-normal mb-8">Editing <%= @service_setting.hostname %></h1>
   <%= form_with(model: [@project, @service_setting], class: "max-w-lg mx-auto my-10") do |form| %>
     <%= form.hidden_field :hostname %>
     <div class="mb-4">
       <%= form.label :label, class: "block text-gray-700 text-sm font-bold mb-2" %>
       <%= form.text_field :label, class: "shadow appearance-none border rounded w-full py-2 px-3 text-gray-700 leading-tight focus:outline-none focus:shadow-outline" %>
+      <p class="block text-gray-400 text-sm mt-1">
+        This is for display purposes on the dashboard. It's a good idea to name it something that makes sense to you.
+      </p>
+    </div>
+    <div class="mb-4">
+      <%= form.label :request_hostname, class: "block text-gray-700 text-sm font-bold mb-2" %>
+      <%= form.text_field :request_hostname, "data-hostname-select-target": "input",
+        class: "shadow appearance-none border rounded w-full py-2 px-3 text-gray-700 leading-tight focus:outline-none focus:shadow-outline" %>
+      <p class="block text-gray-400 text-sm mt-1">
+        With the server requets and status codes coming in, they may report a different hostname if you're running
+        them in docker or a different environment. This is the hostname that will be used to match the server.
+      </p>
+    </div>
+    <div class="border-t border-gray-100 px-4 py-6 sm:col-span-2 sm:px-0">
+      <dt class="text-sm font-medium leading-6 text-gray-900">Recent Hosts</dt>
+      <p class="block text-gray-400 text-sm mt-1">
+        Here are some of the recent hostnames that have been requested. You can select one of these if you'd like.
+      </p>
+      <dd class="mt-2 text-sm text-gray-900">
+        <ul role="list" class="divide-y divide-gray-100 rounded-md border border-gray-200">
+          <% @requests.each do |hostname| %>
+            <li class="flex items-center justify-between py-4 pl-4 pr-5 text-sm leading-6">
+              <div class="flex w-0 flex-1 items-center">
+                <span class="truncate font-medium dark:text-indigo-200" data-target="hostname"><%= hostname %></span>
+              </div>
+              <div class="ml-4 flex-shrink-0">
+                <a href="#" data-action="hostname-select#copy" class="font-medium text-indigo-600 dark:text-indigo-200">Select</a>
+              </div>
+            </li>
+          <% end %>
+        </ul>
+      </dd>
     </div>
     <div class="flex items-center justify-between">
       <%= form.submit class: "btn btn-primary btn-block" %>

data/config/routes.rb

@@ -13,6 +13,8 @@ MissionControl::Servers::Engine.routes.draw do
       resource :cpu_history, only: :show
       resource :memory_history, only: :show
       resource :combo_history, only: :show
+      resource :request_total, only: :show
+      resource :request_chart, only: :show
     end
   end
   root to: "projects#index"

data/db/migrate/20240213011036_create_mission_control_servers_requests.rb

@@ -0,0 +1,15 @@
+class CreateMissionControlServersRequests < ActiveRecord::Migration[7.1]
+  def change
+    create_table :mission_control_servers_requests do |t|
+      t.belongs_to :project, null: false, foreign_key: { to_table: :mission_control_servers_projects }
+      t.string :hostname
+      t.integer :sum_2xx, default: 0
+      t.integer :sum_3xx, default: 0
+      t.integer :sum_4xx, default: 0
+      t.integer :sum_5xx, default: 0
+      t.integer :unknown, default: 0
+
+      t.timestamps
+    end
+  end
+end

data/db/migrate/20240214021836_add_hostname_to_service_settings.rb

@@ -0,0 +1,5 @@
+class AddHostnameToServiceSettings < ActiveRecord::Migration[7.1]
+  def change
+    add_column :mission_control_servers_service_settings, :request_hostname, :string
+  end
+end

data/db/migrate/20240214160849_add_missing_mission_control_server_indexes.rb

@@ -0,0 +1,7 @@
+class AddMissingMissionControlServerIndexes < ActiveRecord::Migration[7.1]
+  def change
+    remove_index :mission_control_servers_services, :hostname
+    add_index :mission_control_servers_services, [:hostname, :created_at]
+    add_index :mission_control_servers_requests, [:hostname, :created_at]
+  end
+end

data/lib/mission_control/servers/engine.rb

@@ -5,8 +5,17 @@ require "stimulus-rails"
 module MissionControl
   module Servers
     class Engine < ::Rails::Engine
+      if ENV['RAILS_ENV'] == 'test'
+        require 'simplecov'
+        SimpleCov.start 'rails'
+      end
+
       isolate_namespace MissionControl::Servers
 
+      initializer 'mission_control-servers.middleware.request_tally' do |app|
+        app.middleware.use RequestTallyMiddleware
+      end
+
       initializer "mission_control-servers.assets" do |app|
         app.config.assets.paths << root.join("app/javascript")
         app.config.assets.precompile += %w[ mission_control_servers_manifest ]

data/lib/mission_control/servers/request_tally_middleware.rb

@@ -0,0 +1,53 @@
+module MissionControl
+  module Servers
+    class RequestTallyMiddleware
+      @@tally = Hash.new(0)
+
+      def initialize(app)
+        @app = app
+        @hostname = if ENV["KAMAL_VERSION"].present?
+          Socket.gethostname.to_s.split("-").first
+        else
+          ENV.fetch('HOSTNAME', Socket.gethostname)
+        end
+      end
+
+      def call(env)
+        req = Rack::Request.new(env)
+        if ingress_request?(req)
+          req.update_param('tally', @@tally.clone.merge('hostname' => @hostname))
+          @@tally.clear
+        end
+
+        status, headers, response = @app.call(env)
+
+        if !ingress_request?(req)
+          category = categorize_status(status)
+          update_tally(category)
+        end
+
+        [status, headers, response]
+      end
+
+      private
+
+      def ingress_request?(req)
+        req.post? && req.path.match?(/^\/[^\/]+\/projects\/[^\/]+\/ingress$/)
+      end
+
+      def update_tally(category)
+        @@tally[category] += 1
+      end
+
+      def categorize_status(status)
+        case status
+        when 200..299 then 'sum_2xx'
+        when 300..399 then 'sum_3xx'
+        when 400..499 then 'sum_4xx'
+        when 500..599 then 'sum_5xx'
+        else 'unknown'
+        end
+      end
+    end
+  end
+end