mints 0.0.25 → 0.0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 669d11338b95147afd994677e57df8df3664ca41db97d1531f6d3fda3589f79f
-  data.tar.gz: 6b41b7f19d801fcb3f9214542959689b717ce860d779f9c23fb6c6bbe2f42a61
+  metadata.gz: 6b16560bcbef38099113cdc45c5d892ef203d277bd47e43aa94854abfbbfd33b
+  data.tar.gz: d0d996931c6067787e310d42f157bea4c5f8fed63a52697cb48ba3f08aa1b05f
 SHA512:
-  metadata.gz: 6baebd5f78812bc3f58978e7449c31fa2b1b06800bb0600d87348c06954522e009440bb79d9e814117175fc021a2d44eeb6d97243b54565d243779529f86ac1c
-  data.tar.gz: 3704c229a2604519d09c4a4462b3a708aec04ded7ad76e6596b9753003a30e0008a865fc5eddd31160f2f3fd8d71474db4a9cb2715c1ba293ec60bc9e288162a
+  metadata.gz: 8246a30d4b83cc010f756992430a1530b861038f41fa31da9a463d49e1d3e6b8f598bad77e0ad0fdd31c18a9d13ecdf9fa46253408dd72d5bc4d9ba8ec9883fa
+  data.tar.gz: f574abc3608cc79b1b063ab49dfa60577bb64fb70a96398527270969c6b09ccb0965ef39fbcfb64a25429af5f5dccd09d72f7edd94374762d72d03db9d81f8f0

data/lib/client.rb

@@ -22,25 +22,30 @@ module Mints
       end
 
       def raw(action, url, options = nil, data = nil, base_url = nil, compatibility_options = {}, only_tracking = false)
-        if compatibility_options === nil
-          compatibility_options = {}
-        end
-        base_url = @base_url if !base_url
+        compatibility_options = {} if compatibility_options.nil?
+
+        base_url = @base_url unless base_url
         uri = ""
-        if (options && options.class == Hash)
-          if (options[:jfilters] && options[:jfilters].class == Hash)
-            options[:jfilters] = Base64.encode64(JSON.generate(options[:jfilters]))
+
+        if options&.class == Hash
+          need_encoding = %w[ jfilters afilters rfilters ]
+          found_options_with_encoding = options.keys.select {|key| need_encoding.include? key.to_s.downcase}
+
+          found_options_with_encoding.each do |key|
+            options[key] = CGI::escape(Base64.encode64(options[key].to_json))
           end
+
           uri = Addressable::URI.new
           uri.query_values = options
         end
 
         full_url = "#{@host}#{base_url}#{url}#{uri}"
         response = nil
-        if action === 'get'
 
-          template = ERB.new File.new("#{Rails.root}/mints_config.yml.erb").read
-          config = YAML.load template.result(binding)
+        template = ERB.new File.new("#{Rails.root}/mints_config.yml.erb").read
+        config = YAML.safe_load template.result(binding)
+
+        if action === 'get'
           url_need_cache = false
           result_from_cache = false
           time = 0
@@ -74,7 +79,7 @@ module Mints
             end
           end
 
-          if !url_need_cache
+          unless url_need_cache
             response = self.send("#{@scope}_#{action}", "#{full_url}", nil, compatibility_options)
           end
 
@@ -89,25 +94,23 @@ module Mints
           response = self.send("#{@scope}_#{action}", "#{full_url}", data, compatibility_options)
         end
 
+        verify_response_status(response, config['sdk']['ignore_http_errors'])
+
         begin
           if result_from_cache
             if @debug
               puts "Method: #{action} \nURL: #{url} \nOptions: #{options.to_json} \nOnly tracking: #{only_tracking} \nResponse from: REDIS"
-              if (data)
-                puts "Data: #{data.to_json}"
-              end
+              puts "Data: #{data.to_json}" if data
             end
+
             return JSON.parse(response)
           else
-            if (response.response.code == "404")
-              raise 'NotFoundError'
-            end
+
             if @debug
               puts "Method: #{action} \nURL: #{url} \nOptions: #{options.to_json} \nOnly tracking: #{only_tracking} \nResponse from: CALI"
-              if (data)
-                puts "Data: #{data.to_json}"
-              end
+              puts "Data: #{data.to_json}" if data
             end
+
             return JSON.parse(response.body)
           end
         rescue
@@ -123,7 +126,7 @@ module Mints
         name_len = name_spplited.size
         # the action always be the first element
         action = name_spplited.first
-        raise 'NoActionError' unless ['get', 'create', 'post', 'update', 'put', 'delete', 'destroy'].include?(action)
+        raise 'NoActionError' unless %w[get create post update put delete destroy verify_response_status].include?(action)
         # the object always be the last element
         object = separator == "__" ? name_spplited.last.gsub("_","-") : name_spplited.last
         # get intermediate url elements
@@ -210,7 +213,7 @@ module Mints
         end
       end
 
-      ##### HTTTP CLIENTS ######
+      ##### HTTP CLIENTS ######
       # Simple HTTP GET
       def http_get(url, headers = nil)
         # if @debug
@@ -220,7 +223,7 @@ module Mints
         #   puts headers
         #   puts "Method: get"
         # end
-        return headers ? HTTParty.get(url, :headers => headers) : HTTParty.get(url)
+        headers ? HTTParty.get(url, :headers => headers) : HTTParty.get(url)
       end
 
       # Simple HTTP POST
@@ -234,7 +237,7 @@ module Mints
         #   puts data
         #   puts "Method: post"
         # end
-        return headers ? HTTParty.post(url, :headers=> headers, :body => data) : HTTParty.post(url, :body => data)
+        headers ? HTTParty.post(url, :headers=> headers, :body => data) : HTTParty.post(url, :body => data)
       end
 
       # Simple HTTP PUT
@@ -248,7 +251,7 @@ module Mints
         #   puts data
         #   puts "Method: put"
         # end
-        return headers ? HTTParty.put(url, :headers=> headers, :body => data) : HTTParty.put(url, :body => data)
+        headers ? HTTParty.put(url, :headers=> headers, :body => data) : HTTParty.put(url, :body => data)
       end
 
       # Simple HTTP DELETE
@@ -262,7 +265,7 @@ module Mints
         #   puts data
         #   puts "Method: delete"
         # end
-        return headers ? HTTParty.delete(url, :headers=> headers, :body => data) : HTTParty.delete(url, :body => data)
+        headers ? HTTParty.delete(url, :headers=> headers, :body => data) : HTTParty.delete(url, :body => data)
       end
 
       # Start contact context
@@ -274,12 +277,14 @@ module Mints
         }
         h["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         h["Authorization"] = "Bearer #{@session_token}" if @session_token
+
         if headers
           headers.each do |k,v|
             h[k] = v
           end
         end
-        return self.http_get(url, h)
+
+        self.http_get(url, h)
       end
 
       def contact_post(url, data, compatibility_options)
@@ -288,9 +293,11 @@ module Mints
           "Accept" => "application/json",
           "ContactToken" => @contact_token_id
         }
+
         headers["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         headers["Authorization"] = "Bearer #{@session_token}" if @session_token
-        return self.http_post(url, headers, data)
+
+        self.http_post(url, headers, data)
       end
 
       def contact_put(url, data, compatibility_options)
@@ -301,7 +308,8 @@ module Mints
         }
         headers["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         headers["Authorization"] = "Bearer #{@session_token}" if @session_token
-        return self.http_put(url, headers, data)
+
+        self.http_put(url, headers, data)
       end
 
       # Start User context
@@ -317,7 +325,8 @@ module Mints
             h[k] = v
           end
         end
-        return self.http_get(url, h)
+
+        self.http_get(url, h)
       end
 
       def user_post(url, data, compatibility_options)
@@ -327,7 +336,8 @@ module Mints
         }
         headers["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         headers["Authorization"] = "Bearer #{@session_token}" if @session_token
-        return self.http_post(url, headers, data)
+
+        self.http_post(url, headers, data)
       end
 
       def user_put(url, data, compatibility_options)
@@ -337,7 +347,8 @@ module Mints
         }
         headers["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         headers["Authorization"] = "Bearer #{@session_token}" if @session_token
-        return self.http_put(url, headers, data)
+
+        self.http_put(url, headers, data)
       end
 
       def user_delete(url, data, compatibility_options)
@@ -347,7 +358,8 @@ module Mints
         }
         headers["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
         headers["Authorization"] = "Bearer #{@session_token}" if @session_token
-        return self.http_delete(url, headers, data)
+
+        self.http_delete(url, headers, data)
       end
       # End User Context
 
@@ -364,6 +376,7 @@ module Mints
             h[k] = v
           end
         end
+
         self.http_get(url, h)
       end
 
@@ -373,12 +386,14 @@ module Mints
           "ApiKey" => @api_key
         }
         h["Content-Type"] = "application/json" unless compatibility_options['no_content_type']
-        h["ContactToken"] = @session_token if @session_token
+        h["ContactToken"] = @contact_token_id if @contact_token_id
+
         if headers
           headers.each do |k,v|
             h[k] = v
           end
         end
+
         self.http_post(url, h, data)
       end
 
@@ -394,7 +409,30 @@ module Mints
             h[k] = v
           end
         end
+
         self.http_put(url, h, data)
       end
+
+      def verify_response_status(response, ignore_http_errors)
+        # Verify if the response is cached
+        unless response.kind_of? String
+          # Raise an error if response code is not 2xx
+          http_status = response&.response&.code&.to_i || 500
+          is_success = (http_status >= 200 and http_status < 300)
+
+          if !is_success and !ignore_http_errors
+            title = "Request failed with status #{http_status}"
+            detail = response&.response&.message || 'Unknown error'
+
+            puts "Error detected: #{http_status}" if @debug
+            error_class = Errors::DynamicError.new(self, title, detail, http_status, response&.parsed_response)
+
+            raise error_class if @debug
+
+            raise error_class.error
+          end
+        end
+      end
+
   end
 end

data/lib/contact.rb

@@ -1,5 +1,5 @@
 require_relative "./client.rb"
-require_relative "./mints_helper.rb"
+require_relative "./mints/helpers/mints_helper.rb"
 include ActionController::Cookies
 module Mints
   class Contact
@@ -38,7 +38,7 @@ module Mints
     #     }
     #     @mints_contact.register(data);
     def register(data)
-      return @client.raw("post", "/contacts/register", nil, data_transform(data))
+      @client.raw("post", "/contacts/register", nil, data_transform(data))
     end
 
     ##
@@ -74,7 +74,7 @@ module Mints
     #     data = { "email": "email@example.com" }
     #     @mints_contact.recover_password(data)
     def recover_password(data)
-      return @client.raw("post", "/contacts/recover-password", nil, data_transform(data))
+      @client.raw("post", "/contacts/recover-password", nil, data_transform(data))
     end
 
     ##
@@ -93,14 +93,14 @@ module Mints
     #     }
     #     @mints_contact.reset_password(data)
     def reset_password(data)
-      return @client.raw("post", "/contacts/reset-password", nil, data_transform(data))
+      @client.raw("post", "/contacts/reset-password", nil, data_transform(data))
     end
 
     ##
     # === OAuth Login.
     # Login a contact using oauth.
     def oauth_login(data)
-      return @client.raw("post", "/contacts/oauth-login", nil, data)
+      @client.raw("post", "/contacts/oauth-login", nil, data)
     end
 
     ##
@@ -151,7 +151,7 @@ module Mints
       else
         data['email'] = email_or_phone
       end
-      return @client.raw("post", "/contacts/magic-link", nil, { data: data }.to_json, '/api/v1')
+      @client.raw("post", "/contacts/magic-link", nil, { data: data }.to_json, '/api/v1')
     end
 
     ### CONTACT/V1 ###
@@ -173,7 +173,7 @@ module Mints
     #     } 
     #     @data = @mints_contact.me(options)
     def me(options = nil)
-      return @client.raw("get", "/me", options, nil, @contact_v1_url)
+      @client.raw("get", "/me", options, nil, @contact_v1_url)
     end
 
     ##
@@ -183,7 +183,7 @@ module Mints
     # ==== Example
     #     @data = @mints_contact.status
     def status
-      return @client.raw("get", "/status", nil, nil, @contact_v1_url)
+      @client.raw("get", "/status", nil, nil, @contact_v1_url)
     end
 
     ##
@@ -200,7 +200,7 @@ module Mints
     #     }
     #     @data = @mints_contact.update(data)
     def update(data)
-      return @client.raw("put", "/update", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/update", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -228,7 +228,7 @@ module Mints
     #     data = { "password": "new_password" }
     #     @data = @mints_contact.change_password(data)
     def change_password(data)
-      return @client.raw("post", "/change-password", nil, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/change-password", nil, data_transform(data), @contact_v1_url)
     end
 
     # Conversations
@@ -241,7 +241,7 @@ module Mints
     # options:: (Hash) -- List of Resource Collection Options shown above can be used as parameter.
     # FIXME: This method doesn't return data.
     def get_conversations(options = nil)
-      return @client.raw("get", "/content/conversations", options, nil, @contact_v1_url)
+      @client.raw("get", "/content/conversations", options, nil, @contact_v1_url)
     end
 
     ##
@@ -253,7 +253,7 @@ module Mints
     # options:: (Hash) -- List of Resource Collection Options shown above can be used as parameter.
     # FIXME: This method doesn't return data.
     def get_conversation(id, options = nil)
-      return @client.raw("get", "/content/conversations/#{id}", options, nil, @contact_v1_url)
+      @client.raw("get", "/content/conversations/#{id}", options, nil, @contact_v1_url)
     end
 
     ##
@@ -269,7 +269,7 @@ module Mints
     #     }
     #     @data = @mints_contact.create_conversation(data)
     def create_conversation(data)
-      return @client.raw("post", "/content/conversations", nil, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/content/conversations", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -281,7 +281,7 @@ module Mints
     # data:: (Hash) -- Data to be submitted.
     # FIXME: This method doesn't locate conversation id to be updated. 
     def update_conversation(id, data)
-      return @client.raw("put", "/content/conversations/#{id}", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/content/conversations/#{id}", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -293,7 +293,7 @@ module Mints
     # data:: (Hash) -- Data to be submitted.
     # FIXME: This method doesn't locate conversation id to be updated. 
     def update_conversation_status(id, data)
-      return @client.raw("put", "/content/conversations/#{id}/status", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/content/conversations/#{id}/status", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -305,7 +305,7 @@ module Mints
     # FIXME: This method doesn't locate conversation id to be updated. 
     def get_conversation_participants(id)
       #TODO: Test if this method needs data in options.
-      return @client.raw("get", "/content/conversations/#{id}/participants", nil, nil, @contact_v1_url)
+      @client.raw("get", "/content/conversations/#{id}/participants", nil, nil, @contact_v1_url)
     end
 
     ##
@@ -316,7 +316,7 @@ module Mints
     # options:: (Hash) -- List of Resource Collection Options shown above can be used as parameter.
     # FIXME: This method doesn't return data.
     def get_messages(options = nil)
-      return @client.raw("get", "/content/messages", options, nil, @contact_v1_url)
+      @client.raw("get", "/content/messages", options, nil, @contact_v1_url)
     end
 
     ##
@@ -328,7 +328,7 @@ module Mints
     # options:: (Hash) -- List of Resource Collection Options shown above can be used as parameter.
     # FIXME: This method doesn't return data.
     def get_message(id, options = nil)
-      return @client.raw("get", "/content/messages/#{id}", options, nil, @contact_v1_url)
+      @client.raw("get", "/content/messages/#{id}", options, nil, @contact_v1_url)
     end
 
     ##
@@ -348,7 +348,7 @@ module Mints
     #     }
     #     @data = @mints_contact.create_message(data)
     def create_message(data)
-      return @client.raw("post", "/content/messages", nil, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/content/messages", nil, data_transform(data), @contact_v1_url)
     end
 
     # Appointments
@@ -369,7 +369,7 @@ module Mints
     #     }
     #     @data = @mints_contact.get_appointments(options)
     def get_appointments(options = nil)
-      return @client.raw("get", "/contacts/appointments", options)
+      @client.raw("get", "/contacts/appointments", options)
     end
 
     ##
@@ -388,7 +388,7 @@ module Mints
     #     }
     #     @data = @mints_contact.get_appointment(1, options)
     def get_appointment(id, options = nil)
-      return @client.raw("get", "/contacts/appointments/#{id}", options)
+      @client.raw("get", "/contacts/appointments/#{id}", options)
     end
 
     ##
@@ -408,7 +408,7 @@ module Mints
     #     }
     #     @data = @mints_contact.create_appointment(data)
     def create_appointment(data)
-      return @client.raw("post", "/contacts/appointments", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments", nil, data_transform(data))
     end
 
     ##
@@ -425,7 +425,7 @@ module Mints
     #     }
     #     @data = @mints_contact.update_appointment(1, data)
     def update_appointment(id, data)
-      return @client.raw("put", "/contacts/appointments/#{id}", nil, data_transform(data))
+      @client.raw("put", "/contacts/appointments/#{id}", nil, data_transform(data))
     end
 
     ##
@@ -444,7 +444,7 @@ module Mints
     #     }
     #     @data = @mints_contact.scheduled_appointments(data)
     def scheduled_appointments(data)
-      return @client.raw("post", "/contacts/appointments/scheduled-appointments", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/scheduled-appointments", nil, data_transform(data))
     end
 
     ## 
@@ -461,7 +461,7 @@ module Mints
     #     }
     #     @data = @mints_contact.attach_invitee(data)
     def attach_invitee(data)
-      return @client.raw("post", "/contacts/appointments/attach-invitee", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/attach-invitee", nil, data_transform(data))
     end
 
     ##
@@ -478,7 +478,7 @@ module Mints
     #     }
     #     @data = @mints_contact.attach_follower(data)
     def attach_follower(data)
-      return @client.raw("post", "/contacts/appointments/attach-follower", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/attach-follower", nil, data_transform(data))
     end
 
     ##
@@ -495,7 +495,7 @@ module Mints
     #     }
     #     @data = @mints_contact.detach_invitee(data)
     def detach_invitee(data)
-      return @client.raw("post", "/contacts/appointments/detach-invitee", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/detach-invitee", nil, data_transform(data))
     end
 
     ##
@@ -512,7 +512,7 @@ module Mints
     #     }
     #     @data = @mints_contact.detach_follower(data)
     def detach_follower(data)
-      return @client.raw("post", "/contacts/appointments/detach-follower", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/detach-follower", nil, data_transform(data))
     end
 
     ##
@@ -529,7 +529,7 @@ module Mints
     #     }
     #     @data = @mints_contact.sync_invitee(data)
     def sync_invitee(data)
-      return @client.raw("post", "/contacts/appointments/sync-invitee", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/sync-invitee", nil, data_transform(data))
     end
 
     ##
@@ -546,7 +546,7 @@ module Mints
     #     }
     #     @data = @mints_contact.sync_follower(data)
     def sync_follower(data)
-      return @client.raw("post", "/contacts/appointments/sync-follower", nil, data_transform(data))
+      @client.raw("post", "/contacts/appointments/sync-follower", nil, data_transform(data))
     end
 
     ##
@@ -569,9 +569,9 @@ module Mints
     #     @data = @mints_pub.get_orders(options, false)
     def get_orders(options = nil, use_post = true)
       if use_post
-        return @client.raw("post", "/ecommerce/orders/query", options, nil, @contact_v1_url)
+        @client.raw("post", "/ecommerce/orders/query", options, nil, @contact_v1_url)
       else
-        return @client.raw("get", "/ecommerce/orders", options, nil, @contact_v1_url)
+        @client.raw("get", "/ecommerce/orders", options, nil, @contact_v1_url)
       end
     end
 
@@ -592,7 +592,7 @@ module Mints
     #     }
     #     @data = @mints_pub.get_product(25, options)
     def get_order(id, options = nil)
-      return @client.raw("get", "/ecommerce/orders/#{id}", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/orders/#{id}", options, nil, @contact_v1_url)
     end
 
     ##
@@ -610,7 +610,7 @@ module Mints
     #     }
     #     @data = @mints_pub.create_order(data)
     def create_order(data)
-      return @client.raw("post", "/ecommerce/orders", nil, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/ecommerce/orders", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -622,7 +622,7 @@ module Mints
     # data:: (Hash) -- Data to be submitted.
     # FIXME: This method doesnt update an order.
     def update_order(id, data)
-      return @client.raw("put", "/ecommerce/orders/#{id}", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/ecommerce/orders/#{id}", nil, data_transform(data), @contact_v1_url)
     end
 
     #TODO: No tested
@@ -634,7 +634,7 @@ module Mints
     # groupId:: (Integer) -- Order items group id.
     #
     def detach_order_item_from_order_item_group(orderItemId, groupId)
-      return @client.raw("put", "/ecommerce/order-items/detach/#{orderItemId}/order-items-groups/#{groupId}", nil, nil, @contact_v1_url)
+      @client.raw("put", "/ecommerce/order-items/detach/#{orderItemId}/order-items-groups/#{groupId}", nil, nil, @contact_v1_url)
     end
 
     #TODO: No tested
@@ -646,7 +646,7 @@ module Mints
     # groupId:: (Integer) -- Order items group id.
     #
     def update_order_item_from_order_item_group(orderItemId, groupId, data)
-      return @client.raw("put", "/ecommerce/order-items/update/#{orderItemId}/order-items-groups/#{groupId}", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/ecommerce/order-items/update/#{orderItemId}/order-items-groups/#{groupId}", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -657,7 +657,7 @@ module Mints
     #     @data = @mints_contact.get_my_shopping_cart
     # FIXME: This method returns a nil data.
     def get_my_shopping_cart(options = nil)
-      return @client.raw("get", "/ecommerce/my-shopping-cart", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/my-shopping-cart", options, nil, @contact_v1_url)
     end
 
     ##
@@ -675,7 +675,7 @@ module Mints
     #     }
     #     @data = @mints_contact.add_item_to_shopping_cart(data)
     def add_item_to_shopping_cart(data, options = nil)
-      return @client.raw("post", "/ecommerce/shopping-cart", options, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/ecommerce/shopping-cart", options, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -683,7 +683,7 @@ module Mints
     # Get a collection of order items.
     #TODO: Find a way to show order items.
     def get_order_items(options = nil)
-      return @client.raw("get", "/ecommerce/order-items", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/order-items", options, nil, @contact_v1_url)
     end
 
     ##
@@ -691,7 +691,7 @@ module Mints
     # Get an order item info.
     #TODO: Find a way to show order items.
     def get_order_item(id, options = nil)
-      return @client.raw("get", "/ecommerce/order-items/#{id}", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/order-items/#{id}", options, nil, @contact_v1_url)
     end
 
     ##
@@ -710,7 +710,7 @@ module Mints
     #     }
     #     @data = @mints_contact.get_order_item_groups(options)
     def get_order_item_groups(options = nil)
-      return @client.raw("get", "/ecommerce/order-items-groups", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/order-items-groups", options, nil, @contact_v1_url)
     end
 
     ##
@@ -730,7 +730,7 @@ module Mints
     #     }
     #     @data = @mints_contact.get_order_item_group(130, options)
     def get_order_item_group(id, options = nil)
-      return @client.raw("get", "/ecommerce/order-items-groups/#{id}", options, nil, @contact_v1_url)
+      @client.raw("get", "/ecommerce/order-items-groups/#{id}", options, nil, @contact_v1_url)
     end
 
     ##
@@ -758,7 +758,7 @@ module Mints
     #     }
     #     @data = @mints_contact.create_order_item_group(data)
     def create_order_item_group(data)
-      return @client.raw("post", "/ecommerce/order-items-groups", nil, data_transform(data), @contact_v1_url)
+      @client.raw("post", "/ecommerce/order-items-groups", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -775,7 +775,7 @@ module Mints
     #     }
     #     @data = @mints_contact.update_order_item_group(130, data)
     def update_order_item_group(id, data)
-      return @client.raw("put", "/ecommerce/order-items-groups/#{id}", nil, data_transform(data), @contact_v1_url)
+      @client.raw("put", "/ecommerce/order-items-groups/#{id}", nil, data_transform(data), @contact_v1_url)
     end
 
     ##
@@ -783,7 +783,7 @@ module Mints
     # Delete an order item group.
     # FIXME: This method doesn't work. Throw no action error. 
     def delete_order_item_group(id)
-      return @client.raw("delete", "/ecommerce/order-items-groups/#{id}", nil, nil, @contact_v1_url)
+      @client.raw("delete", "/ecommerce/order-items-groups/#{id}", nil, nil, @contact_v1_url)
     end
 
     private