minitest_rollbar 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cfa3a94ac9127ea129eb515847863aa955ad4f37
-  data.tar.gz: 3383a834cd51f36d99c673a9b5219b9a7e28f53c
+  metadata.gz: c364e80e6791171ac60e1d572d1b66d8751d2f15
+  data.tar.gz: 369c9601fb7944eccffb7f688d4ecf6e95742289
 SHA512:
-  metadata.gz: 4b35bea9a2e6b262b90b08df71e34c02d30f8f843ab256aab4e7ea3d8a4c15b4124a16f79e3e70e14a31964296ee9c68eb77c1972f29a1794e2a2650dcc4cdf6
-  data.tar.gz: 68f9211b4bca8c4447db10d408cb59270387576ba09d8c6e29a100c9b7a6de7e64c18b4a6d975720adbc46ff994edb7df2ec1a01b450408e40f2bfc85358bcf0
+  metadata.gz: 83123c2ede21ce086307087ebe90e2cd0efed85bf5f5e4241a106876f2fb2b0241d742f9653b7faa1d78b559763801fc321717d39ca4fd07ba5c4be143056975
+  data.tar.gz: 2223f889169c48921b5b4013d0cf0b0101f6ecced930a155624a538fa1df36bcf3e8c07bc260becfbdb3c65ba0154cbb715f401d9ce1dfd47c49edc3664fd8f4

data/README.md

@@ -30,6 +30,11 @@ Set up authentication token by:
 
     MinitestRollbar.access_token = {YOUR_TOKEN}
 
+By default we try to group occurrence by string returned by exception.inspect (Concatenate exception class name and message). We generate a fingerprint for that. To use rollbar's [default](https://rollbar.com/docs/grouping-algorithm/) default grouping algorithm, do
+
+    MinitestRollbar.use_default_grouping = true
+
+
 ## License
 
 This gem is available under the Simplified BSD License.

data/lib/minitest_rollbar/reporters.rb

@@ -4,6 +4,7 @@ require 'minitest/reporters'
 module MinitestRollbar
   class << self
     attr_accessor :access_token
+    attr_accessor :use_default_grouping
   end
 
   class RollbarReporter < Minitest::Reporters::BaseReporter
@@ -12,7 +13,7 @@ module MinitestRollbar
       @sequential_exception_count = 0
       # Inspect will return ExceptionType + Message.
       # E.g #<Selenium::WebDriver::Error::NoSuchWindowError: Window not found. The browser window may have been closed.>
-      # Use this as a criteria of grouping
+      # Use this as a criteria for log batch grouping
       @previous_exception_inspect_result = nil
       @previous_exception = nil
 
@@ -28,22 +29,17 @@ module MinitestRollbar
         current_exception = result.failure.exception
         current_exception_inspect_result = current_exception.inspect
 
-        # If there is no previous exception, start a fresh counter
         if @previous_exception_inspect_result.nil?
           record_new_error(current_exception)
-          # Report or increment the count the previous errors if a new error occurs
         elsif current_exception_inspect_result == @previous_exception_inspect_result
-          # Same error, increment counter
           increment_error_counting
-        else
-          # Different error, report previous errors and record new error
-          report_error_to_rollbar
+        else # New exception
+          report_error_to_rollbar notifier
           record_new_error current_exception
         end
       else
-        # Report previous errors if there is any
         unless @previous_exception.nil?
-          report_error_to_rollbar
+          report_error_to_rollbar notifier
           reset_error_counting
         end
       end
@@ -52,20 +48,20 @@ module MinitestRollbar
     def report
       super
       if @sequential_exception_count > 0
-        notifier = Rollbar.scope(count: @sequential_exception_count)
-        notifier.error(@previous_exception)
-
-        @previous_exception_inspect_result = nil
-        @previous_exception = nil
-        @sequential_exception_count = 0
-
+        report_error_to_rollbar notifier
+        reset_error_counting
       end
     end
 
     private
 
-    def report_error_to_rollbar
-      notifier = Rollbar.scope(count: @sequential_exception_count)
+    def notifier
+      MinitestRollbar.use_default_grouping.nil? ?
+          Rollbar.scope({count: @sequential_exception_count,  fingerprint: @previous_exception_inspect_result}):
+          Rollbar.scope({count: @sequential_exception_count})
+    end
+
+    def report_error_to_rollbar(notifier)
       notifier.error(@previous_exception)
     end
 

data/lib/minitest_rollbar/version.rb

@@ -1,3 +1,3 @@
 module MinitestRollbar
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.2.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest_rollbar
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Yuesong Wang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-04 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -98,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A minitest reporter that logs testexceptions to Rollbar.