minitest_change_assertions 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 131d9f66d84ad2ae5b8b0f768c773337f7c0b2b8
-  data.tar.gz: ade67cd29e944b8facff11bb2446e5c89825f96a
+  metadata.gz: da434b55f9d4ed35cb0b4626491918baad34d2c6
+  data.tar.gz: fa181a3a6db96c67e27bd82d475914da91ae81d1
 SHA512:
-  metadata.gz: 465ddf9b61d4ef86f834dd84458ac6ad81d26a2db4945b110656cd99c7d7f400451598628862ff5d1fb1fc0835a9c01fdfd2eb05cbb99822fe66c5fab27f6024
-  data.tar.gz: 0fe8d8c2d274ef123a0ca2f8c5aa56d5ad6919738c29939c12158cccb4c2a2473ec6f2687c686071756d9c3c3bc0be63e2bf3ecabeafabb075546893185ac7ac
+  metadata.gz: 74b44dd2b05f9fa695ef8754188dea4ce85aca22807d0367d6b8ac4a2c80e8ec0be4cfba814f31878760ccc3767a6b087a9f5459311fa349b2842e46c304183f
+  data.tar.gz: efbd6eb349c5d7a60bb34044b7a9b0767db6c0356f7f5740e738826de1dcc219525d0bb1de9aa5ecf1fd7b7c861259e1f708cfe9edb49bfe43b2b431ca8102b2

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 CHANGELOG
 ---------
 
-- **1.0.0 - UNRELEASED**
+- **1.0.1 - July 11, 2018**
+  - Fix incorrect assertions when using `:to` option
+  - Fix tests
+- **1.0.0 - July 11, 2018**
   - Initial Gem Release

data/lib/minitest_change_assertions/assertions.rb

@@ -7,16 +7,21 @@ Minitest::Assertions.module_eval do
     end
 
     if opts.key?(:to)
-      expected = opts[:to]
+      to = opts[:to]
     elsif opts.key?('to')
-      expected = opts['to']
+      to = opts['to']
     else
       expected = e.call
     end
 
     block.call
 
-    refute_equal expected, e.call
+
+    if to
+      assert_equal to, e.call
+    else
+      refute_equal expected, e.call
+    end
   end
 
   def assert_not_changed(expression, opts={}, &block)
@@ -27,15 +32,19 @@ Minitest::Assertions.module_eval do
     end
 
     if opts.key?(:to)
-      expected = opts[:to]
+      to = opts[:to]
     elsif opts.key?('to')
-      expected = opts['to']
+      to = opts['to']
     else
       expected = e.call
     end
 
     block.call
 
-    assert_equal expected, e.call
+    if to
+      refute_equal to, e.call
+    else
+      assert_equal expected, e.call
+    end
   end
 end

data/lib/minitest_change_assertions/version.rb

@@ -1,3 +1,3 @@
 module MinitestChangeAssertions
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/assertions_test.rb

@@ -16,42 +16,50 @@ class AssertionsTest < MiniTest::Test
   end
 
   def test_assert_changed
-    assert_changed 'user.name' do
-      user.name = 'Bob'
+    name = 'Allen'
+
+    assert_changed 'name' do
+      name = 'Bob'
     end
 
-    assert_changed -> { user.name } do
-      user.name = 'Bob'
+    assert_changed -> { name } do
+      name = 'Greg'
     end
 
     ### OR with optional :to argument
 
-    assert_changed 'user.name', to: 'Bob' do
-      user.name = 'Bob'
+    assert_changed 'name', to: 'Bob' do
+      name = 'Bob'
+    end
+
+    assert_changed -> { name }, to: 'Bob' do
+      name = 'Bob'
     end
 
-    assert_changed -> { user.name }, to: 'Bob' do
-      user.name = 'Bob'
+    assert_changed -> { name }, to: 'Greg' do
+      name = 'Greg'
     end
   end
 
   def test_assert_not_changed
-    assert_not_changed 'user.name' do
-      user.update(attrs)
+    name = 'Allen'
+
+    assert_not_changed 'name' do
+      name = 'Allen'
     end
 
-    assert_not_changed -> { user.name } do
-      user.update(attrs)
+    assert_not_changed -> { name } do
+      name = 'Allen'
     end
 
     ### OR with optional :to argument
 
-    assert_not_changed 'user.name', to: 'Allen' do
-      user.name = 'Bob'
+    assert_not_changed 'name', to: 'Greg' do
+      name = 'Bob'
     end
 
-    assert_not_changed -> { user.name }, to: 'Allen' do
-      user.name = 'Bob'
+    assert_not_changed -> { name }, to: 'Greg' do
+      name = 'Bob'
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest_change_assertions
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Weston Ganger