minitest 5.5.1 → 5.6.0

data/test/minitest/metametameta.rb

@@ -1,10 +1,10 @@
-require 'tempfile'
-require 'stringio'
-require 'minitest/autorun'
+require "tempfile"
+require "stringio"
+require "minitest/autorun"
 
 class Minitest::Test
   def clean s
-    s.gsub(/^ {6}/, '')
+    s.gsub(/^ {6}/, "")
   end
 end
 
@@ -55,17 +55,17 @@ class MetaMetaMetaTestCase < Minitest::Test
 
   def normalize_output output
     output.sub!(/Finished in .*/, "Finished in 0.00")
-    output.sub!(/Loaded suite .*/, 'Loaded suite blah')
+    output.sub!(/Loaded suite .*/, "Loaded suite blah")
 
-    output.gsub!(/ = \d+.\d\d s = /, ' = 0.00 s = ')
-    output.gsub!(/0x[A-Fa-f0-9]+/, '0xXXX')
-    output.gsub!(/ +$/, '')
+    output.gsub!(/ = \d+.\d\d s = /, " = 0.00 s = ")
+    output.gsub!(/0x[A-Fa-f0-9]+/, "0xXXX")
+    output.gsub!(/ +$/, "")
 
     if windows? then
-      output.gsub!(/\[(?:[A-Za-z]:)?[^\]:]+:\d+\]/, '[FILE:LINE]')
+      output.gsub!(/\[(?:[A-Za-z]:)?[^\]:]+:\d+\]/, "[FILE:LINE]")
       output.gsub!(/^(\s+)(?:[A-Za-z]:)?[^:]+:\d+:in/, '\1FILE:LINE:in')
     else
-      output.gsub!(/\[[^\]:]+:\d+\]/, '[FILE:LINE]')
+      output.gsub!(/\[[^\]:]+:\d+\]/, "[FILE:LINE]")
       output.gsub!(/^(\s+)[^:]+:\d+:in/, '\1FILE:LINE:in')
     end
 

data/test/minitest/test_minitest_benchmark.rb

@@ -1,5 +1,5 @@
-require 'minitest/autorun'
-require 'minitest/benchmark'
+require "minitest/autorun"
+require "minitest/benchmark"
 
 ##
 # Used to verify data:
@@ -111,7 +111,7 @@ class TestMinitestBenchmark < Minitest::Test
 
     # income to % of households below income amount
     # http://library.wolfram.com/infocenter/Conferences/6461/PowerLaws.nb
-    x = [15000, 25000, 35000, 50000, 75000, 100000]
+    x = [15_000, 25_000, 35_000, 50_000, 75_000, 100_000]
     y = [0.154, 0.283, 0.402, 0.55, 0.733, 0.843]
 
     # verified in numbers

data/test/minitest/test_minitest_mock.rb

@@ -1,4 +1,4 @@
-require 'minitest/autorun'
+require "minitest/autorun"
 
 class TestMinitestMock < Minitest::Test
   parallelize_me!
@@ -141,7 +141,7 @@ class TestMinitestMock < Minitest::Test
   def test_respond_appropriately
     assert @mock.respond_to?(:foo)
     assert @mock.respond_to?(:foo, true)
-    assert @mock.respond_to?('foo')
+    assert @mock.respond_to?("foo")
     assert !@mock.respond_to?(:bar)
   end
 
@@ -252,12 +252,10 @@ class TestMinitestMock < Minitest::Test
   end
 
   def test_mock_block_is_passed_function_params
-    arg1, arg2, arg3 = :bar, [1,2,3], {:a => 'a'}
+    arg1, arg2, arg3 = :bar, [1, 2, 3], { :a => "a" }
     mock = Minitest::Mock.new
     mock.expect :foo, nil do |a1, a2, a3|
-      a1 == arg1 &&
-      a2 == arg2 &&
-      a3 == arg3
+      a1 == arg1 && a2 == arg2 && a3 == arg3
     end
 
     mock.foo arg1, arg2, arg3
@@ -267,12 +265,12 @@ class TestMinitestMock < Minitest::Test
 
   def test_mock_block_is_passed_function_block
     mock = Minitest::Mock.new
-    block = proc { 'bar' }
+    block = proc { "bar" }
     mock.expect :foo, nil do |arg, &blk|
-      arg == 'foo' &&
+      arg == "foo" &&
       blk == block
     end
-    mock.foo 'foo', &block
+    mock.foo "foo", &block
     assert mock.verify
   end
 
@@ -339,7 +337,7 @@ class TestMinitestMock < Minitest::Test
 
   def test_mock_called_via_send_with_args
     mock = Minitest::Mock.new
-    mock.expect(:foo, true, [1,2,3])
+    mock.expect(:foo, true, [1, 2, 3])
 
     mock.send(:foo, 1, 2, 3)
     mock.verify
@@ -356,7 +354,7 @@ class TestMinitestStub < Minitest::Test
     super
     Minitest::Test.reset
 
-    @tc = Minitest::Test.new 'fake tc'
+    @tc = Minitest::Test.new "fake tc"
     @assertion_count = 1
   end
 
@@ -400,12 +398,12 @@ class TestMinitestStub < Minitest::Test
 
     fail_clapper = Class.new do
       def fail_clap
-        fail
+        raise
         :clap
       end
     end.new
 
-    fail_clapper.stub :fail, nil do |safe_clapper|
+    fail_clapper.stub :raise, nil do |safe_clapper|
       @tc.assert_equal :clap, safe_clapper.fail_clap # either form works
       @tc.assert_equal :clap, fail_clapper.fail_clap # yay closures
     end

data/test/minitest/test_minitest_spec.rb

@@ -32,7 +32,7 @@ describe Minitest::Spec do
   end
 
   after do
-    self.assertions.must_equal @assertion_count if passed? and not skipped?
+    _(self.assertions).must_equal @assertion_count if passed? and not skipped?
   end
 
   it "needs to be able to catch a Minitest::Assertion exception" do
@@ -112,11 +112,11 @@ describe Minitest::Spec do
     @assertion_count = 2
 
     methods = Object.public_instance_methods.find_all { |n| n =~ /^must|^wont/ }
-    methods.map! { |m| m.to_s } if Symbol === methods.first
+    methods.map!(&:to_s) if Symbol === methods.first
 
     musts, wonts = methods.sort.partition { |m| m =~ /^must/ }
 
-    expected_musts = %w(must_be
+    expected_musts = %w[must_be
                         must_be_close_to
                         must_be_empty
                         must_be_instance_of
@@ -132,7 +132,7 @@ describe Minitest::Spec do
                         must_output
                         must_raise
                         must_respond_to
-                        must_throw)
+                        must_throw]
 
     bad = %w[not raise throw send output be_silent]
 
@@ -442,6 +442,30 @@ describe Minitest::Spec do
     end
   end
 
+  describe "expect" do
+    before do
+      @assertion_count -= 3
+    end
+
+    it "can use expect" do
+      _(1 + 1).must_equal 2
+    end
+
+    it "can use expect with a lambda" do
+      _ { raise "blah" }.must_raise RuntimeError
+    end
+
+    it "can use expect in a thread" do
+      Thread.new { _(1 + 1).must_equal 2 }.join
+    end
+
+    it "can NOT use must_equal in a thread. It must use expect in a thread" do
+      assert_raises NoMethodError do
+        Thread.new { (1 + 1).must_equal 2 }.join
+      end
+    end
+  end
+
   it "needs to verify throw" do
     @assertion_count += 2 # 2 extra tests
 
@@ -519,7 +543,6 @@ describe Minitest::Spec do
       42.must_respond_to :clear, "msg"
     end
   end
-
 end
 
 describe Minitest::Spec, :let do
@@ -556,7 +579,7 @@ describe Minitest::Spec, :let do
     proc { self.class.let(:test_value) { true } }.must_raise ArgumentError
   end
 
-  it 'raises an error if the name shadows a normal instance method' do
+  it "raises an error if the name shadows a normal instance method" do
     proc { self.class.let(:message) { true } }.must_raise ArgumentError
   end
 
@@ -572,8 +595,8 @@ describe Minitest::Spec, :let do
     end.call.must_equal :good
   end
 
-  it 'procs come after dont_flip' do
-    p = proc{ }
+  it "procs come after dont_flip" do
+    p = proc { }
     assert_respond_to p, :call
     p.must_respond_to :call
   end
@@ -599,7 +622,7 @@ class TestMetaStatic < Minitest::Test
   def test_children
     Minitest::Spec.children.clear # prevents parallel run
 
-    x = y = z = nil
+    y = z = nil
     x = describe "top-level thingy" do
       y = describe "first thingy" do end
 
@@ -617,7 +640,7 @@ class TestMetaStatic < Minitest::Test
   def test_it_wont_remove_existing_child_test_methods
     Minitest::Spec.children.clear # prevents parallel run
 
-    outer = inner = nil
+    inner = nil
     outer = describe "outer" do
       inner = describe "inner" do
         it do
@@ -636,7 +659,7 @@ class TestMetaStatic < Minitest::Test
   def test_it_wont_add_test_methods_to_children
     Minitest::Spec.children.clear # prevents parallel run
 
-    outer = inner = nil
+    inner = nil
     outer = describe "outer" do
       inner = describe "inner" do end
       it do
@@ -655,7 +678,7 @@ class TestMeta < MetaMetaMetaTestCase
   parallelize_me!
 
   def util_structure
-    x = y = z = nil
+    y = z = nil
     before_list = []
     after_list  = []
     x = describe "top-level thingy" do
@@ -674,8 +697,8 @@ class TestMeta < MetaMetaMetaTestCase
           after  { after_list  << 3 }
           it "inner-it" do end
 
-          it      {} # ignore me
-          specify {} # anonymous it
+          it      { } # ignore me
+          specify { } # anonymous it
         end
       end
     end
@@ -690,7 +713,7 @@ class TestMeta < MetaMetaMetaTestCase
 
     Minitest::Spec.register_spec_type(/woot/, TestMeta)
 
-    p = lambda do |x| true end
+    p = lambda do |_| true end
     Minitest::Spec.register_spec_type TestMeta, &p
 
     keys = Minitest::Spec::TYPES.map(&:first)
@@ -708,7 +731,7 @@ class TestMeta < MetaMetaMetaTestCase
     Minitest::Spec.register_spec_type MiniSpecB do |desc|
       desc.superclass == ExampleA
     end
-    Minitest::Spec.register_spec_type MiniSpecC do |desc, *addl|
+    Minitest::Spec.register_spec_type MiniSpecC do |_desc, *addl|
       addl.include? :woot
     end
 
@@ -770,10 +793,10 @@ class TestMeta < MetaMetaMetaTestCase
     assert_equal "inner thingy",      y.desc
     assert_equal "very inner thingy", z.desc
 
-    top_methods = %w(setup teardown test_0001_top-level-it)
-    inner_methods1 = %w(setup teardown test_0001_inner-it)
+    top_methods = %w[setup teardown test_0001_top-level-it]
+    inner_methods1 = %w[setup teardown test_0001_inner-it]
     inner_methods2 = inner_methods1 +
-      %w(test_0002_anonymous test_0003_anonymous)
+      %w[test_0002_anonymous test_0003_anonymous]
 
     assert_equal top_methods,    x.instance_methods(false).sort.map(&:to_s)
     assert_equal inner_methods1, y.instance_methods(false).sort.map(&:to_s)
@@ -794,8 +817,8 @@ class TestMeta < MetaMetaMetaTestCase
       it "inner-it" do end
     end
 
-    assert_equal %w(test_0001_inner-it), y.instance_methods(false).map(&:to_s)
-    assert_equal %w(test_0001_inner-it), z.instance_methods(false).map(&:to_s)
+    assert_equal %w[test_0001_inner-it], y.instance_methods(false).map(&:to_s)
+    assert_equal %w[test_0001_inner-it], z.instance_methods(false).map(&:to_s)
   end
 
   def test_setup_teardown_behavior
@@ -811,7 +834,7 @@ class TestMeta < MetaMetaMetaTestCase
   end
 
   def test_describe_first_structure
-    x = x1 = x2 = y = z = nil
+    x1 = x2 = y = z = nil
     x = describe "top-level thingy" do
       y = describe "first thingy" do end
 
@@ -822,12 +845,11 @@ class TestMeta < MetaMetaMetaTestCase
     end
 
     test_methods = ["test_0001_top level it",
-                    "test_0002_не латинские &いった α, β, γ, δ, ε hello!!! world"
+                    "test_0002_не латинские &いった α, β, γ, δ, ε hello!!! world",
                    ].sort
 
     assert_equal test_methods, [x1, x2]
-    assert_equal test_methods,
-      x.instance_methods.grep(/^test/).map {|o| o.to_s}.sort
+    assert_equal test_methods, x.instance_methods.grep(/^test/).map(&:to_s).sort
     assert_equal [], y.instance_methods.grep(/^test/)
     assert_equal [], z.instance_methods.grep(/^test/)
   end
@@ -838,7 +860,7 @@ class TestMeta < MetaMetaMetaTestCase
       def xyz; end
     end
     y = Class.new x do
-      z = describe("inner") {}
+      z = describe("inner") { }
     end
 
     assert_respond_to x.new(nil), "xyz"

data/test/minitest/test_minitest_unit.rb

@@ -1,5 +1,5 @@
-require 'pathname'
-require 'minitest/metametameta'
+require "pathname"
+require "minitest/metametameta"
 
 module MyModule; end
 class AnError < StandardError; include MyModule; end
@@ -9,7 +9,7 @@ class TestMinitestUnit < MetaMetaMetaTestCase
   parallelize_me!
 
   pwd = Pathname.new File.expand_path Dir.pwd
-  basedir = Pathname.new(File.expand_path "lib/minitest") + 'mini'
+  basedir = Pathname.new(File.expand_path "lib/minitest") + "mini"
   basedir = basedir.relative_path_from(pwd).to_s
   MINITEST_BASE_DIR = basedir[/\A\./] ? basedir : "./#{basedir}"
   BT_MIDDLE = ["#{MINITEST_BASE_DIR}/test.rb:161:in `each'",
@@ -32,7 +32,7 @@ class TestMinitestUnit < MetaMetaMetaTestCase
           "test/test_autotest.rb:62:in `test_add_exception'"]
     ex = util_expand_bt ex
 
-    fu = Minitest::filter_backtrace(bt)
+    fu = Minitest.filter_backtrace(bt)
 
     assert_equal ex, fu
   end
@@ -42,7 +42,7 @@ class TestMinitestUnit < MetaMetaMetaTestCase
           BT_MIDDLE +
           ["#{MINITEST_BASE_DIR}/test.rb:29"])
     ex = bt.clone
-    fu = Minitest::filter_backtrace(bt)
+    fu = Minitest.filter_backtrace(bt)
     assert_equal ex, fu
   end
 
@@ -55,7 +55,7 @@ class TestMinitestUnit < MetaMetaMetaTestCase
     bt = util_expand_bt bt
 
     ex = ["-e:1"]
-    fu = Minitest::filter_backtrace bt
+    fu = Minitest.filter_backtrace bt
     assert_equal ex, fu
   end
 
@@ -99,7 +99,7 @@ class TestMinitestUnit < MetaMetaMetaTestCase
   end
 
   def util_expand_bt bt
-    if RUBY_VERSION >= '1.9.0' then
+    if RUBY_VERSION >= "1.9.0" then
       bt.map { |f| (f =~ /^\./) ? File.expand_path(f) : f }
     else
       bt
@@ -110,7 +110,7 @@ end
 class TestMinitestUnitInherited < MetaMetaMetaTestCase
   def with_overridden_include
     Class.class_eval do
-      def inherited_with_hacks klass
+      def inherited_with_hacks _klass
         throw :inherited_hook
       end
 
@@ -455,7 +455,7 @@ class TestMinitestRunner < MetaMetaMetaTestCase
     assert_report expected
   end
 
-  require 'monitor'
+  require "monitor"
 
   class Latch
     def initialize count = 1
@@ -675,7 +675,7 @@ class TestMinitestRunnable < Minitest::Test
   def test_marshal
     setup_marshal Minitest::Runnable
 
-    assert_marshal %w(@NAME @assertions @failures)
+    assert_marshal %w[@NAME @assertions @failures]
   end
 end
 
@@ -685,7 +685,7 @@ class TestMinitestTest < TestMinitestRunnable
       tc.time = 3.14
     end
 
-    assert_marshal %w(@NAME @assertions @failures @time) do |new_tc|
+    assert_marshal %w[@NAME @assertions @failures @time] do |new_tc|
       assert_in_epsilon 3.14, new_tc.time
     end
   end
@@ -696,14 +696,14 @@ class TestMinitestUnitTestCase < Minitest::Test
   # which is not threadsafe. Nearly every method in here is an
   # assertion test so it isn't worth splitting it out further.
 
-  RUBY18 = ! defined? Encoding
+  RUBY18 = !defined? Encoding
 
   def setup
     super
 
     Minitest::Test.reset
 
-    @tc = Minitest::Test.new 'fake tc'
+    @tc = Minitest::Test.new "fake tc"
     @zomg = "zomg ponies!"
     @assertion_count = 1
   end
@@ -851,7 +851,7 @@ class TestMinitestUnitTestCase < Minitest::Test
     util_assert_triggered msg do
       o1 = "blah" * 10
       o2 = "blah" * 10
-      def o1.== o
+      def o1.== _
         false
       end
       @tc.assert_equal o1, o2
@@ -917,18 +917,18 @@ class TestMinitestUnitTestCase < Minitest::Test
   def test_assert_in_epsilon
     @assertion_count = 10
 
-    @tc.assert_in_epsilon 10000, 9991
-    @tc.assert_in_epsilon 9991, 10000
+    @tc.assert_in_epsilon 10_000, 9991
+    @tc.assert_in_epsilon 9991, 10_000
     @tc.assert_in_epsilon 1.0, 1.001
     @tc.assert_in_epsilon 1.001, 1.0
 
-    @tc.assert_in_epsilon 10000, 9999.1, 0.0001
-    @tc.assert_in_epsilon 9999.1, 10000, 0.0001
+    @tc.assert_in_epsilon 10_000, 9999.1, 0.0001
+    @tc.assert_in_epsilon 9999.1, 10_000, 0.0001
     @tc.assert_in_epsilon 1.0, 1.0001, 0.0001
     @tc.assert_in_epsilon 1.0001, 1.0, 0.0001
 
     @tc.assert_in_epsilon(-1, -1)
-    @tc.assert_in_epsilon(-10000, -9991)
+    @tc.assert_in_epsilon(-10_000, -9991)
   end
 
   def test_epsilon_consistency
@@ -943,8 +943,8 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_assert_in_epsilon_triggered
-    util_assert_triggered 'Expected |10000 - 9990| (10) to be <= 9.99.' do
-      @tc.assert_in_epsilon 10000, 9990
+    util_assert_triggered "Expected |10000 - 9990| (10) to be <= 9.99." do
+      @tc.assert_in_epsilon 10_000, 9990
     end
   end
 
@@ -1002,7 +1002,7 @@ class TestMinitestUnitTestCase < Minitest::Test
     @assertion_count = 2
 
     pattern = Object.new
-    def pattern.=~(other) true end
+    def pattern.=~(_) true end
 
     @tc.assert_match pattern, 5
   end
@@ -1020,10 +1020,10 @@ class TestMinitestUnitTestCase < Minitest::Test
     @assertion_count = 2
 
     pattern = Object.new
-    def pattern.=~(other) false end
+    def pattern.=~(_) false end
     def pattern.inspect; "[Object]" end
 
-    util_assert_triggered 'Expected [Object] to match 5.' do
+    util_assert_triggered "Expected [Object] to match 5." do
       @tc.assert_match pattern, 5
     end
   end
@@ -1040,7 +1040,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_assert_nil_triggered
-    util_assert_triggered 'Expected 42 to be nil.' do
+    util_assert_triggered "Expected 42 to be nil." do
       @tc.assert_nil 42
     end
   end
@@ -1051,7 +1051,7 @@ class TestMinitestUnitTestCase < Minitest::Test
 
   def test_assert_operator_bad_object
     bad = Object.new
-    def bad.==(other) true end
+    def bad.==(_) true end
 
     @tc.assert_operator bad, :equal?, bad
   end
@@ -1183,8 +1183,8 @@ class TestMinitestUnitTestCase < Minitest::Test
       ---------------
     EOM
 
-    actual = e.message.gsub(/^.+:\d+/, 'FILE:LINE')
-    actual.gsub!(/block \(\d+ levels\) in /, '') if RUBY_VERSION >= '1.9.0'
+    actual = e.message.gsub(/^.+:\d+/, "FILE:LINE")
+    actual.gsub!(/block \(\d+ levels\) in /, "") if RUBY_VERSION >= "1.9.0"
 
     assert_equal expected, actual
   end
@@ -1206,8 +1206,8 @@ class TestMinitestUnitTestCase < Minitest::Test
       ---------------
     EOM
 
-    actual = e.message.gsub(/^.+:\d+/, 'FILE:LINE')
-    actual.gsub!(/block \(\d+ levels\) in /, '') if RUBY_VERSION >= '1.9.0'
+    actual = e.message.gsub(/^.+:\d+/, "FILE:LINE")
+    actual.gsub!(/block \(\d+ levels\) in /, "") if RUBY_VERSION >= "1.9.0"
 
     assert_equal expected.chomp, actual
   end
@@ -1252,8 +1252,8 @@ class TestMinitestUnitTestCase < Minitest::Test
       ---------------
     EOM
 
-    actual = e.message.gsub(/^.+:\d+/, 'FILE:LINE')
-    actual.gsub!(/block \(\d+ levels\) in /, '') if RUBY_VERSION >= '1.9.0'
+    actual = e.message.gsub(/^.+:\d+/, "FILE:LINE")
+    actual.gsub!(/block \(\d+ levels\) in /, "") if RUBY_VERSION >= "1.9.0"
 
     assert_equal expected, actual
   end
@@ -1280,7 +1280,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   def test_assert_same_triggered
     @assertion_count = 2
 
-    util_assert_triggered 'Expected 2 (oid=N) to be the same as 1 (oid=N).' do
+    util_assert_triggered "Expected 2 (oid=N) to be the same as 1 (oid=N)." do
       @tc.assert_same 1, 2
     end
 
@@ -1335,7 +1335,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_assert_throws_different
-    util_assert_triggered 'Expected :blah to have been thrown, not :not_blah.' do
+    util_assert_triggered "Expected :blah to have been thrown, not :not_blah." do
       @tc.assert_throws :blah do
         throw :not_blah
       end
@@ -1343,7 +1343,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_assert_throws_unthrown
-    util_assert_triggered 'Expected :blah to have been thrown.' do
+    util_assert_triggered "Expected :blah to have been thrown." do
       @tc.assert_throws :blah do
         # do nothing
       end
@@ -1355,8 +1355,8 @@ class TestMinitestUnitTestCase < Minitest::Test
 
     non_verbose do
       out, err = capture_io do
-        puts 'hi'
-        $stderr.puts 'bye!'
+        puts "hi"
+        $stderr.puts "bye!"
       end
 
       assert_equal "hi\n", out
@@ -1369,12 +1369,12 @@ class TestMinitestUnitTestCase < Minitest::Test
 
     non_verbose do
       out, err = capture_subprocess_io do
-        system("echo 'hi'")
-        system("echo 'bye!' 1>&2")
+        system("echo hi")
+        system("echo bye! 1>&2")
       end
 
       assert_equal "hi\n", out
-      assert_equal "bye!\n", err
+      assert_equal "bye!", err.strip
     end
   end
 
@@ -1382,7 +1382,7 @@ class TestMinitestUnitTestCase < Minitest::Test
     @assertion_count = 0
 
     methods = Minitest::Assertions.public_instance_methods
-    methods.map! { |m| m.to_s } if Symbol === methods.first
+    methods.map!(&:to_s) if Symbol === methods.first
 
     # These don't have corresponding refutes _on purpose_. They're
     # useless and will never be added, so don't bother.
@@ -1397,12 +1397,12 @@ class TestMinitestUnitTestCase < Minitest::Test
     asserts = methods.grep(/^assert/).sort - ignores
     refutes = methods.grep(/^refute/).sort - ignores
 
-    assert_empty refutes.map { |n| n.sub(/^refute/, 'assert') } - asserts
-    assert_empty asserts.map { |n| n.sub(/^assert/, 'refute') } - refutes
+    assert_empty refutes.map { |n| n.sub(/^refute/, "assert") } - asserts
+    assert_empty asserts.map { |n| n.sub(/^assert/, "refute") } - refutes
   end
 
   def test_flunk
-    util_assert_triggered 'Epic Fail!' do
+    util_assert_triggered "Epic Fail!" do
       @tc.flunk
     end
   end
@@ -1458,7 +1458,7 @@ class TestMinitestUnitTestCase < Minitest::Test
 
   def test_prints
     printer = Class.new { extend Minitest::Assertions }
-    @tc.assert_equal '"test"', printer.mu_pp(ImmutableString.new 'test')
+    @tc.assert_equal '"test"', printer.mu_pp(ImmutableString.new "test")
   end
 
   def test_refute
@@ -1503,13 +1503,13 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_refute_in_epsilon
-    @tc.refute_in_epsilon 10000, 9990-1
+    @tc.refute_in_epsilon 10_000, 9990-1
   end
 
   def test_refute_in_epsilon_triggered
-    util_assert_triggered 'Expected |10000 - 9990| (10) to not be <= 10.0.' do
-      @tc.refute_in_epsilon 10000, 9990
-      fail
+    util_assert_triggered "Expected |10000 - 9990| (10) to not be <= 10.0." do
+      @tc.refute_in_epsilon 10_000, 9990
+      flunk
     end
   end
 
@@ -1564,10 +1564,10 @@ class TestMinitestUnitTestCase < Minitest::Test
     @assertion_count = 2
 
     pattern = Object.new
-    def pattern.=~(other) true end
+    def pattern.=~(_) true end
     def pattern.inspect; "[Object]" end
 
-    util_assert_triggered 'Expected [Object] to not match 5.' do
+    util_assert_triggered "Expected [Object] to not match 5." do
       @tc.refute_match pattern, 5
     end
   end
@@ -1584,7 +1584,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_refute_nil_triggered
-    util_assert_triggered 'Expected nil to not be nil.' do
+    util_assert_triggered "Expected nil to not be nil." do
       @tc.refute_nil nil
     end
   end
@@ -1605,7 +1605,7 @@ class TestMinitestUnitTestCase < Minitest::Test
 
   def test_refute_operator_bad_object
     bad = Object.new
-    def bad.==(other) true end
+    def bad.==(_) true end
 
     @tc.refute_operator true, :equal?, bad
   end
@@ -1631,7 +1631,7 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def test_refute_same_triggered
-    util_assert_triggered 'Expected 1 (oid=N) to not be the same as 1 (oid=N).' do
+    util_assert_triggered "Expected 1 (oid=N) to not be the same as 1 (oid=N)." do
       @tc.refute_same 1, 1
     end
   end
@@ -1657,9 +1657,9 @@ class TestMinitestUnitTestCase < Minitest::Test
     srand 42
     expected = case
                when maglev? then
-                 %w(test_test2 test_test3 test_test1)
+                 %w[test_test2 test_test3 test_test1]
                else
-                 %w(test_test2 test_test1 test_test3)
+                 %w[test_test2 test_test1 test_test3]
                end
     assert_equal expected, sample_test_case.runnable_methods
   end
@@ -1674,7 +1674,7 @@ class TestMinitestUnitTestCase < Minitest::Test
       def test_test1; assert "does not matter" end
     end
 
-    expected = %w(test_test1 test_test2 test_test3)
+    expected = %w[test_test1 test_test2 test_test3]
     assert_equal expected, sample_test_case.runnable_methods
   end
 
@@ -1693,7 +1693,7 @@ class TestMinitestUnitTestCase < Minitest::Test
 
     shitty_test_case = Class.new Minitest::Test
 
-    def shitty_test_case.test_order ; :lol end
+    def shitty_test_case.test_order; :lol end
 
     assert_silent do
       shitty_test_case.i_suck_and_my_tests_are_order_dependent!
@@ -1706,7 +1706,7 @@ class TestMinitestUnitTestCase < Minitest::Test
     end
 
     msg = e.message.sub(/(---Backtrace---).*/m, '\1')
-    msg.gsub!(/\(oid=[-0-9]+\)/, '(oid=N)')
+    msg.gsub!(/\(oid=[-0-9]+\)/, "(oid=N)")
     msg.gsub!(/(\d\.\d{6})\d+/, '\1xxx') # normalize: ruby version, impl, platform
 
     assert_equal expected, msg