minitest 5.23.1 → 5.25.1

data/lib/minitest/mock.rb

@@ -8,7 +8,7 @@ module Minitest # :nodoc:
   # All mock objects are an instance of Mock
 
   class Mock
-    alias :__respond_to? :respond_to?
+    alias __respond_to? respond_to?
 
     overridden_methods = %i[
       ===
@@ -93,7 +93,7 @@ module Minitest # :nodoc:
     def expect name, retval, args = [], **kwargs, &blk
       name = name.to_sym
 
-      if block_given?
+      if blk then
         raise ArgumentError, "args ignored when block given" unless args.empty?
         raise ArgumentError, "kwargs ignored when block given" unless kwargs.empty?
         @expected_calls[name] << { :retval => retval, :block => blk }
@@ -106,7 +106,7 @@ module Minitest # :nodoc:
             kwargs = args.pop
           else
             unless @@KW_WARNED then
-              from = caller.first
+              from = caller(1..1).first
               warn "Using MT_KWARGS_HAC\K yet passing kwargs. From #{from}"
               @@KW_WARNED = true
             end
@@ -141,7 +141,7 @@ module Minitest # :nodoc:
 
     def verify
       @expected_calls.each do |name, expected|
-        actual = @actual_calls.fetch(name, nil)
+        actual = @actual_calls.fetch name, nil # defaults to []
         raise MockExpectationError, "expected #{__call name, expected[0]}" unless actual
         raise MockExpectationError, "expected #{__call name, expected[actual.size]}, got [#{__call name, actual}]" if
           actual.size < expected.size
@@ -150,7 +150,7 @@ module Minitest # :nodoc:
     end
 
     def method_missing sym, *args, **kwargs, &block # :nodoc:
-      unless @expected_calls.key?(sym) then
+      unless @expected_calls.key? sym then
         if @delegator && @delegator.respond_to?(sym)
           if kwargs.empty? then # FIX: drop this after 2.7 dead
             return @delegator.public_send(sym, *args, &block)
@@ -172,9 +172,9 @@ module Minitest # :nodoc:
       end
 
       expected_args, expected_kwargs, retval, val_block =
-        expected_call.values_at(:args, :kwargs, :retval, :block)
+        expected_call.values_at :args, :kwargs, :retval, :block
 
-      expected_kwargs = kwargs.map { |ak, av| [ak, Object] }.to_h if
+      expected_kwargs = kwargs.to_h { |ak, av| [ak, Object] } if
         Hash == expected_kwargs
 
       if val_block then
@@ -197,7 +197,7 @@ module Minitest # :nodoc:
           [sym, expected_kwargs.size, kwargs]
       end
 
-      zipped_args = expected_args.zip(args)
+      zipped_args = expected_args.zip args
       fully_matched = zipped_args.all? { |mod, a|
         mod === a or mod == a
       }
@@ -212,10 +212,10 @@ module Minitest # :nodoc:
         raise MockExpectationError, fmt % [sym, expected_kwargs.keys, kwargs.keys]
       end
 
-      zipped_kwargs = expected_kwargs.map { |ek, ev|
+      zipped_kwargs = expected_kwargs.to_h { |ek, ev|
         av = kwargs[ek]
         [ek, [ev, av]]
-      }.to_h
+      }
 
       fully_matched = zipped_kwargs.all? { |ek, (ev, av)|
         ev === av or ev == av
@@ -228,8 +228,8 @@ module Minitest # :nodoc:
 
       @actual_calls[sym] << {
         :retval => retval,
-        :args => zipped_args.map { |e, a| e === a ? e : a },
-        :kwargs => zipped_kwargs.map { |k, (e, a)| [k, e === a ? e : a] }.to_h,
+        :args   => zipped_args.map { |e, a| e === a ? e : a },
+        :kwargs => zipped_kwargs.to_h { |k, (e, a)| [k, e === a ? e : a] },
       }
 
       retval
@@ -238,7 +238,7 @@ module Minitest # :nodoc:
     def respond_to? sym, include_private = false # :nodoc:
       return true if @expected_calls.key? sym.to_sym
       return true if @delegator && @delegator.respond_to?(sym, include_private)
-      __respond_to?(sym, include_private)
+      __respond_to? sym, include_private
     end
   end
 end

data/lib/minitest/parallel.rb

@@ -1,5 +1,5 @@
 module Minitest
-  module Parallel #:nodoc:
+  module Parallel # :nodoc:
 
     ##
     # The engine used to run multiple tests in parallel.
@@ -24,10 +24,10 @@ module Minitest
       # Start the executor
 
       def start
-        @pool  = size.times.map {
-          Thread.new(@queue) do |queue|
+        @pool  = Array.new(size) {
+          Thread.new @queue do |queue|
             Thread.current.abort_on_exception = true
-            while (job = queue.pop)
+            while job = queue.pop do
               klass, method, reporter = job
               reporter.synchronize { reporter.prerecord klass, method }
               result = Minitest.run_one_method klass, method

data/lib/minitest/pride_plugin.rb

@@ -8,13 +8,13 @@ module Minitest
   end
 
   def self.plugin_pride_init options # :nodoc:
-    if PrideIO.pride? then
-      klass = ENV["TERM"] =~ /^xterm|-256color$/ ? PrideLOL : PrideIO
-      io    = klass.new options[:io]
+    return unless PrideIO.pride?
 
-      self.reporter.reporters.grep(Minitest::Reporter).each do |rep|
-        rep.io = io if rep.io.tty?
-      end
+    klass = ENV["TERM"] =~ /^xterm|-256color$/ ? PrideLOL : PrideIO
+    io    = klass.new options[:io]
+
+    self.reporter.reporters.grep(Minitest::Reporter).each do |rep|
+      rep.io = io if rep.io.tty?
     end
   end
 
@@ -59,12 +59,10 @@ module Minitest
 
     def print o
       case o
-      when "." then
+      when ".", "S" then
         io.print pride o
       when "E", "F" then
         io.print "#{ESC}41m#{ESC}37m#{o}#{NND}"
-      when "S" then
-        io.print pride o
       else
         io.print o
       end
@@ -72,11 +70,9 @@ module Minitest
 
     def puts *o # :nodoc:
       o.map! { |s|
-        s.to_s.sub(/Finished/) {
+        s.to_s.sub("Finished") {
           @index = 0
-          "Fabulous run".split(//).map { |c|
-            pride(c)
-          }.join
+          "Fabulous run".chars.map { |c| pride(c) }.join
         }
       }
 
@@ -113,7 +109,7 @@ module Minitest
       #
       #   plot (3*sin(x)+3), (3*sin(x+2*pi/3)+3), (3*sin(x+4*pi/3)+3)
 
-      @colors = (6 * 7).times.map { |n|
+      @colors = Array.new(6 * 7) { |n|
         n *= 1.0 / 3
         r  = (3 * Math.sin(n           ) + 3).to_i
         g  = (3 * Math.sin(n + 4 * PI_3) + 3).to_i

data/lib/minitest/spec.rb

@@ -4,11 +4,11 @@ class Module # :nodoc:
   def infect_an_assertion meth, new_name, dont_flip = false # :nodoc:
     block = dont_flip == :block
     dont_flip = false if block
-    target_obj = block ? '_{obj.method}' : '_(obj)'
+    target_obj = block ? "_{obj.method}" : "_(obj)"
 
     # https://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html
     # Drop this when we can drop ruby 2.6 (aka after rails 6.1 EOL, ~2024-06)
-    kw_extra = "ruby2_keywords %p" % [new_name] if respond_to?(:ruby2_keywords, true)
+    kw_extra = "ruby2_keywords %p" % [new_name] if respond_to? :ruby2_keywords, true
 
     # warn "%-22p -> %p %p" % [meth, new_name, dont_flip]
     self.class_eval <<-EOM, __FILE__, __LINE__ + 1
@@ -249,7 +249,7 @@ class Minitest::Spec < Minitest::Test
       pre, post = "let '#{name}' cannot ", ". Please use another name."
       methods = Minitest::Spec.instance_methods.map(&:to_s) - %w[subject]
       raise ArgumentError, "#{pre}begin with 'test'#{post}" if
-        name =~ /\Atest/
+        name.start_with? "test"
       raise ArgumentError, "#{pre}override a method in Minitest::Spec#{post}" if
         methods.include? name
 
@@ -268,7 +268,7 @@ class Minitest::Spec < Minitest::Test
     end
 
     def create name, desc # :nodoc:
-      cls = Class.new(self) do
+      cls = Class.new self do
         @name = name
         @desc = desc
 
@@ -289,7 +289,7 @@ class Minitest::Spec < Minitest::Test
     end
 
     attr_reader :desc # :nodoc:
-    alias :specify :it
+    alias specify it
 
     ##
     # Rdoc... why are you so dumb?

data/lib/minitest/test.rb

@@ -85,20 +85,18 @@ module Minitest
     # Runs a single test with setup/teardown hooks.
 
     def run
-      with_info_handler do
-        time_it do
-          capture_exceptions do
-            SETUP_METHODS.each do |hook|
-              self.send hook
-            end
-
-            self.send self.name
+      time_it do
+        capture_exceptions do
+          SETUP_METHODS.each do |hook|
+            self.send hook
           end
 
-          TEARDOWN_METHODS.each do |hook|
-            capture_exceptions do
-              self.send hook
-            end
+          self.send self.name
+        end
+
+        TEARDOWN_METHODS.each do |hook|
+          capture_exceptions do
+            self.send hook
           end
         end
       end
@@ -230,16 +228,6 @@ module Minitest
       ne
     end
 
-    def with_info_handler &block # :nodoc:
-      t0 = Minitest.clock_time
-
-      handler = lambda do
-        warn "\nCurrent: %s#%s %.2fs" % [self.class, self.name, Minitest.clock_time - t0]
-      end
-
-      self.class.on_signal ::Minitest.info_signal, handler, &block
-    end
-
     include LifecycleHooks
     include Guard
     extend Guard

data/lib/minitest/test_task.rb

@@ -1,6 +1,12 @@
 require "shellwords"
 require "rbconfig"
-require "rake/tasklib"
+
+begin
+  require "rake/tasklib"
+rescue LoadError => e
+  warn e.message
+  return
+end
 
 module Minitest # :nodoc:
 
@@ -144,7 +150,7 @@ module Minitest # :nodoc:
         ENV["N"] && ENV["N"].to_i > 0
 
       lib_extras = (ENV["MT_LIB_EXTRAS"] || "").split File::PATH_SEPARATOR
-      self.libs[0,0] = lib_extras
+      self.libs[0, 0] = lib_extras
 
       extra_args << "-n" << ENV["N"]                      if ENV["N"]
       extra_args << "-e" << ENV["X"]                      if ENV["X"]
@@ -163,7 +169,7 @@ module Minitest # :nodoc:
     def define # :nodoc:
       desc "Run the test suite. Use N, X, A, and TESTOPTS to add flags/args."
       task name do
-        ruby make_test_cmd, verbose:verbose
+        ruby make_test_cmd, verbose: verbose
       end
 
       desc "Print out the test command. Good for profiling and other tools."
@@ -177,7 +183,7 @@ module Minitest # :nodoc:
 
         # 3 seems to be the magic number... (tho not by that much)
         bad, good, n = {}, [], (ENV.delete("K") || 3).to_i
-        file = ENV.delete("F")
+        file = ENV.delete "F"
         times = {}
 
         tt0 = Time.now
@@ -238,7 +244,7 @@ module Minitest # :nodoc:
 
       task "#{name}:deps" => "#{name}:isolated" # now just an alias
 
-      desc "Show bottom 25 tests wrt time."
+      desc "Run the test suite and report the slowest 25 tests."
       task "#{name}:slow" do
         sh ["rake #{name} A=-v",
             "egrep '#test_.* s = .'",
@@ -262,11 +268,11 @@ module Minitest # :nodoc:
       runner = runner.join "; "
 
       args  = []
-      args << "-I#{libs.join(File::PATH_SEPARATOR)}" unless libs.empty?
+      args << "-I#{libs.join File::PATH_SEPARATOR}" unless libs.empty?
       args << "-w" if warning
-      args << '-e'
+      args << "-e"
       args << "'#{runner}'"
-      args << '--'
+      args << "--"
       args << extra_args.map(&:shellescape)
 
       args.join " "
@@ -287,10 +293,10 @@ class Work < Queue # :nodoc:
 end
 
 class Integer # :nodoc:
-  def threads_do(jobs) # :nodoc:
+  def threads_do jobs # :nodoc:
     q = Work.new jobs
 
-    self.times.map {
+    Array.new(self) {
       Thread.new do
         while job = q.pop # go until quit value
           yield job