minitest 5.11.1 → 5.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4532535af505aea7a24c6a12ed614dc4daac90f7
-  data.tar.gz: f046da3055edc520f92fd89a7337d14073068100
+SHA256:
+  metadata.gz: 0d02b78e719c5f0e0d66c70ce7d14dec24cd6b9238927d8aa4c7140ef0a9c73f
+  data.tar.gz: 558f87be0d0a767424bfaaef04bcebfa889ea946e46ab5e1ca0857a3016df2a3
 SHA512:
-  metadata.gz: fa14c057616423821c8e5afeaf80068fdb63f0e596c85dae9dbe64c307269c08e10a126db0807eb2a0077ed9b2886ceae264aeb4beb213fa6efbaed25ea69312
-  data.tar.gz: f810e3d8ffab481cf3fe9720735eaf44a099b824a591fc510bde5c204ad27242bf784850cef9b2cf5f9d4f879ffa40834a243d1eb1cb04d5a9a3091b2c50402f
+  metadata.gz: d5f6dace06643179027dad2514c33d546a00b18525237ea296570b5e575ff5144c39fef97f02dabba4ca778d0181d7e16718ca9aba58d33c6b2a489105a62263
+  data.tar.gz: bfbbbbb1d3e72976e0a162524e0026b4342a4e3395a601f1931384b511f85885e9d148cc3c855db98df01f9477ab5808495e942b9ab5e11d8b7b1ccc091389db

data/History.rdoc

@@ -1,3 +1,14 @@
+=== 5.11.2 / 2018-01-25
+
+* 1 minor enhancement:
+
+  * Reversed Test < Result. Back to < Runnable and using Reportable for shared code.
+
+* 2 bug fixes:
+
+  * Fixed Result#location for instances of Test. (alexisbernard)
+  * Fixed deprecation message for Runnable#marshal_dump. (y-yagi)
+
 === 5.11.1 / 2018-01-02
 
 * 1 bug fix:

data/lib/minitest.rb

@@ -8,7 +8,7 @@ require "stringio"
 # :include: README.rdoc
 
 module Minitest
-  VERSION = "5.11.1" # :nodoc:
+  VERSION = "5.11.2" # :nodoc:
   ENCS = "".respond_to? :encoding # :nodoc:
 
   @@installed_at_exit ||= false
@@ -381,7 +381,7 @@ module Minitest
 
     def marshal_dump # :nodoc:
       unless @@marshal_dump_warned then
-        warn ["Minitest::Test#marshal_dump is deprecated.",
+        warn ["Minitest::Runnable#marshal_dump is deprecated.",
               "You might be violating internals. From", caller.first].join " "
         @@marshal_dump_warned = true
       end
@@ -436,6 +436,49 @@ module Minitest
     end
   end
 
+  ##
+  # Shared code for anything that can get passed to a Reporter. See
+  # Minitest::Test & Minitest::Result.
+
+  module Reportable
+    ##
+    # Did this run pass?
+    #
+    # Note: skipped runs are not considered passing, but they don't
+    # cause the process to exit non-zero.
+
+    def passed?
+      not self.failure
+    end
+
+    ##
+    # The location identifier of this test. Depends on a method
+    # existing called class_name.
+
+    def location
+      loc = " [#{self.failure.location}]" unless passed? or error?
+      "#{self.class_name}##{self.name}#{loc}"
+    end
+
+    def class_name # :nodoc:
+      raise NotImplementedError, "subclass responsibility"
+    end
+
+    ##
+    # Returns ".", "F", or "E" based on the result of the run.
+
+    def result_code
+      self.failure and self.failure.result_code or "."
+    end
+
+    ##
+    # Was this run skipped?
+
+    def skipped?
+      self.failure and Skip === self.failure
+    end
+  end
+
   ##
   # This represents a test result in a clean way that can be
   # marshalled over a wire. Tests can do anything they want to the
@@ -444,6 +487,8 @@ module Minitest
   # that the test result can be marshalled.
 
   class Result < Runnable
+    include Minitest::Reportable
+
     undef_method :marshal_dump
     undef_method :marshal_load
 
@@ -481,36 +526,8 @@ module Minitest
       self.failures.any? { |f| UnexpectedError === f }
     end
 
-    ##
-    # The location identifier of this test.
-
-    def location
-      loc = " [#{self.failure.location}]" unless passed? or error?
-      "#{self.klass}##{self.name}#{loc}"
-    end
-
-    ##
-    # Did this run pass?
-    #
-    # Note: skipped runs are not considered passing, but they don't
-    # cause the process to exit non-zero.
-
-    def passed?
-      not self.failure
-    end
-
-    ##
-    # Returns ".", "F", or "E" based on the result of the run.
-
-    def result_code
-      self.failure and self.failure.result_code or "."
-    end
-
-    ##
-    # Was this run skipped?
-
-    def skipped?
-      self.failure and Skip === self.failure
+    def class_name # :nodoc:
+      self.klass # for Minitest::Reportable
     end
 
     def to_s # :nodoc:

data/lib/minitest/parallel.rb

@@ -53,7 +53,7 @@ module Minitest
       end
     end
 
-    module Test
+    module Test # :nodoc:
       def _synchronize; Minitest::Test.io_lock.synchronize { yield }; end # :nodoc:
 
       module ClassMethods # :nodoc:

data/lib/minitest/test.rb

@@ -7,9 +7,14 @@ module Minitest
   #
   # See Minitest::Assertions
 
-  class Test < Result
+  class Test < Runnable
     require "minitest/assertions"
     include Minitest::Assertions
+    include Minitest::Reportable
+
+    def class_name # :nodoc:
+      self.class.name # for Minitest::Reportable
+    end
 
     PASSTHROUGH_EXCEPTIONS = [NoMemoryError, SignalException, SystemExit] # :nodoc:
 

data/test/minitest/test_minitest_spec.rb

@@ -509,7 +509,9 @@ describe Minitest::Spec do
 
     it "can NOT use must_equal in a thread. It must use expect in a thread" do
       assert_raises NoMethodError do
-        Thread.new { (1 + 1).must_equal 2 }.join
+        capture_io do
+          Thread.new { (1 + 1).must_equal 2 }.join
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest
 version: !ruby/object:Gem::Version
-  version: 5.11.1
+  version: 5.11.2
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   AhXhF6Wi2GTMezlj5jlI5XV7WsJUSwTp/YiVvcmT74ZaCRvexm6EnNhkrvJJ1Xeu
   V+HB+LYYhXWitInO/eXxDrFB
   -----END CERTIFICATE-----
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2018-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
@@ -170,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: minitest provides a complete suite of testing facilities supporting TDD,