minitest-spec-rails 5.4.0 → 5.5.0

data/test/cases/active_support_test.rb

@@ -3,14 +3,13 @@ require 'test_helper'
 class SomeRandomModel < ActiveRecord::Base; end
 
 class ActiveSupportTest < MiniTestSpecRails::TestCase
-
   it 'resolves spec type for active record constants' do
     assert_support MiniTest::Spec.spec_type(SomeRandomModel)
     assert_support MiniTest::Spec.spec_type(User)
   end
 
   it 'wont resolve spec type for random strings' do
-    assert_spec MiniTest::Spec.spec_type("Unmatched String")
+    assert_spec MiniTest::Spec.spec_type('Unmatched String')
   end
 
   private
@@ -22,32 +21,32 @@ class ActiveSupportTest < MiniTestSpecRails::TestCase
   def assert_spec(actual)
     assert_equal MiniTest::Spec, actual
   end
-
 end
 
 class ActiveSupportCallbackTest < ActiveSupport::TestCase
- 
   setup :foo
   setup :bar
- 
+
   it 'works' do
     @foo.must_equal 'foo'
     @bar.must_equal 'bar'
   end
- 
+
   private
- 
-  def foo ; @foo = 'foo' ; end
-  def bar ; @bar = 'bar' ; end
- 
+
+  def foo
+    @foo = 'foo'
+  end
+
+  def bar
+    @bar = 'bar'
+  end
 end
 
 class ActiveSupportSpecTest < ActiveSupport::TestCase
-
   it 'current spec name' do
     Thread.current[:current_spec].must_equal self
   end
-
 end
 
 class ActiveSupportDescribeNamesTest < ActiveSupport::TestCase
@@ -66,3 +65,14 @@ class ActiveSupportDescribeNamesTest < ActiveSupport::TestCase
   end
 end
 
+class ActiveSupportTestSyntaxTest < ActiveSupport::TestCase
+  test 'records the correct test method line number' do
+    method_name = public_methods(false).find do |name|
+      name.to_s =~ /test.*records the correct test method line number/
+    end
+    method_obj = method(method_name)
+
+    assert_match %r{test\/cases\/active_support_test.rb}, method_obj.source_location[0]
+    assert_equal 69, method_obj.source_location[1]
+  end
+end

data/test/cases/mini_shoulda_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper_dummy'
 
 class PostTests < ActiveSupport::TestCase
-
   i_suck_and_my_tests_are_order_dependent!
 
   $teardown_ran = false
@@ -27,11 +26,8 @@ class PostTests < ActiveSupport::TestCase
   end
 
   context 'level 1' do
-
     should 'work' do
       @post.must_be_instance_of Post
     end
-
   end
-
 end

data/test/dummy_app/app/controllers/application_controller.rb

@@ -1,7 +1,5 @@
 class ApplicationController < ActionController::Base
-
   def index
-    render :html => '<h1>Rendered MiniTest::Spec</h1>'.html_safe, :layout => false
+    render html: '<h1>Rendered MiniTest::Spec</h1>'.html_safe, layout: false
   end
-
 end

data/test/dummy_app/app/controllers/users_controller.rb

@@ -1,12 +1,10 @@
 class UsersController < ApplicationController
-
   def index
     @users = User.all
-    render :layout => false
+    render layout: false
   end
 
   def update
     redirect_to users_url
   end
-
 end

data/test/dummy_app/app/helpers/application_helper.rb

@@ -1,3 +1,2 @@
 module ApplicationHelper
-
 end

data/test/dummy_app/app/helpers/foos_helper.rb

@@ -2,10 +2,12 @@ module FoosHelper
   def passes
     true
   end
+
   def users_path_helper
     users_path
   end
+
   def users_url_helper
     users_url
   end
-end
+end

data/test/dummy_app/app/helpers/users_helper.rb

@@ -1,9 +1,7 @@
 module UsersHelper
-
   def render_users_list(users)
     content_tag :ul do
-      users.map{ |user| content_tag :li, user.email }.join.html_safe
+      users.map { |user| content_tag :li, user.email }.join.html_safe
     end
   end
-
 end

data/test/dummy_app/app/mailers/user_mailer.rb

@@ -1,10 +1,8 @@
 class UserMailer < ActionMailer::Base
-
-  default :from => 'rails@minitest.spec'
+  default from: 'rails@minitest.spec'
 
   def welcome(user)
     @user = user
-    mail :to => @user.email, :subject => 'Welcome', :body => "Welcome to MiniTest::Spec #{@user.email}!"
+    mail to: @user.email, subject: 'Welcome', body: "Welcome to MiniTest::Spec #{@user.email}!"
   end
-
 end

data/test/dummy_app/app/models/post.rb

@@ -1,6 +1,3 @@
 class Post < ActiveRecord::Base
-
   belongs_to :user
-
-
 end

data/test/dummy_app/app/models/user.rb

@@ -1,6 +1,3 @@
 class User < ActiveRecord::Base
-
   has_many :posts
-
-
 end

data/test/dummy_app/config/routes.rb

@@ -1,4 +1,4 @@
 Dummy::Application.routes.draw do
-  root :to => 'application#index'
+  root to: 'application#index'
   resources :users
 end

data/test/dummy_app/init.rb

@@ -1,12 +1,11 @@
-ENV["RAILS_ENV"] ||= "test"
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __FILE__)
+ENV['RAILS_ENV'] ||= 'test'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __dir__)
 require 'bundler/setup'
 require 'rails/all'
 Bundler.require(:default, Rails.env)
 
 module Dummy
   class Application < ::Rails::Application
-
     # Basic Engine
     config.root = File.join __FILE__, '..'
     config.cache_store = :memory_store
@@ -31,7 +30,6 @@ module Dummy
 
     # Custom
     config.minitest_spec_rails.mini_shoulda = true
-
   end
 end
 

data/test/dummy_tests/application_controller_test.rb

@@ -3,7 +3,6 @@ require 'test_helper_dummy'
 module ApplicationControllerTests
   extend ActiveSupport::Concern
   included do
-
     before { get :index }
 
     it 'works' do
@@ -12,7 +11,7 @@ module ApplicationControllerTests
     end
 
     it 'allows custom assertions' do
-      assert_select 'h1', :text => 'Rendered MiniTest::Spec'
+      assert_select 'h1', text: 'Rendered MiniTest::Spec'
     end
 
     it 'can find the controller_class' do
@@ -24,7 +23,6 @@ module ApplicationControllerTests
     end
 
     describe 'nested 1' do
-
       it('works') { skip }
 
       it 'can find the controller_class' do
@@ -32,13 +30,9 @@ module ApplicationControllerTests
       end
 
       describe 'nested 2' do
-
         it('works') { skip }
-
       end
-
     end
-
   end
 end
 
@@ -50,12 +44,12 @@ class ApplicationControllerTest < ActionController::TestCase
   end
   describe 'level 1' do
     it 'reflects' do
-      described_class.must_equal  ApplicationController
+      described_class.must_equal ApplicationController
       self.class.described_class.must_equal ApplicationController
     end
     describe 'level 2' do
       it 'reflects' do
-        described_class.must_equal  ApplicationController
+        described_class.must_equal ApplicationController
         self.class.described_class.must_equal ApplicationController
       end
     end

data/test/dummy_tests/foos_helper_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper_dummy'
 
 class FoosHelperTest < ActionView::TestCase
-
   it 'allows path and url helpers' do
     users_path_helper.must_equal '/users'
     users_url_helper.must_equal  'http://test.host/users'
@@ -12,6 +11,4 @@ class FoosHelperTest < ActionView::TestCase
       assert passes
     end
   end
-
 end
-

data/test/dummy_tests/integration_test.rb

@@ -3,7 +3,6 @@ require 'test_helper_dummy'
 module IntegrationTests
   extend ActiveSupport::Concern
   included do
-
     fixtures :all
 
     it 'works' do
@@ -12,7 +11,7 @@ module IntegrationTests
     end
 
     it 'works with assert_routing' do
-      assert_routing '/', :controller => 'application', :action => 'index'
+      assert_routing '/', controller: 'application', action: 'index'
     end
 
     it 'can find the app' do
@@ -20,7 +19,6 @@ module IntegrationTests
     end
 
     describe 'nested 1' do
-
       it('works') { skip }
 
       it 'can find the app' do
@@ -28,13 +26,9 @@ module IntegrationTests
       end
 
       describe 'nested 2' do
-
         it('works') { skip }
-
       end
-
     end
-    
   end
 end
 
@@ -44,6 +38,6 @@ end
 
 class AppTest < ActionDispatch::IntegrationTest
   def test_homepage
-    assert_routing '/', :controller => 'application', :action => 'index'
+    assert_routing '/', controller: 'application', action: 'index'
   end
 end

data/test/dummy_tests/special_users_controller_test.rb

@@ -1,12 +1,10 @@
 require 'test_helper_dummy'
 
 class SpecialUsersControllerTest < ActionController::TestCase
-
   tests UsersController
 
   it 'works' do
     get :index
     assert_select 'h1', "All #{User.count} Users"
   end
-
 end

data/test/dummy_tests/user_mailer_test.rb

@@ -3,15 +3,14 @@ require 'test_helper_dummy'
 module UserMailerTests
   extend ActiveSupport::Concern
   included do
-
     let(:deliveries)        { ActionMailer::Base.deliveries }
     let(:user_mailer_class) { UserMailer }
-    let(:user_email)        {
+    let(:user_email)        do
       user_mailer_class.welcome(user_ken).tap do |mail|
         laterable = Rails.version > '4.2' || Rails.version.starts_with?('4.2')
         laterable ? mail.deliver_now : mail.deliver
       end
-    }
+    end
 
     it 'works' do
       deliveries.must_be :empty?
@@ -31,7 +30,6 @@ module UserMailerTests
     end
 
     describe 'nested 1' do
-
       it('works') { skip }
 
       it 'can find the mailer_class' do
@@ -39,13 +37,9 @@ module UserMailerTests
       end
 
       describe 'nested 2' do
-
         it('works') { skip }
-
       end
-
     end
-
   end
 end
 
@@ -57,12 +51,12 @@ class UserMailerTest < ActionMailer::TestCase
   end
   describe 'level 1' do
     it 'reflects' do
-      described_class.must_equal  UserMailer
+      described_class.must_equal UserMailer
       self.class.described_class.must_equal UserMailer
     end
     describe 'level 2' do
       it 'reflects' do
-        described_class.must_equal  UserMailer
+        described_class.must_equal UserMailer
         self.class.described_class.must_equal UserMailer
       end
     end

data/test/dummy_tests/user_test.rb

@@ -3,7 +3,6 @@ require 'test_helper_dummy'
 module UserTests
   extend ActiveSupport::Concern
   included do
-
     it 'works' do
       user_ken.must_be_instance_of User
     end
@@ -17,21 +16,16 @@ module UserTests
     end
 
     describe 'nested 1' do
-
       it('works') { skip }
 
       describe 'nested 2' do
-
         it('works') { skip }
-
       end
 
       test 'works with test' do
         user_ken.must_be_instance_of User
       end
-
     end
-    
   end
 end
 
@@ -43,12 +37,12 @@ class UserTest < ActiveSupport::TestCase
   end
   describe 'level 1' do
     it 'reflects' do
-      described_class.must_equal  User
+      described_class.must_equal User
       self.class.described_class.must_equal User
     end
     describe 'level 2' do
       it 'reflects' do
-        described_class.must_equal  User
+        described_class.must_equal User
         self.class.described_class.must_equal User
       end
     end

data/test/dummy_tests/users_controller_test.rb

@@ -3,7 +3,6 @@ require 'test_helper_dummy'
 module UsersControllerTests
   extend ActiveSupport::Concern
   included do
-
     it 'works' do
       get :index
       assert_select 'h1', "All #{User.count} Users"
@@ -17,9 +16,8 @@ module UsersControllerTests
     private
 
     def put_update_0
-      rails5? ? put(:update, :params => {:id => 0}) : put(:update, :id => 0)
+      rails5? ? put(:update, params: { id: 0 }) : put(:update, id: 0)
     end
-
   end
 end