minitest-spec-rails 5.2.0 → 5.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9408e396ed2d699f0d7c87a2ff129b6c5f2054a
-  data.tar.gz: 495b7c539331c43354e2d652f74206bbaf8be340
+  metadata.gz: 342a48e3db12a8cab6201515dbb13fede213619f
+  data.tar.gz: 77c97a7bc152f267a4a112cca7c6d5219f7bd70e
 SHA512:
-  metadata.gz: a6113aadd99cccdd0f45345a9ed4877b88e5ffbd7d137b00c7c20f7c3cc63f5a262c627731a024cc20f424b9028cf5f61764c126c81b409a3c7d2b317bccd526
-  data.tar.gz: 5512028271386985bd24bccf781d65597252a5a84a66ad242b27fdaa666afba433d4d88ecb028cda8c0d56d9a1169ab3f26f669b19d68be6c565f7215c8c83c3
+  metadata.gz: b1c5569edae61252ea18748398bd20b8d2518475972566f60370f8f99d9567181a34602b61098bed7617b800944e4048b91ff464670732d95eb024b3fbb54a37
+  data.tar.gz: 2d207c12753bbcd49cef976b743cfa279ef8890cab9580fc4a14b2e306996eebd0fb48702b62cbfcb833c1d174a2b4081c9e25584883606f5842fd358a82e675

data/CHANGELOG.md

@@ -1,4 +1,12 @@
 
+## 5.2.2
+
+* Fix ActiveJob support for `described_class`. Thanks @pschambacher.
+
+## 5.2.1
+
+* Only add our Thread.current[:current_spec] hack if needed. Fixes #45.
+
 ## 5.2.0
 
 * Added ActiveJob support. Fixes #59. Thanks @xpepermint.

data/README.md

@@ -100,26 +100,26 @@ end
 ```ruby
 require 'test_helper'
 describe User do
-  # This will work too, but is not recommended
+  # THIS IS NOT RECOMMENDED!
 end
 ```
 
-Just for reference, here is a full list of each of Rails test case classes and the matching describe alternative if one exists. Remember, names are important when using the describe syntax. So, you can not have a mailer named `FooBar` and expect it to work with the outer describe spec style since there is no way to map the spec type based on an existing naming convention.
+RSpec 3 is also moving away from the outer describe test type inference, as described in this line from their [release notes](https://www.relishapp.com/rspec/rspec-rails/v/3-1/docs/changelog).
 
-Using `describe` in this way [is not recommended](https://github.com/metaskills/minitest-spec-rails/issues/56).
+> Spec types are no longer inferred by location, they instead need to be explicitly tagged. The old behaviour is enabled by config.infer_spec_type_from_file_location!, which is still supplied in the default generated spec_helper.rb. (Xavier Shay, Myron Marston)
+
+Not that we want to mimic RSpec, but the aim of this gem is very straight forward and minimilistic. We simply want to expose the Minitest Spec::DSL and core assertion style within ActiveSupport. Period. So it is very possible that us matching outer describe to classes is simply going to go away one day soon.
+
+Just for reference, here is a full list of each of Rails test case we support.
 
 ```ruby
 # Model Test (or anything else not listed below)
 class UserTest < ActiveSupport::TestCase
 end
-describe User do
-end
 
 # Controller Test
 class UsersControllerTest < ActionController::TestCase
 end
-describe UsersController do
-end
 
 # Integration Tests - Must use subclass style!
 class IntegrationTest < ActionDispatch::IntegrationTest
@@ -128,13 +128,13 @@ end
 # Mailer Test
 class UserMailerTest < ActionMailer::TestCase
 end
-describe UserMailer do
-end
 
 # View Helper Test
 class UsersHelperTest < ActionView::TestCase
 end
-describe UsersHelper do
+
+# Job Helper Test
+class MyJobTest < ActiveJob::TestCase
 end
 ```
 
@@ -194,7 +194,7 @@ If you are migrating away from Shoulda, then minitest-spec-rails' mini_shoulda f
 config.minitest_spec_rails.mini_shoulda = true
 ```
 
-Doing so only enables a few aliases that allow the Shoulda `context`, `should`, and `should_eventually` methods. The following code demonstrates the full features of the mini_shoulda implementation. It basically replaces the shell of [should-context](https://github.com/thoughtbot/shoulda-context) in a few lines of code.
+Doing so only enables a few aliases that allow the Shoulda `context`, `should`, and `should_eventually` methods. The following code demonstrates the full features of the mini_shoulda implementation. It basically replaces the shell of [shoulda-context](https://github.com/thoughtbot/shoulda-context) in a few lines of code.
 
 ```ruby
 class PostTests < ActiveSupport::TestCase
@@ -211,7 +211,7 @@ class PostTests < ActiveSupport::TestCase
 end
 ```
 
-If you are in the assertions provided by shoulda-context like `assert_same_elements`, then you may want to consider copying them [from here](https://github.com/thoughtbot/shoulda-context/blob/master/lib/shoulda/context/assertions.rb) and including them in `MiniTest::Spec` yourself. I personally recommend just replacing these assertions with something more modern. A few examples are below.
+If you prefer the assertions provided by shoulda-context like `assert_same_elements`, then you may want to consider copying them [from here](https://github.com/thoughtbot/shoulda-context/blob/master/lib/shoulda/context/assertions.rb) and including them in `MiniTest::Spec` yourself. I personally recommend just replacing these assertions with something more modern. A few examples are below.
 
 ```ruby
 assert_same_elements a, b  # From
@@ -223,7 +223,7 @@ a.wont_include b              # To
 
 ### Matchers
 
-**I highly suggest that you stay away from matchers** since MiniTest::Spec gives you all the tools you need to write good tests. Staying away from matchers will make your code's tests live longer. So my advice is to stay away from things like `.should ==` and just write `.must_equal` instead. However, if matchers are really your thing, I recommend the [minitest-matchers](https://github.com/zenspider/minitest-matchers) gem. You can also check out the [valid_attribute](https://github.com/bcardarella/valid_attribute) gem built on top of minitest-matchers.
+**I highly suggest that you stay away from matchers** since MiniTest::Spec gives you all the tools you need to write good tests. Staying away from matchers will make your code's tests live longer. So my advice is to stay away from things like `.should ==` and just write `.must_equal` instead. However, if matchers are really your thing, I recommend the [minitest-matchers](https://github.com/wojtekmach/minitest-matchers) gem. You can also check out the [valid_attribute](https://github.com/bcardarella/valid_attribute) gem built on top of minitest-matchers.
 
 ```ruby
 describe Post do

data/lib/minitest-spec-rails/init/active_job.rb

@@ -14,7 +14,9 @@ module MiniTestSpecRails
       module Descriptions
 
         def described_class
-          determine_default_mailer(name)
+          determine_constant_from_test_name(name) do |constant|
+            Class === constant && constant < ActiveJob::Base
+          end
         end
 
       end

data/lib/minitest-spec-rails/init/active_support.rb

@@ -25,7 +25,7 @@ module MiniTestSpecRails
       def initialize(*args)
         Thread.current[:current_spec] = self
         super
-      end
+      end if Minitest::VERSION < "5.3.3"
 
     end
   end

data/lib/minitest-spec-rails/version.rb

@@ -1,3 +1,3 @@
 module MiniTestSpecRails
-  VERSION = "5.2.0"
+  VERSION = "5.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-spec-rails
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.2.2
 platform: ruby
 authors:
 - Ken Collins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-19 00:00:00.000000000 Z
+date: 2015-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -160,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Make Rails Use MiniTest::Spec!