minitest-reporters 1.3.1 → 1.3.2.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b651c07f7a8f7f20f851c02cfe393672e0805389e04ff4308bbe425d1d46970b
-  data.tar.gz: 256eabefc4c0d7e4867d7c99fcac72a57051a3fda344a4ca0eed014d8869c7e4
+  metadata.gz: 3257dd726eea7dfcb07c3945e9066149fcbbd6c5cd8c7d4a05fa259c6f1fc849
+  data.tar.gz: 266cd94a13ebe4b9899feed855e9831edc03f87e8a137813df4067d15ab73499
 SHA512:
-  metadata.gz: 87e39445f0d0ee596490830d3909b59084bbb479bbddc172122bae95ab2dd6fa76404b4958bfbae8827ce5a58cd51d852db22236d531da33d0c0f2792d82a7a8
-  data.tar.gz: b4648956608c503d25e4b6ae3f0c92f1a32c48be02e68a6f0ce009ab9513fba6276b170d49bd2161f51de52a84d43c9660a4902eb17010423c55cb5918de0f7d
+  metadata.gz: b2c695a962ded855e76c60c55a668f7b0d77d2b111c713367912a61e138f548861cf940877a1410a63d1b91550bc3c18986d28e864ec95b941b79894077aa15f
+  data.tar.gz: 13d3872725a4bb52c928e5238ebcc90f1e27c2660aaa0e2427860a5d0ec85532248d7e950f77516ff923a0a210f4048545f15c561e18a6c1278061a2579e831b

data/.rubocop.yml

@@ -0,0 +1,8 @@
+Metrics/LineLength:
+  Max: 120
+
+Naming/UncommunicativeMethodParamName:
+  MinNameLength: 1
+
+Style/FormatStringToken:
+  Enabled: false

data/.travis.yml

@@ -2,9 +2,12 @@ script: 'rake test'
 before_install:
   - gem install bundler
 rvm:
-  - 2.3.0
+  - 2
+  - 2.5
+  - 2.4
+  - 2.3
   - 2.2
   - 2.1
-  - 2.0.0
+  - 2.0
   - 1.9.3
-  - jruby-9.1.9.0
+  - jruby

data/CHANGELOG.md

@@ -1,14 +1,21 @@
-### [dev](https://github.com/kern/minitest-reporters/compare/v1.3.1...master)
+### [dev](https://github.com/kern/minitest-reporters/compare/v1.3.2.beta1...master)
 
-### [v1.3.1](https://github.com/kern/minitest-reporters/compare/v1.3.1.beta1...v1.3.1)
+### [1.3.2.beta1](https://github.com/kern/minitest-reporters/compare/v1.3.1...v1.3.2.beta1)
 
-### [v1.3.1.beta1](https://github.com/kern/minitest-reporters/compare/v1.3.0...v1.3.1.beta1)
+* SpecReporter do not print exception name any more (unless it is an test error) [#264](https://github.com/kern/minitest-reporters/pull/264)
+* Fixed loading error caused by fix for [#265](https://github.com/kern/minitest-reporters/pull/265)
+  see [#267](https://github.com/kern/minitest-reporters/pull/267) and 
+  [#268](https://github.com/kern/minitest-reporters/pull/268) for more details.
+
+### [1.3.1](https://github.com/kern/minitest-reporters/compare/v1.3.1.beta1...v1.3.1)
+
+### [1.3.1.beta1](https://github.com/kern/minitest-reporters/compare/v1.3.0...v1.3.1.beta1)
 
 * Fixed time reporting [#265](https://github.com/kern/minitest-reporters/pull/265) contributed by [brendandeere](https://github.com/brendandeere)
 
-### [v1.3.0](https://github.com/kern/minitest-reporters/compare/v1.3.0.beta3...v1.3.0)
+### [1.3.0](https://github.com/kern/minitest-reporters/compare/v1.3.0.beta3...v1.3.0)
 
-### [v1.3.0.beta3](https://github.com/kern/minitest-reporters/compare/v1.3.0.beta2...v1.3.0.beta3)
+### [1.3.0.beta3](https://github.com/kern/minitest-reporters/compare/v1.3.0.beta2...v1.3.0.beta3)
 
 * [#261](https://github.com/kern/minitest-reporters/issues/261) fixed by [#262](https://github.com/kern/minitest-reporters/pull/262) contributed by [trabulmonkee](https://github.com/trabulmonkee)
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2011 Alexander Kern
+Copyright (c) 2018 Alexander Kern
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
@@ -17,4 +17,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/Rakefile

@@ -1,5 +1,6 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
+require 'rubocop/rake_task'
 
 task :default => :test
 Rake::TestTask.new do |t|
@@ -58,3 +59,12 @@ task :reset_statistics do
   puts "The mean time reporter statistics have been reset."
   exit 0
 end
+
+desc 'Run RuboCop on the lib directory'
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.patterns = ['lib/**/*.rb']
+  # only show the files with failures
+  task.formatters = ['clang']
+  # don't abort rake on failure
+  task.fail_on_error = false
+end

data/lib/minitest/reporters/base_reporter.rb

@@ -1,5 +1,15 @@
 module Minitest
   module Reporters
+    class Suite
+      attr_reader :name
+      def initialize(name)
+        @name = name
+      end
+
+      def to_s
+        name.to_s
+      end
+    end
     class BaseReporter < Minitest::StatisticsReporter
       attr_accessor :tests
 
@@ -14,11 +24,12 @@ module Minitest
 
       # called by our own before hooks
       def before_test(test)
-        last_test = tests.last
-        suite_changed = test_class(last_test) != test.class
+        last_test = test_class(tests.last)
+
+        suite_changed = last_test.nil? || last_test.name != test.class.name
 
         if suite_changed
-          after_suite(test_class(last_test)) if last_test
+          after_suite(last_test) if last_test
           before_suite(test.class)
         end
       end
@@ -58,8 +69,11 @@ module Minitest
       end
 
       def test_class(result)
-        if result.respond_to?(:klass) && result.klass
-          load_constant(result.klass)
+        # Minitest broke API between 5.10 and 5.11 this gets around Result object
+        if result.nil?
+          nil
+        elsif result.respond_to? :klass
+          Suite.new(result.klass)
         else
           result.class
         end
@@ -106,14 +120,6 @@ module Minitest
           trace.each { |line| print_with_info_padding(line) }
         end
       end
-
-      # This method is to be version compatible with ruby 1.X. In these
-      # versions constant lookup was not namespace aware
-      def load_constant(name)
-        name.to_s.split('::').inject(Object) do |namespace, const_name|
-          namespace.const_get(const_name)
-        end
-      end
     end
   end
 end

data/lib/minitest/reporters/default_reporter.rb

@@ -125,7 +125,7 @@ module Minitest
           puts
 
           slow_suites.each do |slow_suite|
-            puts "%.6fs %s" % [slow_suite[1], slow_suite[0]]
+            puts "%.6fs %s" % [slow_suite[1], test_class(slow_suite[0])]
           end
         end
 

data/lib/minitest/reporters/mean_time_reporter.rb

@@ -1,4 +1,5 @@
 require 'minitest/reporters'
+require 'tmpdir'
 require 'yaml'
 
 module Minitest
@@ -125,8 +126,8 @@ module Minitest
           show_progress:          true,
           show_all_runs:          true,
           sort_column:            :avg,
-          previous_runs_filename: '/tmp/minitest_reporters_previous_run',
-          report_filename:        '/tmp/minitest_reporters_report',
+          previous_runs_filename: Dir.tmpdir + '/minitest_reporters_previous_run',
+          report_filename:        Dir.tmpdir + 'minitest_reporters_report'
         }
       end
 
@@ -249,15 +250,13 @@ module Minitest
       def create_or_update_previous_runs!
         if previously_ran?
           current_run.each do |description, elapsed|
-          new_times = if previous_run["#{description}"]
-                        Array(previous_run["#{description}"]) << elapsed
+            new_times = if previous_run[description.to_s]
+                          Array(previous_run[description.to_s]) << elapsed
+                        else
+                          Array(elapsed)
+                        end
 
-                      else
-                        Array(elapsed)
-
-                      end
-
-            previous_run.store("#{description}", new_times)
+            previous_run.store(description.to_s, new_times)
           end
 
           File.write(previous_runs_filename, previous_run.to_yaml)

data/lib/minitest/reporters/spec_reporter.rb

@@ -52,7 +52,7 @@ module Minitest
 
       def record_print_failures_if_any(test)
         if !test.skipped? && test.failure
-          print_info(test.failure)
+          print_info(test.failure, test.error?)
           puts
         end
       end

data/lib/minitest/reporters/version.rb

@@ -1,5 +1,5 @@
 module Minitest
   module Reporters
-    VERSION = '1.3.1'
+    VERSION = '1.3.2.beta1'.freeze
   end
 end

data/minitest-reporters.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'maruku'
   s.add_development_dependency 'rake'
+  s.add_development_dependency 'rubocop'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/test/fixtures/mean_time_test.rb

@@ -5,4 +5,32 @@ require 'minitest/reporters/mean_time_reporter'
 
 Minitest::Reporters.use! Minitest::Reporters::MeanTimeReporter.new
 
-require_relative '../gallery/good_test'
+class TestClass < Minitest::Test
+  def test_assertion
+    assert true
+  end
+
+  def test_fail
+    fail
+  end
+end
+
+class AnotherTestClass < Minitest::Test
+  def test_assertion
+    assert true
+  end
+
+  def test_fail
+    fail
+  end
+end
+
+class LastTestClass < Minitest::Test
+  def test_assertion
+    assert true
+  end
+
+  def test_fail
+    fail
+  end
+end

data/test/fixtures/spec_test.rb

@@ -1,13 +1,18 @@
+require 'bundler/setup'
 require 'minitest'
 require 'minitest/reporters'
 require 'minitest/autorun'
 
-Minitest::Reporters.use! Minitest::Reporters::ProgressReporter.new
+Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
 
 describe String do
   describe '#length' do
     it 'works' do
       assert_equal 5, 'hello'.length
     end
+
+    it 'doesn\'t works' do
+      assert_equal 6, 'hello'.length
+    end
   end
 end

data/test/unit/minitest/mean_time_reporter_unit_test.rb

@@ -1,4 +1,4 @@
-require_relative "../../test_helper"
+require_relative '../../test_helper'
 
 module MinitestReportersTest
   class MeanTimeReporterUnitTest < Minitest::Test

data/test/unit/minitest/spec_reporter_test.rb

@@ -37,5 +37,25 @@ module MinitestReportersTest
       @reporter.record(the_test)
       assert_respond_to the_test, the_test.name
     end
+
+    def test_report_for_describe_not_using_const
+      klass = describe("whatever") { it("passes") { assert true } }
+      runnable = klass.runnable_methods.first
+
+      # Run the test
+      result = klass.new(runnable).run
+      @reporter.start
+      @reporter.record(result)
+
+      error_msg = nil
+      begin
+        @reporter.report
+      rescue => e
+        error_msg = "error executing @reporter.report, #{e}"
+      end
+
+      refute error_msg, error_msg
+    end
   end
 end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-reporters
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2.beta1
 platform: ruby
 authors:
 - Alexander Kern
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-25 00:00:00.000000000 Z
+date: 2018-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Death to haphazard monkey-patching! Extend Minitest through simple hooks.
 email:
 - alex@kernul.com
@@ -102,6 +116,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".travis.yml"
 - ".yardopts"
@@ -164,9 +179,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: minitest-reporters
 rubygems_version: 2.7.6