minitest-reporters 1.1.11 → 1.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88d6126ca997acbf677b531e44849c74d37af66b
-  data.tar.gz: 24a96027c20c449926bbf346989d99ad7353c81d
+  metadata.gz: f9a13367d73b48623e2124cd6cfcfdfeab4e50e6
+  data.tar.gz: df4d8a09132fd4f992641f0958d4d7682930fd65
 SHA512:
-  metadata.gz: 3e9f3a0c9a8245b1ff5b1d0767c635aa88410129cc601d8d9e2bfb4384227c084ceb4e902dae25dc961c7a27a934b3687ac6762dd1d3a47fbbb0e7be1ed2da66
-  data.tar.gz: d66a69f5e620abdb0ac9ea4b762ece8220e8a248b36badb681a6a79c9d9aa3f8d8762ae545bfd120b76dc8d363a57bade6dc0d5f663dfb914fa9719f81d4cb9e
+  metadata.gz: 8337e7a82318d409675b9907ed60aa979bd7fc3658ab107bc330433555465d97da0f778b8ae7edacbba01369c5579ea0f80d3a56302617fc0f2d829fac1c2e7e
+  data.tar.gz: 2eb20439c9528c2aaa1d07c2bca1e404b9cd3bf78b29ffbb86e80ed9bef4ac980c2f62542621c0923b915566e3c0069f1873c318ad7237b8b8f2ba55fa418842

data/lib/minitest/reporters/mean_time_reporter.rb

@@ -148,10 +148,10 @@ module Minitest
         order_sorted_body.each_with_object([]) do |result, obj|
           rating = rate(result[:last], result[:min], result[:max])
 
-          obj << "#{avg_label} #{result[:avg]} " \
-                 "#{min_label} #{result[:min]} " \
-                 "#{max_label} #{result[:max]} " \
-                 "#{run_label(rating)} #{result[:last]} " \
+          obj << "#{avg_label} #{result[:avg].to_s.ljust(12)} " \
+                 "#{min_label} #{result[:min].to_s.ljust(12)} " \
+                 "#{max_label} #{result[:max].to_s.ljust(12)} " \
+                 "#{run_label(rating)} #{result[:last].to_s.ljust(12)} " \
                  "#{des_label} #{result[:desc]}\n"
         end.join
       end
@@ -177,10 +177,10 @@ module Minitest
           size = Array(timings).size
           sum  = Array(timings).inject { |total, x| total + x }
           obj << {
-            avg:  (sum / size).round(9).to_s.ljust(12),
-            min:  Array(timings).min.round(9).to_s.ljust(12),
-            max:  Array(timings).max.round(9).to_s.ljust(12),
-            last: Array(timings).last.round(9).to_s.ljust(12),
+            avg:  (sum / size).round(9),
+            min:  Array(timings).min.round(9),
+            max:  Array(timings).max.round(9),
+            last: Array(timings).last.round(9),
             desc: description,
           }
         end.sort_by { |k| k[sort_column] }

data/lib/minitest/reporters/version.rb

@@ -1,5 +1,5 @@
 module Minitest
   module Reporters
-    VERSION = '1.1.11'
+    VERSION = '1.1.12'
   end
 end

data/test/unit/minitest/mean_time_reporter_unit_test.rb

@@ -0,0 +1,152 @@
+require_relative "../../test_helper"
+
+module MinitestReportersTest
+  class MeanTimeReporterUnitTest < Minitest::Test
+    def setup
+      configure_report_paths
+      previous_test_run
+    end
+
+    def teardown
+      File.delete(@previous_run_path) if File.exist?(@previous_run_path)
+      File.delete(@report_file_path) if File.exist?(@report_file_path)
+    end
+
+    def test_sorts_avg_numerically
+      report_output = generate_report(:avg)
+
+      expected_order = [
+        'AVG_SLOW',
+        'MAX_SLOW',
+        'MIN_SLOW',
+        'MIDDLE',
+        'MIN_FAST',
+        'MAX_FAST',
+        'AVG_FAST'
+      ]
+      verify_result_order(report_output, expected_order)
+    end
+
+    def test_sorts_min_numerically
+      report_output = generate_report(:min)
+
+      expected_order = [
+        'MIN_SLOW',
+        'AVG_SLOW',
+        'MAX_SLOW',
+        'MIDDLE',
+        'MAX_FAST',
+        'AVG_FAST',
+        'MIN_FAST'
+      ]
+      verify_result_order(report_output, expected_order)
+    end
+
+    def test_sorts_max_numerically
+      report_output = generate_report(:max)
+
+      expected_order = [
+        'MAX_SLOW',
+        'AVG_SLOW',
+        'MIN_SLOW',
+        'MIDDLE',
+        'MIN_FAST',
+        'AVG_FAST',
+        'MAX_FAST'
+      ]
+      verify_result_order(report_output, expected_order)
+    end
+
+    def test_sorts_last_numerically
+      report_output = generate_report(:last)
+
+      expected_order = [
+        'AVG_SLOW',
+        'MIN_SLOW',
+        'MAX_SLOW',
+        'MIDDLE',
+        'MIN_FAST',
+        'MAX_FAST',
+        'AVG_FAST'
+      ]
+      verify_result_order(report_output, expected_order)
+    end
+
+    private
+
+    def simulate_suite_runtime(suite_name, run_time)
+      test_suite = Minitest::Test.new(suite_name)
+      base_clock_time = Minitest::Reporters.clock_time
+      Minitest::Reporters.stub(:clock_time, base_clock_time - run_time) do
+        @reporter.before_suite(test_suite)
+      end
+      @reporter.after_suite(test_suite)
+    end
+
+    def previous_test_run
+      @reporter = Minitest::Reporters::MeanTimeReporter.new(
+        previous_runs_filename: @previous_run_path,
+        report_filename: @report_file_path
+      )
+
+      simulate_suite_runtime('MIDDLE', 5.0)
+      simulate_suite_runtime('MIN_FAST', 0.5)
+      simulate_suite_runtime('MIN_SLOW', 10.5)
+      simulate_suite_runtime('MAX_FAST', 1.2)
+      simulate_suite_runtime('MAX_SLOW', 16.3)
+      simulate_suite_runtime('AVG_FAST', 1.3)
+      simulate_suite_runtime('AVG_SLOW', 10.2)
+      @reporter.tests << Minitest::Test.new('Final')
+      # Generate a "previous" run
+      @reporter.io = StringIO.new
+      @reporter.start
+      @reporter.report
+    end
+
+    def configure_report_paths
+      previous_runs_file = Tempfile.new('minitest-mean-time-previous-runs')
+      previous_runs_file.close
+      @previous_run_path = previous_runs_file.path
+      previous_runs_file.delete
+      report_file = Tempfile.new('minitest-mean-time-report')
+      report_file.close
+      @report_file_path = report_file.path
+      report_file.delete
+    end
+
+    def generate_report(sort_column)
+      # Reset the reporter for the test run
+      @reporter = Minitest::Reporters::MeanTimeReporter.new(
+        previous_runs_filename: @previous_run_path,
+        report_filename: @report_file_path,
+        sort_column: sort_column
+      )
+      simulate_suite_runtime('MIDDLE', 5.0)
+      simulate_suite_runtime('MIN_FAST', 3.5)
+      simulate_suite_runtime('MIN_SLOW', 10.5)
+      simulate_suite_runtime('MAX_FAST', 0.9)
+      simulate_suite_runtime('MAX_SLOW', 6.3)
+      simulate_suite_runtime('AVG_FAST', 0.65)
+      simulate_suite_runtime('AVG_SLOW', 14.2)
+      @reporter.tests << Minitest::Test.new('Final')
+
+      report_output = StringIO.new
+      @reporter.io = report_output
+      @reporter.start
+      @reporter.report
+      report_output
+    end
+
+    def verify_result_order(report_output, expected_order)
+      report_output.rewind
+      test_lines = report_output.read.split("\n")
+      test_lines.select! { |line| line.start_with?('Avg:') }
+
+      # Exclude the final placeholder 0 second test from assertions
+      test_lines.reject! { |line| line.end_with?('Minitest::Test') }
+      actual_order = test_lines.map { |line| line.gsub(/.*Description: /, '') }
+
+      assert_equal(expected_order, actual_order, "\n#{test_lines.join("\n")}")
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-reporters
 version: !ruby/object:Gem::Version
-  version: 1.1.11
+  version: 1.1.12
 platform: ruby
 authors:
 - Alexander Kern
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-30 00:00:00.000000000 Z
+date: 2016-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -143,6 +143,7 @@ files:
 - test/integration/reporters/progress_reporter_test.rb
 - test/test_helper.rb
 - test/unit/minitest/extensible_backtrace_filter_test.rb
+- test/unit/minitest/mean_time_reporter_unit_test.rb
 - test/unit/minitest/minitest_reporter_plugin_test.rb
 - test/unit/minitest/reporters_test.rb
 - test/unit/minitest/spec_reporter_test.rb