minitest-rails 3.0.0 → 6.1.0

data/lib/generators/minitest/scaffold/templates/api_functional_test.rb.tt

@@ -0,0 +1,44 @@
+require "test_helper"
+
+<% module_namespacing do -%>
+class <%= controller_class_name %>ControllerTest < ActionDispatch::IntegrationTest
+  <%- if mountable_engine? -%>
+  include Engine.routes.url_helpers
+
+  <%- end -%>
+  setup do
+    @<%= singular_table_name %> = <%= fixture_name %>(:one)
+  end
+
+  def test_get_index
+    get <%= index_helper %>_url, as: :json
+    assert_response :success
+  end
+
+  def test_create_<%= singular_table_name %>
+    assert_difference("<%= class_name %>.count") do
+      post <%= index_helper %>_url, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }, as: :json
+    end
+
+    assert_response 201
+  end
+
+  def test_show_<%= singular_table_name %>
+    get <%= show_helper %>, as: :json
+    assert_response :success
+  end
+
+  def test_update_<%= singular_table_name %>
+    patch <%= show_helper %>, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }, as: :json
+    assert_response 200
+  end
+
+  def test_destroy_<%= singular_table_name %>
+    assert_difference("<%= class_name %>.count", -1) do
+      delete <%= show_helper %>, as: :json
+    end
+
+    assert_response 204
+  end
+end
+<% end -%>

data/lib/generators/minitest/scaffold/templates/functional_spec.rb.tt

@@ -0,0 +1,52 @@
+require "test_helper"
+
+<% module_namespacing do -%>
+describe <%= controller_class_name %>Controller do
+  <%- if mountable_engine? -%>
+  include Engine.routes.url_helpers
+
+  <%- end -%>
+  let(:<%= singular_table_name %>) { <%= fixture_name %>(:one) }
+
+  it "should get index" do
+    get <%= index_helper %>_url
+    must_respond_with :success
+  end
+
+  it "should get new" do
+    get <%= new_helper %>
+    must_respond_with :success
+  end
+
+  it "should create <%= singular_table_name %>" do
+    assert_difference("<%= class_name %>.count") do
+      post <%= index_helper %>_url, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }
+    end
+
+    must_redirect_to <%= singular_table_name %>_url(<%= class_name %>.last)
+  end
+
+  it "should show <%= singular_table_name %>" do
+    get <%= show_helper %>
+    must_respond_with :success
+  end
+
+  it "should get edit" do
+    get <%= edit_helper %>
+    must_respond_with :success
+  end
+
+  it "should update <%= singular_table_name %>" do
+    patch <%= show_helper %>, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }
+    must_redirect_to <%= singular_table_name %>_url(<%= "#{singular_table_name}" %>)
+  end
+
+  it "should destroy <%= singular_table_name %>" do
+    assert_difference("<%= class_name %>.count", -1) do
+      delete <%= show_helper %>
+    end
+
+    must_redirect_to <%= index_helper %>_url
+  end
+end
+<% end -%>

data/lib/generators/minitest/scaffold/templates/{controller_test.rb → functional_test.rb.tt}

@@ -6,49 +6,49 @@ class <%= controller_class_name %>ControllerTest < ActionDispatch::IntegrationTe
   include Engine.routes.url_helpers
 
   <%- end -%>
-  def <%= singular_table_name %>
-    @<%= singular_table_name %> ||= <%= fixture_name %> :one
+  setup do
+    @<%= singular_table_name %> = <%= fixture_name %>(:one)
   end
 
-  def test_index
+  def test_get_index
     get <%= index_helper %>_url
     assert_response :success
   end
 
-  def test_new
+  def test_get_new
     get <%= new_helper %>
     assert_response :success
   end
 
-  def test_create
-    assert_difference "<%= class_name %>.count" do
-      post <%= index_helper %>_url, params: { <%= "#{singular_table_name}: { #{attributes_hash} }" %> }
+  def test_create_<%= singular_table_name %>
+    assert_difference("<%= class_name %>.count") do
+      post <%= index_helper %>_url, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }
     end
 
-    assert_redirected_to <%= singular_table_name %>_path(<%= class_name %>.last)
+    assert_redirected_to <%= singular_table_name %>_url(<%= class_name %>.last)
   end
 
-  def test_show
+  def test_show_<%= singular_table_name %>
     get <%= show_helper %>
     assert_response :success
   end
 
-  def test_edit
+  def test_get_edit
     get <%= edit_helper %>
     assert_response :success
   end
 
-  def test_update
-    patch <%= show_helper %>, params: { <%= "#{singular_table_name}: { #{attributes_hash} }" %> }
-    assert_redirected_to <%= singular_table_name %>_path(<%= "#{singular_table_name}" %>)
+  def test_update_<%= singular_table_name %>
+    patch <%= show_helper %>, params: { <%= "#{singular_table_name}: { #{attributes_string} }" %> }
+    assert_redirected_to <%= singular_table_name %>_url(<%= "@#{singular_table_name}" %>)
   end
 
-  def test_destroy
-    assert_difference "<%= class_name %>.count", -1  do
+  def test_destroy_<%= singular_table_name %>
+    assert_difference("<%= class_name %>.count", -1) do
       delete <%= show_helper %>
     end
 
-    assert_redirected_to <%= index_helper %>_path
+    assert_redirected_to <%= index_helper %>_url
   end
 end
 <% end -%>

data/lib/generators/minitest/scaffold/templates/system_spec.rb.tt

@@ -0,0 +1,55 @@
+require "application_system_test_case"
+
+<% module_namespacing do -%>
+describe "<%= class_name.pluralize %>", :system do
+  let(:<%= singular_table_name %>) { <%= fixture_name %>(:one) }
+
+  it "visiting the index" do
+    visit <%= plural_table_name %>_url
+    assert_selector "h1", text: "<%= class_name.pluralize.titleize %>"
+  end
+
+  it "creating a <%= human_name %>" do
+    visit <%= plural_table_name %>_url
+    click_on "New <%= class_name.titleize %>"
+
+    <%- attributes_hash.each do |attr, value| -%>
+    <%- if boolean?(attr) -%>
+    check "<%= attr.humanize %>" if <%= value %>
+    <%- else -%>
+    fill_in "<%= attr.humanize %>", with: <%= value %>
+    <%- end -%>
+    <%- end -%>
+    click_on "Create <%= human_name %>"
+
+    assert_text "<%= human_name %> was successfully created"
+    click_on "Back"
+  end
+
+  it "updating a <%= human_name %>" do
+    visit <%= plural_table_name %>_url
+    click_on "Edit", match: :first
+
+    <%- attributes_hash.each do |attr, value| -%>
+    <%- if boolean?(attr) -%>
+    check "<%= attr.humanize %>" if <%= value %>
+    <%- else -%>
+    fill_in "<%= attr.humanize %>", with: <%= value %>
+    <%- end -%>
+    <%- end -%>
+    click_on "Update <%= human_name %>"
+
+    assert_text "<%= human_name %> was successfully updated"
+    click_on "Back"
+  end
+
+  it "destroying a <%= human_name %>" do
+    visit <%= plural_table_name %>_url
+    page.accept_confirm do
+      click_on "Destroy", match: :first
+    end
+
+    assert_text "<%= human_name %> was successfully destroyed"
+  end
+end
+<% end -%>

data/lib/generators/minitest/scaffold/templates/system_test.rb.tt

@@ -0,0 +1,57 @@
+require "application_system_test_case"
+
+<% module_namespacing do -%>
+class <%= class_name.pluralize %>Test < ApplicationSystemTestCase
+  setup do
+    @<%= singular_table_name %> = <%= fixture_name %>(:one)
+  end
+
+  def test_visiting_index
+    visit <%= plural_table_name %>_url
+    assert_selector "h1", text: "<%= class_name.pluralize.titleize %>"
+  end
+
+  def test_creating_<%= human_name %>
+    visit <%= plural_table_name %>_url
+    click_on "New <%= class_name.titleize %>"
+
+    <%- attributes_hash.each do |attr, value| -%>
+    <%- if boolean?(attr) -%>
+    check "<%= attr.humanize %>" if <%= value %>
+    <%- else -%>
+    fill_in "<%= attr.humanize %>", with: <%= value %>
+    <%- end -%>
+    <%- end -%>
+    click_on "Create <%= human_name %>"
+
+    assert_text "<%= human_name %> was successfully created"
+    click_on "Back"
+  end
+
+  def test_updating_<%= human_name %>
+    visit <%= plural_table_name %>_url
+    click_on "Edit", match: :first
+
+    <%- attributes_hash.each do |attr, value| -%>
+    <%- if boolean?(attr) -%>
+    check "<%= attr.humanize %>" if <%= value %>
+    <%- else -%>
+    fill_in "<%= attr.humanize %>", with: <%= value %>
+    <%- end -%>
+    <%- end -%>
+    click_on "Update <%= human_name %>"
+
+    assert_text "<%= human_name %> was successfully updated"
+    click_on "Back"
+  end
+
+  def test_destroying_<%= human_name %>
+    visit <%= plural_table_name %>_url
+    page.accept_confirm do
+      click_on "Destroy", match: :first
+    end
+
+    assert_text "<%= human_name %> was successfully destroyed"
+  end
+end
+<% end -%>

data/lib/generators/minitest/system/system_generator.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "generators/minitest"
+
+module Minitest # :nodoc:
+  module Generators # :nodoc:
+    class SystemGenerator < Base # :nodoc:
+      check_class_collision suffix: "Test"
+
+      def create_test_files
+        unless File.exist?(File.join("test/application_system_test_case.rb"))
+          template "application_system_test_case.rb", File.join("test", "application_system_test_case.rb")
+        end
+
+        template "system_#{test_file_type}.rb", File.join("test/system", class_path, "#{file_name.pluralize}_test.rb")
+      end
+
+      private
+
+      def file_name
+        @_file_name ||= super.sub(/_test\z/i, "")
+      end
+    end
+  end
+end

data/lib/generators/minitest/system/templates/application_system_test_case.rb.tt

@@ -0,0 +1,10 @@
+require "test_helper"
+require "minitest/rails/capybara"
+
+class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
+  driven_by :selenium, using: :chrome, screen_size: [1400, 1400]
+
+  register_spec_type(self) do |desc, *addl|
+    addl.include? :system
+  end
+end

data/lib/generators/minitest/system/templates/system_spec.rb.tt

@@ -0,0 +1,9 @@
+require "application_system_test_case"
+
+class <%= class_name.pluralize %>Test < ApplicationSystemTestCase
+  # test "visiting the index" do
+  #   visit <%= plural_table_name %>_url
+  #
+  #   assert_selector "h1", text: "<%= class_name %>"
+  # end
+end

data/lib/generators/minitest/system/templates/system_test.rb.tt

@@ -0,0 +1,9 @@
+require "application_system_test_case"
+
+class <%= class_name.pluralize %>Test < ApplicationSystemTestCase
+  # test "visiting the index" do
+  #   visit <%= plural_table_name %>_url
+  #
+  #   assert_selector "h1", text: "<%= class_name %>"
+  # end
+end

data/lib/minitest/rails.rb

@@ -4,102 +4,58 @@ require "minitest/spec"
 require "minitest/mock"
 require "minitest/hell" if ENV["MT_HELL"]
 
-################################################################################
-# Do we support old school controller tests?
-################################################################################
-
-module Minitest
-  module Rails
-    def self.controller_tests?
-      require "rails-controller-testing"
-      return true
-    rescue LoadError
-      return false
-    end
-  end
-end
-
-################################################################################
-# Add and configure the spec DSL
-################################################################################
-
 require "active_support/test_case"
-require "minitest/rails/constant_lookup"
+require "active_support/testing/constant_lookup"
+
 class ActiveSupport::TestCase
+  # Add and configure the spec DSL
   # Remove describe method if present
-  class << self
-    remove_method :describe
-  end if self.respond_to?(:describe) &&
-         self.method(:describe).owner == ActiveSupport::TestCase
+  if respond_to?(:describe) &&
+     method(:describe).owner == ActiveSupport::TestCase
+    class << self
+      remove_method :describe
+    end
+  end
 
   # Add spec DSL
   extend Minitest::Spec::DSL
 
   # Resolve constants from the test name when using the spec DSL
-  include Minitest::Rails::ConstantLookup
-end
+  include ActiveSupport::Testing::ConstantLookup
 
-class ActiveSupport::TestCase
-  if defined?(ActiveRecord::Base)
-    # Use AS::TestCase for the base class when describing a model
+  # Use AS::TC for the base class when describing a model
+  if defined? ActiveRecord
     register_spec_type(self) do |desc|
       desc < ActiveRecord::Base if desc.is_a?(Class)
     end
   end
-  register_spec_type(self) do |desc, *addl|
-    addl.include? :model
-  end
-end
-
-if Minitest::Rails.controller_tests?
-  require "action_controller/test_case"
-  require "minitest/rails/controller"
-  class ActionController::TestCase
-    # Use AC::TestCase for the base class when describing a controller
-    register_spec_type(self) do |desc|
-      Class === desc && desc < ActionController::Metal
-    end
-    register_spec_type(/Controller( ?Test)?\z/i, self)
-    register_spec_type(self) do |desc, *addl|
-      addl.include? :controller
-    end
 
-    # Resolve the controller from the test name when using the spec DSL
-    def self.determine_default_controller_class(name)
-      controller = determine_constant_from_test_name(name) do |constant|
-        Class === constant && constant < ActionController::Metal
-      end
-      raise NameError.new("Unable to resolve controller for #{name}") if controller.nil?
-      controller
-    end
+  # Use AS::TC for the base class when described using :model
+  register_spec_type(self) do |_desc, *addl|
+    addl.include? :model
   end
 end
 
 require "action_view/test_case"
-class ActionView::TestCase
-  # Use AV::TestCase for the base class for helpers and views
-  register_spec_type(/(Helper( ?Test)?| View Test)\z/i, self)
-  register_spec_type(self) do |desc, *addl|
-    addl.include?(:view) ||
-      addl.include?(:helper)
-  end
 
-  # Resolve the helper or view from the test name when using the spec DSL
-  def self.determine_default_helper_class(name)
-    determine_constant_from_test_name(name) do |constant|
-      Module === constant && !(Class === constant)
-    end
+class ActionView::TestCase
+  # Use AV::TC for the base class when described using :view or :helper
+  register_spec_type(self) do |_desc, *addl|
+    addl.include?(:view) || addl.include?(:helper)
   end
 end
 
 if defined? ActiveJob
+  # TODO: require?
+
   class ActiveJob::TestCase
-    # Use AJ::TestCase for the base when describing a job
+    # Use AJ::TC for the base when describing a job
     register_spec_type(self) do |desc|
       desc < ActiveJob::Base if desc.is_a?(Class)
     end
-    register_spec_type(/Job( ?Test)?\z/i, self)
-    register_spec_type(self) do |desc, *addl|
+
+    # Use AJ::TC for the base class when described using :job
+    register_spec_type(self) do |_desc, *addl|
       addl.include? :job
     end
   end
@@ -108,64 +64,73 @@ end
 if defined? ActionMailer
   require "action_mailer/test_helper"
   require "action_mailer/test_case"
+
   class ActionMailer::TestCase
-    # Use AM::TestCase for the base class when describing a mailer
+    # Use AM::TC for the base class when describing a mailer
     register_spec_type(self) do |desc|
       desc < ActionMailer::Base if desc.is_a?(Class)
     end
-    register_spec_type(/Mailer( ?Test)?\z/i, self)
-    register_spec_type(self) do |desc, *addl|
-      addl.include? :mailer
-    end
 
-    # Resolve the mailer from the test name when using the spec DSL
-    def self.determine_default_mailer(name)
-      mailer = determine_constant_from_test_name(name) do |constant|
-        Class === constant && constant < ::ActionMailer::Base
-      end
-      raise ActionMailer::NonInferrableMailerError.new(name) if mailer.nil?
-      mailer
+    # Use AM::TC for the base class when described using :mailer
+    register_spec_type(self) do |_desc, *addl|
+      addl.include? :mailer
     end
   end
 end
 
 require "action_dispatch/testing/integration"
+
 class ActionDispatch::IntegrationTest
-  if Minitest::Rails.controller_tests?
-    # Register by Integration name only
-    register_spec_type(/Integration( ?Test)?\z/i, self)
-    register_spec_type(self) do |desc, *addl|
-      addl.include? :integration
-    end
-  else
-    # Use AD::IntegrationTest for the base class when describing a controller
-    register_spec_type(self) do |desc|
-      Class === desc && desc < ActionController::Metal
-    end
-    # Register by name, either Integration or Controller
-    register_spec_type(/(Integration|Controller)( ?Test)?\z/i, self)
-    register_spec_type(self) do |desc, *addl|
-      addl.include?(:integration) ||
-        addl.include?(:controller)
-    end
+  # Use AD:IT for the base class when describing a controller
+  register_spec_type(self) do |desc|
+    desc < ActionController::Metal if desc.is_a?(Class)
+  end
+
+  # Use AD:IT for the base class when described using :integration
+  register_spec_type(self) do |_desc, *addl|
+    addl.include? :integration
   end
 end
 
+# TODO: Rails::Generators::TestCase require?
+
 class Rails::Generators::TestCase
+  # Use R::G::TC for the base class when describing a generator
   register_spec_type(self) do |desc|
     desc < Rails::Generators::Base if desc.is_a?(Class)
   end
-  register_spec_type(/Generator( ?Test)?\z/i, self)
-  register_spec_type(self) do |desc, *addl|
+
+  # Use R::G::TC for the base class when described using :generator
+  register_spec_type(self) do |_desc, *addl|
     addl.include? :generator
   end
+end
 
-  def self.determine_default_generator(name)
-    generator = determine_constant_from_test_name(name) do |constant|
-      Class === constant && constant < Rails::Generators::Base
+if defined? ActionCable
+  # TODO: require?
+
+  class ActionCable::Channel::TestCase
+    # Use AC::Ch::TC for the base class when describing a channel
+    register_spec_type(self) do |desc|
+      desc < ActionCable::Channel::Base if desc.is_a?(Class)
+    end
+
+    # Use AC::Ch::TC for the base class when described using :channel
+    register_spec_type(self) do |_desc, *addl|
+      addl.include? :channel
+    end
+  end
+
+  class ActionCable::Connection::TestCase
+    # Use AC::Co::TC for the base class when describing a connection
+    register_spec_type(self) do |desc|
+      desc < ActionCable::Connection::Base if desc.is_a?(Class)
+    end
+
+    # Use AC::Co::TC for the base class when described using :connection
+    register_spec_type(self) do |_desc, *addl|
+      addl.include? :connection
     end
-    raise NameError.new("Unable to resolve generator for #{name}") if generator.nil?
-    generator
   end
 end
 
@@ -176,6 +141,12 @@ end
 require "minitest/rails/assertions"
 require "minitest/rails/expectations"
 
+################################################################################
+# Support Rails parallelize
+################################################################################
+
+require "minitest/rails/parallelize"
+
 # :stopdoc:
 
 ################################################################################