minitest-parallel_fork 1.2.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c152ef9216b8cbc9700f7f7e0281847695b325e660b51268b0d148a44e5aba2
-  data.tar.gz: 9d0739abeb8ccfaeb0ed023cb75b4fe30bb3f6e509af6d952204042229356649
+  metadata.gz: bdbf96cdc1b208955148ed3e6ccba3d93542785b6e0c628a9b73acad4bcc0614
+  data.tar.gz: 18a0e8ed8d41d9c2d36d8927939d3b8865264b363df7194fefe1cb8238cecac3
 SHA512:
-  metadata.gz: e075bac95ab8dd13987e59533ace22ff48d878db63399659764f7af6c553cf835282b39044b50592ec776ab5ebc2d1af095bc9d8df955c0b230cce3cfe58a2e3
-  data.tar.gz: 57448ca69342f474102377fb287c67d298db98147bef22450d721cdae0acc4e9f65aad7d3e3937fc834118fd10e6200ced55d04609bc7ac43527dc1d6b63f5c7
+  metadata.gz: 874cd2b108f8f52135e6ea193dd5bb46b9416247dafab76e135a02456cc456a499c05f140aca081b9bf6f5a7c27affdd553cf752d51d8f7513ff150a1dca2d5d
+  data.tar.gz: ad5e405c811f861ae524a56c9d7e1d9bb397f4421898d5a103dddc646747b1c6dd5f02d20aafc2e0b40397308e4a897fb13611f3d9615c9d25766e309492ec85

data/CHANGELOG

@@ -1,3 +1,15 @@
+=== 1.3.1 (2023-09-25)
+
+* Bump required_ruby_version to 2.2, since that is lowest version supported by minitest 5.15.0 (jeremyevans)
+
+* Update count and assertions for all configured statistics reporters, not just the first (akimd) (#10)
+
+=== 1.3.0 (2022-07-05)
+
+* Bump minimum minitest version to 5.15.0 (jeremyevans)
+
+* Detect reporter to use by looking for specific methods, instead of specifically for a Minitest::StatisticsReporter (jeremyevans) (#8)
+
 === 1.2.0 (2021-08-16)
 
 * Work correctly with Minitest 5.14+ (jeremyevans)

data/lib/minitest/parallel_fork.rb

@@ -25,7 +25,9 @@ module Minitest
   end
   
   def self.parallel_fork_stat_reporter(reporter)
-    reporter.reporters.detect{|rep| rep.is_a?(StatisticsReporter)}
+    reporter.reporters.detect do |rep|
+      %w'count assertions results count= assertions='.all?{|meth| rep.respond_to?(meth)}
+    end
   end
 
   # Override __run to use a child forks to run the speeds, which
@@ -42,7 +44,7 @@ module Minitest
     n.times do |i|
       read, write = IO.pipe.each{|io| io.binmode}
       reads << read
-      fork do
+      Process.fork do
         read.close
         if @after_parallel_fork
           @after_parallel_fork.call(i)
@@ -52,38 +54,13 @@ module Minitest
         suites.each_with_index{|s, j| p_suites << s if j % n == i}
         p_suites.each do |s|
           if s.is_a?(Minitest::Parallel::Test::ClassMethods)
-           s.extend(Unparallelize)
+            s.extend(Unparallelize)
           end
 
           s.run(reporter, options)
         end
 
         data = %w'count assertions results'.map{|meth| stat_reporter.send(meth)}
-        if data[-1].any?{|result| !result.is_a?(Minitest::Result)}
-          data[-1] = data[-1].map do |result|
-            Minitest::Result.from(result)
-          end
-        end
-
-        data[-1].each do |result|
-          result.failures.each do |failure|
-            if failure.is_a?(Minitest::UnexpectedError)
-              e = failure.respond_to?(:error) ? failure.error : failure.exception
-              begin
-                Marshal.dump(e)
-              rescue TypeError
-                e2 = RuntimeError.new("Wrapped undumpable exception for: #{e.class}: #{e.message}")
-                e2.set_backtrace(e.backtrace)
-                if failure.respond_to?(:error=)
-                  failure.error = e2
-                else
-                  failure.exception = e2
-                end
-              end
-            end
-          end
-        end
-
         write.write(Marshal.dump(data))
         write.close
       end
@@ -99,9 +76,12 @@ module Minitest
         end
         raise
       end
-      stat_reporter.count += count
-      stat_reporter.assertions += assertions
-      stat_reporter.results.concat(results)
+      reporter.reporters.each do |rep|
+        next unless %w'count assertions results count= assertions='.all?{|meth| rep.respond_to?(meth)}
+        rep.count += count
+        rep.assertions += assertions
+        rep.results.concat(results)
+      end
     end
 
     nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-parallel_fork
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Jeremy Evans
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-16 00:00:00.000000000 Z
+date: 2023-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.11.0
+        version: 5.15.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.15.0
+- !ruby/object:Gem::Dependency
+  name: minitest-hooks
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.11.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest-global_expectations
   requirement: !ruby/object:Gem::Requirement
@@ -56,15 +70,16 @@ files:
 - CHANGELOG
 - MIT-LICENSE
 - README.rdoc
-- Rakefile
 - lib/minitest/parallel_fork.rb
-- spec/minitest_parallel_fork_example.rb
-- spec/minitest_parallel_fork_spec.rb
 homepage: http://github.com/jeremyevans/minitest-parallel_fork
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  bug_tracker_uri: https://github.com/jeremyevans/minitest-parallel_fork/issues
+  changelog_uri: https://github.com/jeremyevans/minitest-parallel_fork/blob/master/CHANGELOG
+  mailing_list_uri: https://github.com/jeremyevans/minitest-parallel_fork/discussions
+  source_code_uri: https://github.com/jeremyevans/minitest-parallel_fork
+post_install_message:
 rdoc_options:
 - "--quiet"
 - "--line-numbers"
@@ -79,15 +94,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Fork-based parallelization for minitest
 test_files: []

data/Rakefile

@@ -1,46 +0,0 @@
-require "rake"
-require "rake/clean"
-
-CLEAN.include ["minitest-parallel_fork-*.gem", "rdoc", "coverage"]
-
-desc "Build minitest-parallel_fork gem"
-task :package=>[:clean] do |p|
-  sh %{#{FileUtils::RUBY} -S gem build minitest-parallel_fork.gemspec}
-end
-
-### Specs
-
-desc "Run specs"
-task :spec do
-  ENV['RUBY'] = FileUtils::RUBY
-  sh %{#{FileUtils::RUBY} spec/minitest_parallel_fork_spec.rb}
-end
-
-task :default=>:spec
-
-### RDoc
-
-RDOC_DEFAULT_OPTS = ["--quiet", "--line-numbers", "--inline-source", '--title', 'minitest-parallel_fork: fork-based parallelization for minitest']
-
-begin
-  gem 'hanna-nouveau'
-  RDOC_DEFAULT_OPTS.concat(['-f', 'hanna'])
-rescue Gem::LoadError
-end
-
-rdoc_task_class = begin
-  require "rdoc/task"
-  RDoc::Task
-rescue LoadError
-  require "rake/rdoctask"
-  Rake::RDocTask
-end
-
-RDOC_OPTS = RDOC_DEFAULT_OPTS + ['--main', 'README.rdoc']
-
-rdoc_task_class.new do |rdoc|
-  rdoc.rdoc_dir = "rdoc"
-  rdoc.options += RDOC_OPTS
-  rdoc.rdoc_files.add %w"README.rdoc CHANGELOG MIT-LICENSE lib/**/*.rb"
-end
-

data/spec/minitest_parallel_fork_example.rb

@@ -1,59 +0,0 @@
-gem 'minitest'
-require 'minitest/global_expectations/autorun'
-require 'minitest/parallel_fork'
-
-a = nil
-Minitest.before_parallel_fork do
-  a = 'a'
-  print ":parent"
-end
-
-Minitest.after_parallel_fork do |i|
-  print ":child#{i}#{a}"
-end
-
-if ENV['MPF_TEST_CHILD_FAILURE']
-  Minitest.on_parallel_fork_marshal_failure do |i|
-    print ":child-failure#{i}#{a}"
-  end
-end
-
-class MyExceptionClass < StandardError
-  attr_reader :something
-end
-
-4.times do |i|
-  describe 'minitest/parallel_fork' do
-    parallelize_me! if ENV['MPF_PARALLELIZE_ME']
-
-    if ENV['MPF_TEST_ORDER_PARALLEL']
-      def self.test_order
-        :parallel
-      end
-    end
-
-    it "should work" do
-      sleep(1)
-      1.must_equal 1
-    end
-
-    it "should fail" do
-      1.must_equal 2
-    end
-
-    it "should raise" do
-      exit(1) if ENV['MPF_TEST_CHILD_FAILURE']
-      raise
-    end
-
-    it "should raise exception containing undumpable data" do
-      e = MyExceptionClass.new("error")
-      e.something = Class.new
-      raise e
-    end
-
-    it "should skip" do
-      skip
-    end
-  end
-end

data/spec/minitest_parallel_fork_spec.rb

@@ -1,40 +0,0 @@
-ENV['MT_NO_PLUGINS'] = '1'
-gem 'minitest'
-require 'minitest/global_expectations/autorun'
-
-describe 'minitest/parallel_fork' do
-  [[nil, ''],
-   ['MPF_PARALLELIZE_ME', ' when parallelize_me! is used'],
-   ['MPF_TEST_ORDER_PARALLEL', ' when test_order parallel is used']
-  ].each do |env_key, msg|
-    it "should execute in parallel#{msg}" do
-      t = Time.now
-      ENV['NCPU'] = '4'
-      ENV[env_key] = '1' if env_key
-      output = `#{ENV['RUBY']} -I lib spec/minitest_parallel_fork_example.rb`
-      ENV.delete(env_key) if env_key
-
-      time = (Time.now - t)
-      time.must_be :<, 4
-      time.must_be :>, 1
-      output.must_match /:parent/
-      output.must_match /20 runs, 8 assertions, 4 failures, 8 errors, 4 skips/
-      4.times do |i|
-        output.must_match /:child#{i}a/
-      end
-    end
-  end
-
-  it "should call on_parallel_fork_marshal_failure on failure" do
-    t = Time.now
-    ENV['NCPU'] = '4'
-    ENV['MPF_TEST_CHILD_FAILURE'] = '1'
-    output = `#{ENV['RUBY']} -I lib spec/minitest_parallel_fork_example.rb 2>&1`
-    ENV.delete('MPF_TEST_CHILD_FAILURE')
-
-    time = (Time.now - t)
-    time.must_be :<, 4
-    output.must_match /:child-failurea/
-    output.must_match /marshal data too short/
-  end
-end