minitest-parallel_fork 1.1.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42db9e813710ee5326a0df5f24f4b5deb361cc21372e6a87124008039526cddc
-  data.tar.gz: e29d3ab12e2559a840a9bf92dd4653f0e98397c0381167c3f1dbb1fc6c7391f7
+  metadata.gz: b7def66702fe6ea3e7cf52578a812f0ecdbb4b3545c2bd4d04ee5ff73a417af5
+  data.tar.gz: 138a5104f9f344284e806a6b90deb20d61fdf2b16562488b8afc3917f9d8738d
 SHA512:
-  metadata.gz: 4e45f180446e10b90ab9aaa7051261eec1e5c472422a1b5c522f7d58cd44f4f0adef68f2d875f3061c4902662e2ed190208d8448af6d89b6faf78445e132c9dc
-  data.tar.gz: 5d8b6fecb607917c6bc3940ad758eae573a32c5f5b803f68bddc2e3bada9a50c0668e0ddfdb84d9cd14ee357a53ae6b15cd2ca33c24830cf1b57ded37b92b463
+  metadata.gz: cbc75286347260d6a6cd54e3c8bb1c21f1cd3c9c24c2e843a3942ab7056fc53e4ee092a4a65cb66e52816433a96dfbdfd338b871e334acc1e973fa80ad184d6c
+  data.tar.gz: f882ac98930a53fa6ec7d02b3edf50bf9a34b3bb7ce17f72b834879313df0f251c9aa23ea45b5cb1f4d02e969933728dca5ec7f1e8898c3c4cc9b2e7d95fe487

data/CHANGELOG

@@ -1,3 +1,19 @@
+=== 1.3.0 (2022-07-05)
+
+* Bump minimum minitest version to 5.15.0 (jeremyevans)
+
+* Detect reporter to use by looking for specific methods, instead of specifically for a Minitest::StatisticsReporter (jeremyevans) (#8)
+
+=== 1.2.0 (2021-08-16)
+
+* Work correctly with Minitest 5.14+ (jeremyevans)
+
+* Add on_parallel_fork_marshal_failure hook for handling marshal failures (child process exiting) (jeremyevans)
+
+=== 1.1.2 (2018-07-05)
+
+* Handle raised exceptions containing unmarshallable data (jeremyevans)
+
 === 1.1.1 (2018-05-07)
 
 * Work around marshalling issue when there are failures in *_all hooks when using minitest-hooks (jeremyevans)

data/README.rdoc

@@ -59,6 +59,15 @@ disconnected, and after forking, the database name is changed in each child to r
 a child-specific database, so that the child processes do not share a database and are
 thus independent.
 
+There is also a hook for debugging.  +on_parallel_fork_marshal_failure+ is called if
+there is an error unmarshalling data sent from the child process to the parent process.
+This can happen if one of the child processes exits unexpected during the test, before
+it reports results.
+
+  Minitest.on_parallel_fork_marshal_failure do
+    # Gather relevant logs for more debugging
+  end
+
 == ActiveRecord
 
 To use this with Rails/ActiveRecord, you probably want to use hooks similar to:

data/lib/minitest/parallel_fork.rb

@@ -6,18 +6,28 @@ module Minitest
   def self.before_parallel_fork(&block)
     @before_parallel_fork = block
   end
+  @before_parallel_fork = nil
 
   # Set the after_parallel_fork block to the given block
   def self.after_parallel_fork(i=nil, &block)
     @after_parallel_fork = block
   end
+  @after_parallel_fork = nil
+
+  # Set the on_parallel_fork_marshal_failure block to the given block
+  def self.on_parallel_fork_marshal_failure(&block)
+    @on_parallel_fork_marshal_failure = block
+  end
+  @on_parallel_fork_marshal_failure = nil
 
   module Unparallelize
     define_method(:run_one_method, &Minitest::Test.method(:run_one_method))
   end
   
   def self.parallel_fork_stat_reporter(reporter)
-    reporter.reporters.detect{|rep| rep.is_a?(StatisticsReporter)}
+    reporter.reporters.detect do |rep|
+      %w'count assertions results count= assertions='.all?{|meth| rep.respond_to?(meth)}
+    end
   end
 
   # Override __run to use a child forks to run the speeds, which
@@ -28,15 +38,15 @@ module Minitest
 
     n = (ENV['NCPU'] || 4).to_i
     reads = []
-    if defined?(@before_parallel_fork)
+    if @before_parallel_fork
       @before_parallel_fork.call
     end
     n.times do |i|
       read, write = IO.pipe.each{|io| io.binmode}
       reads << read
-      fork do
+      Process.fork do
         read.close
-        if defined?(@after_parallel_fork)
+        if @after_parallel_fork
           @after_parallel_fork.call(i)
         end
 
@@ -44,19 +54,13 @@ module Minitest
         suites.each_with_index{|s, j| p_suites << s if j % n == i}
         p_suites.each do |s|
           if s.is_a?(Minitest::Parallel::Test::ClassMethods)
-           s.extend(Unparallelize)
+            s.extend(Unparallelize)
           end
 
           s.run(reporter, options)
         end
 
         data = %w'count assertions results'.map{|meth| stat_reporter.send(meth)}
-        if data[-1].any?{|result| !result.is_a?(Minitest::Result)}
-          data[-1] = data[-1].map do |result|
-            Minitest::Result.from(result)
-          end
-        end
-
         write.write(Marshal.dump(data))
         write.close
       end
@@ -64,7 +68,14 @@ module Minitest
     end
 
     reads.map{|read| Thread.new(read, &:read)}.map(&:value).each do |data|
-      count, assertions, results = Marshal.load(data)
+      begin
+        count, assertions, results = Marshal.load(data)
+      rescue ArgumentError
+        if @on_parallel_fork_marshal_failure
+          @on_parallel_fork_marshal_failure.call
+        end
+        raise
+      end
       stat_reporter.count += count
       stat_reporter.assertions += assertions
       stat_reporter.results.concat(results)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-parallel_fork
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2022-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.11.0
+        version: 5.15.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.15.0
+- !ruby/object:Gem::Dependency
+  name: minitest-hooks
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-global_expectations
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.11.0
+        version: '0'
 description: |
   minitest-parallel_fork adds fork-based parallelization to Minitest.  Each test/spec
   suite is run in one of the forks, allowing this to work correctly when using
@@ -42,14 +70,15 @@ files:
 - CHANGELOG
 - MIT-LICENSE
 - README.rdoc
-- Rakefile
 - lib/minitest/parallel_fork.rb
-- spec/minitest_parallel_fork_example.rb
-- spec/minitest_parallel_fork_spec.rb
 homepage: http://github.com/jeremyevans/minitest-parallel_fork
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: https://github.com/jeremyevans/minitest-parallel_fork/issues
+  changelog_uri: https://github.com/jeremyevans/minitest-parallel_fork/blob/master/CHANGELOG
+  mailing_list_uri: https://github.com/jeremyevans/minitest-parallel_fork/discussions
+  source_code_uri: https://github.com/jeremyevans/minitest-parallel_fork
 post_install_message: 
 rdoc_options:
 - "--quiet"
@@ -72,8 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Fork-based parallelization for minitest

data/Rakefile

@@ -1,46 +0,0 @@
-require "rake"
-require "rake/clean"
-
-CLEAN.include ["minitest-parallel_fork-*.gem", "rdoc", "coverage"]
-
-desc "Build minitest-parallel_fork gem"
-task :package=>[:clean] do |p|
-  sh %{#{FileUtils::RUBY} -S gem build minitest-parallel_fork.gemspec}
-end
-
-### Specs
-
-desc "Run specs"
-task :spec do
-  ENV['RUBY'] = FileUtils::RUBY
-  sh %{#{FileUtils::RUBY} spec/minitest_parallel_fork_spec.rb}
-end
-
-task :default=>:spec
-
-### RDoc
-
-RDOC_DEFAULT_OPTS = ["--quiet", "--line-numbers", "--inline-source", '--title', 'minitest-parallel_fork: fork-based parallelization for minitest']
-
-begin
-  gem 'hanna-nouveau'
-  RDOC_DEFAULT_OPTS.concat(['-f', 'hanna'])
-rescue Gem::LoadError
-end
-
-rdoc_task_class = begin
-  require "rdoc/task"
-  RDoc::Task
-rescue LoadError
-  require "rake/rdoctask"
-  Rake::RDocTask
-end
-
-RDOC_OPTS = RDOC_DEFAULT_OPTS + ['--main', 'README.rdoc']
-
-rdoc_task_class.new do |rdoc|
-  rdoc.rdoc_dir = "rdoc"
-  rdoc.options += RDOC_OPTS
-  rdoc.rdoc_files.add %w"README.rdoc CHANGELOG MIT-LICENSE lib/**/*.rb"
-end
-

data/spec/minitest_parallel_fork_example.rb

@@ -1,41 +0,0 @@
-gem 'minitest'
-require 'minitest/autorun'
-require 'minitest/parallel_fork'
-
-a = nil
-Minitest.before_parallel_fork do
-  a = 'a'
-  print ":parent"
-end
-
-Minitest.after_parallel_fork do |i|
-  print ":child#{i}#{a}"
-end
-
-4.times do |i|
-  describe 'minitest/parallel_fork' do
-    parallelize_me! if ENV['MPF_PARALLELIZE_ME']
-
-    if ENV['MPF_TEST_ORDER_PARALLEL']
-      def self.test_order
-        :parallel
-      end
-    end
-
-    it "should work" do
-      sleep(1).must_equal 1
-    end
-
-    it "should fail" do
-      1.must_equal 2
-    end
-
-    it "should raise" do
-      raise
-    end
-
-    it "should skip" do
-      skip
-    end
-  end
-end

data/spec/minitest_parallel_fork_spec.rb

@@ -1,26 +0,0 @@
-gem 'minitest'
-require 'minitest/autorun'
-
-describe 'minitest/parallel_fork' do
-  [[nil, ''],
-   ['MPF_PARALLELIZE_ME', ' when parallelize_me! is used'],
-   ['MPF_TEST_ORDER_PARALLEL', ' when test_order parallel is used']
-  ].each do |env_key, msg|
-    it "should execute in parallel#{msg}" do
-      t = Time.now
-      ENV['NCPU'] = '4'
-      ENV[env_key] = '1' if env_key
-      output = `#{ENV['RUBY']} -I lib spec/minitest_parallel_fork_example.rb`
-      ENV.delete(env_key) if env_key
-
-      time = (Time.now - t)
-      time.must_be :<, 4
-      time.must_be :>, 1
-      output.must_match /:parent/
-      output.must_match /16 runs, 8 assertions, 4 failures, 4 errors, 4 skips/
-      4.times do |i|
-        output.must_match /:child#{i}a/
-      end
-    end
-  end
-end