minitest-matchers 1.1.0.rc2 → 1.1.0.rc3

data/README.txt

@@ -7,14 +7,15 @@
 minitest-matchers adds support for RSpec/Shoulda-style matchers to
 minitest/unit and minitest/spec.
 
-A matcher is a class that must implement #description, #matches?,
-#failure_message and #negative_failure_message methods.
-Expactations are then builded using these methods.
+More information about matchers can be found here:
+* https://www.relishapp.com/rspec/rspec-expectations
+* http://railscasts.com/episodes/157-rspec-matchers-macros
 
 == FEATURES/PROBLEMS:
 
 * Enables you to use existing matcher classes from projects like
-  valid_attribute, (with some additional work) shoulda-matchers and remarkable.
+  valid_attribute and in the future shoulda-matchers and maybe even remarkable.
+* Can be used both in MiniTest::Unit::TestCase & MiniTest::Spec
 
 == SYNOPSIS:
 

data/Rakefile

@@ -4,6 +4,7 @@ require "rubygems"
 require "hoe"
 
 Hoe.plugin :minitest
+Hoe.plugin :gemspec
 
 Hoe.spec "minitest-matchers" do
   developer "Ryan Davis", "ryand-ruby@zenspider.com"

data/lib/minitest/matchers.rb

@@ -1,22 +1,7 @@
 require "minitest/spec"
 
 module MiniTest::Matchers
-  VERSION = "1.1.0.rc2" # :nodoc:
-
-  ##
-  # Every matcher must respond to following methods:
-  #   - #description
-  #   - #matches?
-  #   - #failure_message
-  #   - #negative_failure_message
-
-  def self.check_matcher matcher
-    [:description, :matches?, :failure_message, :negative_failure_message].each do |m|
-      unless matcher.respond_to? m
-        fail "Matcher must respond to #{m}."
-      end
-    end
-  end
+  VERSION = "1.1.0.rc3" # :nodoc:
 end
 
 module MiniTest
@@ -31,10 +16,15 @@ module MiniTest
     #   end
 
     def assert_must matcher, subject, msg = nil
-      MiniTest::Matchers.check_matcher matcher
       result = matcher.matches? subject
 
-      msg = message(msg) { matcher.failure_message }
+      msg = message(msg) do
+        if matcher.respond_to? :negative_failure_message
+          matcher.negative_failure_message
+        else
+          matcher.failure_message_for_should
+        end
+      end
 
       assert result, msg
     end
@@ -49,10 +39,15 @@ module MiniTest
     #   end
 
     def assert_wont matcher, subject, msg = nil
-      MiniTest::Matchers.check_matcher matcher
       result = matcher.matches? subject
 
-      msg = message(msg) { matcher.negative_failure_message }
+      msg = message(msg) do
+        if matcher.respond_to? :negative_failure_message
+          matcher.negative_failure_message
+        else
+          matcher.failure_message_for_should_not
+        end
+      end
 
       refute result, msg
     end

data/test/test_minitest_matchers.rb

@@ -15,14 +15,14 @@ class KindOfMatcher
   end
 
   def matches? subject
-    subject.kind_of?  @klass
+    subject.kind_of? @klass
   end
 
-  def failure_message
+  def failure_message_for_should
     "expected to " + description
   end
 
-  def negative_failure_message
+  def failure_message_for_should_not
     "expected not to " + description
   end
 end
@@ -32,10 +32,6 @@ def be_kind_of klass
 end
 
 describe MiniTest::Unit::TestCase do
-  it "needs to verify matcher has #description and #matches?" do
-    proc { assert_must BadMatcher.new, [] }.must_raise RuntimeError
-  end
-
   it "needs to verify assert_must" do
     assert_must(be_kind_of(Array), []).must_equal true
     proc { assert_must be_kind_of(String), [] }.must_raise MiniTest::Assertion
@@ -48,10 +44,6 @@ describe MiniTest::Unit::TestCase do
 end
 
 describe MiniTest::Spec do
-  it "needs to verify matcher has #description and #matches?" do
-    proc { [].must BadMatcher.new, [] }.must_raise RuntimeError
-  end
-
   it "needs to verify must" do
     [].must(be_kind_of(Array)).must_equal true
     proc { [].must be_kind_of(String) }.must_raise MiniTest::Assertion
@@ -66,27 +58,23 @@ describe MiniTest::Spec do
     spec_class = Class.new(MiniTest::Spec) do
       subject { [1, 2, 3] }
 
-      it("1") { must be_kind_of(Array) }
-      it("2") { must be_kind_of(String) }
+      it { must be_kind_of(String) }
     end
 
     spec = spec_class.new("A spec")
 
-    spec.send "test_0001_1"
-    proc { spec.send "test_0002_2"}.must_raise MiniTest::Assertion
+    proc { spec.send spec_class.test_methods.first}.must_raise MiniTest::Assertion
   end
 
   it "needs to verify wont with implicit subject" do
     spec_class = Class.new(MiniTest::Spec) do
       subject { [1, 2, 3] }
 
-      it("1") { wont be_kind_of(String) }
-      it("2") { wont be_kind_of(Array) }
+      it { wont be_kind_of(Array) }
     end
 
     spec = spec_class.new("A spec")
 
-    spec.send "test_0001_1"
-    proc { spec.send "test_0002_2"}.must_raise MiniTest::Assertion
+    proc { spec.send spec_class.test_methods.first}.must_raise MiniTest::Assertion
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-matchers
 version: !ruby/object:Gem::Version
-  version: 1.1.0.rc2
+  version: 1.1.0.rc3
   prerelease: 6
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-03 00:00:00.000000000Z
+date: 2011-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70279503203140 !ruby/object:Gem::Requirement
+  requirement: &70336486719080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,21 +22,21 @@ dependencies:
         version: 2.5.0
   type: :runtime
   prerelease: false
-  version_requirements: *70279503203140
+  version_requirements: *70336486719080
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70279503202320 !ruby/object:Gem::Requirement
+  requirement: &70336486718660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.8'
   type: :development
   prerelease: false
-  version_requirements: *70279503202320
+  version_requirements: *70336486718660
 - !ruby/object:Gem::Dependency
   name: hoe
-  requirement: &70279503201140 !ruby/object:Gem::Requirement
+  requirement: &70336486718240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,8 +44,17 @@ dependencies:
         version: '2.12'
   type: :development
   prerelease: false
-  version_requirements: *70279503201140
-description: methods.
+  version_requirements: *70336486718240
+description: ! 'minitest-matchers adds support for RSpec/Shoulda-style matchers to
+
+  minitest/unit and minitest/spec.
+
+
+  More information about matchers can be found here:
+
+  * https://www.relishapp.com/rspec/rspec-expectations
+
+  * http://railscasts.com/episodes/157-rspec-matchers-macros'
 email:
 - ryand-ruby@zenspider.com
 - wojtek@wojtekmach.pl
@@ -89,6 +98,7 @@ rubyforge_project: minitest-matchers
 rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
-summary: methods.
+summary: minitest-matchers adds support for RSpec/Shoulda-style matchers to minitest/unit
+  and minitest/spec
 test_files:
 - test/test_minitest_matchers.rb