minitest-markdown 0.2.0.pre → 0.2.2.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50ca2163359f3e4b038a8e4837bcb38511bca5e5b00bc2603873816bba2408e1
-  data.tar.gz: 15fcbc54bcc387111b92b86fe5c291ce82d05f9391f12d41955aaa0d191c2735
+  metadata.gz: 0a9a40aad00d3cf796ff92234e9677cc452131a2ca0ff09936d77de0155e1cd7
+  data.tar.gz: 57e2ce0e6b9b4a3752a621dde91cdf8e483dca82efa4eb6373a2de04f2175769
 SHA512:
-  metadata.gz: 26bba54a86204e035f3890032eb985ac494133a697fc79c937ed863270e7659acb8675e916aba14b83062b1cb162b5ca7ef7a73e3283ad2c80b95889e8fac356
-  data.tar.gz: f6556b67590972e176b120c879d499d00fc2bc0574c1f134bec9f76c12f6f37907b2b1c09fb19aab7e73d41bd697bdf37c289f2180797b8f4940043935441043
+  metadata.gz: a09e92d607c2484518f8f23fac73e709de766b62f41d17bdfeaccc4931293b2e00cbdf35a5ad4872be6aae6f4022a6579d38dc31c23a5581191c16c85924b596
+  data.tar.gz: 96fbb9758bfd397dcce743c0f76c9e78e6155b4fd5f4a299e9c64bb304503732565f4310b348032a43fb4febccab3e7eb79b1cc12aa3a21b82563fc2760d829d

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 ## [Unreleased]
 
+## [0.2.2.pre] - 2025-05-08
+
+- Improve magic comment & hook comment parsing
+- Fix bug with empty sting after magic comment
+- Fix bug in config if Bundler undefined
+
+## [0.2.1.pre] - 2025-05-07
+
+- Fix issue with require in eval
+- Fix bug in StubChain where instance was mutated after #call
+
 ## [0.2.0.pre] - 2025-05-06
 
 - Add ability to pass any number of stubs to a test code block

data/README.md

@@ -21,6 +21,17 @@ If bundler is not being used to manage dependencies, install the gem by executin
 gem install minitest-markdown
 ```
 
+## Configuration
+
+No configuation is required if you use Bundler. If not, set your `project_root` path using the setter method:
+```ruby
+@config = Markdown.config
+# => instance_of Configuration
+
+Configuration.instance_methods(false)
+# => includes :project_root=
+```
+
 ## Usage
 
 ### In your test class
@@ -106,11 +117,13 @@ Everything in the code blocks above runs as test code. [minitest-proveit](https:
 It is possible to pass stubs to the generated tests. This is done using the stubs keyword. Hash keys represent the index of the test code block and the key is an instance of `StubChain`. `StubChain.stubproc` returns a procified stub which is called around the relevant test code. Zero or more of these reusable procs can be used to instantiate a StubChain object:
 ```ruby
 class MarkdownTest < Minitest::Test
-  set_stubs_new = Minitest::StubChain.stubproc(Set, :new, []) # returns a proc which stubs Set.new to return an empty array
-  array_stubs_size = Minitest::StubChain.stubproc(Array, :size, 42, any_instance: true) # uses the bundled minitest-stub_any_instance gem
+  set_stubs_new = Minitest::StubChain.stubproc(Set, :new, Set.new) # returns a proc which stubs Set.new to return an empty set
+  set_stubs_size = Minitest::StubChain.stubproc(Set, :size, 42, any_instance: true) # uses the bundled minitest-stub_any_instance gem
 
   stubs = {}
-  stubs[8] = Minitest::StubChain.new([set_stubs_new, array_stubs_size]) # initialized with zero or more stub procs
+  @stub_chain = Minitest::StubChain.new([set_stubs_new, set_stubs_size]) # initialized with zero or more stub procs
+  stubs[9] = @stub_chain
+  stubs[10] = @stub_chain # StubChain instances themseves may be reused
 
   Markdown.generate_markdown_tests(self, stubs: stubs)
 end
@@ -118,22 +131,21 @@ end
 ```
 The 2 stubs above are demonstated in the following examples:
 ```ruby
-# This is test_block8
-Set.new([1, 'c', :s]).size # Here Set.new was stubbed to return an Array and Array#size was stubbed to return 42
+# This is test_block9
+Set.new([1, 'c', :s]).size # Here Set.new was stubbed to return an empty set and Set#size was stubbed to return 42
 # => 42
 ```
-
-## Configuration
-
-No configuation is required if you use Bundler. If not, set your `project_root` path using the setter method:
+Example showing the reuse of a StubChain:
 ```ruby
-@config = Markdown.config
-# => instance_of Configuration
-
-Configuration.instance_methods(false)
-# => includes :project_root=
+# This is test_block10
+Set.new.size
+# => 42
 ```
 
+### Errors
+
+All errors subclass `Markdown::Error`
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/minitest/markdown/configuration.rb

@@ -2,29 +2,32 @@
 
 require 'pathname'
 
-require_relative 'error'
+require_relative 'errors'
 
 module Minitest
   module Markdown
     # configuration for gem
     class Configuration
-      attr_accessor :project_root, :prove_it
+      PROJECT_ROOT_UNDETERMINED = "Project root can't be determined, set with 'Markdown.config.project_root = /path'"
+
+      attr_writer :project_root
+      attr_accessor :prove_it
 
       def initialize
-        @project_root = determine_project_root
+        @project_root = self.class.determine_project_root
         @prove_it = true
       end
 
-      def readme_path
-        project_root.join 'README.md'
+      def self.determine_project_root
+        Bundler.root if defined? Bundler
       end
 
-      private
-
-      def determine_project_root
-        return Bundler.root if defined? Bundler
+      def project_root
+        @project_root || (raise Error, PROJECT_ROOT_UNDETERMINED)
+      end
 
-        raise Error::MarkdownError, "Project root can't be determined, set with 'Config.project_root = /root/path'"
+      def readme_path
+        project_root.join 'README.md'
       end
     end
   end

data/lib/minitest/markdown/{error.rb → errors.rb}

@@ -2,8 +2,6 @@
 
 module Minitest
   module Markdown
-    module Error
-      class MarkdownError < StandardError; end
-    end
+    class Error < StandardError; end
   end
 end

data/lib/minitest/markdown/test_class.rb

@@ -3,6 +3,8 @@
 require_relative '../assertions_extensions'
 require_relative 'test_code_block'
 
+$LOAD_PATH << '.' # fix #2
+
 module Minitest
   module Markdown
     # knows how to build a markdown test
@@ -11,12 +13,15 @@ module Minitest
       HOOK_METHODS = %i[before_all after_all around around_all].freeze # minitest-hooks extension
       NON_TEST_METHODS = %i[setup teardown].freeze
 
+      BAD_KLASS = 'TestClass must be instantiated with Minitest::Test or subclass thereof'
+      BAD_PATH = 'Path does not exist or is not readable:'
+
       attr_reader :klass, :path
 
       def initialize(klass, path: nil)
-        @klass = klass
+        @klass = validate_class(klass)
         @config = Markdown.config
-        @path = path || @config.readme_path
+        @path = validate_path(path)
         @ruby_blocks = parse_ruby_blocks
       end
 
@@ -28,6 +33,19 @@ module Minitest
 
       private
 
+      def validate_class(klass)
+        raise ArgumentError, BAD_KLASS unless klass.respond_to?(:ancestors) && klass.ancestors.include?(Minitest::Test)
+
+        klass
+      end
+
+      def validate_path(path)
+        return @config.readme_path if path.nil?
+        raise ArgumentError, "#{BAD_PATH} #{path}" unless File.exist?(path) && File.file?(path)
+
+        path
+      end
+
       def parse_ruby_blocks
         File.new(path).read.scan(FENCED_BLOCK_REGEXP).flatten.map { |str| TestCodeBlock.new(str) }
       end
@@ -52,13 +70,17 @@ module Minitest
       end
 
       def parse_non_test_method_block(type)
-        blocks = @ruby_blocks.map.select { |blk| blk.fenced_block_str.lines.first == "# #{type}\n" }
+        blocks = @ruby_blocks.map.select { |blk| parse_type(blk, type) }
         return if blocks.empty?
-        raise Error::MarkdownError, "Multiple #{type} blocks are not allowed" if blocks.size > 1
+        raise Error, "Multiple #{type} blocks are not allowed" if blocks.size > 1
 
         @ruby_blocks.delete(blocks.first).fenced_block_str # hook method blocks can't be test methods
       end
 
+      def parse_type(blk, type)
+        blk.fenced_block_str.lines.first.match?(/^\s*#\s*#{type}\s*\n$/)
+      end
+
       def define_test_method(block, meth_index, stub_chain = nil)
         stub_chain ||= StubChain.new
         instance = self # scope
@@ -73,7 +95,7 @@ module Minitest
       def evaluation_assertions(assertion_hash, bind)
         ruby, assertion, args = TestCodeBlock::ASSERTION_KEYS.map { |key| assertion_hash[key] } # order dep
 
-        lmbda = -> { eval(ruby) } # rubocop:disable Security/Eval
+        lmbda = -> { kernel_eval(ruby) }
         return unless assertion
         return eval_with_block(bind, assertion, lmbda, args) if Assertions::WITH_BLOCK_EVAL.include? assertion
 
@@ -83,20 +105,26 @@ module Minitest
       def eval_with_block(bind, assertion, actual, args)
         return bind.receiver.send(assertion, &actual) if args.empty?
 
-        bind.receiver.send(assertion, *eval(args), &actual) # rubocop:disable Security/Eval
+        bind.receiver.send(assertion, *kernel_eval(args), &actual)
       end
 
       def eval_without_block(bind, assertion, lmbda, args)
         actual = lmbda.call
         return bind.receiver.send(assertion, actual) if args == '[]'
 
-        expected, *rest = eval(args) # rubocop:disable Security/Eval
+        expected, *rest = kernel_eval(args)
         expected, actual = actual, expected if Assertions::EXPECTED_ACTUAL_REVERSED.include? assertion
         kwargs = rest.last.is_a?(Hash) ? rest.last : nil
         return bind.receiver.send(assertion, expected, actual, *rest) unless kwargs
 
         bind.receiver.send(assertion, expected, actual, *rest, **kwargs) # assert_respond_to takes a kwarg..
       end
+
+      def kernel_eval(args)
+        eval args # rubocop:disable Security/Eval
+      rescue SyntaxError
+        raise ArgumentError, "Invalid test code, failed to parse #{args}"
+      end
     end
   end
 end

data/lib/minitest/markdown/test_code_block.rb

@@ -3,7 +3,7 @@
 require 'minifyrb' # DEP
 
 require_relative '../assertions_extensions' # for assert_truthy
-require_relative '../markdown/error'
+require_relative '../markdown/errors'
 
 module Minitest
   module Markdown
@@ -16,9 +16,9 @@ module Minitest
 
       ASSERTION_KEYS = %i[ruby assertion test_args].freeze
 
-      MAGIC_COMMENT_DELIMITER = '# => '
-      MAGIC_COMMENT_REGEXP = /^#{MAGIC_COMMENT_DELIMITER}.*$/
-      MAGIC_COMMENT_SCAN_REGEXP = /^#{MAGIC_COMMENT_DELIMITER}(.*)$/ # strips delimiter prefix
+      MAGIC_COMMENT_DELIMITER = '=>'
+      MAGIC_COMMENT_REGEXP = /^\s*#\s*#{MAGIC_COMMENT_DELIMITER}.*$/
+      MAGIC_COMMENT_SCAN_REGEXP = /^\s*#\s*#{MAGIC_COMMENT_DELIMITER}(.*)$/ # strips delimiter prefix
 
       attr_reader :fenced_block_str
 
@@ -41,10 +41,12 @@ module Minitest
       private
 
       def assertions_arr
-        code_strings.zip(magic_comments.map { |s| parse(s) }).map(&:flatten)
+        code_strings.zip(magic_comments.each_with_index.map { |s, i| parse(s, i) }).map(&:flatten)
       end
 
-      def parse(magic_comment_string)
+      def parse(magic_comment_string, idx)
+        raise ArgumentError, "Block#{idx} magic comment missing assertion or value" if magic_comment_string.strip.empty?
+
         assertion = parse_assertion(magic_comment_string)
         return [DEFAULT_ASSERTION, "[#{magic_comment_string}]"] if assertion.nil?
         return [assertion, '[]'] if magic_comment_string.split.size == 1
@@ -57,14 +59,14 @@ module Minitest
       end
 
       def magic_comments
-        @fenced_block_str.scan(MAGIC_COMMENT_SCAN_REGEXP).flatten
+        @fenced_block_str.scan(MAGIC_COMMENT_SCAN_REGEXP).flatten.map(&:strip)
       end
 
       def code_strings
         @fenced_block_str.split(MAGIC_COMMENT_REGEXP).map do |str|
           Minifyrb::Minifier.new(str).minify.strip
         rescue SyntaxError
-          raise Error::MarkdownError, "Syntax error in:\n\n#{str}"
+          raise Error, "Syntax error in:\n\n#{str}"
         end
       end
     end

data/lib/minitest/markdown/version.rb

@@ -2,6 +2,6 @@
 
 module Minitest
   module Markdown
-    VERSION = '0.2.0.pre'
+    VERSION = '0.2.2.pre'
   end
 end

data/lib/minitest/markdown.rb

@@ -4,7 +4,7 @@ require 'minitest/stub_any_instance'
 
 require_relative 'stub_chain'
 require_relative 'markdown/configuration'
-require_relative 'markdown/error'
+require_relative 'markdown/errors'
 require_relative 'markdown/version'
 require_relative 'markdown/test_class'
 

data/lib/minitest/stub_chain.rb

@@ -20,8 +20,7 @@ module Minitest
 
     def call(test_code_proc)
       validate(test_code_proc)
-      stubs << test_code_proc
-      call_recursive
+      call_recursive [*stubs, test_code_proc]
     end
 
     private
@@ -32,10 +31,11 @@ module Minitest
       test_code_proc
     end
 
-    def call_recursive
-      (prok = stubs.shift).call # "undefined method 'call' for nil" if proc calls a block - i.e. stubs
-    rescue NoMethodError
-      prok.call { call_recursive }
+    def call_recursive(call_chain)
+      prok = call_chain.shift
+      return prok.call if call_chain.empty?
+
+      prok.call { call_recursive(call_chain) }
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-markdown
 version: !ruby/object:Gem::Version
-  version: 0.2.0.pre
+  version: 0.2.2.pre
 platform: ruby
 authors:
 - MatzFan
@@ -77,7 +77,7 @@ files:
 - lib/minitest/assertions_extensions.rb
 - lib/minitest/markdown.rb
 - lib/minitest/markdown/configuration.rb
-- lib/minitest/markdown/error.rb
+- lib/minitest/markdown/errors.rb
 - lib/minitest/markdown/test_class.rb
 - lib/minitest/markdown/test_code_block.rb
 - lib/minitest/markdown/version.rb