minitest-junit 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 518beb2f7cb77d8e953d77f9b4342c5ec1d20603b8807782f71305b58a0f985d
-  data.tar.gz: d3dec1da3aa864c7e92a80628353e24c75a465df90d7e60fddb134a1dc725d89
+  metadata.gz: e77d4317b3cfdd887b3a79497498e5117a9e7ce1c38670c5b045b34eb2926c54
+  data.tar.gz: decabac10b6b204e9518444c7bb4cc363746e33df37749335f8da88aaa59c0a4
 SHA512:
-  metadata.gz: 1c2bc15ede221fc4128d62be93abd9dc6eb6137dd409faf763507c938b9d4bfdb4dd79af78d7de3f195ce1758dc72d5b6d1096c9b28893062c54db90c1a179bc
-  data.tar.gz: 32a0b2014027182f2c357b76defd7402fbc4996d994c5e8f3189844c66d634c16cfd26b9e0c524af3328bf347c5bbf608a480d85f927a021de81ce037543b760
+  metadata.gz: 874208f1793f8824d98bf84cb5f72c720780d4c8c7be01d872693e80a97bd469f6e06638fa9cbfe1c44b8276eac7f9d5b7731051488d78a17a5995344ed10c9d
+  data.tar.gz: 87e1ee1a293c2cd58a1e64f2129db7b76d6ff766832ab48901f22031fabf53823ae4c7487e033366737ed56caabbc2fddc2c197ad2153c74c9cafb95169deef8

data/.github/workflows/main.yml

@@ -1,7 +1,9 @@
 name: Main
 on:
   push:
-  workflow_dispatch:
+    branches: [release]
+  pull_request:
+    types: [opened, synchronize]
 
 jobs:
   tests:

data/lib/minitest/junit/version.rb

@@ -1,6 +1,6 @@
 module Minitest
   # :nodoc:
   module Junit
-    VERSION = '2.0.0'
+    VERSION = '2.1.0'
   end
 end

data/lib/minitest/junit.rb

@@ -28,11 +28,12 @@ module Minitest
       end
 
       def report
-        doc = Ox::Document.new(:version => '1.0')
+        doc = Ox::Document.new(version: '1.0', encoding: 'UTF-8')
         instruct = Ox::Instruct.new(:xml)
         instruct[:version] = '1.0'
         instruct[:encoding] = 'UTF-8'
         doc << instruct
+
         testsuite = Ox::Element.new('testsuite')
         testsuite['name'] = @options[:name] || 'minitest'
         testsuite['timestamp'] = @options[:timestamp]
@@ -46,7 +47,10 @@ module Minitest
           testsuite << format(result)
         end
 
-        doc << testsuite
+        testsuites = Ox::Element.new('testsuites')
+        testsuites << testsuite
+
+        doc << testsuites
         @io << Ox.dump(doc)
       end
 
@@ -58,6 +62,7 @@ module Minitest
         testcase['file'] = relative_to_cwd(result.source_location.first)
         testcase['line'] = result.source_location.last
         testcase['assertions'] = result.assertions
+
         if result.skipped?
           skipped = Ox::Element.new('skipped')
           skipped['message'] = result
@@ -72,6 +77,16 @@ module Minitest
           end
         end
 
+        # Minitest 5.19 supports metadata
+        # Rails 7.1 adds `failure_screenshot_path` to metadata
+        # Output according to Gitlab format
+        # https://docs.gitlab.com/ee/ci/testing/unit_test_reports.html#view-junit-screenshots-on-gitlab
+        if result.respond_to?("metadata") && result.metadata[:failure_screenshot_path]
+          screenshot = Ox::Element.new("system-out")
+          screenshot << "[[ATTACHMENT|#{result.metadata[:failure_screenshot_path]}]]"
+          testcase << screenshot
+        end
+
         testcase
       end
 
@@ -89,10 +104,6 @@ module Minitest
         @working_directory ||= Dir.getwd
       end
 
-      def failure_message(result)
-        "#{result.klass}##{result.name}: #{result.failure}"
-      end
-
       def relative_to_cwd(path)
         path.sub(working_directory, '.')
       end

data/test/reporter_test.rb

@@ -14,11 +14,23 @@ class ReporterTest < Minitest::Test
     reporter.report
 
     assert_match(
-      %r{<?xml version="1.0" encoding="UTF-8"\?>\n<testsuite name="minitest" timestamp="[^"]+" hostname="[^"]+" tests="0" skipped="0" failures="0" errors="0" time="0.000000"\/>},
+      %r{<?xml version="1.0" encoding="UTF-8"\?>\n<testsuites>\n  <testsuite name="minitest" timestamp="[^"]+" hostname="[^"]+" tests="0" skipped="0" failures="0" errors="0" time="0.000000"\/>\n<\/testsuites>\n},
       reporter.output
     )
   end
 
+  # NOTE: This test will generate a temp file: "test/tmp/report.xml"
+  def test_encoding
+    # Enforce File.external_encoding to UTF-8 to ensure that ASCII character will be correctly converted to UTF-8
+    file = File.new('test/tmp/report.xml', 'w:UTF-8')
+    reporter = Minitest::Junit::Reporter.new file, { hostname: '‹foo›' }
+    reporter.start
+    reporter.report
+    file.close
+
+    assert_match(/hostname="‹foo›"/, File.new('test/tmp/report.xml', 'r:UTF-8').read)
+  end
+
   def test_formats_each_successful_result_with_a_formatter
     reporter = create_reporter
 
@@ -37,8 +49,9 @@ class ReporterTest < Minitest::Test
     results.each do |result|
       parsed_report.xpath("//testcase[@name='#{result.name}']").any?
     end
-    # Check if some testcase has a failure
+    # Check if some testcase has a failure and screenshot path
     assert parsed_report.xpath("//testcase//failure").any?
+    assert parsed_report.xpath("//testcase//system-out").any?
   end
 
   def test_xml_nodes_has_file_and_line_attributes
@@ -81,6 +94,11 @@ class ReporterTest < Minitest::Test
         end
       end.new
     end
+
+    if failures.positive?
+      test.metadata[:failure_screenshot_path] = '/tmp/screenshot.png'
+    end
+
     Minitest::Result.from test
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-junit
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Allan Espinosa
@@ -135,6 +135,7 @@ files:
 - test/junit_plugin_test.rb
 - test/reporter_test.rb
 - test/testcase_formatter_test.rb
+- test/tmp/.keep
 homepage: http://github.com/aespinosa/minitest-junit
 licenses:
 - MIT
@@ -163,3 +164,4 @@ test_files:
 - test/junit_plugin_test.rb
 - test/reporter_test.rb
 - test/testcase_formatter_test.rb
+- test/tmp/.keep