minitest-junit 0.1.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2b91b566809b95993d90be26881a2b7301965f4b
-  data.tar.gz: d3dbd54d0b1811587bfa6f8298a64e933a429e18
+SHA256:
+  metadata.gz: 0fa66307fd2fdfd6109450defbb4413afdf292d773222c93a04622680ebb6c37
+  data.tar.gz: 103ddd1223b0d692972416eb0551e072f06734658069906a986f9d0c1975a16f
 SHA512:
-  metadata.gz: 788bc66cc5ce34ae8fa1944e59299d38d072039dae2ef36ea8938e5eb4bdbf8364a861c6c5ed252add21f23598fd3fb1207022fdcdfa892b4876226629886c98
-  data.tar.gz: 26ebf4dbd2d4dfcdbcf0bee8f63dd5aff2fab5d20bea5468b6e6e5fdb2b6e130206993cb8fc739b147652b5ee6ef318733dfd9127da82bd442f653cf3d32d921
+  metadata.gz: 4c4dabfdcf0a30f2dc9d858962444d88fa445983404189b3fce805374f23d64c2c3ed43e044f5275bb68446ffe7b72365fc9e2d8bb82fcab58d9320103204a24
+  data.tar.gz: 5777cfd69357a6855de6e5609d8e1c5cc6a227ae670fe4abaef56ce28d10e9b579e1aeef0022cc5dc00731cd5bb31829b22f6c8a14b232cbf25df43eb15d3122

data/README.md

@@ -24,6 +24,7 @@ Or install it yourself as:
     Known extensions: junit, ...
             --junit                      Generate a junit xml report
             --junit-filename=OUT         Target output filename. Defaults to report.xml
+            --junit-jenkins              Sanitize test names for Jenkins display
     ...
 
 ## Contributing

data/Rakefile

@@ -6,4 +6,5 @@ RuboCop::RakeTask.new
 
 Rake::TestTask.new do |t|
   t.test_files = FileList['test/*_test.rb']
+  t.options = '--junit --junit-jenkins' if ENV['CI']
 end

data/lib/minitest/junit/version.rb

@@ -1,6 +1,6 @@
 module Minitest
   # :nodoc:
   module Junit
-    VERSION = '0.1.0'
+    VERSION = '0.4.0'
   end
 end

data/lib/minitest/junit.rb

@@ -7,9 +7,10 @@ module Minitest
   module Junit
     # :nodoc:
     class Reporter
-      def initialize(io)
+      def initialize(io, options)
         @io = io
         @results = []
+        @options = options
       end
 
       def passed?
@@ -32,10 +33,13 @@ module Minitest
         xml = Builder::XmlMarkup.new
         xml.testcase classname: format_class(result), name: format_name(result),
                      time: result.time, assertions: result.assertions do |t|
-          t.skipped if result.skipped?
-          result.failures.each do |failure|
-            type = classify failure
-            xml.tag! type, format_backtrace(failure), message: result
+          if result.skipped?
+            t.skipped message: result
+          else
+            result.failures.each do |failure|
+              type = classify failure
+              xml.tag! type, format_backtrace(failure), message: result
+            end
           end
         end
         xml.target!
@@ -56,12 +60,14 @@ module Minitest
       end
 
       def format_class(result)
-        result.class.to_s.gsub(/(.*)::(.*)/, '\1.\2')
-        result.class
+        if @options[:junit_jenkins]
+          result.class.to_s.gsub(/(.*)::(.*)/, '\1.\2')
+        else
+          result.class
+        end
       end
 
       def format_name(result)
-        result.name.sub(/^test_/, '').gsub('_', ' ')
         result.name
       end
     end

data/lib/minitest/junit_plugin.rb

@@ -10,12 +10,15 @@ module Minitest
                                     ' Defaults to report.xml' do |out|
       options[:junit_filename] = out
     end
+    opts.on '--junit-jenkins', 'Sanitize test names for Jenkins display' do
+      options[:junit_jenkins] = true
+    end
   end
 
   def self.plugin_junit_init(options)
-    return unless options[:junit]
-    file_klass = options[:file_klass] || File
-    io = file_klass.new options[:junit_filename] || 'report.xml', 'w'
-    reporter << Junit::Reporter.new(io) if options[:junit]
+    return unless options.delete :junit
+    file_klass = options.delete(:file_klass) || File
+    io = file_klass.new options.delete(:junit_filename) || 'report.xml', 'w'
+    reporter << Junit::Reporter.new(io, options)
   end
 end

data/minitest-junit.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(/^(test)\//)
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'minitest', '~> 5.0'
+  spec.add_dependency 'minitest', '~> 5.0', '< 5.11'
   spec.add_dependency 'builder', '~> 3.2'
 
-  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.3.2'
   spec.add_development_dependency 'rubocop', '~> 0.24.1'
 end

data/test/junit_plugin_test.rb

@@ -72,4 +72,12 @@ class PluginTest < Minitest::Test
 
     assert_equal 'somefile.xml', options[:junit_filename]
   end
+
+  def test_jenkins_sanitization_is_specified_by_a_flag
+    opts = OptionParser.new
+    options = {}
+    Minitest.plugin_junit_options opts, options
+    opts.parse('--junit-jenkins')
+    assert options[:junit_jenkins]
+  end
 end

data/test/reporter_test.rb

@@ -31,7 +31,7 @@ class ReporterTest < Minitest::Test
 
   def create_reporter
     io = StringIO.new
-    reporter = Minitest::Junit::Reporter.new io
+    reporter = Minitest::Junit::Reporter.new io, {}
     def reporter.output
       @io.string
     end

data/test/testcase_formatter_test.rb

@@ -20,7 +20,7 @@ class TestCaseFormatter < Minitest::Test
 
     reporter.report
 
-    assert_match(/<skipped\/>/, reporter.output)
+    assert_match(/<skipped message="[^<>]+"\/><\/testcase>\n<\/testsuite>\n/, reporter.output)
   end
 
   def test_failing_tests_creates_failure_tag
@@ -45,6 +45,16 @@ class TestCaseFormatter < Minitest::Test
     assert_match(/<error/, reporter.output)
   end
 
+  def test_jenkins_sanitizer_uses_modules_as_packages
+    test = create_test_result 'FirstModule::SecondModule::TestClass'
+    reporter = create_reporter junit_jenkins: true
+    reporter.record test
+
+    reporter.report
+
+    assert_match 'FirstModule::SecondModule.TestClass', reporter.output
+  end
+
   private
 
   def create_error(klass)
@@ -53,11 +63,12 @@ class TestCaseFormatter < Minitest::Test
     e
   end
 
-  def create_test_result
-    test = Minitest::Test.new 'passing test'
-    def test.class
-      'ATestClass'
-    end
+  def create_test_result(name = 'ATestClass')
+    test = Class.new Minitest::Test do
+      define_method 'class' do
+        name
+      end
+    end.new 'test_method_name'
     test.time = a_number
     test.assertions = a_number
     test
@@ -67,9 +78,9 @@ class TestCaseFormatter < Minitest::Test
     rand(100)
   end
 
-  def create_reporter
+  def create_reporter(options = {})
     io = StringIO.new ''
-    reporter = Minitest::Junit::Reporter.new io
+    reporter = Minitest::Junit::Reporter.new io, options
     def reporter.output
       @io.string
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-junit
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Allan Espinosa
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-10-11 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -17,6 +17,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,6 +27,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.11'
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -42,16 +48,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -104,7 +110,7 @@ homepage: http://github.com/aespinosa/minitest-junit
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -119,9 +125,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.1
-signing_key: 
+rubygems_version: 3.2.26
+signing_key:
 specification_version: 4
 summary: Junit reporter for Minitest ~> 5.0
 test_files: