minitest-heat 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc3d70999fca25317d7ff7a96b67cd2c6ee6f59970054b0eaec88c051581b855
-  data.tar.gz: 1197c05fe06b12737b2c73c27d7266e986fcae22cd3957b3e64cd14e2e70295f
+  metadata.gz: dbfeed7b313b60332751ad13c01750b56452e6cac80f98346d4f7233ae807cef
+  data.tar.gz: 7a734d467343b7da882c8a5f62e1005664ea9b2ab889d766416d8f21fce2299b
 SHA512:
-  metadata.gz: 207f670e0e27dedb872c8251e3890043955c60b6dd6e7dbafce1ba11fd9de5dde20ecf902ac0afd7fa5338d846afa9bc0c2f498df1ca5cdf83b964865792075f
-  data.tar.gz: c7d3219eb7c7d357a6bdeb82695356f2b56f1bc0f617ed9a9719c3c8227ca9b9bbf0c4929c14d75eed60ce6eade8552f693ad689d6b71c057fc08015a3d38828
+  metadata.gz: '07468b2090eef7a6475382db46e9bc150d2fc30e54d54d6744c0c12d6c33364f6d39aff6938baf4647c0e64fe7c754d0c1ad8b42aebf7b87e8edce8a1c35542f'
+  data.tar.gz: f1f961dc9bcf258d09fec7184dc0cb778d5b9fbc865ad2ed2c9d2f68628c4329990febc45b41770582826ab26576236c41657ced44c0ddb494b1b7fb71403c38

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    minitest-heat (0.0.3)
+    minitest-heat (0.0.4)
       minitest
 
 GEM

data/lib/minitest/heat/issue.rb

@@ -8,7 +8,20 @@ module Minitest
     class Issue
       extend Forwardable
 
-      SLOW_THRESHOLD = 0.5
+      SLOW_THRESHOLDS = {
+        slow: 1.0,
+        painful: 3.0
+      }
+
+      MARKERS = {
+        success:  '·',
+        slow:     '–',
+        painful:  '—',
+        broken:   'B',
+        error:    'E',
+        skipped:  'S',
+        failure:  'F',
+      }
 
       SHARED_SYMBOLS = {
         spacer: ' · ',
@@ -52,6 +65,8 @@ module Minitest
           :skipped
         elsif !passed?
           :failure
+        elsif painful?
+          :painful
         elsif slow?
           :slow
         else
@@ -59,8 +74,16 @@ module Minitest
         end
       end
 
+      def hit?
+        !passed? || slow?
+      end
+
       def slow?
-        time > SLOW_THRESHOLD
+        time >= SLOW_THRESHOLDS[:slow]
+      end
+
+      def painful?
+        time >= SLOW_THRESHOLDS[:painful]
       end
 
       def in_test?
@@ -111,14 +134,7 @@ module Minitest
       end
 
       def marker
-        case type
-        when :broken then  'B'
-        when :error then   'E'
-        when :skipped then 'S'
-        when :failure then 'F'
-        when :slow then    '_'
-        else               '.'
-        end
+        MARKERS.fetch(type.to_sym)
       end
 
       def summary

data/lib/minitest/heat/location.rb

@@ -37,7 +37,7 @@ module Minitest
       def source_file
         return test_file if backtrace.empty?
 
-        source_line = backtrace.final_project_location
+        source_line = backtrace.final_project_location || backtrace.final_location
 
         reduced_path("#{source_line.path}/#{source_line.file}")
       end

data/lib/minitest/heat/map.rb

@@ -13,11 +13,12 @@ module Minitest
       #   test is broken (i.e. raising an exception), that's a special sort of failure that would be
       #   misleading. It doesn't represent a proper failure, but rather a test that doesn't work.
       WEIGHTS = {
-        error: 3,   # exceptions from source code have the highest liklihood of a ripple effect
-        broken: 1,  # broken tests won't have ripple effects but can't help if they can't run
-        failure: 1, # failures are kind of the whole point, and they could have ripple effects
-        skipped: 0, # skips aren't failures, but they shouldn't go ignored
-        slow: 0     # slow tests aren't failures, but they shouldn't be ignored
+        error: 3,    # exceptions from source code have the highest liklihood of a ripple effect
+        broken: 1,   # broken tests won't have ripple effects but can't help if they can't run
+        failure: 1,  # failures are kind of the whole point, and they could have ripple effects
+        skipped: 0,  # skips aren't failures, but they shouldn't go ignored
+        painful: 0,  # slow tests aren't failures, but they shouldn't be ignored
+        slow: 0,
       }
 
       def initialize
@@ -46,7 +47,7 @@ module Minitest
         files = {}
         @hits.each_pair do |filename, details|
           # Can't really be a "hot spot" with just a single issue
-          next unless details[:total] > 1
+          next unless details[:weight] > 1
 
           files[filename] = details[:weight]
         end

data/lib/minitest/heat/output.rb

@@ -58,13 +58,12 @@ module Minitest
 
         def style_components
           {
-            success_bold: %i[bold green],
             success: %i[default green],
-            slow: %i[default green],
+            slow: %i[bold green],
             error: %i[bold red],
             broken: %i[bold red],
             failure: %i[default red],
-            skipped: %i[bold yellow],
+            skipped: %i[default yellow],
             warning_light: %i[light yellow],
             source: %i[italic default],
             bold: %i[bold default],
@@ -127,7 +126,6 @@ module Minitest
         when 'B' then text(:failure, value)
         when 'F' then text(:failure, value)
         when 'S' then text(:skipped, value)
-        when '_' then text(:success, value)
         else          text(:success, value)
         end
       end
@@ -165,7 +163,7 @@ module Minitest
           text(:broken, 'B' * values[:broken].size) if values[:broken]&.any?
           text(:failure, 'F' * values[:failure].size) if values[:failure]&.any?
           text(:skipped, 'S' * values[:skipped].size) if values[:skipped]&.any?
-          text(:muted, ' ')
+          text(:muted, ' ') if values[:error]&.any? || values[:broken]&.any? || values[:failure]&.any? || values[:skipped]&.any?
 
           text(:muted, "#{path.delete_prefix('/')}")
           text(:default, "#{filename}")

data/lib/minitest/heat/results.rb

@@ -49,8 +49,8 @@ module Minitest
         (assertion_count / total_time).round(2)
       end
 
-      def issues?
-        errors? || failures? || skips?
+      def problems?
+        errors? || brokens? || failures? || skips?
       end
 
       def errors
@@ -93,19 +93,13 @@ module Minitest
         skips.any?
       end
 
-      def count(result)
+      def record(issue)
         @test_count += 1
-        @assertion_count += result.assertions
-        @success_count += 1 if result.passed?
-      end
-
-      def record_issue(result)
-        issue = Heat::Issue.new(result)
+        @assertion_count += issue.result.assertions
+        @success_count += 1 if issue.result.passed?
 
         @issues[issue.type] ||= []
         @issues[issue.type] << issue
-
-        issue
       end
     end
   end

data/lib/minitest/heat/version.rb

@@ -1,5 +1,5 @@
 module Minitest
   module Heat
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/lib/minitest/heat_reporter.rb

@@ -59,14 +59,13 @@ module Minitest
     # Minitest::Result source:
     #   https://github.com/seattlerb/minitest/blob/f4f57afaeb3a11bd0b86ab0757704cb78db96cf4/lib/minitest.rb#L504
     def record(result)
-      @results.count(result)
-      if !result.passed? || result.time > ::Minitest::Heat::Issue::SLOW_THRESHOLD
-        issue = @results.record_issue(result)
-        @map.add(*issue.to_hit)
-        output.marker(issue.marker)
-      else
-        output.marker(result.result_code)
-      end
+      issue = Heat::Issue.new(result)
+
+      @results.record(issue)
+
+      @map.add(*issue.to_hit) if issue.hit?
+
+      output.marker(issue.marker)
     end
 
     # Outputs the summary of the run.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-heat
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Garrett Dimon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-30 00:00:00.000000000 Z
+date: 2021-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest