minitest-given 3.7.1 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39a78e633e738fbce67c2563b5fae535ec81b4f7
-  data.tar.gz: 5b0485aae6e42d5df7e6d3f6306d8f5c3e93700c
+  metadata.gz: da6a81f5ad6dbf98e0063bcc1b606d9f5dbef825
+  data.tar.gz: eaa3e62e9daeb482980727f759d30689e7cc8813
 SHA512:
-  metadata.gz: 45d5123c6470195a71154f48dc8226f2f655e69add11c20a5d775d64471c1a268ab619afa632d0e17eef7cdd4841bbd940cab71227c76e373be75f54e7a04fd8
-  data.tar.gz: 569c233f21a5c3a195963f79e95839fad5e8ae98e298770ace4212c188b85dd8b4a70ad22c4dd1f569243b6dd79b59f991bea0cfd7ac49c9cf7cdf981905c38e
+  metadata.gz: 39b64acd32322b994f459ef26782d848f77ab69a6fa3e52327f6de90252ceb29a55c1c1868d0d24e5d5a17ffe84a889eb8c27bf4f5fd082c32085239a65eeefb
+  data.tar.gz: 758d980afe8784dac520508a0266a26710d01ac26276a0c72585582643cf18983e9c18c37417e41a06108d2b94e00a77010ad673a1c7642782857fe1eb02265f

data/Gemfile.lock

@@ -2,21 +2,21 @@ GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.2.5)
-    minitest (5.7.0)
-    rake (10.4.2)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.1)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.0)
+    minitest (5.8.3)
+    rake (10.5.0)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.1)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.1)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
     sorcerer (1.0.2)
 
 PLATFORMS

data/README.md

@@ -4,7 +4,7 @@
 | :----: |
 | [![Master Build Status](https://secure.travis-ci.org/rspec-given/rspec-given.png?branch=master)](https://travis-ci.org/rspec-given/rspec-given) |
 
-Covering rspec-given, minitest-given, and given-core, version 3.7.0.
+Covering rspec-given, minitest-given, and given-core, version 3.8.0.
 
 rspec-given and minitest-given are extensions to your favorite testing
 framework to allow Given/When/Then notation when writing specs.
@@ -347,6 +347,17 @@ should use an empty _Then_ clause, like this:
     Then { }
 ```
 
+A _Then_ clause accepts arguments for user-defined RSpec metadata:
+
+```ruby
+    Then(:zippy, :foo => 17) { ... }
+```
+
+Metadata on _Then_ clauses is an RSpec-only feature. You can read more about
+metadata [in RSpec's
+documentation](https://www.relishapp.com/rspec/rspec-core/docs/metadata/user-defined-metadata).
+
+
 #### Then examples:
 
 ```ruby
@@ -760,12 +771,13 @@ _expect_.
 
 Given uses the Ripper library to parse the source lines and failing
 conditions to find all the sub-expression values upon a failure.
-Currently Ripper is not supported on Rubinius and versions of JRuby
-prior to JRuby-1.7.5.
 
-If you want to use a version of Ruby that does not support Ripper,
-then natural assertions will disabled. In addition, you should also
-disable source caching in the configuration (see the configuration
+If Ripper is not available, like on Rubinius and versions of JRuby prior to
+JRuby-1.7.5, detailed explanations of failures for natural assertions won't be
+available.  Natural assertions will still work, though.
+
+If you want to use a version of Ruby that does not support Ripper, then you
+should disable source caching in the configuration (see the configuration
 section below).
 
 ### Non-Spec Assertions
@@ -870,6 +882,14 @@ License. See the MIT-LICENSE file in the source distribution.
 
 # History
 
+* Version 3.8.0
+
+  * RSpec metadata can now be added to _Then_ clauses (see [#11](https://github.com/rspec-given/rspec-given/pull/11))
+  * Natural assertions now run on Rubinius and older versions of JRuby (see [#15](https://github.com/rspec-given/rspec-given/issues/15))
+    * WARNING: On these platforms, detailed failure explanations aren't available and source code snippets of Then clauses will only show the first line.
+    * WARNING: Assertions of void statements (e.g. `Then { }`) will fail only under runtimes lacking Ripper support
+  * `Given.ok_to_use_natural_assertions` was removed; the method was never properly supported as public, but it was publicly reachable
+
 * Version 3.7.1
 
   * Mixin Minitest extensions for both ActiveSupport::TestCase (when present) as well as for MiniTest::Spec (see [#8](https://github.com/rspec-given/rspec-given/pulls/8))

data/Rakefile

@@ -67,10 +67,6 @@ EXAMPLES = FileList['examples/**/*_spec.rb', 'examples/use_assertions.rb'].
 
 MT_EXAMPLES = FileList['examples/minitest-rails/**/*_spec.rb', 'examples/minitest/**/*_spec.rb']
 
-unless Given::NATURAL_ASSERTIONS_SUPPORTED
-  EXAMPLES.exclude("examples/stack/*.rb")
-end
-
 FAILING_EXAMPLES = FileList['examples/failing/**/*_spec.rb']
 
 desc "Run the RSpec specs and examples"

data/examples/integration/failing_messages_spec.rb

@@ -2,24 +2,28 @@ require 'example_helper'
 require 'open3'
 
 describe "Failing Messages" do
-  use_natural_assertions_if_supported
-
   IOS = Struct.new(:out, :err)
 
   def run_spec(filename)
-    inn, out, err, wait = Open3.popen3("rspec", "examples/integration/failing/#{filename}")
+    _inn, out, err, _wait = Open3.popen3(
+      "rspec", "examples/integration/failing/#{filename}",
+      # Ensure our `project_source_dirs` config is set when we shell out to RSpec.
+      "-rexample_helper"
+    )
     IOS.new(out.read, err.read)
   end
 
   When(:ios) { run_spec(failing_test) }
 
   context "when referencing constants from nested modules" do
+    skip_natural_assertions_if_not_supported
     Given(:failing_test) { "module_nesting_spec.rb" }
     Then { ios.err == "" }
     And { ios.out !~ /uninitialized constant RSpec::Given::InstanceExtensions::X/ }
   end
 
   context "when referencing undefined methods" do
+    skip_natural_assertions_if_not_supported
     Given(:failing_test) { "undefined_method_spec.rb" }
     Then { ios.err == "" }
     And { complains_xyz_is_not_in_scope?(ios.out) }
@@ -35,6 +39,7 @@ describe "Failing Messages" do
   end
 
   context "when breaking down expressions" do
+    skip_natural_assertions_if_not_supported
     Given(:failing_test) { "eval_subexpression_spec.rb" }
     Then { ios.err == "" }
     And  { ios.out =~ /false *<- array\[index\]\.upcase == value$/ }
@@ -51,8 +56,9 @@ describe "Failing Messages" do
   end
 
   context "with an oddly formatted then" do
+    skip_natural_assertions_if_not_supported
     Given(:failing_test) { "oddly_formatted_then.rb" }
-    Then { ios.out =~ /Failure\/Error: Then \{ result == \['a',$/ }
+    Then { ios.out =~ /Failure\/Error:\s*Then \{ result == \['a',$/ }
     And  { ios.out =~ /expected: "anything"/ }
     And  { ios.out =~ /to equal: \["a", "a"\]/ }
   end

data/examples/integration/then_spec.rb

@@ -11,11 +11,10 @@ end
 
 describe "Then" do
   context "empty thens with natural assertions" do
-    use_natural_assertions_if_supported
+    skip_natural_assertions_if_not_supported #<--we can't detect void statements
     Then { }
   end
   context "thens to_bool/true will pass" do
-    use_natural_assertions_if_supported
     Then { ToBool.new(true) }
   end
 end

data/examples/minitest_helper.rb

@@ -1,4 +1,3 @@
-
 module GivenAssertions
   def given_assert(cond)
     assert cond
@@ -23,13 +22,9 @@ module GivenAssertions
 end
 
 module NaturalAssertionControl
-  def use_natural_assertions_if_supported(enabled=true)
-    if enabled && ! Given::NATURAL_ASSERTIONS_SUPPORTED
-      Given {
-        skip "Natural assertions are not supported in JRuby"
-      }
-    else
-      use_natural_assertions(enabled)
+  def skip_natural_assertions_if_not_supported
+    if !Given::NATURAL_ASSERTIONS_SUPPORTED
+      Given { skip "This test requires a Ruby runtime with full natural assertions support." }
     end
   end
 end

data/examples/use_assertions.rb

@@ -1,47 +1,44 @@
 require 'given/module_methods'
 
-if Given::NATURAL_ASSERTIONS_SUPPORTED
+require 'given/assertions'
+require 'given/fuzzy_number'
 
-  require 'given/assertions'
-  require 'given/fuzzy_number'
+include Given::Assertions
+include Given::Fuzzy
 
-  include Given::Assertions
-  include Given::Fuzzy
-
-  def sqrt(n)
-    Precondition { n >= 0 }
-    result = Math.sqrt(n)
-    Postcondition { result ** 2 == about(n) }
-    result
-  end
+def sqrt(n)
+  Precondition { n >= 0 }
+  result = Math.sqrt(n)
+  Postcondition { result ** 2 == about(n) }
+  result
+end
 
-  def sqrt_bad_postcondition(n)
-    Precondition { n >= 0 }
-    result = Math.sqrt(n)
-    Postcondition { result ** 2 == about(n+1) }
-    result
-  end
+def sqrt_bad_postcondition(n)
+  Precondition { n >= 0 }
+  result = Math.sqrt(n)
+  Postcondition { result ** 2 == about(n+1) }
+  result
+end
 
-  def use_assert(n)
-    Assert { n == 1 }
-  end
+def use_assert(n)
+  Assert { n == 1 }
+end
 
-  def should_fail
-    begin
-      yield
-      fail "Expected error"
-    rescue Given::Assertions::AssertError => ex
-      true
-    end
+def should_fail
+  begin
+    yield
+    fail "Expected error"
+  rescue Given::Assertions::AssertError => ex
+    true
   end
+end
 
-  sqrt(1)
-  sqrt(2)
-  sqrt(0)
+sqrt(1)
+sqrt(2)
+sqrt(0)
 
-  should_fail { sqrt(-1) }
-  should_fail { sqrt_bad_postcondition(1) }
+should_fail { sqrt(-1) }
+should_fail { sqrt_bad_postcondition(1) }
 
-  use_assert(1)
-  should_fail { use_assert(0) }
-end
+use_assert(1)
+should_fail { use_assert(0) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-given
 version: !ruby/object:Gem::Version
-  version: 3.7.1
+  version: 3.8.0
 platform: ruby
 authors:
 - Jim Weirich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-08 00:00:00.000000000 Z
+date: 2016-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: given_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 3.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 3.8.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -111,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: given
-rubygems_version: 2.2.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Given/When/Then Specification Extensions for Minitest::Spec.