minitest-fork_executor 1.0.0 → 1.0.1

data/lib/minitest/fork_executor.rb

@@ -1,23 +1,25 @@
 module Minitest
   class ForkExecutor
+    # Minitest runs individual test cases via Minitest.run_one_method. When
+    # ForkExecutor is started, we need to override it and implement the fork
+    # algorithm. See the detailed comments below to understand how it's done.
+    #
+    # Please keep in mind we support Ruby 1.9 and hence can't use conveniences
+    # offered by more modern Rubies.
     def start
-      # Minitest runs test cases via Minitest.run_one_method. Each test case
-      # in a test class is run separately. We need to override that method and
-      # fork there. run_one_method is a method on the Minitest module so we need
-      # to *prepend* our version so that it's called first.
-      metaclass = (class << Minitest; self; end)
-      metaclass.prepend ClassMethods
-    end
+      # Store the reference to the original run_one_method singleton method.
+      original_run_one_method = Minitest.method(:run_one_method)
 
-    def shutdown
-      # Nothing to do here but required by Minitest.
-    end
+      # Remove the original singleton method from Minitest in order to avoid
+      # method redefinition warnings when patching it in the next step.
+      class << Minitest
+        remove_method(:run_one_method)
+      end
 
-    module ClassMethods
-      # The updated version of Minitest.run_one_method that forks before
-      # actually running a test case, makes the child run it and send the result
-      # to the parent process.
-      def run_one_method klass, method_name
+      # Define a new version of run_one_method that forks, calls the original
+      # run_one_method in the child process, and sends results back to the
+      # parent.
+      Minitest.define_singleton_method(:run_one_method) do |klass, method_name|
         read_io, write_io = IO.pipe
         read_io.binmode
         write_io.binmode
@@ -33,7 +35,7 @@ module Minitest
         else
           # Child: just run normally, dump the result, and exit the process to
           # avoid double-reporting.
-          result = super
+          result = original_run_one_method.call(klass, method_name)
 
           read_io.close
           Marshal.dump(result, write_io)
@@ -44,5 +46,10 @@ module Minitest
         result
       end
     end
+
+    def shutdown
+      # Nothing to do here but required by Minitest. In a future version, we may
+      # reinstate the original Minitest.run_one_method here.
+    end
   end
 end

data/test/minitest/fork_executor_test.rb

@@ -15,7 +15,7 @@ Minitest.parallel_executor = Minitest::ForkExecutor.new
 # 2. These processes are different from the parent process that spawned the
 #    test suite - hence recording @@parent_pid at the top.
 class ForkTest < Minitest::Test
-  @@log = Tempfile.new
+  @@log = Tempfile.new('pid')
   @@parent_pid = Process.pid
 
   def test_run_in_process_one

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: minitest-fork_executor
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
+  prerelease: 
 platform: ruby
 authors:
 - Greg Navis
@@ -13,31 +14,35 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.2.1
 description: Run each test_* method in a separate process thus eliminating test case
   interference.
 email: contact@gregnavis.com
@@ -50,25 +55,33 @@ files:
 homepage: https://github.com/gregnavis/minitest-fork_executor
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1027518140381874469
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1027518140381874469
 requirements: []
-rubygems_version: 3.0.1
+rubyforge_project: 
+rubygems_version: 1.8.23.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Near-perfect process-level test case isolation.
 test_files:
 - test/minitest/fork_executor_test.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA256:
-  metadata.gz: b399f50e3a52b2505c2125113c05ab712b1db59d26f00dd1075d7be2346c979b
-  data.tar.gz: a3394aab364af126482879b30badfd400ab2168185b1e746305555c42ef84ff2
-SHA512:
-  metadata.gz: b6014495cb3f12a88165cb983533be9a9b2f4e3188cbb67fa2e355577de3af285fc0ea6bf575e82e194d2526bedfa25ef979482be9377d96e1ca67082994a211
-  data.tar.gz: d887d4b98c08f8c7ba5e5c41687b88875ea431c9dd4ea0fbf5cb546947a524c6326ea5212519c98dcf3c91bceb417cc8feaeb04c1ef6e00cf6face124e8fef62