minitest-ci 3.0.2 → 3.0.3

data/History.txt

@@ -1,3 +1,10 @@
+=== 3.0.3 / 2013-10-08
+
+* 1 unknown:
+
+  * Escape suite and testcase name. (statianzo) #12
+
+
 === 3.0.2 / 2013-08-19
 
 * 4 unknowns:

data/lib/minitest/ci.rb

@@ -4,7 +4,7 @@ require 'cgi'
 module Minitest
   class Ci
 
-    VERSION = '3.0.2'
+    VERSION = '3.0.3'
 
     class << self
 
@@ -85,11 +85,11 @@ module Minitest
 
       xml << '<?xml version="1.0" encoding="UTF-8"?>'
       xml << "<testsuite time='%6f' skipped='%d' failures='%d' errors='%d' name=%p assertions='%d' tests='%d'>" %
-        [total_time, skips, failures, errors, name.to_s, assertions, results.count]
+        [total_time, skips, failures, errors, escape(name), assertions, results.count]
 
       results.each do |result|
         xml << "  <testcase time='%6f' name=%p assertions='%s'>" %
-          [result.time, result.name, result.assertions]
+          [result.time, escape(result.name), result.assertions]
         if failure = result.failure
           label = failure.result_label.downcase
 

data/test/minitest/test_ci.rb

@@ -35,12 +35,18 @@ class MockTestSuite < Minitest::Test
   end
 end
 
-SpecWithPunctuation = describe "spec/with::'punctuation'" do
+describe "spec/with::'punctuation'" do
  it "passes" do
    pass
  end
 end
 
+describe "spec/with::\"doublequotes\"" do
+ it 'will "pass"' do
+   pass
+ end
+end
+
 # better way?
 $ci_io = StringIO.new
 Minitest::Ci.clean = false
@@ -138,9 +144,19 @@ class TestMinitest::TestCi < Minitest::Test
     refute_match( /lib\/minitest/, error.inner_text )
   end
 
-  def test_suitename
+  def test_suitename_with_single_quotes
     file = File.read "test/reports/TEST-spec%2Fwith%3A%3A%27punctuation%27.xml"
     suite = Nokogiri.parse(file).at_xpath('/testsuite')
     assert_equal "spec/with::'punctuation'", suite['name']
   end
+
+  def test_suitename_with_double_quotes
+    file = File.read "test/reports/TEST-spec%2Fwith%3A%3A%22doublequotes%22.xml"
+    doc = Nokogiri.parse(file)
+    suite = doc.at_xpath('/testsuite')
+    testcase = doc.at_xpath('/testsuite/testcase')
+
+    assert_equal 'spec/with::"doublequotes"', suite['name']
+    assert_equal 'test_0001_will "pass"', testcase['name']
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-ci
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-19 00:00:00.000000000 Z
+date: 2013-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest