minitest-bisect 1.4.1 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cff92ce857a2c5a2a5ec16125c68b77513490096eeb225d88c9a386e01c7970e
-  data.tar.gz: e9683eb9d3f1960aa90f2558aa860eb372cfd1f12053536e651917e7a02fb256
+  metadata.gz: 895bdb11c49734d1219e519a88532a03221bd0b2ae25431cc3e35d552716f841
+  data.tar.gz: 661d13d6f64de3a029fec5b68d7b89a3843e5e628fe9f53191e20981ed5bd806
 SHA512:
-  metadata.gz: 5b4867ee6ac8d70e7fc85d7a1e5982db15d161f8f5deac85d1def14bf0a8ffdfad921924a6d7fe5137ca0445a65908c4d00668456bcfcad6a965cd13e1437459
-  data.tar.gz: a5548ed9cd15fb5174e2e8f8a51998818431603410aa95015357651b6394e9333e71cb41a278ae4f854c992bec7aa3a218a91227b7d6883d6d68d3e78e71615b
+  metadata.gz: a2d962388ce5dafc12591a3e5362d3e0be98b2e46f1bb6ce46a0b7897836ec517c4ad9f4ed07f159311cbfbd792f148fd6e8acfb88b8fec95ac770b47cce0fd5
+  data.tar.gz: 5b896b2f11f3a01e99106abde712ad9784d55e4b974a66d453331acfb09f0e68d2c41973dd643d3827866d5a649d756c2d7388226b5f669164a544ca7b52d74c

data/History.rdoc

@@ -1,3 +1,14 @@
+=== 1.5.0 / 2019-06-06
+
+* 2 minor enhancements:
+
+  * Print out the culprit methods once done.
+  * Default to using -Itest:lib like minitest-sprint.
+
+* 1 bug fix:
+
+  * Remove the server arguments from the final repro output.
+
 === 1.4.1 / 2019-05-26
 
 * 2 bug fixes:

data/README.rdoc

@@ -30,13 +30,37 @@ Let's say you have a bunch of test files and they fail sometimes, but
 not consistently. You get a run that fails, so you record the
 randomization seed that minitest displays at the top of every run.
 
+=== Normally, it passes:
+
+  % minitest example
+  Run options: --seed 42
+
+  # Running:
+
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ..............................................................................
+  ....................
+
+  Finished in 200.341744s, 3.6371 runs/s, 3.4230 assertions/s.
+
+  800 runs, 798 assertions, 0 failures, 0 errors, 0 skips
+
 === Original Failure:
 
-Here's an example run that fails randomly:
+But someone sees the failure either locally or on the CI. They record
+the output and get the randomization seed that causes the test
+ordering bug:
 
-  $ rake
-  ruby -I.:lib -e 'require "example/test_bad1.rb";require "example/test_bad2.rb";require "example/test_bad3.rb";require "example/test_bad4.rb";require "example/test_bad5.rb";require "example/test_bad6.rb";require "example/test_bad7.rb";require "example/test_bad8.rb"'
-  Run options: --seed 3911
+  $ minitest example --seed 314
+  Run options: --seed 314
 
   # Running:
 
@@ -73,58 +97,50 @@ same order and reproduce every time.
 minitest_bisect will first minimize the number of files, then it will
 turn around and minimize the number of methods.
 
-  $ minitest_bisect --seed 3911 example/test*.rb
-  reproducing...
-  reproduced
-  # of culprit files: 4
-  # of culprit files: 2
-  # of culprit files: 2
-  # of culprit files: 2
-  # of culprit files: 2
+  % minitest_bisect example --seed 314
+  reproducing... in 203.83 sec
+  verifying... in 0.37 sec
+  # of culprit methods: 64 in 16.65 sec
+  # of culprit methods: 32 in 8.53 sec
+  # of culprit methods: 32 in 8.52 sec
+  # of culprit methods: 16 in 4.46 sec
+  # of culprit methods: 16 in 4.44 sec
+  # of culprit methods: 8 in 2.41 sec
+  # of culprit methods: 4 in 1.40 sec
+  # of culprit methods: 2 in 0.89 sec
+  # of culprit methods: 2 in 0.89 sec
+  # of culprit methods: 1 in 0.62 sec
+  # of culprit methods: 1 in 0.63 sec
 
-  Minimal files found in 5 steps:
+  Minimal methods found in 11 steps:
 
-  ruby -Ilib -e 'require "./example/test_bad1.rb" ; require "./example/test_bad4.rb"' -- --seed 3911 -s 48222
+  Culprit methods: ["TestBad1#test_bad1_1"]
 
-  reproducing...
-  reproduced
-  # of culprit methods: 64
-  # of culprit methods: 64
-  # of culprit methods: 32
-  # of culprit methods: 16
-  # of culprit methods: 8
-  # of culprit methods: 8
-  # of culprit methods: 4
-  # of culprit methods: 2
-  # of culprit methods: 2
-  # of culprit methods: 1
-
-  Minimal methods found in 10 steps:
-
-  ruby -Ilib -e 'require "./example/test_bad1.rb" ; require "./example/test_bad4.rb"' -- --seed 3911 -s 48222 -n '/^(?:TestBad1\#test_bad1_1|TestBad4\#test_bad4_4)$/'
+  ruby -Itest:lib -e 'require "./example/test_bad1.rb" ; require "./example/test_bad2.rb" ; require "./example/test_bad3.rb" ; require "./example/test_bad4.rb" ; require "./example/test_bad5.rb" ; require "./example/test_bad6.rb" ; require "./example/test_bad7.rb" ; require "./example/test_bad8.rb"' -- --seed 314 -n "/^(?:TestBad1#(?:test_bad1_1)|TestBad4#(?:test_bad4_4))$/"
 
   Final reproduction:
 
-  Run options: --seed 3911 -s 48222 -n "/^(?:TestBad1\\#test_bad1_1|TestBad4\\#test_bad4_4)$/"
+  Run options: --seed 314 -n "/^(?:TestBad1#(?:test_bad1_1)|TestBad4#(?:test_bad4_4))$/"
 
   # Running:
 
   .F
 
-  Finished in 0.505776s, 3.9543 runs/s, 1.9772 assertions/s.
+  Finished in 0.512999s, 3.8986 runs/s, 1.9493 assertions/s.
 
     1) Failure:
   TestBad4#test_bad4_4 [/Users/ryan/Work/p4/zss/src/minitest-bisect/dev/example/helper.rb:16]:
   muahahaha order dependency bug!
 
-  2 runs, 1 assertions, 1 failures, 0 errors, 0 skips
-
 Voila! This reduced it from 800 tests across 8 files down to 2 tests
-across 2 files. Note how we went from a 200 second test run to a 0.5
-second test run. Debugging that will be much easier.
+across 2 files. Note how we went from a ~200 second test run to a ~0.5
+second test run. Debugging that will be 400x faster and that much
+easier.
+
+=== What Now?
 
-It is now up to you to look at the source of both of those tests to
-determine what side-effects (or lack thereof) are causing your test
+Now, it is now up to you to look at the source of both of those tests
+to determine what side-effects (or lack thereof) are causing your test
 failure when run in this specific order.
 
 This happens in a single run. Depending on how many files / tests you

data/example-many/helper.rb

@@ -14,7 +14,7 @@ def create_test suffix, n_methods, bad_methods = {}
         case bad_methods[n]
         when true then
           $hosed += 1
-        when Fixnum then
+        when Integer then
           flunk "muahahaha order dependency bug!" if $hosed >= bad_methods[n]
         else
           assert true

data/lib/minitest/bisect.rb

@@ -5,7 +5,7 @@ require "rbconfig"
 require "path_expander"
 
 class Minitest::Bisect
-  VERSION = "1.4.1"
+  VERSION = "1.5.0"
 
   class PathExpander < ::PathExpander
     TEST_GLOB = "**/{test_*,*_test,spec_*,*_spec}.rb" # :nodoc:
@@ -14,7 +14,7 @@ class Minitest::Bisect
 
     def initialize args = ARGV # :nodoc:
       super args, TEST_GLOB
-      self.rb_flags = []
+      self.rb_flags = %w[-Itest:lib]
     end
 
     ##
@@ -162,8 +162,10 @@ class Minitest::Bisect
     puts
     puts "Minimal methods found in #{count} steps:"
     puts
+    puts "Culprit methods: %p" % [found]
+    puts
     cmd = build_methods_cmd cmd, found, bad
-    puts cmd
+    puts cmd.sub(/--server \d+/, "")
     puts
     cmd
   end

data/test/minitest/test_bisect.rb

@@ -220,7 +220,7 @@ class TestMinitest::TestBisect::TestPathExpander < Minitest::Test
     expander = mtbpe.new args
 
     assert_kind_of PathExpander, expander
-    assert_equal [], expander.rb_flags
+    assert_equal %w[-Itest:lib], expander.rb_flags
     assert_same mtbpe::TEST_GLOB, expander.glob
   end
 
@@ -230,7 +230,7 @@ class TestMinitest::TestBisect::TestPathExpander < Minitest::Test
     expander = Minitest::Bisect::PathExpander.new args
 
     exp_files = %w[1 2 3 4 5 6]
-    exp_flags = %w[-Iblah -d -w]
+    exp_flags = %w[-Itest:lib -Iblah -d -w]
 
     files = expander.process_flags(args)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-bisect
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   Em82dBUFsipwMLCYj39kcyHWAxyl6Ae1Cn9r/ItVBCxoeFdrHjfavnrIEoXUt4bU
   UfBugfLD19bu3nvL+zTAGx/U
   -----END CERTIFICATE-----
-date: 2019-05-27 00:00:00.000000000 Z
+date: 2019-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-server
@@ -99,14 +99,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.17'
+        version: '3.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.17'
+        version: '3.18'
 description: |-
   Hunting down random test failures can be very very difficult,
   sometimes impossible, but minitest-bisect makes it easy.
@@ -178,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Hunting down random test failures can be very very difficult, sometimes impossible,