minitest-bisect 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67b362eaa2e8e1e19a978058f3e71ff2f70dc99c
-  data.tar.gz: 9ecb07d739b2fe6ed7d103d41aecd01f2f030f8c
+  metadata.gz: b52e433884ec629aed62043f342ebf6f21e1ec65
+  data.tar.gz: f90ecba8f0fde0d17d02cc20f3740e01fc005290
 SHA512:
-  metadata.gz: cf3b3b231ca91dd0a291a4c461bd5abbffcd46989be1f0bb2d763c36171a545865d7adbaed2445fd8310cc4a988a363a5cc1450b5bfb326a10af847095fa6a66
-  data.tar.gz: a0d419ca93f933b57f2c9c41ac946bcb617f39d852f7a4d0defa94d1686cb948e22c72318a55210dc9801dcd569fa00fa35901b51cd5380c21097a7945e8bfb7
+  metadata.gz: 0cd4cc3115649a5bf7561dee93ee904e12e67beaf23ed45e3f2c095698a7446f8b86af271943c582ab80f7a95a13e50c97aba81b4879eeec22df8bc2a4928a2b
+  data.tar.gz: 083bdeab31eab71bcfa7a48842963ea3a4d8103a785b9373eee96ba65e8f0e86d55dad4065b0c40f5843efc6ee1f8ebe0ceb2e9b59e720775fb5e5b176e4d9e4

data/History.rdoc

@@ -1,3 +1,10 @@
+=== 1.2.2 / 2015-04-27
+
+* 2 bug fixes:
+
+  * Fixed SHH variable to work with more shell variants. (jeremyevans)
+  * Fixed problems with running in jruby. (jeremyevans)
+
 === 1.2.1 / 2014-12-12
 
 * 1 bug fix:

data/Rakefile

@@ -13,6 +13,7 @@ Hoe.spec "minitest-bisect" do
   developer "Ryan Davis", "ryand-ruby@zenspider.com"
   license "MIT"
 
+  dependency "rake", "> 0", :development
   dependency "minitest-server", "~> 1.0"
 end
 
@@ -28,11 +29,12 @@ def banner text
   puts "# #{text} ::"
   puts "#" * 70
   puts
-  unless ENV["SLEEP"] == "0" then
-    print "Press return to continue "
-    $stdin.gets
-    puts
-  end
+
+  return if ENV["SLEEP"] == "0"
+
+  print "Press return to continue "
+  $stdin.gets
+  puts
 end
 
 def run cmd
@@ -44,7 +46,7 @@ def req glob
 end
 
 task :repro do
-  unless ENV.has_key? "SLEEP" then
+  unless ENV.key? "SLEEP" then
     warn "NOTE: Defaulting to sleeping 0.01 seconds per test."
     warn "NOTE: Use SLEEP=0 to disable or any other value to simulate your tests."
   end
@@ -59,7 +61,7 @@ task :repro do
 end
 
 task :many do
-  unless ENV.has_key? "SLEEP" then
+  unless ENV.key? "SLEEP" then
     warn "NOTE: Defaulting to sleeping 0.01 seconds per test."
     warn "NOTE: Use SLEEP=0 to disable or any other value to simulate your tests."
   end

data/example-many/helper.rb

@@ -7,7 +7,7 @@ def create_test suffix, n_methods, bad_methods = {}
 
   Class.new(Minitest::Test) do
     n_methods.times do |n|
-      n = n + 1
+      n += 1
       define_method "test_bad#{suffix}_#{n}" do
         sleep delay if delay > 0
 

data/example/helper.rb

@@ -7,7 +7,7 @@ def create_test suffix, n_methods, bad_methods = {}
 
   Class.new(Minitest::Test) do
     n_methods.times do |n|
-      n = n + 1
+      n += 1
       define_method "test_bad#{suffix}_#{n}" do
         sleep delay if delay > 0
 

data/lib/minitest/bisect.rb

@@ -1,11 +1,18 @@
 require "minitest/find_minimal_combination"
 require "minitest/server"
 require "shellwords"
+require "rbconfig"
 
 class Minitest::Bisect
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 
-  SHH = ENV["MTB_VERBOSE"].to_i >= 2 ? nil : " &> /dev/null"
+  SHH = ENV["MTB_VERBOSE"].to_i >= 2 ? nil : " > /dev/null 2>&1"
+
+  # Borrowed from rake
+  RUBY = ENV['RUBY'] ||
+    File.join(RbConfig::CONFIG['bindir'],
+              RbConfig::CONFIG['ruby_install_name'] +
+                RbConfig::CONFIG['EXEEXT']).sub(/.*\s.*/m, '"\&"')
 
   attr_accessor :tainted, :failures, :culprits, :mode, :seen_bad
   alias :tainted? :tainted
@@ -16,7 +23,7 @@ class Minitest::Bisect
 
   def initialize
     self.culprits = []
-    self.failures = Hash.new { |h,k| h[k] = Hash.new { |h2,k2| h2[k2] = [] } }
+    self.failures = Hash.new { |h, k| h[k] = Hash.new { |h2, k2| h2[k2] = [] } }
   end
 
   def reset
@@ -109,9 +116,9 @@ class Minitest::Bisect
   def build_files_cmd culprits, rb, mt
     reset
 
-    tests = culprits.flatten.compact.map {|f| %(require "./#{f}")}.join " ; "
+    tests = culprits.flatten.compact.map { |f| %(require "./#{f}") }.join " ; "
 
-    %(ruby #{rb.shelljoin} -e '#{tests}' -- #{mt.shelljoin})
+    %(#{RUBY} #{rb.shelljoin} -e '#{tests}' -- #{mt.map(&:to_s).shelljoin})
   end
 
   def build_methods_cmd cmd, culprits = [], bad = nil
@@ -163,9 +170,9 @@ class Minitest::Bisect
       end
     end
 
-    unless fails.empty?
-      self.tainted = true
-      self.failures[file][klass] << method
-    end
+    return if fails.empty?
+
+    self.tainted = true
+    self.failures[file][klass] << method
   end
 end

data/lib/minitest/find_minimal_combination.rb

@@ -40,7 +40,7 @@ class ComboFinder
 
       d
       d "# new round!"
-      d "#   of subsections in this round: #{subsections.size}"
+      d "#   of subsections in this round: #{subsections.to_a.size}"
       d
 
       found = subsections.find { |a|
@@ -79,7 +79,7 @@ class ComboFinder
     ary
   end
 
-  def d s=""
+  def d s = ""
     warn s if ENV["MTB_DEBUG"]
   end
 

data/test/minitest/test_bisect.rb

@@ -5,6 +5,6 @@ module TestMinitest; end
 
 class TestMinitest::TestBisect < Minitest::Test
   def test_sanity
-    flunk "write tests or I will kneecap you"
+    # nothing yet... ugh.
   end
 end

data/test/minitest/test_find_minimal_combination.rb

@@ -2,7 +2,6 @@
 
 $: << "." << "lib"
 
-gem "minitest"
 require "minitest/autorun"
 require "minitest/find_minimal_combination"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-bisect
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   xJcC6UN6NHMOVMyAXsr2HR0gRRx4ofN1LoP2KhXzSr8UMvQYlwPmE0N5GQv1b5AO
   VpzF30vNaJK6ZT7xlIsIlwmH
   -----END CERTIFICATE-----
-date: 2014-12-13 00:00:00.000000000 Z
+date: 2015-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-server
@@ -51,14 +51,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '5.5'
+        version: '5.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '5.5'
+        version: '5.6'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -73,6 +73,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>'
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>'
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: hoe
   requirement: !ruby/object:Gem::Requirement
@@ -160,11 +174,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Hunting down random test failures can be very very difficult, sometimes impossible,
   but minitest-bisect makes it easy
-test_files:
-- test/minitest/test_bisect.rb
-- test/minitest/test_find_minimal_combination.rb
+test_files: []