minitar 0.8 → 0.12

data/test/test_tar_writer.rb

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require 'minitar'
-require 'minitest_helper'
+require "minitar"
+require "minitest_helper"
 
 class TestTarWriter < Minitest::Test
   include Archive::Tar::Minitar::ByteSize
@@ -21,15 +21,15 @@ class TestTarWriter < Minitest::Test
     end
 
     def reset
-      @data = ''
-      @data.force_encoding('ascii-8bit') if @data.respond_to?(:force_encoding)
+      @data = ""
+      @data.force_encoding("ascii-8bit") if @data.respond_to?(:force_encoding)
     end
   end
 
   def setup
-    @data = 'a' * 10
+    @data = "a" * 10
     @unicode = [0xc3.chr, 0xa5.chr].join * 10
-    @unicode.force_encoding('utf-8') if @unicode.respond_to?(:force_encoding)
+    @unicode.force_encoding("utf-8") if @unicode.respond_to?(:force_encoding)
     @dummyos = DummyIO.new
     @os = Minitar::Writer.new(@dummyos)
   end
@@ -46,63 +46,61 @@ class TestTarWriter < Minitest::Test
     assert writer.closed?
   end
 
-
   def test_add_file_simple
     @dummyos.reset
 
     Minitar::Writer.open(@dummyos) do |os|
-      os.add_file_simple('lib/foo/bar', :mode => 0o644, :size => 10) do |f|
-        f.write 'a' * 10
+      os.add_file_simple("lib/foo/bar", :mode => 0o644, :size => 10) do |f|
+        f.write "a" * 10
       end
-      os.add_file_simple('lib/bar/baz', :mode => 0o644, :size => 100) do |f|
-        f.write 'fillme'
+      os.add_file_simple("lib/bar/baz", :mode => 0o644, :size => 100) do |f|
+        f.write "fillme"
       end
     end
 
-    assert_headers_equal(tar_file_header('lib/foo/bar', '', 0o644, 10),
+    assert_headers_equal(tar_file_header("lib/foo/bar", "", 0o644, 10),
       @dummyos.data[0, 512])
-    assert_equal('a' * 10 + "\0" * 502, @dummyos.data[512, 512])
-    assert_headers_equal(tar_file_header('lib/bar/baz', '', 0o644, 100),
+    assert_equal("a" * 10 + "\0" * 502, @dummyos.data[512, 512])
+    assert_headers_equal(tar_file_header("lib/bar/baz", "", 0o644, 100),
       @dummyos.data[512 * 2, 512])
-    assert_equal('fillme' + "\0" * 506, @dummyos.data[512 * 3, 512])
+    assert_equal("fillme" + "\0" * 506, @dummyos.data[512 * 3, 512])
     assert_equal("\0" * 512, @dummyos.data[512 * 4, 512])
     assert_equal("\0" * 512, @dummyos.data[512 * 5, 512])
   end
 
   def test_write_operations_fail_after_closed
     @dummyos.reset
-    @os.add_file_simple('sadd', :mode => 0o644, :size => 20) { |f| }
+    @os.add_file_simple("sadd", :mode => 0o644, :size => 20) { |f| }
     @os.close
     assert_raises(Minitar::ClosedStream) { @os.flush }
-    assert_raises(Minitar::ClosedStream) {
-      @os.add_file('dfdsf', :mode => 0o644) {}
-    }
-    assert_raises(Minitar::ClosedStream) { @os.mkdir 'sdfdsf', :mode => 0o644 }
+    assert_raises(Minitar::ClosedStream) { @os.add_file("dfdsf", :mode => 0o644) {} }
+    assert_raises(Minitar::ClosedStream) { @os.mkdir "sdfdsf", :mode => 0o644 }
+    assert_raises(Minitar::ClosedStream) { @os.symlink "a", "b", :mode => 0o644 }
   end
 
   def test_file_name_is_split_correctly
     # test insane file lengths, and: a{100}/b{155}, etc
     @dummyos.reset
     names = [
-      "#{'a' * 155}/#{'b' * 100}",
-      "#{'a' * 151}/#{'qwer/' * 19}bla",
-      "/#{'a' * 49}/#{'b' * 50}",
-      "#{'a' * 49}/#{'b' * 50}x",
-      "#{'a' * 49}x/#{'b' * 50}"
+      "#{"a" * 155}/#{"b" * 100}",
+      "#{"a" * 151}/#{"qwer/" * 19}bla",
+      "/#{"a" * 49}/#{"b" * 50}",
+      "#{"a" * 49}/#{"b" * 50}x",
+      "#{"a" * 49}x/#{"b" * 50}"
     ]
     o_names = [
-      'b' * 100,
-      "#{'qwer/' * 19}bla",
-      'b' * 50,
-      "#{'b' * 50}x",
-      'b' * 50
+      "b" * 100,
+      "#{"qwer/" * 19}bla",
+      "b" * 50,
+      "#{"b" * 50}x",
+      "b" * 50
     ]
     o_prefixes = [
-      'a' * 155,
-      'a' * 151,
-      "/#{'a' * 49}",
-      'a' * 49,
-      "#{'a' * 49}x"
+      "a" * 155,
+      "a" * 151,
+      "/#{"a" * 49}",
+      "a" * 49,
+      "#{"a" * 49}x"
     ]
     names.each do |name|
       @os.add_file_simple(name, :mode => 0o644, :size => 10) {}
@@ -118,46 +116,83 @@ class TestTarWriter < Minitest::Test
   def test_file_name_is_long
     @dummyos.reset
 
-    @os.add_file_simple(File.join('a' * 152, 'b' * 10, 'c' * 92),
-                        :mode => 0o644, :size => 10) {}
-    @os.add_file_simple(File.join('d' * 162, 'e' * 10),
-                        :mode => 0o644, :size => 10) {}
-    @os.add_file_simple(File.join('f' * 10, 'g' * 110),
-                        :mode => 0o644, :size => 10) {}
+    @os.add_file_simple(File.join("a" * 152, "b" * 10, "c" * 92),
+      :mode => 0o644, :size => 10) {}
+    @os.add_file_simple(File.join("d" * 162, "e" * 10),
+      :mode => 0o644, :size => 10) {}
+    @os.add_file_simple(File.join("f" * 10, "g" * 110),
+      :mode => 0o644, :size => 10) {}
     # Issue #6.
-    @os.add_file_simple('a' * 114, :mode => 0o644, :size => 10) {}
+    @os.add_file_simple("a" * 114, :mode => 0o644, :size => 10) {}
 
     # "././@LongLink", a file name, its actual header, its data, ...
     4.times do |i|
       assert_equal(Minitar::PosixHeader::GNU_EXT_LONG_LINK,
-                   @dummyos.data[4 * i * 512, 32].rstrip)
+        @dummyos.data[4 * i * 512, 32].rstrip)
     end
   end
 
+  def test_add_file_simple_content_with_long_name
+    @dummyos.reset
+
+    long_name_file_content = "where_is_all_the_content_gone"
+
+    @os.add_file_simple("a" * 114, :mode => 0o0644, :data => long_name_file_content)
+
+    assert_equal(long_name_file_content,
+      @dummyos.data[3 * 512, long_name_file_content.bytesize])
+  end
+
+  def test_add_file_content_with_long_name
+    dummyos = StringIO.new
+    def dummyos.method_missing(meth, *a)
+      string.send(meth, *a)
+    end
+
+    def dummyos.respond_to_missing?(meth, all)
+      string.respond_to?(meth, all)
+    end
+
+    long_name_file_content = "where_is_all_the_content_gone"
+
+    Minitar::Writer.open(dummyos) do |os|
+      os.add_file("a" * 114, :mode => 0o0644) do |f|
+        f.write(long_name_file_content)
+      end
+    end
+
+    assert_equal(long_name_file_content,
+      dummyos[3 * 512, long_name_file_content.bytesize])
+  end
+
   def test_add_file
     dummyos = StringIO.new
-    def dummyos.method_missing(meth, *a) # rubocop:disable Style/MethodMissing
+    def dummyos.method_missing(meth, *a)
       string.send(meth, *a)
     end
-    content1 = ('a'..'z').to_a.join('') # 26
-    content2 = ('aa'..'zz').to_a.join('') # 1352
+
+    def dummyos.respond_to_missing?(meth, all)
+      string.respond_to?(meth, all)
+    end
+    content1 = ("a".."z").to_a.join("") # 26
+    content2 = ("aa".."zz").to_a.join("") # 1352
     Minitar::Writer.open(dummyos) do |os|
-      os.add_file('lib/foo/bar', :mode => 0o644) { |f, _opts| f.write 'a' * 10 }
-      os.add_file('lib/bar/baz', :mode => 0o644) { |f, _opts| f.write content1 }
-      os.add_file('lib/bar/baz', :mode => 0o644) { |f, _opts| f.write content2 }
-      os.add_file('lib/bar/baz', :mode => 0o644) { |_f, _opts| }
+      os.add_file("lib/foo/bar", :mode => 0o644) { |f, _opts| f.write "a" * 10 }
+      os.add_file("lib/bar/baz", :mode => 0o644) { |f, _opts| f.write content1 }
+      os.add_file("lib/bar/baz", :mode => 0o644) { |f, _opts| f.write content2 }
+      os.add_file("lib/bar/baz", :mode => 0o644) { |_f, _opts| }
     end
-    assert_headers_equal(tar_file_header('lib/foo/bar', '', 0o644, 10),
+    assert_headers_equal(tar_file_header("lib/foo/bar", "", 0o644, 10),
       dummyos[0, 512])
-    assert_equal(%Q(#{'a' * 10}#{"\0" * 502}), dummyos[512, 512])
+    assert_equal(%(#{"a" * 10}#{"\0" * 502}), dummyos[512, 512])
     offset = 512 * 2
-    [content1, content2, ''].each do |data|
-      assert_headers_equal(tar_file_header('lib/bar/baz', '', 0o644,
+    [content1, content2, ""].each do |data|
+      assert_headers_equal(tar_file_header("lib/bar/baz", "", 0o644,
         bytesize(data)), dummyos[offset, 512])
       offset += 512
-      until !data || data == ''
+      until !data || data == ""
         chunk = data[0, 512]
-        data[0, 512] = ''
+        data[0, 512] = ""
         assert_equal(chunk + "\0" * (512 - bytesize(chunk)),
           dummyos[offset, 512])
         offset += 512
@@ -168,28 +203,28 @@ class TestTarWriter < Minitest::Test
 
   def test_add_file_tests_seekability
     assert_raises(Archive::Tar::Minitar::NonSeekableStream) do
-      @os.add_file('libdfdsfd', :mode => 0o644) { |f| }
+      @os.add_file("libdfdsfd", :mode => 0o644) { |f| }
     end
   end
 
   def test_write_header
     @dummyos.reset
-    @os.add_file_simple('lib/foo/bar', :mode => 0o644, :size => 0) {}
+    @os.add_file_simple("lib/foo/bar", :mode => 0o644, :size => 0) {}
     @os.flush
-    assert_headers_equal(tar_file_header('lib/foo/bar', '', 0o644, 0),
+    assert_headers_equal(tar_file_header("lib/foo/bar", "", 0o644, 0),
       @dummyos.data[0, 512])
     @dummyos.reset
-    @os.mkdir('lib/foo', :mode => 0o644)
-    assert_headers_equal(tar_dir_header('lib/foo', '', 0o644),
+    @os.mkdir("lib/foo", :mode => 0o644)
+    assert_headers_equal(tar_dir_header("lib/foo", "", 0o644),
       @dummyos.data[0, 512])
-    @os.mkdir('lib/bar', :mode => 0o644)
-    assert_headers_equal(tar_dir_header('lib/bar', '', 0o644),
+    @os.mkdir("lib/bar", :mode => 0o644)
+    assert_headers_equal(tar_dir_header("lib/bar", "", 0o644),
       @dummyos.data[512 * 1, 512])
   end
 
   def test_write_data
     @dummyos.reset
-    @os.add_file_simple('lib/foo/bar', :mode => 0o644, :size => 10) do |f|
+    @os.add_file_simple("lib/foo/bar", :mode => 0o644, :size => 10) do |f|
       f.write @data
     end
     @os.flush
@@ -203,10 +238,10 @@ class TestTarWriter < Minitest::Test
     if @unicode.respond_to?(:bytesize)
       assert_equal 10, @unicode.size
       assert_equal 20, @unicode.bytesize
-      @unicode.force_encoding('ascii-8bit')
+      @unicode.force_encoding("ascii-8bit")
     end
 
-    file = ['lib/foo/b', 0xc3.chr, 0xa5.chr, 'r'].join
+    file = ["lib/foo/b", 0xc3.chr, 0xa5.chr, "r"].join
 
     @os.add_file_simple(file, :mode => 0o644, :size => 20) do |f|
       f.write @unicode
@@ -219,10 +254,25 @@ class TestTarWriter < Minitest::Test
   def test_file_size_is_checked
     @dummyos.reset
     assert_raises(Minitar::Writer::WriteBoundaryOverflow) do
-      @os.add_file_simple('lib/foo/bar', :mode => 0o644, :size => 10) do |f|
-        f.write '1' * 100
+      @os.add_file_simple("lib/foo/bar", :mode => 0o644, :size => 10) do |f|
+        f.write "1" * 100
       end
     end
-    @os.add_file_simple('lib/foo/bar', :mode => 0o644, :size => 10) { |f| }
+    @os.add_file_simple("lib/foo/bar", :mode => 0o644, :size => 10) { |f| }
+  end
+
+  def test_symlink
+    @dummyos.reset
+    @os.symlink("lib/foo/bar", "lib/foo/baz", :mode => 0o644)
+    @os.flush
+    assert_headers_equal(tar_symlink_header("lib/foo/bar", "", 0o644, "lib/foo/baz"),
+      @dummyos.data[0, 512])
+  end
+
+  def test_symlink_target_size_is_checked
+    @dummyos.reset
+    assert_raises(Minitar::FileNameTooLong) do
+      @os.symlink("lib/foo/bar", "x" * 101)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitar
 version: !ruby/object:Gem::Version
-  version: '0.8'
+  version: '0.12'
 platform: ruby
 authors:
 - Austin Ziegler
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-01-05 00:00:00.000000000 Z
+date: 2024-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.24'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.24'
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: hoe
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: hoe-doofus
   requirement: !ruby/object:Gem::Requirement
@@ -53,19 +81,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: hoe-git
+  name: hoe-git2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: hoe-rubygems
   requirement: !ruby/object:Gem::Requirement
@@ -81,39 +109,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: hoe-travis
+  name: minitest-autotest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: minitest-autotest
+  name: minitest-focus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +145,7 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '12'
+        version: '14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -133,7 +155,7 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '12'
+        version: '14'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -149,41 +171,38 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.0'
 - !ruby/object:Gem::Dependency
-  name: hoe
+  name: standard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.17'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.17'
+        version: '0.21'
 description: |-
   The minitar library is a pure-Ruby library that provides the ability to deal
   with POSIX tar(1) archive files.
 
-  This is release 0.7, providing fixes for several issues and clarifying the
-  Minitar security stance. There are two minor breaking changes in this version
-  so that exceptions will be thrown if a negative size is provided in a tar
-  stream header or if the tar stream header is otherwise invalid.
-
-  This release continues the migration and modernization of the code:
-
-  *   the licence has been changed to match the modern Ruby licensing scheme
-      (Ruby and Simplified BSD instead of Ruby and GNU GPL);
-  *   the +minitar+ command-line program has been separated into the
-      +minitar-cli+ gem; and
-  *   the +archive-tar-minitar+ gem now points to the +minitar+ and +minitar-cli+
-      gems and discourages its installation.
-
-  Some of these changes may break existing programs that depend on the internal
-  structure of the minitar library, but every effort has been made to ensure
-  compatibility; inasmuch as is possible, this compatibility will be maintained
-  through the release of minitar 1.0 (which will have strong breaking changes).
+  This is release 0.12. This is likely the last revision before 1.0.
 
   minitar (previously called Archive::Tar::Minitar) is based heavily on code
   originally written by Mauricio Julio Fernández Pradier for the rpa-base
@@ -219,6 +238,7 @@ files:
 - lib/archive/tar/minitar/reader.rb
 - lib/archive/tar/minitar/writer.rb
 - lib/minitar.rb
+- support/hoe/deprecated_gem.rb
 - test/minitest_helper.rb
 - test/support/tar_test_helpers.rb
 - test/test_tar_header.rb
@@ -230,7 +250,11 @@ homepage: https://github.com/halostatue/minitar/
 licenses:
 - Ruby
 - BSD-2-Clause
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/halostatue/minitar/
+  source_code_uri: https://github.com/halostatue/minitar/
+  bug_tracker_uri: https://github.com/halostatue/minitar/issues
+  rubygems_mfa_required: 'true'
 post_install_message: |
   The `minitar` executable is no longer bundled with `minitar`. If you are
   expecting this executable, make sure you also install `minitar-cli`.
@@ -250,9 +274,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
-signing_key: 
+rubygems_version: 3.5.17
+signing_key:
 specification_version: 4
 summary: The minitar library is a pure-Ruby library that provides the ability to deal
   with POSIX tar(1) archive files