minio_runner 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce1a05760ce2ec7932d48b99d21d94b8a4d9c7e88521b82aa36a1845bd934f96
-  data.tar.gz: 2e0dc3f55ed0f9a78a93d00f5ad98648e61b32ab470966e9662d76f416ac5f89
+  metadata.gz: ce06f5ad735c373c93d962a986aa801275ea6d176793dbe3aa68de4aae4bca9f
+  data.tar.gz: dec506832311083518a2a54e07a11e845bf8829ff3384456921652ecde0280ca
 SHA512:
-  metadata.gz: 0d778019e25efa46ec83b05f5ca63f59c52f9f5de005363a1feebc1765593fd21191f0ff6f80c767ec785d120e69bb9b0b3a0c7b9be6c56c0f287b1f51d1f1c1
-  data.tar.gz: a6d5f557141f850dd40435aaf8f664f9361066a24552dd7809c994f2ca9fe9fa879add876f65e5de54b63048385f4d6b861a95b4930d0202882e2aa9812dd0ed
+  metadata.gz: 4385d8054248c2870106a0c27796642f2667bf134588ce773714769021d673e328ac2a9bf958de5494918f8036da03316a3c50dac4d8aac2e4ccf92e735b0f1c
+  data.tar.gz: a69728fe684c1abf2edd638f38d9bf202de77a9d1d4129523b84d80ea7c42257e8b67d83fff75fbb75b840e8f2e7618995850e87b0033938aab7809defe7ef61

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    minio_runner (1.0.1)
+    minio_runner (1.1.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/minio_runner/mc_manager.rb

@@ -1,26 +1,29 @@
 # frozen_string_literal: true
 
+require "open3"
+
 module MinioRunner
   class McManager
+    CommandError = Class.new(StandardError)
+
+    DEFAULT_RETRIES = 5
+    RETRY_DELAY = 1
+
     class << self
       def command
         ["#{MinioRunner::McBinary.binary_file_path}"]
       end
 
       def bucket_exists?(alias_name, name)
-        system(
-          *command.concat(["ls", "#{alias_name}/#{name}"]),
-          out: MinioServerManager.log_file_path,
-        )
+        # `mc ls` exits non-zero when the bucket is missing, which is fine here.
+        _, _, status = run_mc(["ls", "#{alias_name}/#{name}"], allow_failure: true, retries: 0)
+        status.success?
       end
 
       def create_bucket(alias_name, name)
         MinioRunner.logger.debug("Creating bucket #{alias_name}/#{name}...")
         if !bucket_exists?(alias_name, name)
-          system(
-            *command.concat(["mb", "#{alias_name}/#{name}"]),
-            out: MinioServerManager.log_file_path,
-          )
+          run_mc(["mb", "#{alias_name}/#{name}"])
           MinioRunner.logger.debug("Created  #{alias_name}/#{name}.")
         else
           MinioRunner.logger.debug("Bucket #{alias_name}/#{name} already exists, doing nothing.")
@@ -29,18 +32,15 @@ module MinioRunner
 
       def set_alias(name, url)
         MinioRunner.logger.debug("Setting alias #{name} to #{url}...")
-        system(
-          *command.concat(
-            [
-              "alias",
-              "set",
-              name,
-              url,
-              MinioRunner.config.minio_root_user,
-              MinioRunner.config.minio_root_password,
-            ],
-          ),
-          out: MinioServerManager.log_file_path,
+        run_mc(
+          [
+            "alias",
+            "set",
+            name,
+            url,
+            MinioRunner.config.minio_root_user,
+            MinioRunner.config.minio_root_password,
+          ],
         )
         MinioRunner.logger.debug("Set alias #{name} to #{url}.")
       end
@@ -49,12 +49,40 @@ module MinioRunner
         MinioRunner.logger.debug(
           "Setting anonymous access for #{alias_name}/#{bucket} to policy #{policy}...",
         )
-        system(
-          *command.concat(["anonymous", "set", policy, "#{alias_name}/#{bucket}"]),
-          out: MinioServerManager.log_file_path,
-        )
+        run_mc(["anonymous", "set", policy, "#{alias_name}/#{bucket}"])
         MinioRunner.logger.debug("Anonymous access set for #{alias_name}/#{bucket}.")
       end
+
+      # Captures stdout/stderr to the minio log file, retries with backoff
+      # on non-zero exit codes (covers errors like "Server not initialized yet"
+      # and "connection refused" when minio is still starting) and raises
+      # `CommandError` on actual failures. (unless `allow_failure` is set)
+      def run_mc(args, allow_failure: false, retries: DEFAULT_RETRIES)
+        full_command = command + args
+        max_attempts = retries + 1
+        attempts = 0
+        stdout = stderr = status = nil
+
+        while attempts < max_attempts
+          stdout, stderr, status = Open3.capture3(*full_command)
+          File.open(MinioServerManager.log_file_path, "a") { |f| f.write(stdout, stderr) }
+
+          attempts += 1
+          break if status.success? || attempts == max_attempts
+
+          MinioRunner.logger.warn(
+            "mc #{args.join(" ")} failed (attempt #{attempts}/#{max_attempts}, " \
+              "exit #{status.exitstatus}); retrying in #{RETRY_DELAY}s: #{stderr.strip}",
+          )
+          sleep(RETRY_DELAY)
+        end
+
+        return stdout, stderr, status if status.success? || allow_failure
+
+        raise CommandError,
+              "mc #{args.join(" ")} failed after #{attempts} attempts " \
+                "(exit #{status.exitstatus}): #{stderr.strip}"
+      end
     end
   end
 end

data/lib/minio_runner/minio_health_check.rb

@@ -8,8 +8,10 @@ module MinioRunner
   # Also used to check whether /etc/hosts is configured properly; some platforms
   # (read: macOS) have to be configured in a certain way to avoid this.
   class MinioHealthCheck
+    DEFAULT_RETRIES = 10
+
     class << self
-      def call(retries: 2, initial_retries: nil)
+      def call(retries: DEFAULT_RETRIES, initial_retries: nil)
         initial_retries ||= retries
         begin
           Network.get("#{MinioRunner.config.minio_server_url}/minio/health/live")

data/lib/minio_runner/minio_server_manager.rb

@@ -48,7 +48,7 @@ module MinioRunner
       @process.start
 
       # Make sure the minio server is ready to accept requests.
-      MinioRunner::MinioHealthCheck.call(retries: 2)
+      MinioRunner::MinioHealthCheck.call
 
       MinioRunner.logger.debug("minio server running at pid #{@process.pid}!")
     end

data/lib/minio_runner/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MinioRunner
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minio_runner
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Martin Brennan