minimapper 0.6.0 → 0.6.1

data/README.md

@@ -246,6 +246,25 @@ User.new(:reminder_on => "2012-01-01").reminder # => #<Date: 2012-01-01 ...>
 
 Minimapper only calls #convert on non-empty strings. When the value is blank or nil, the attribute is set to nil.
 
+### Overriding attribute accessors
+
+Attribute readers and writers are implemented so that you can override them with inheritance:
+
+``` ruby
+class User
+  include Minimapper::Entity
+  attribute :name
+
+  def name
+    super.upcase
+  end
+
+  def name=(value)
+    super(value.strip)
+  end
+end
+```
+
 ### Associations
 
 There is no core support for associations, but we're implementing them in [minimapper-extras](https://github.com/barsoom/minimapper-extras) as we need them.

data/lib/minimapper/entity/attributes.rb

@@ -5,10 +5,17 @@ module Minimapper
     module Attributes
       def attributes(*list)
         columns = add_columns(list)
+
+        # By adding instance methods via an included module,
+        # they become overridable with "super".
+        instance_method_container = Module.new
+
         columns.each do |column|
-          define_reader(column)
-          define_writer(column)
+          define_reader(column, instance_method_container)
+          define_writer(column, instance_method_container)
         end
+
+        include instance_method_container
       end
 
       def attribute(*opts)
@@ -27,15 +34,19 @@ module Minimapper
         @entity_columns |= list.map { |data| Column.new(data) }
       end
 
-      def define_reader(column)
-        define_method(column.name) do
-          attributes[column.name]
+      def define_reader(column, instance_method_container)
+        instance_method_container.module_eval do
+          define_method(column.name) do
+            attributes[column.name]
+          end
         end
       end
 
-      def define_writer(column)
-        define_method("#{column.name}=") do |value|
-          attributes[column.name] = Convert.new(value).to(column.type)
+      def define_writer(column, instance_method_container)
+        instance_method_container.module_eval do
+          define_method("#{column.name}=") do |value|
+            attributes[column.name] = Convert.new(value).to(column.type)
+          end
         end
       end
 

data/lib/minimapper/entity/convert.rb

@@ -27,7 +27,7 @@ module Minimapper
 
       def converter_for(type)
         if type && !@@converters[type]
-          raise "Unknown attribute type: #{type}. Perhaps you've spelled it wrong or not registered the converter for it."
+          raise "Unknown attribute type: #{type}. Perhaps you've spelled it wrong or haven't registered the converter for it."
         end
 
         @@converters.fetch(type, NoOpConverter.new)

data/lib/minimapper/version.rb

@@ -1,3 +1,3 @@
 module Minimapper
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/unit/entity/convert_spec.rb

@@ -29,4 +29,8 @@ describe Minimapper::Entity::Convert do
   it "raises when the type isn't known" do
     lambda { described_class.new('foobar').to(:unknown) }.should raise_error(/Unknown attribute type/)
   end
+
+  it "does not make false nil" do
+    described_class.new(false).to(:unknown).should eq(false)
+  end
 end

data/unit/entity_spec.rb

@@ -20,9 +20,23 @@ class TestTask
   attribute :due_at, :date_time
 end
 
+class OverridingTestUser
+  include Minimapper::Entity
+  attributes :name
+
+  def name
+    super.upcase
+  end
+
+  def name=(value)
+    super(value.strip)
+  end
+end
+
 describe Minimapper::Entity do
   it "handles base attributes" do
     entity = TestEntity.new
+
     entity.id = 5
     entity.id.should == 5
 
@@ -40,7 +54,7 @@ describe Minimapper::Entity do
     entity.attributes[:id].should == 5
   end
 
-  it "can access attributes set though a hash" do
+  it "can access attributes set through a hash" do
     entity = TestUser.new
     entity.attributes = { :id => 5 }
     entity.id.should == 5
@@ -72,6 +86,18 @@ describe Minimapper::Entity do
     entity.attributes = { "id" => "15" }
     entity.attributes[:id].should == 15
   end
+
+  it "is possible to override attribute readers with inheritance" do
+    user = OverridingTestUser.new
+    user.name = "pelle"
+    user.name.should == "PELLE"
+  end
+
+  it "is possible to override attribute writers with inheritance" do
+    user = OverridingTestUser.new
+    user.name = " 123 "
+    user.name.should == "123"
+  end
 end
 
 describe Minimapper::Entity, "attributes without type" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimapper
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-17 00:00:00.000000000 Z
+date: 2013-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70151297215480 !ruby/object:Gem::Requirement
+  requirement: &70347747664260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70151297215480
+  version_requirements: *70347747664260
 description: A minimalistic way of separating your models from ORMs like ActiveRecord.
 email:
 - joakim.kolsjo@gmail.com
@@ -75,18 +75,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -4467739529293173565
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -4467739529293173565
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5