minimapper 0.5.1 → 0.5.2

data/README.md

@@ -23,7 +23,7 @@ This gem is tested against all major rubies in 1.8, 1.9 and 2.0, see [.travis.ym
 
 ### Only the most basic API
 
-This library only implements the most basic persistence API (mostly just CRUD). Any significant additions will be made into separate gems. The reasons for this are:
+This library only implements the most basic persistence API (mostly just CRUD). Any significant additions will be made into separate gems (like [minimapper-extras](https://github.com/barsoom/minimapper-extras)). The reasons for this are:
 
 * It should have a stable API
 * It should be possible to learn all it does in a short time
@@ -91,7 +91,7 @@ old_id = user.id
 user_mapper.delete(user)
 p user.id                        # => nil
 p user_mapper.find_by_id(old_id) # => nil
-# user_mapper.find(old_id)       # raises Minimapper::Mapper::CanNotFindEntity
+# user_mapper.find(old_id)       # raises Minimapper::EntityNotFound
 # user_mapper.delete_all
 # user_mapper.delete_by_id(1)
 

data/lib/minimapper/entity/convert.rb

@@ -17,7 +17,7 @@ module Minimapper
       register_converter :date_time, ToDateTime.new
 
       def to(type)
-        return nil if value.blank?
+        return nil   if     value != false && value.blank?
         return value unless value.is_a?(String)
 
         converter_for(type).convert(value)

data/lib/minimapper/mapper/ar.rb

@@ -107,7 +107,7 @@ module Minimapper
 
       def find_record_safely(id)
         find_record(id) ||
-          raise(CanNotFindEntity, :id => id)
+          raise(EntityNotFound, :id => id)
       end
 
       def find_record(id)
@@ -116,7 +116,7 @@ module Minimapper
 
       def record_for(entity)
         (entity.id && record_class.find_by_id(entity.id)) ||
-          raise(CanNotFindEntity, entity.inspect)
+          raise(EntityNotFound, entity.inspect)
       end
 
       def entities_for(records)

data/lib/minimapper/mapper/common.rb

@@ -1,7 +1,7 @@
 module Minimapper
-  module Mapper
-    CanNotFindEntity = Class.new(StandardError)
+  EntityNotFound = Class.new(StandardError)
 
+  module Mapper
     module Common
       attr_accessor :repository
     end

data/lib/minimapper/mapper/memory.rb

@@ -77,7 +77,7 @@ module Minimapper
 
       def find_internal_safely(id)
         find_internal(id) ||
-          raise(CanNotFindEntity, :id => id)
+          raise(EntityNotFound, :id => id)
       end
 
       def find_internal(id)

data/lib/minimapper/version.rb

@@ -1,3 +1,3 @@
 module Minimapper
-  VERSION = "0.5.1"
+  VERSION = "0.5.2"
 end

data/spec/support/shared_examples/mapper.rb

@@ -64,7 +64,7 @@ shared_examples :mapper do
     end
 
     it "fails when an entity can not be found" do
-      lambda { mapper.find(-1) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.find(-1) }.should raise_error(Minimapper::EntityNotFound)
     end
   end
 
@@ -199,14 +199,14 @@ shared_examples :mapper do
 
     it "fails when the entity does not have an id" do
       entity = build_valid_entity
-      lambda { mapper.update(entity) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.update(entity) }.should raise_error(Minimapper::EntityNotFound)
     end
 
     it "fails when the entity no longer exists" do
       entity = build_valid_entity
       mapper.create(entity)
       mapper.delete_all
-      lambda { mapper.update(entity) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.update(entity) }.should raise_error(Minimapper::EntityNotFound)
     end
   end
 
@@ -231,13 +231,13 @@ shared_examples :mapper do
 
     it "fails when the entity does not have an id" do
       entity = entity_class.new
-      lambda { mapper.delete(entity) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.delete(entity) }.should raise_error(Minimapper::EntityNotFound)
     end
 
     it "fails when the entity can not be found" do
       entity = entity_class.new
       entity.id = -1
-      lambda { mapper.delete(entity) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.delete(entity) }.should raise_error(Minimapper::EntityNotFound)
     end
   end
 
@@ -252,7 +252,7 @@ shared_examples :mapper do
     end
 
     it "fails when an entity can not be found" do
-      lambda { mapper.delete_by_id(-1) }.should raise_error(Minimapper::Mapper::CanNotFindEntity)
+      lambda { mapper.delete_by_id(-1) }.should raise_error(Minimapper::EntityNotFound)
     end
   end
 

data/unit/entity/convert_spec.rb

@@ -11,7 +11,7 @@ describe Minimapper::Entity::Convert do
     described_class.new('2012-01-01 20:57').to(:date_time).should == DateTime.new(2012, 01, 01, 20, 57)
   end
 
-  it "make it nil when it can't convert" do
+  it "makes it nil when it can't convert" do
     described_class.new(' ').to(:integer).should be_nil
     described_class.new(' ').to(:date_time).should be_nil
     described_class.new('garbage').to(:integer).should be_nil
@@ -21,4 +21,8 @@ describe Minimapper::Entity::Convert do
   it "returns the value as-is when it does not know how to convert it" do
     described_class.new('foobar').to(:unknown).should == 'foobar'
   end
+
+  it "does not make false nil" do
+    described_class.new(false).to(:unknown).should eq(false)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimapper
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-22 00:00:00.000000000 Z
+date: 2013-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70153436310520 !ruby/object:Gem::Requirement
+  requirement: &70225357873540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70153436310520
+  version_requirements: *70225357873540
 description: A minimalistic way of separating your models from ORMs like ActiveRecord.
 email:
 - joakim.kolsjo@gmail.com
@@ -75,18 +75,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3918684014874405558
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3918684014874405558
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5