minimal_feedback 0.0.2 → 0.0.3

data/README.md

@@ -23,7 +23,18 @@ rake db:migrate
 Let's say we have an Issue ActiveRecord model and we want to be able to give it feedback
 
 ```ruby
+class User < ActiveRecord::Base
+  has_many :issues
+end
+
 class Issue < ActiveRecord::Base
+  include MinimalFeedback
+
+  attr_accessor :condition
+
+  allow_feedback :if => proc { condition }
+
+  belongs_to :user
 end
 ```
 
@@ -31,6 +42,7 @@ What would happen with this configuration:
 
 ```ruby
 issue = Issue.create
+issue.condition = proc { true }
 issue.give_feedback(:positive)
 issue.feedbacks.first.type
 => :positive
@@ -40,6 +52,8 @@ issue.feedbacks.last.type
 => :negative
 ```
 
+Else if the condition proc returns false when the feedback validation is performed an exception is raised
+
 ## Contributing
 
 1. Fork it

data/lib/generators/minimal_feedback/templates/create_mf_feedbacks.rb

@@ -3,6 +3,7 @@ class CreateMsmStates < ActiveRecord::Migration
     create_table :mf_feedbacks do |t|
       t.string :type
       t.integer :rating
+      t.references :user
       t.references :rateable, :polymorphic => true
       t.timestamps
     end

data/lib/minimal_feedback/feedback.rb

@@ -5,9 +5,16 @@ module MinimalFeedback
     self.table_name = 'mf_feedbacks'
 
     belongs_to :rateable, :polymorphic => true
+    belongs_to :user
 
     validates :rating, :inclusion => { :in => [1, -1] }
 
+    validate do
+      if rateable.class.feedback_condition && !rateable.instance_eval(&rateable.class.feedback_condition).call
+        errors.add(:base, 'feedback is not allowed')
+      end
+    end
+
     def type
       case rating
       when 1

data/lib/minimal_feedback/version.rb

@@ -1,3 +1,3 @@
 module MinimalFeedback
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/minimal_feedback.rb

@@ -10,16 +10,31 @@ module MinimalFeedback
 
     class InvalidFeedbackError < StandardError; end
 
-    def give_feedback(type)
-      feedback_type = type.to_sym
-      case feedback_type
+    cattr_accessor :feedback_condition
+
+    def self.allow_feedback(options)
+      self.feedback_condition = options[:if]
+    end
+
+    def give_feedback(*args)
+      options = args.extract_options!
+      type = args.first.to_sym
+
+      feedback = Feedback.new do |f|
+        f.rateable = self
+        f.user = options[:user]
+      end
+
+      case type
       when :positive
-        Feedback.create(:rating => 1) { |f| f.rateable = self }
+        feedback.rating = 1
       when :negative
-        Feedback.create(:rating => -1) { |f| f.rateable = self }
+        feedback.rating = -1
       else
         raise InvalidFeedbackError
       end
+
+      feedback.save!
     end
   end
 end

data/spec/minimal_feedback_spec.rb

@@ -1,32 +1,61 @@
 require 'spec_helper'
 
 ActiveRecord::Base.connection.execute("DROP TABLE IF EXISTS 'mf_feedbacks'")
+ActiveRecord::Base.connection.execute("DROP TABLE IF EXISTS 'users'")
 ActiveRecord::Base.connection.execute("DROP TABLE IF EXISTS 'issues'")
 ActiveRecord::Base.connection.create_table(:mf_feedbacks) do |t|
   t.string :type
   t.integer :rating
+  t.references :user
   t.references :rateable, :polymorphic => true  
   t.timestamps
 end
 
-ActiveRecord::Base.connection.create_table(:issues)
+ActiveRecord::Base.connection.create_table(:users)
+ActiveRecord::Base.connection.create_table(:issues) do |t|
+  t.references :user
+end
+
+class User < ActiveRecord::Base
+  has_many :issues
+end
 
 class Issue < ActiveRecord::Base
   include MinimalFeedback
+
+  attr_accessor :condition
+
+  allow_feedback :if => proc { condition }
+
+  belongs_to :user
 end
 
 describe Issue do
   before(:each) do
-    @issue = Issue.create
+    @user = User.create
+    @issue = Issue.create do |i|
+      i.user = @user
+    end
   end
 
   it 'assigns positive feedback' do
-    @issue.give_feedback(:positive)
+    user = User.create
+    @issue.condition = proc { true }
+    @issue.give_feedback(:positive, :user => user)
+
     @issue.feedbacks.first.type.should == :positive
   end
 
   it 'assigns negative feedback' do
-    @issue.give_feedback(:negative)
+    user = User.create
+    @issue.condition = proc { true }
+    @issue.give_feedback(:negative, :user => user)
+
     @issue.feedbacks.first.type.should == :negative
   end
+
+  it 'cannot assign feedback if the condition is false' do
+    @issue.condition = proc { false }
+    expect { @issue.give_feedback(:positive, :user => @user) }.to raise_error
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimal_feedback
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -143,7 +143,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4159579160644425485
+      hash: -2381872170530731746
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4159579160644425485
+      hash: -2381872170530731746
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24