minicron 0.3 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9dd39723811b197138d5655e871e4c07fb49d4d4
-  data.tar.gz: 30b855c523a3ce04c9aaa83bc0a348b950e947c4
+  metadata.gz: 1b6939554f2e620783856cad085a5caebb87d70c
+  data.tar.gz: 3384f8536105f764031a7035c9a3fea95b985bcf
 SHA512:
-  metadata.gz: 5cb855f69d4a2727a5f837df5a96f9c1ff68a85f74150ca2f1c9497729f733af92517e7eb72fbf65457b0483205055c0f2ec9d9b596751f468da79449e2ae13a
-  data.tar.gz: 3181ea25877f42863c5317d39bb8a6998d563b5d55f75f6d06c0f478c140c3c76114e342edc30fd8d49c68e40c56abb7c1aa91318088eb330ede9b94ef116c79
+  metadata.gz: f9420b0503c77643198a875eda7a194630186dd9809f90574b1c234eff524ffc9a1f6b925dc5e766ad775f2d9f89e94e3450c3c810347157d55de6745f9b8287
+  data.tar.gz: d4ffe62daecf9ae0abab5b85baf68d40da45a6c1b89a68b20793c4256a7488c8b1e875e4827ab5bcf0856d455c2260d5ed5cf1359b5d41e60d4d9fdc70b487b7

data/README.md

@@ -14,23 +14,31 @@ server(s) and executes your cron command and reports the status back to the Hub.
 where data from one or many instances of the CLI are is recieved and stored in a database. The Hub also provides
 a web interface to the data and makes it easy to manage your cron jobs.
 
-- [Background](https://github.com/jamesrwhite/minicron/blob/master/README.md#background)
-- [Features](https://github.com/jamesrwhite/minicron/blob/master/README.md#goals)
-- [Requirements](https://github.com/jamesrwhite/minicron/blob/master/README.md#requirements)
-- [Installation](https://github.com/jamesrwhite/minicron/blob/master/README.md#installation)
-- [Usage](https://github.com/jamesrwhite/minicron/blob/master/README.md#usage)
-- [Documentation](https://github.com/jamesrwhite/minicron/blob/master/README.md#documentation)
-- [Versioning](https://github.com/jamesrwhite/minicron/blob/master/README.md#versioning)
-- [Contributing](https://github.com/jamesrwhite/minicron/blob/master/README.md#contributing)
-- [Support](https://github.com/jamesrwhite/minicron/blob/master/README.md#support)
-- [License](https://github.com/jamesrwhite/minicron/blob/master/README.md#license)
+- [Screenshots](#screenshots)
+- [Background](#background)
+- [Features](#goals)
+- [Requirements](#requirements)
+- [Installation](#installation)
+- [Usage](#usage)
+- [Documentation](#documentation)
+- [Versioning](#versioning)
+- [Contributing](#contributing)
+- [Support](#support)
+- [License](#license)
+
+Screenshots
+------------
+
+<img src="http://f.cl.ly/items/2o3q3x1N1X3n2t180H1u/Image%202014-04-12%20at%2010.54.39%20pm.png" height="100"/>
+
+More coming..
 
 Background
 -----------
 
-I'm developing minicron as part of my dissertation at university which is due in May but I plan to continue
-development after that. My inspiration for developing minicron comes from time spent working at
-[Miniclip](http://www.miniclip.com) where the management and monitoring of cron jobs at times proved to be tricky!
+I'm developing minicron as part of my dissertation at university which has to be completed by May but I plan to continue
+development after that. The inspiration for developing minicron comes from my own experience, in particular my time spent
+working at [Miniclip](http://www.miniclip.com) where the management and monitoring of cron jobs at times proved to be tricky!
 
 Features
 ---------
@@ -43,9 +51,9 @@ Features
 - Alerts when jobs executions are missed or fail via:
   - Email
   - SMS ([using Twilio](https://www.twilio.com))
-  - [PagerDuty](www.pagerduty.com)
+  - [PagerDuty](http://www.pagerduty.com) (SMS, Phone, Mobile Push Notifications and Email)
 
-Lots more is planned for the future, see issues tagged [feature](https://github.com/jamesrwhite/minicron/issues?labels=feature&milestone=&page=1&state=open).
+Lots more is planned for the future, see [open issues](issues?state=open) or if you don't see the feature you want there add it!
 
 Requirements
 -------------
@@ -53,7 +61,7 @@ Requirements
 #### Ruby
 - **MRI**: 1.9.3 and above (tested on 1.9.3, 2.0.0, 2.1.0)
 - <del>**Rubinius**: Travis builds are run on the latest release</del> [*awaiting bug fix*](https://github.com/rubinius/rubinius/issues/2944)
-- **JRuby:** currently untested but most likely needs some workn
+- **JRuby:** currently untested but most likely needs some work
 
 #### Database
 
@@ -63,7 +71,7 @@ Requirements
 #### Web Server / Reverse Proxy
 
 If you want to run minicron behind a web server or proxy it needs to support the web socket protocol.
-nginx for example supports web sockets from version 1.3.13 and up. I've included an [example config](https://github.com/jamesrwhite/minicron/blob/master/sample.nginx.conf) for nginx.
+nginx for example supports web sockets from version 1.3.13 and up. I've included an [example config](sample.nginx.conf) for nginx.
 
 #### Browser
 
@@ -72,22 +80,22 @@ I'm currently unsure of how it functions in the various of Internet Explorer but
 
 #### OS
 
-Should run on any linux/bsd based OS that the above ruby versions run on.
+Should run on osx and any linux/bsd based OS that the above ruby versions run on.
 
 Installation
 -------------
 
 minicron is currently under heavy development and as such I would not recommend that you use this in production yet
-but I encourage you to give it a try in a non critical environment and help me to improve it.
+but I encourage you to give it a try in a non critical environment and help me to improve it and work towards the first stable release (1.0).
 
-1. First check you meet the [requirements](https://github.com/jamesrwhite/minicron/blob/master/README.md#requirements)
+1. First check you meet the [requirements](#requirements)
 
 2. On some distributions you may need to install the ````ruby-dev```` and ````build-essential```` packages
 
-3. To install the latest release (currently 0.3) you can ````gem install minicron````, depending on your ruby setup
+3. To install the latest release (currently 0.4) you can ````gem install minicron````, depending on your ruby setup
    you may need to run this with ````sudo````
 
-4. Set your database configuration options in ````/etc/minicron.toml````, you can use the [default.config.toml](https://github.com/jamesrwhite/minicron/blob/master/default.config.toml) as a guide on what options are configurable
+4. Set your database configuration options in ````/etc/minicron.toml````, you can use the [default.config.toml](default.config.toml) as a guide on what options are configurable
 
 5. Make sure you have created an empty database with the name you set in ````/etc/minicron.toml````
 
@@ -99,7 +107,7 @@ but I encourage you to give it a try in a non critical environment and help me t
   > ````
 
 6. You can then ````minicron db setup```` to create the database schema, alternatively you can use
-   the [schema dump provided](https://github.com/jamesrwhite/minicron/blob/master/lib/minicron/hub/db/schema.sql)
+   the [schema dump provided](lib/minicron/hub/db/schema.sql)
 
 7. Done! See the usage section below for more details on how to use minicron now you have it installed
 
@@ -149,7 +157,7 @@ you can also use the ````stop```` and ````status```` commands to control the ser
 To run the server in debug mode, i.e not as a daemon so you can see its output you can pass the ````--debug````
 option.
 
-See [sample.nginx.conf](https://github.com/jamesrwhite/minicron/blob/master/sample.nginx.conf) for an example of
+See [sample.nginx.conf](sample.nginx.conf) for an example of
 how to run minicron behind a reverse proxy.
 
 #### Connecting to a host via SSH
@@ -163,7 +171,7 @@ most linux distributions or ````/var/root/.ssh/authorized_keys```` on OSX.
 
 #### Version
 
-Like many command line programs minicron will show it's version number when the global options ````-v````
+Like many command line programs minicron will show its version number when the global options ````-v````
 or ````--version```` are passed to the CLI.
 
 #### Configuration
@@ -171,14 +179,14 @@ or ````--version```` are passed to the CLI.
 Some configuration options can be passed in manually but the recommend way to configure minicron is through the use
 of a config file. You can specify the path to the file using the ````--config```` global option. The file is expected
 to be in the [toml](https://github.com/mojombo/toml "toml") format. The default options are specified in the
-[default.config.toml](https://github.com/jamesrwhite/minicron/blob/master/default.config.toml "default.config.toml")
+[default.config.toml](default.config.toml "default.config.toml")
 file and minicron will parse a config located in ````/etc/minicron.toml```` if it exists. Options specified via
 the command line will take precedence over those taken from a config file.
 
 Documentation
 -------------
 
-minicron uses [Yard](http://yardoc.org/ "Yard") for it's code documentation, you can either generate it and view
+minicron uses [Yard](http://yardoc.org/ "Yard") for its code documentation (currently the only *usage* documentation is what you're reading right now), you can either generate it and view
 it locally using the following commands:
 
 ````bash
@@ -191,7 +199,8 @@ or view the most up to date version online at [RubyDoc.info](http://rdoc.info/gi
 Versioning
 -----------
 
-Where possible all releases will follow the [semantic versioning](http://semver.org/) guidelines.
+All stable releases will follow the [semantic versioning](http://semver.org/) guidelines. Until 1.0 hits I will try to document any
+major breaking changes in the release descriptions.
 
 Releases will be numbered with the following format:
 
@@ -206,17 +215,17 @@ Based on the following guidelines:
 Contributing
 ------------
 
-Feedback and pull requests are welcome, please see [CONTRIBUTING.md](https://github.com/jamesrwhite/minicron/blob/master/CONTRIBUTING.md "CONTRIBUTING.md") for more info.
+Feedback and pull requests are welcome, please see [CONTRIBUTING.md](CONTRIBUTING.md "CONTRIBUTING.md") for more info.
 
 Areas that I would love some help with:
 
-- Any of the unassigned [issues here](https://github.com/jamesrwhite/minicron/issues?state=open).
+- Any of the unassigned [issues here](issues?state=open).
 - General testing of the system, let me know what you think and create issues for any bugs you find!
 - Tests!!
 - Validation and error handling improvements
-- Documentation improvements. Find something confusing or unexpected, let me know and I'll add or improve
+- Documentation improvements. If you find something confusing or unexpected let me know and I'll add or improve
   documentation for it!
-- Look for '[TODO:](https://github.com/jamesrwhite/minicron/search?q=TODO%3A)' notices littered around the code,
+- Look for '[TODO:](search?q=TODO%3A)' notices littered around the code,
   I'm trying to convert them all to issues but there are a lot..
 - Code refactoring, I had a reasonably tight deadline to have the main concept done by so some parts are a bit rushed
 - UI improvements
@@ -234,4 +243,4 @@ Or feel free to open an issue and I'll do my best to help.
 License
 --------
 
-minicron is licensed under the GPL v3, [see here for the full license](https://github.com/jamesrwhite/minicron/blob/master/LICENSE "see here")
+minicron is licensed under the GPL v3, [see here for the full license](LICENSE "see here")

data/bin/minicron

@@ -4,6 +4,9 @@ require 'minicron'
 require 'minicron/cli'
 require 'minicron/transport/server'
 
+# Set the process name to something more useful
+$PROGRAM_NAME = "minicron #{ARGV.join(' ')}"
+
 begin
   # Capture any output from STDERR so we can handle it how we want to
   Minicron.capture_output(:type => :stderr) do

data/lib/minicron.rb

@@ -1,10 +1,12 @@
-require 'stringio'
-require 'toml'
-require 'sshkey'
 require 'minicron/constants'
 
 # @author James White <dev.jameswhite+minicron@gmail.com>
 module Minicron
+  # Define module autoloading
+  autoload :TOML,             'toml'
+  autoload :StringIO,         'stringio'
+  autoload :SSHKey,           'sshkey'
+
   # Default configuration, this can be overriden
   @config = {
     'verbose' => false,
@@ -179,4 +181,11 @@ module Minicron
   def self.get_hostname
     `hostname -s`.strip
   end
+
+  # Get the user minicron is being run as
+  #
+  # @return [String]
+  def self.get_user
+    `whoami`.strip
+  end
 end

data/lib/minicron/alert.rb

@@ -1,10 +1,13 @@
-require 'minicron/alert/email'
-require 'minicron/alert/sms'
-require 'minicron/alert/pagerduty'
-require 'minicron/hub/models/alert'
-require 'minicron/hub/models/job'
-
 module Minicron
+  autoload :Email,      'minicron/alert/email'
+  autoload :SMS,        'minicron/alert/sms'
+  autoload :PagerDuty,  'minicron/alert/pagerduty'
+
+  module Hub
+    autoload :Alert,    'minicron/hub/models/alert'
+    autoload :Job,      'minicron/hub/models/job'
+  end
+
   # Allows the sending of alerts via multiple mediums
   class Alert
     # Send an alert using all enabled mediums

data/lib/minicron/cli.rb

@@ -1,17 +1,23 @@
-require 'pty'
+autoload :PTY,        'pty'
+autoload :Minicron,   'minicron'
+
 require 'English'
 require 'rainbow/ext/string'
 require 'commander'
 require 'minicron/constants'
 require 'minicron/cli/commands'
-require 'minicron/transport'
-require 'minicron/transport/client'
-require 'minicron/transport/server'
-require 'minicron/monitor'
 
 include Commander::UI
 
 module Minicron
+  autoload :Transport, 'minicron/transport'
+  autoload :Monitor,   'minicron/monitor'
+
+  module Transport
+    autoload :Client, 'minicron/transport/client'
+    autoload :Server, 'minicron/transport/server'
+  end
+
   # Handles the main CLI interaction of minicron
   # TODO: this class is probably too complicated and should be refactored a bit
   module CLI
@@ -188,6 +194,9 @@ module Minicron
       @cli.program :version, Minicron::VERSION
       @cli.program :description, 'cli for minicron; a system a to manage and monitor cron jobs'
 
+      # Display the output in a compact format
+      @cli.program :help_formatter, Commander::HelpFormatter::TerminalCompact
+
       # Set the default command to run
       @cli.default_command :help
 
@@ -197,7 +206,7 @@ module Minicron
       end
 
       # Add a global option for verbose mode
-      @cli.global_option '--verbose', "Turn on verbose mode. Default: #{Minicron.config['cli']['verbose']}" do
+      @cli.global_option '--verbose', "Turn on verbose mode. Default: #{Minicron.config['verbose'].to_s}" do
         Minicron.config['verbose'] = true
       end
 

data/lib/minicron/cli/commands.rb

@@ -1,8 +1,23 @@
-require 'insidious'
-require 'minicron'
-require 'minicron/transport/client'
+autoload :Minicron,            'minicron'
+autoload :Insidious,           'insidious'
+autoload :Rake,                'rake'
+
+module Sinatra
+  autoload :ActiveRecordTasks, 'sinatra/activerecord/rake'
+end
 
 module Minicron
+  autoload :Transport,         'minicron/transport'
+
+  module Transport
+    autoload :Client,          'minicron/transport/client'
+    autoload :Server,          'minicron/transport/server'
+  end
+
+  module Hub
+    autoload :App,             'minicron/hub/app'
+  end
+
   module CLI
     class Commands
       # Add the `minicron db` command
@@ -20,11 +35,6 @@ module Minicron
             # Parse the file and cli config options
             Minicron::CLI.parse_config(opts)
 
-            # These are inlined as we only need them in this use case
-            require 'rake'
-            require 'minicron/hub/app'
-            require 'sinatra/activerecord/rake'
-
             # Setup the db
             Minicron::Hub::App.setup_db
 
@@ -125,7 +135,16 @@ module Minicron
                 # Set up the job and get the jexecution and job ids back from the server
                 ids = setup_job(args.first, faye)
               end
+            rescue Exception => e
+              raise Exception, "Unable to setup job, reason: #{e.message}"
 
+              # Ensure that all messages are delivered and that we
+              unless Minicron.config['cli']['dry_run']
+                faye.tidy_up
+              end
+            end
+
+            begin
               # Execute the command and yield the output
               Minicron::CLI.run_command(args.first, :mode => Minicron.config['cli']['mode'], :verbose => Minicron.config['verbose']) do |output|
                 # We need to handle the yielded output differently based on it's type
@@ -143,6 +162,7 @@ module Minicron
                 yield output[:output] unless output[:type] == :status
               end
             rescue Exception => e
+              p e
               # Send the exception message to the server and yield it
               unless Minicron.config['cli']['dry_run']
                 faye.send(:job_id => ids[:job_id], :execution_id => ids[:execution_id], :type => :output, :message => e.message)
@@ -171,9 +191,6 @@ module Minicron
         # Get the fully qualified domain name of the currnet host
         fqdn = Minicron.get_fqdn
 
-        # Get the short hostname of the current host
-        hostname = Minicron.get_hostname
-
         # Get the md5 hash for the job
         job_hash = Minicron::Transport.get_job_hash(command, fqdn)
 
@@ -181,7 +198,13 @@ module Minicron
         faye.ensure_em_running
 
         # Setup the job on the server
-        ids = faye.setup(job_hash, command, fqdn, hostname)
+        ids = faye.setup(
+          :job_hash => job_hash,
+          :user => Minicron.get_user,
+          :command => command,
+          :fqdn => fqdn,
+          :hostname => Minicron.get_hostname
+        )
 
         # Wait until we get the execution id
         faye.ensure_delivery

data/lib/minicron/constants.rb

@@ -1,6 +1,6 @@
 # The minicron module
 module Minicron
-  VERSION = '0.3'
+  VERSION = '0.4'
   DEFAULT_CONFIG_FILE = '/etc/minicron.toml'
   BASE_PATH = File.expand_path('../../../', __FILE__)
   LIB_PATH = File.expand_path('../../', __FILE__)

data/lib/minicron/cron.rb

@@ -3,9 +3,6 @@ require 'escape'
 
 module Minicron
   # Used to interact with the crontab on hosts over an ssh connection
-  # TODO: I've had a moment of clarity, I don't need to do all the CRUD
-  # using unix commands. I can cat the crontab, manipulate it in ruby
-  # and then echo it back!
   class Cron
     # Initialise the cron class
     #
@@ -16,15 +13,49 @@ module Minicron
 
     # Build the minicron command to be used in the crontab
     #
-    # @param command [String]
     # @param schedule [String]
+    # @param user [String]
+    # @param command [String]
     # @return [String]
-    def build_minicron_command(command, schedule)
+    def build_minicron_command(schedule, user, command)
       # Escape the command so it will work in bourne shells
       command = Escape.shell_command(['minicron', 'run', command])
-      cron_command =Escape.shell_command(['/bin/bash', '-l', '-c', command])
+      cron_command = Escape.shell_command(['/bin/bash', '-l', '-c', command])
 
-      "#{schedule} root #{cron_command}"
+      "#{schedule} #{user} #{cron_command}"
+    end
+
+    # Test an SSH connection and the permissions for the crontab
+    #
+    # @param conn an instance of an open ssh connection
+    # @return [Hash]
+    def test_host_permissions(conn = nil)
+      # Open an SSH connection
+      conn ||= @ssh.open
+
+      # Check if /etc is writeable
+      etc_write = conn.exec!("/bin/sh -c 'test -w /etc && echo \"y\" || echo \"n\"'").strip
+
+      # Check if /etc is executable
+      etc_execute = conn.exec!("/bin/sh -c 'test -x /etc && echo \"y\" || echo \"n\"'").strip
+
+      # Check if the crontab is readable
+      crontab_read = conn.exec!("/bin/sh -c 'test -r /etc/crontab && echo \"y\" || echo \"n\"'").strip
+
+      # Check if the crontab is writeable
+      crontab_write = conn.exec!("/bin/sh -c 'test -w /etc/crontab && echo \"y\" || echo \"n\"'").strip
+
+      {
+        :connect => true,
+        :etc => {
+          :write => etc_write == 'y',
+          :execute => etc_execute == 'y'
+        },
+        :crontab => {
+          :read => crontab_read == 'y',
+          :write => crontab_write == 'y'
+        }
+      }
     end
 
     # Used to find a string and replace it with another in the crontab by
@@ -34,7 +65,27 @@ module Minicron
     # @param find [String]
     # @param replace [String]
     def find_and_replace(conn, find, replace)
-      # TODO: move ssh test here for crontab permissions
+      begin
+        # Test the SSH connection first
+        test = test_host_permissions(conn)
+      rescue Exception => e
+        raise Exception, "Error connecting to host, reason: #{e.message}"
+      end
+
+      # Check the connection worked
+      raise Exception, "Unable to connect to host, reason: unknown" if !test[:connect]
+
+      # Check the crontab is readable
+      raise Exception, "Insufficient permissions to read from /etc/crontab" if !test[:crontab][:read]
+
+      # Check the crontab is writeable
+      raise Exception, "Insufficient permissions to write to /etc/crontab" if !test[:crontab][:write]
+
+      # Check /etc is writeable
+      raise Exception, "/etc is not writeable by the current user" if !test[:etc][:write]
+
+      # Check /etc is executable
+      raise Exception, "/etc is not executable by the current user" if !test[:etc][:execute]
 
       # Get the full crontab
       crontab = conn.exec!('cat /etc/crontab').to_s.strip
@@ -47,17 +98,12 @@ module Minicron
       end
 
       # Echo the crontab back to the tmp crontab
-      update = conn.exec!("echo #{crontab.shellescape} > /etc/crontab.tmp && echo 'y' || echo 'n'").to_s.strip
-
-      # Throw an exception if it failed
-      if update != 'y'
-        fail Exception, "Unable to replace '#{find}' with '#{replace}' in the crontab"
-      end
+      conn.exec!("echo #{crontab.shellescape} > /tmp/minicron_crontab").to_s.strip
 
       # If it's a delete
       if replace == ''
         # Check the original line is no longer there
-        grep = conn.exec!("grep -F #{find.shellescape} /etc/crontab.tmp").to_s.strip
+        grep = conn.exec!("grep -F #{find.shellescape} /tmp/minicron_crontab").to_s.strip
 
         # Throw an exception if we can't see our new line at the end of the file
         if grep != replace
@@ -65,7 +111,7 @@ module Minicron
         end
       else
         # Check the updated line is there
-        grep = conn.exec!("grep -F #{replace.shellescape} /etc/crontab.tmp").to_s.strip
+        grep = conn.exec!("grep -F #{replace.shellescape} /tmp/minicron_crontab").to_s.strip
 
         # Throw an exception if we can't see our new line at the end of the file
         if grep != replace
@@ -74,10 +120,10 @@ module Minicron
       end
 
       # And finally replace the crontab with the new one now we now the change worked
-      move = conn.exec!("mv /etc/crontab.tmp /etc/crontab && echo 'y' || echo 'n'").to_s.strip
+      move = conn.exec!("/bin/sh -c 'mv /tmp/minicron_crontab /etc/crontab && echo \"y\" || echo \"n\"'").to_s.strip
 
       if move != 'y'
-        fail Exception, 'Unable to move tmp crontab with updated crontab'
+        fail Exception, 'Unable to move /tmp/minicron_crontab to /etc/crontab, check the permissions?'
       end
     end
 
@@ -91,20 +137,15 @@ module Minicron
       conn ||= @ssh.open
 
       # Prepare the line we are going to write to the crontab
-      line = build_minicron_command(job.command, schedule)
+      line = build_minicron_command(schedule, job.user, job.command)
       escaped_line = line.shellescape
-      echo_line = "echo #{escaped_line} >> /etc/crontab && echo 'y' || echo 'n'"
+      echo_line = "echo #{escaped_line} >> /etc/crontab"
 
       # Append it to the end of the crontab
-      write = conn.exec!(echo_line).strip
-
-      # Throw an exception if it failed
-      if write != 'y'
-        fail Exception, "Unable to echo #{escaped_line} to the crontab"
-      end
+      conn.exec!(echo_line).to_s.strip
 
       # Check the line is there
-      tail = conn.exec!('tail -n 1 /etc/crontab').strip
+      tail = conn.exec!('tail -n 1 /etc/crontab').to_s.strip
 
       # Throw an exception if we can't see our new line at the end of the file
       if tail != line
@@ -123,10 +164,10 @@ module Minicron
       conn ||= @ssh.open
 
       # We are looking for the current value of the schedule
-      find = build_minicron_command(job.command, old_schedule)
+      find = build_minicron_command(old_schedule, job.user, job.command)
 
       # And replacing it with the updated value
-      replace = build_minicron_command(job.command, new_schedule)
+      replace = build_minicron_command(new_schedule, job.user, job.command)
 
       # Replace the old schedule with the new schedule
       find_and_replace(conn, find, replace)
@@ -142,7 +183,7 @@ module Minicron
       conn ||= @ssh.open
 
       # We are looking for the current value of the schedule
-      find = build_minicron_command(job.command, schedule)
+      find = build_minicron_command(schedule, job.user, job.command)
 
       # Replace the old schedule with nothing i.e deleting it
       find_and_replace(conn, find, '')