mini_sql 0.3 → 1.1.2

data/lib/mini_sql/sqlite/connection.rb

@@ -11,6 +11,14 @@ module MiniSql
         @deserializer_cache = (args && args[:deserializer_cache]) || DeserializerCache.new
       end
 
+      def prepared(condition = true)
+        if condition
+          @prepared ||= PreparedConnection.new(self, @deserializer_cache)
+        else
+          self
+        end
+      end
+
       def query_single(sql, *params)
         # a bit lazy can be optimized
         run(sql, *params).flatten!
@@ -68,7 +76,9 @@ module MiniSql
         end
         if block_given?
           stmt = SQLite3::Statement.new(raw_connection, sql)
-          yield stmt.execute
+          result = yield stmt.execute
+          stmt.close
+          result
         else
           raw_connection.execute(sql)
         end

data/lib/mini_sql/sqlite/deserializer_cache.rb

@@ -13,18 +13,20 @@ module MiniSql
 
       def materialize(result, decorator_module = nil)
 
-        key = result.columns
+        key = result.columns.join(',')
 
         # trivial fast LRU implementation
         materializer = @cache.delete(key)
         if materializer
           @cache[key] = materializer
         else
-          materializer = @cache[key] = new_row_matrializer(result)
+          materializer = @cache[key] = new_row_materializer(result)
           @cache.shift if @cache.length > @max_size
         end
 
-        materializer.include(decorator_module) if decorator_module
+        if decorator_module
+          materializer = materializer.decorated(decorator_module)
+        end
 
         r = []
         # quicker loop
@@ -39,22 +41,14 @@ module MiniSql
 
       private
 
-      def new_row_matrializer(result)
+      def new_row_materializer(result)
         fields = result.columns
 
         Class.new do
-          attr_accessor(*fields)
-
-          # AM serializer support
-          alias :read_attribute_for_serialization :send
+          extend MiniSql::Decoratable
+          include MiniSql::Result
 
-          def to_h
-            r = {}
-            instance_variables.each do |f|
-              r[f.to_s.sub('@', '').to_sym] = instance_variable_get(f)
-            end
-            r
-          end
+          attr_accessor(*fields)
 
           instance_eval <<~RUBY
             def materialize(data)

data/lib/mini_sql/sqlite/prepared_binds.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require "mini_sql/abstract/prepared_binds"
+
+module MiniSql
+  module Sqlite
+    class PreparedBinds < ::MiniSql::Abstract::PreparedBinds
+
+      def bind_output(i)
+        '?'
+      end
+
+    end
+  end
+end

data/lib/mini_sql/sqlite/prepared_cache.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "mini_sql/abstract/prepared_cache"
+
+module MiniSql
+  module Sqlite
+    class PreparedCache < MiniSql::Abstract::PreparedCache
+
+      private
+
+      def alloc(sql)
+        @connection.prepare(sql)
+      end
+
+      def dealloc(statement)
+        statement.close unless statement.closed?
+      end
+
+    end
+  end
+end

data/lib/mini_sql/sqlite/prepared_connection.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module MiniSql
+  module Sqlite
+    class PreparedConnection < Connection
+
+      attr_reader :unprepared
+
+      def initialize(unprepared_connection, deserializer_cache)
+        @unprepared         = unprepared_connection
+        @raw_connection     = unprepared_connection.raw_connection
+        @deserializer_cache = deserializer_cache
+        @param_encoder      = unprepared_connection.param_encoder
+
+        @prepared_cache     = PreparedCache.new(@raw_connection)
+        @param_binder       = PreparedBinds.new
+      end
+
+      def build(_)
+        raise 'Builder can not be called on prepared connections, instead of `::MINI_SQL.prepared.build(sql).query` use `::MINI_SQL.build(sql).prepared.query`'
+      end
+
+      def prepared(condition = true)
+        condition ? self : @unprepared
+      end
+
+      private def run(sql, params)
+        prepared_sql, binds, _bind_names = @param_binder.bind(sql, params)
+        statement = @prepared_cache.prepare_statement(prepared_sql)
+        statement.bind_params(binds)
+        if block_given?
+          yield statement.execute
+        else
+          statement.execute.to_a
+        end
+      end
+
+    end
+  end
+end

data/lib/mini_sql/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module MiniSql
-  VERSION = "0.3"
+  VERSION = "1.1.2"
 end

data/mini_sql.gemspec

@@ -25,11 +25,11 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  # rubocop:disable DiscoruseCops/NoChdir
+  # rubocop:disable Discourse/NoChdir
   spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  # rubocop:enable DiscoruseCops/NoChdir
+  # rubocop:enable Discourse/NoChdir
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "> 1.16"
@@ -38,8 +38,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "guard", "~> 2.14"
   spec.add_development_dependency "guard-minitest", "~> 2.4"
   spec.add_development_dependency "activesupport", "~> 5.2"
-  spec.add_development_dependency 'rubocop', '~> 0.79.0'
-  spec.add_development_dependency 'rubocop-discourse', '~> 1.0.2'
+  spec.add_development_dependency 'rubocop', '~> 1.4.0'
+  spec.add_development_dependency 'rubocop-discourse', '~> 2.4.1'
+  spec.add_development_dependency 'm', '~> 1.5.1'
 
   if RUBY_ENGINE == 'jruby'
     spec.add_development_dependency "activerecord-jdbcpostgresql-adapter", "~> 52.2"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_sql
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: 1.1.2
 platform: ruby
 authors:
 - Sam Saffron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-25 00:00:00.000000000 Z
+date: 2021-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -100,28 +100,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 1.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: rubocop-discourse
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 2.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: 2.4.1
+- !ruby/object:Gem::Dependency
+  name: m
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.1
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -171,10 +185,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop-https---raw-githubusercontent-com-discourse-discourse-master--rubocop-yml"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -182,25 +196,45 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bench/builder_perf.rb
+- bench/decorator_perf.rb
+- bench/mini_sql_methods_perf.rb
+- bench/prepared_perf.rb
+- bench/shared/generate_data.rb
 - bench/timestamp_perf.rb
 - bench/topic_mysql_perf.rb
 - bench/topic_perf.rb
+- bench/topic_wide_perf.rb
 - bin/console
 - bin/setup
 - lib/mini_sql.rb
+- lib/mini_sql/abstract/prepared_binds.rb
+- lib/mini_sql/abstract/prepared_cache.rb
 - lib/mini_sql/builder.rb
 - lib/mini_sql/connection.rb
+- lib/mini_sql/decoratable.rb
 - lib/mini_sql/deserializer_cache.rb
 - lib/mini_sql/inline_param_encoder.rb
 - lib/mini_sql/mysql/connection.rb
 - lib/mini_sql/mysql/deserializer_cache.rb
+- lib/mini_sql/mysql/prepared_binds.rb
+- lib/mini_sql/mysql/prepared_cache.rb
+- lib/mini_sql/mysql/prepared_connection.rb
 - lib/mini_sql/postgres/coders.rb
 - lib/mini_sql/postgres/connection.rb
 - lib/mini_sql/postgres/deserializer_cache.rb
+- lib/mini_sql/postgres/prepared_binds.rb
+- lib/mini_sql/postgres/prepared_cache.rb
+- lib/mini_sql/postgres/prepared_connection.rb
 - lib/mini_sql/postgres_jdbc/connection.rb
 - lib/mini_sql/postgres_jdbc/deserializer_cache.rb
+- lib/mini_sql/result.rb
+- lib/mini_sql/serializer.rb
 - lib/mini_sql/sqlite/connection.rb
 - lib/mini_sql/sqlite/deserializer_cache.rb
+- lib/mini_sql/sqlite/prepared_binds.rb
+- lib/mini_sql/sqlite/prepared_cache.rb
+- lib/mini_sql/sqlite/prepared_connection.rb
 - lib/mini_sql/version.rb
 - mini_sql.gemspec
 homepage: https://github.com/discourse/mini_sql
@@ -225,7 +259,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.2
 signing_key:
 specification_version: 4
 summary: A fast, safe, simple direct SQL executor

data/.travis.yml

@@ -1,28 +0,0 @@
-language: ruby
-rvm:
-  - 2.5
-  - 2.6
-  - 2.7
-  - ruby-head
-
-before_install:
-  - gem install bundler
-
-cache: bundler
-sudo: false
-
-services:
-  - mysql
-
-addons:
-  postgresql: 9.6
-  mysql: 5.7
-
-install:
-  - createdb test_mini_sql
-  - mysql -e 'CREATE DATABASE test_mini_sql;'
-  - bundle install
-
-matrix:
-  allow_failures:
-    - rvm: ruby-head