mini_racer 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fef1f817dc1b549c08a4755afd1c767ea3bdfc34f44febd1792df24f867f28e8
-  data.tar.gz: 559080d182a14c5c52215d119afb9e79aec02a11a976b39b18088cb0841cbc6e
+  metadata.gz: 5923ad9b3aa9cdea7785f0f2eb3fa27357217d0feb5ed439dad46b5ea7eaea8f
+  data.tar.gz: ffac8a1b740c74467f40e0200730a3fe25892d63105022f8775fe8aaffdcdd20
 SHA512:
-  metadata.gz: b88dd39b59e72befdecc2312096e32e6fd79ee0822ea9ae2b319cfec4fc1327c1092a84bf8c30db721a7309fe279e009b2939cef9ce8334094cd701aea229540
-  data.tar.gz: 691b89578567b3fa2325f15a13a294f8cad664897fd0e966b78dfb13eae455abfb51d489ca73ffb166738b46a0e37b8ad8ccc225205170d19c58322e11ff10b3
+  metadata.gz: 0f8ab9852328121e3d55119fb1a2a8a875806b0a256d2c79ab09846fe2ed7df174beb68949213057fe8186376b73993b21dc21fe22ce82632f26e0a4354c982e
+  data.tar.gz: 88c0a37a5a26ab746312c76499a202578a0604098a1ec3fcf7b98110aace6facd95490b19bd0f6abb8afba136b9ae94f5f1367d55050d6abdcf62bd628d6b8f2

data/CHANGELOG

@@ -1,3 +1,9 @@
+- 0.19.0 - 24-06-2025
+  - upgrade to node 24.1.0 
+
+- 0.18.1 - 03-04-2025
+  - Convert round doubles to fixnum for very big floats - this has better parity with JavaScript - Ben Noorhuis
+
 - 0.18.0 - 05-03-2025
   - Time for a major release
   - Handle ActiveSupport TimeWithZone objects during serialization - Sam Saffron

data/ext/mini_racer_extension/mini_racer_extension.c

@@ -1,8 +1,10 @@
 #include <stdatomic.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <pthread.h>
+#include <math.h>
 
 #include "ruby.h"
 #include "ruby/encoding.h"
@@ -282,7 +284,11 @@ static void des_int(void *arg, int64_t v)
 
 static void des_num(void *arg, double v)
 {
-    put(arg, DBL2NUM(v));
+    if (isfinite(v) && v == trunc(v) && v >= INT64_MIN && v <= INT64_MAX) {
+        put(arg, LONG2FIX(v));
+    } else {
+        put(arg, DBL2NUM(v));
+    }
 }
 
 static void des_date(void *arg, double v)
@@ -321,8 +327,19 @@ static void des_bigint(void *arg, const void *p, size_t n, int sign)
     if (t >> 63)
         *a++ = 0; // suppress sign extension
     v = rb_big_unpack(limbs, a-limbs);
-    if (sign < 0)
-        v = rb_big_mul(v, LONG2FIX(-1));
+    if (sign < 0) {
+        // rb_big_unpack returns T_FIXNUM for smallish bignums
+        switch (TYPE(v)) {
+        case T_BIGNUM:
+            v = rb_big_mul(v, LONG2FIX(-1));
+            break;
+        case T_FIXNUM:
+            v = LONG2FIX(-1 * FIX2LONG(v));
+            break;
+        default:
+            abort();
+        }
+    }
     put(c, v);
 }
 
@@ -614,14 +631,16 @@ static int serialize1(Ser *s, VALUE refs, VALUE v)
             struct timeval tv = rb_time_timeval(v);
             ser_date(s, tv.tv_sec*1e3 + tv.tv_usec/1e3);
         } else {
-	    snprintf(s->err, sizeof(s->err), "unsupported type %s", rb_class2name(CLASS_OF(v)));
-	    return -1;
+            snprintf(s->err, sizeof(s->err), "unsupported type %s", rb_class2name(CLASS_OF(v)));
+            return -1;
         }
         break;
     default:
         snprintf(s->err, sizeof(s->err), "unsupported type %x", TYPE(v));
         return -1;
     }
+    if (*s->err)
+        return -1;
     return 0;
 }
 

data/ext/mini_racer_extension/mini_racer_v8.cc

@@ -192,6 +192,24 @@ bool reply(State& st, v8::Local<v8::Value> result, v8::Local<v8::Value> err)
     return true;
 }
 
+// for when a reply is not expected to fail because of serialization
+// errors but can still fail when preempted by isolate termination;
+// temporarily cancels the termination exception so it can send the reply
+void reply_retry(State& st, v8::Local<v8::Value> response)
+{
+    v8::TryCatch try_catch(st.isolate);
+    try_catch.SetVerbose(st.verbose_exceptions);
+    bool ok = reply(st, response);
+    while (!ok) {
+        assert(try_catch.HasCaught());
+        assert(try_catch.HasTerminated());
+        if (!try_catch.HasTerminated()) abort();
+        st.isolate->CancelTerminateExecution();
+        ok = reply(st, response);
+        st.isolate->TerminateExecution();
+    }
+}
+
 v8::Local<v8::Value> sanitize(State& st, v8::Local<v8::Value> v)
 {
     // punch through proxies
@@ -434,7 +452,7 @@ extern "C" void v8_attach(State *pst, const uint8_t *p, size_t n)
 fail:
     if (!cause && try_catch.HasCaught()) cause = RUNTIME_ERROR;
     auto err = to_error(st, &try_catch, cause);
-    if (!reply(st, err)) abort();
+    reply_retry(st, err);
 }
 
 // response is errback [result, err] array
@@ -590,7 +608,7 @@ extern "C" void v8_heap_stats(State *pst)
     PROP(number_of_native_contexts);
     PROP(number_of_detached_contexts);
 #undef PROP
-    if (!reply(st, response)) abort();
+    reply_retry(st, response);
 }
 
 struct OutputStream : public v8::OutputStream
@@ -641,7 +659,7 @@ fail:
         st.err_reason = NO_ERROR;
     }
     auto result = v8::Boolean::New(st.isolate, ran_task);
-    if (!reply(st, result)) abort();
+    reply_retry(st, result);
 }
 
 int snapshot(bool is_warmup, bool verbose_exceptions,

data/ext/mini_racer_extension/serde.c

@@ -239,15 +239,44 @@ static void ser_num(Ser *s, double v)
     }
 }
 
+// ser_bigint: |n| is in bytes, not quadwords
+static void ser_bigint(Ser *s, const uint64_t *p, size_t n, int sign)
+{
+    if (*s->err)
+        return;
+    if (n % 8) {
+        snprintf(s->err, sizeof(s->err), "bad bigint");
+        return;
+    }
+    w_byte(s, 'Z');
+    // chop off high all-zero words
+    n /= 8;
+    while (n--)
+        if (p[n])
+            break;
+    if (n == (size_t)-1) {
+        w_byte(s, 0); // normalized zero
+    } else {
+        n = 8*n + 8;
+        w_varint(s, 2*n + (sign < 0));
+        w(s, p, n);
+    }
+}
+
 static void ser_int(Ser *s, int64_t v)
 {
+    uint64_t t;
+    int sign;
+
     if (*s->err)
         return;
     if (v < INT32_MIN || v > INT32_MAX) {
         if (v > INT64_MIN/1024)
             if (v <= INT64_MAX/1024)
                 return ser_num(s, v);
-        snprintf(s->err, sizeof(s->err), "out of range: %lld", (long long)v);
+        t = v < 0 ? -v : v;
+        sign = v < 0 ? -1 : 1;
+        ser_bigint(s, &t, sizeof(t), sign);
     } else {
         w_byte(s, 'I');
         w_zigzag(s, v);
@@ -265,30 +294,6 @@ static void ser_date(Ser *s, double v)
     }
 }
 
-// ser_bigint: |n| is in bytes, not quadwords
-static void ser_bigint(Ser *s, const uint64_t *p, size_t n, int sign)
-{
-    if (*s->err)
-        return;
-    if (n % 8) {
-        snprintf(s->err, sizeof(s->err), "bad bigint");
-        return;
-    }
-    w_byte(s, 'Z');
-    // chop off high all-zero words
-    n /= 8;
-    while (n--)
-        if (p[n])
-            break;
-    if (n == (size_t)-1) {
-        w_byte(s, 0); // normalized zero
-    } else {
-        n = 8*n + 8;
-        w_varint(s, 2*n + (sign < 0));
-        w(s, p, n);
-    }
-}
-
 // string must be utf8
 static void ser_string(Ser *s, const char *p, size_t n)
 {

data/lib/mini_racer/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module MiniRacer
-  VERSION = "0.18.0"
-  LIBV8_NODE_VERSION = "~> 23.6.1.0"
+  VERSION = "0.19.0"
+  LIBV8_NODE_VERSION = "~> 24.1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_racer
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Sam Saffron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-05 00:00:00.000000000 Z
+date: 2025-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 23.6.1.0
+        version: 24.1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 23.6.1.0
+        version: 24.1.0.0
 description: Minimal embedded v8 engine for Ruby
 email:
 - sam.saffron@gmail.com
@@ -137,9 +137,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/discourse/mini_racer/issues
-  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.18.0/CHANGELOG
-  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.18.0
-  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.18.0
+  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.19.0/CHANGELOG
+  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.19.0
+  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.19.0
 post_install_message:
 rdoc_options: []
 require_paths: