mini_racer 0.17.0.pre7 → 0.17.0.pre8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d058a397309a0e5354576fa25b299f26e9ca9576b23333063dbcd46fcf9f775
-  data.tar.gz: 3dde7c0c2e713ebb419593eb6fb0d7634f07ee4d91e35549aa9fb57987a255e5
+  metadata.gz: 6a4649daa0104376800784775a305593ff637dbde023f27ed6d9126b77c54548
+  data.tar.gz: e46ffb00764e6113cef170508d8ed1ac4b68cab29ace1051fc7c5df4c7d97f07
 SHA512:
-  metadata.gz: 8cf3e4c85acafb8161ff8a88d193b7bfde7e2b1ab241366364306a72416f462cbd31b4886a3b1f01402557a6045fd6ad40b1837849f307df9d3ac3fafdd7c6d0
-  data.tar.gz: a08db269e750b147daa7501cdf38dccdee8de7d07530b0112aecd1da3949b8daab704c778f1b3657d0dea328b087db9173f30e9aeb43f9d755d4a95dd1e51bac
+  metadata.gz: 38202ee576c23d016afd7b69ba9bada8ca47a82c3a460c028a42e25c23438f965e4ac2e8d6c4a24bea7211bed6436a9f2cc55bc4c9c0c42fd6b8e5054602c8f5
+  data.tar.gz: e8da8f6787111b63e698db0964a9ad35ffe62c1acca83db7efa08cdb7db94d8d68ed39b989f81fd77b310fff510790d16454761f083bc5bd1154105f93c20f6f

data/CHANGELOG

@@ -1,3 +1,7 @@
+- 0.17.0.pre8 - 11-01-2025
+  - Fix handling of UTF 32 LE and Ascii encoding strings - Ben Noordhuis
+  - Handle rare edge case in V8 serialization - Ben Noordhuis
+
 - 0.17.0.pre7 - 10-01-2025
 
   - Objects containing non serializable properties will return an Error object vs raising an exception. Ben Noordhuis

data/ext/mini_racer_extension/mini_racer_extension.c

@@ -422,6 +422,25 @@ static int collect(VALUE k, VALUE v, VALUE a)
     return ST_CONTINUE;
 }
 
+static void add_string(Ser *s, VALUE v)
+{
+    rb_encoding *e;
+    const void *p;
+    size_t n;
+
+    Check_Type(v, T_STRING);
+    e = rb_enc_get(v);
+    p = RSTRING_PTR(v);
+    n = RSTRING_LEN(v);
+    if (e) {
+        if (!strcmp(e->name, "ISO-8859-1"))
+            return ser_string8(s, p, n);
+        if (!strcmp(e->name, "UTF-16LE"))
+            return ser_string16(s, p, n);
+    }
+    return ser_string(s, p, n);
+}
+
 static int serialize1(Ser *s, VALUE refs, VALUE v)
 {
     unsigned long limbs[64];
@@ -525,7 +544,7 @@ static int serialize1(Ser *s, VALUE refs, VALUE v)
         v = rb_sym2str(v);
         // fallthru
     case T_STRING:
-        ser_string(s, RSTRING_PTR(v), RSTRING_LENINT(v));
+        add_string(s, v);
         break;
     default:
         snprintf(s->err, sizeof(s->err), "unsupported type %x", TYPE(v));
@@ -1062,7 +1081,7 @@ static VALUE context_attach(VALUE self, VALUE name, VALUE proc)
     // request is (A)ttach, [name, id] array
     ser_init1(&s, 'A');
     ser_array_begin(&s, 2);
-    ser_string(&s, RSTRING_PTR(name), RSTRING_LENINT(name));
+    add_string(&s, name);
     ser_int(&s, RARRAY_LENINT(c->procs));
     ser_array_end(&s, 2);
     rb_ary_push(c->procs, proc);
@@ -1159,8 +1178,8 @@ static VALUE context_eval(int argc, VALUE *argv, VALUE self)
     // request is (E)val, [filename, source] array
     ser_init1(&s, 'E');
     ser_array_begin(&s, 2);
-    ser_string(&s, RSTRING_PTR(filename), RSTRING_LENINT(filename));
-    ser_string(&s, RSTRING_PTR(source), RSTRING_LENINT(source));
+    add_string(&s, filename);
+    add_string(&s, source);
     ser_array_end(&s, 2);
     // response is [result, errname] array
     a = rendezvous(c, &s.b); // takes ownership of |s.b|
@@ -1462,7 +1481,7 @@ static VALUE snapshot_initialize(int argc, VALUE *argv, VALUE self)
     TypedData_Get_Struct(cv, Context, &context_type, c);
     // request is snapsho(T), "code"
     ser_init1(&s, 'T');
-    ser_string(&s, RSTRING_PTR(code), RSTRING_LENINT(code));
+    add_string(&s, code);
     // response is [arraybuffer, error]
     a = rendezvous(c, &s.b);
     e = rb_ary_pop(a);
@@ -1489,7 +1508,7 @@ static VALUE snapshot_warmup(VALUE self, VALUE arg)
     ser_init1(&s, 'W');
     ser_array_begin(&s, 2);
     ser_string8(&s, (const uint8_t *)RSTRING_PTR(ss->blob), RSTRING_LENINT(ss->blob));
-    ser_string(&s, RSTRING_PTR(arg), RSTRING_LENINT(arg));
+    add_string(&s, arg);
     ser_array_end(&s, 2);
     // response is [arraybuffer, error]
     a = rendezvous(c, &s.b);

data/ext/mini_racer_extension/serde.c

@@ -303,6 +303,14 @@ static void ser_string8(Ser *s, const uint8_t *p, size_t n)
     w(s, p, n);
 }
 
+// string must be utf16le; |n| is in bytes, not code points
+static void ser_string16(Ser *s, const void *p, size_t n)
+{
+    w_byte(s, 'c');
+    w_varint(s, n);
+    w(s, p, n);
+}
+
 static void ser_object_begin(Ser *s)
 {
     w_byte(s, 'o');
@@ -362,6 +370,7 @@ static int des1(char (*err)[64], const uint8_t **p, const uint8_t *pe,
 
     if (depth < 0)
         return bail(err, "too much recursion");
+again:
     if (*p >= pe)
         goto too_short;
     switch ((c = *(*p)++)) {
@@ -372,7 +381,9 @@ static int des1(char (*err)[64], const uint8_t **p, const uint8_t *pe,
             snprintf(*err, sizeof(*err), "bad tag: %02x", c);
         }
         return -1;
-    case '\0': // padding
+    case '\0': // skip alignment padding for two-byte strings
+        if (*p < pe)
+            goto again;
         break;
     case '^':
         if (r_varint(p, pe, &u))

data/lib/mini_racer/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module MiniRacer
-  VERSION = "0.17.0.pre7"
+  VERSION = "0.17.0.pre8"
   LIBV8_NODE_VERSION = "~> 22.7.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_racer
 version: !ruby/object:Gem::Version
-  version: 0.17.0.pre7
+  version: 0.17.0.pre8
 platform: ruby
 authors:
 - Sam Saffron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-09 00:00:00.000000000 Z
+date: 2025-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,9 +123,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/discourse/mini_racer/issues
-  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.17.0.pre7/CHANGELOG
-  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.17.0.pre7
-  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.17.0.pre7
+  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.17.0.pre8/CHANGELOG
+  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.17.0.pre8
+  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.17.0.pre8
 post_install_message:
 rdoc_options: []
 require_paths: