mini_racer 0.17.0.pre11 → 0.17.0.pre13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6851fdd7226dd520cf865af8b60e64b3456a0b0cfd31a22d4f275495c8f42aef
-  data.tar.gz: ffd5db728de9571a2b7e7d83348a95b658809d36f869050338c1f5b0a814146b
+  metadata.gz: 02c93cf015b4c5e591ce5f6b3f61b787c3c12ea1d98b33dde6879461140ef9bd
+  data.tar.gz: f77c6dbdee02fedcea41a2fe077aa71bc30c2c0dbc0630a1c09ebc90f075e4a1
 SHA512:
-  metadata.gz: 76e7edac2249f6aa850bd03f1a7d4c353095f4e3f0a89466c83763f945de44ac68881b57d5b784ac7b6391dd467812a7d27eeeba98ba13624f60dbe4e1db70ab
-  data.tar.gz: 9519ee4b2601ab14a0a1898518bdcda5f318b66b4b4631d7881c2e83ea656c461cbf3fa38682d8702234e01d1cad7c2358125c9b4689333db686ca7207b27fc0
+  metadata.gz: 5b9370d3e4aa2bb017e9c450651381bc3b11880bcfee9448949cdc1cb0a7c01a3bb0836112c10a32d2f9c199c687cea16a5374142e9ba5201b5c526e524b09dc
+  data.tar.gz: fecf25f26fa787280cc22eccd13deeee4dd554a36ee23e347149bc4e6d34b6a5eab623b8454d6ad0b6ad685e06e47cf8d45625ee015b033a1ed115ffb931e181

data/CHANGELOG

@@ -1,3 +1,9 @@
+- 0.17.0.pre13 - 04-02-2025
+  - Only issue idle GC once post dispatch - reduces CPU usage for auto cleanup - Sam Saffron
+
+- 0.17.0.pre12 - 23-01-2025
+  - Corrected off-by-one error with object serialization - Ben Noordhuis
+
 - 0.17.0.pre11 - 21-01-2025
   - Corrected encoding bug with deserialization of strings - Ben Noordhuis
 

data/ext/mini_racer_extension/mini_racer_extension.c

@@ -611,6 +611,13 @@ static int serialize1(Ser *s, VALUE refs, VALUE v)
     return 0;
 }
 
+// don't mix with ser_array_begin/ser_object_begin because
+// that will throw off the object reference count
+static int serialize(Ser *s, VALUE v)
+{
+    return serialize1(s, rb_hash_new(), v);
+}
+
 static struct timespec deadline_ms(int ms)
 {
     static const int64_t ns_per_sec = 1000*1000*1000;
@@ -721,6 +728,7 @@ static void dispatch(Context *c)
 void v8_thread_main(Context *c, struct State *pst)
 {
     struct timespec deadline;
+    bool issued_idle_gc = true;
 
     c->pst = pst;
     barrier_wait(&c->late_init);
@@ -730,8 +738,10 @@ void v8_thread_main(Context *c, struct State *pst)
             if (c->idle_gc > 0) {
                 deadline = deadline_ms(c->idle_gc);
                 pthread_cond_timedwait(&c->cv, &c->mtx, &deadline);
-                if (deadline_exceeded(deadline))
+                if (deadline_exceeded(deadline) && !issued_idle_gc) {
                     v8_low_memory_notification(c->pst);
+                    issued_idle_gc = true;
+                }
             } else {
                 pthread_cond_wait(&c->cv, &c->mtx);
             }
@@ -739,6 +749,7 @@ void v8_thread_main(Context *c, struct State *pst)
         if (!c->req.len)
             continue; // spurious wakeup or quit signal from other thread
         dispatch(c);
+        issued_idle_gc = false;
         pthread_cond_signal(&c->cv);
     }
 }
@@ -859,18 +870,11 @@ static void *rendezvous_callback(void *arg)
         goto fail;
     }
     ser_init1(&s, 'c'); // callback reply
-    ser_array_begin(&s, 2);
-    // either [result, undefined] or [undefined, err]
-    if (exc)
-        ser_undefined(&s);
-    if (serialize1(&s, rb_hash_new(), r)) { // should not happen
+    if (serialize(&s, r)) { // should not happen
         c->exception = rb_exc_new_cstr(internal_error, s.err);
         ser_reset(&s);
         goto fail;
     }
-    if (!exc)
-        ser_undefined(&s);
-    ser_array_end(&s, 2);
 out:
     buf_move(&s.b, a->req);
     return NULL;
@@ -1202,25 +1206,21 @@ static VALUE context_stop(VALUE self)
 
 static VALUE context_call(int argc, VALUE *argv, VALUE self)
 {
-    VALUE a, e, h;
+    VALUE name, args;
+    VALUE a, e;
     Context *c;
-    int i;
     Ser s;
 
     TypedData_Get_Struct(self, Context, &context_type, c);
-    rb_scan_args(argc, argv, "1*", &a, &e);
-    Check_Type(a, T_STRING);
+    rb_scan_args(argc, argv, "1*", &name, &args);
+    Check_Type(name, T_STRING);
+    rb_ary_unshift(args, name);
     // request is (C)all, [name, args...] array
     ser_init1(&s, 'C');
-    ser_array_begin(&s, argc);
-    h = rb_hash_new();
-    for (i = 0; i < argc; i++) {
-        if (serialize1(&s, h, argv[i])) {
-            ser_reset(&s);
-            rb_raise(runtime_error, "Context.call: %s", s.err);
-        }
+    if (serialize(&s, args)) {
+        ser_reset(&s);
+        rb_raise(runtime_error, "Context.call: %s", s.err);
     }
-    ser_array_end(&s, argc);
     // response is [result, err] array
     a = rendezvous(c, &s.b); // takes ownership of |s.b|
     e = rb_ary_pop(a);

data/ext/mini_racer_extension/mini_racer_v8.cc

@@ -378,18 +378,7 @@ void v8_api_callback(const v8::FunctionCallbackInfo<v8::Value>& info)
     des.ReadHeader(st.context).Check();
     v8::Local<v8::Value> result;
     if (!des.ReadValue(st.context).ToLocal(&result)) return; // exception pending
-    v8::Local<v8::Object> response; // [result, err]
-    if (!result->ToObject(st.context).ToLocal(&response)) return;
-    v8::Local<v8::Value> err;
-    if (!response->Get(st.context, 1).ToLocal(&err)) return;
-    if (err->IsUndefined()) {
-        if (!response->Get(st.context, 0).ToLocal(&result)) return;
-        info.GetReturnValue().Set(result);
-    } else {
-        v8::Local<v8::String> message;
-        if (!err->ToString(st.context).ToLocal(&message)) return;
-        st.isolate->ThrowException(v8::Exception::Error(message));
-    }
+    info.GetReturnValue().Set(result);
 }
 
 // response is err or empty string

data/lib/mini_racer/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module MiniRacer
-  VERSION = "0.17.0.pre11"
+  VERSION = "0.17.0.pre13"
   LIBV8_NODE_VERSION = "~> 22.7.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_racer
 version: !ruby/object:Gem::Version
-  version: 0.17.0.pre11
+  version: 0.17.0.pre13
 platform: ruby
 authors:
 - Sam Saffron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-20 00:00:00.000000000 Z
+date: 2025-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,9 +123,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/discourse/mini_racer/issues
-  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.17.0.pre11/CHANGELOG
-  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.17.0.pre11
-  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.17.0.pre11
+  changelog_uri: https://github.com/discourse/mini_racer/blob/v0.17.0.pre13/CHANGELOG
+  documentation_uri: https://www.rubydoc.info/gems/mini_racer/0.17.0.pre13
+  source_code_uri: https://github.com/discourse/mini_racer/tree/v0.17.0.pre13
 post_install_message:
 rdoc_options: []
 require_paths: