mini_phone 1.0.3 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f19ec27523bfdcd42b72b4421441b4016b4bf86c94f91f527e10bf5a33d1a16
-  data.tar.gz: 7ab2cf83930eaa1c35f7bf2a2faa7afded85238b8a69bf8822013f3f33ee274a
+  metadata.gz: 9fb40430cfcb4a6d8cc44557e7fb84622fe20cf14819c14f10a919dc5b9880e7
+  data.tar.gz: 5ad868da4e69d3b0ef3b91687863547ea876ec01e0bd2d7ae2e9bea1c8e16668
 SHA512:
-  metadata.gz: 853cc1202032f2c6f2fec744de57bfdabac907116fd1495060b65c5d51da060dbf317f253ca3179787f2de9162c7961e83d3f1c39909bbf7ae252262dcfaf7e4
-  data.tar.gz: 3965cf5f9798b3529eab55f0eb24b3532950f306005fca4655589d8d27c925028115a976fa623af6ca16e715aa6f8f9993cd8716779356f5c194b7cc5f7d4e6f
+  metadata.gz: df02fd332486b4b1c2775420377d2b478324b1b25de950268279ce6dd1875373dd4c7bc798300b0446cee72d7581d7338f4a0725d811a0ff317b7209bdebb4a7
+  data.tar.gz: a4130f908c91d8369665ec31174857ab6a2e7dc07b85f97008560a3d057db23a49dc39b85e53d0f61a290e0f89c8b320b2f5023041b0b19704bf66f9363ed672

data/Dockerfile.dev

@@ -0,0 +1,9 @@
+FROM ruby:2.7-alpine
+
+WORKDiR /app
+
+# RUN apt-get update -y && apt-get install -y valgrind libphonenumber
+RUN apk add --no-cache libphonenumber-dev valgrind git make libffi-dev build-base
+COPY Gemfile Gemfile.lock mini_phone.gemspec ./
+COPY lib/mini_phone/version.rb ./lib/mini_phone/version.rb
+RUN bundle install -j4

data/Gemfile

@@ -7,6 +7,7 @@ gemspec
 
 gem 'rake', require: false
 # https://github.com/rake-compiler/rake-compiler/pull/166
+gem 'get_process_mem', require: false
 gem 'rake-compiler', github: 'larskanis/rake-compiler', branch: 'fix-native-version'
 gem 'rspec', '~> 3.0', require: false
 gem 'rspec-github', require: false

data/README.md

@@ -1,9 +1,9 @@
 # MiniPhone
 
-A Ruby gem which plugs directly in the the Google's native C++
-[libphonenumber](https://github.com/google/libphonenumber) for extemely
+A Ruby gem which plugs directly into Google's native C++
+[libphonenumber](https://github.com/google/libphonenumber) for extremely
 _fast_ and _robust_ phone number parsing, validation, and formatting. On
-average, most methods are 40x t0 50x faster than other Ruby phone number
+average, most methods are 40x to 50x faster than other Ruby phone number
 libraries.
 
 ## Usage
@@ -23,10 +23,12 @@ MiniPhone.default_country = 'US'
 
 phone_number = MiniPhone.parse('404-384-1399')
 
-phone_number.e164          # +14043841399
-phone_number.national      # (404) 384-1399
-phone_number.international # +1 404-384-1399
-phone_number.rfc3966       # tel:+1-404-384-1384
+phone_number.e164                 # +14043841399
+phone_number.national             # (404) 384-1399
+phone_number.raw_national         # 4043841399
+phone_number.dasherized_national  # 404-384-1399
+phone_number.international        # +1 404-384-1399
+phone_number.rfc3966              # tel:+1-404-384-1384
 ```
 
 ### Checking if a phone number is possible
@@ -41,7 +43,7 @@ phone_number.possible? # false
 
 ```ruby
 MiniPhone.parse('+12423570000').type # :mobile
-MiniPhone.parse['+12423651234').type # :fixed_line
+MiniPhone.parse('+12423651234').type # :fixed_line
 ```
 
 The possible types are directly mapped from [this
@@ -65,14 +67,14 @@ enum](https://github.com/google/libphonenumber/blob/4e9954edea7cf263532c5dd3861a
 ## Compatibility with PhoneLib
 
 MiniPhone aims to be compatible with
-[Phonelib](https://github.com/daddyz/phonelib) so in many cases it can be a
-drop in replacement. It has a smaller feature set, so if you need it it not a
-drop in replacement for every use case. If there is a feature you need, open
+[Phonelib](https://github.com/daddyz/phonelib). In many cases it can be a
+drop in replacement. It has a smaller feature set, so it is not a
+replacement for every use case. If there is a feature you need, open
 an issue and we will try to support it.
 
 ## Benchmarks
 
-On average, most methods are 40x t0 50x faster than other libraries. To run
+On average, most methods are 40x to 50x faster than other libraries. To run
 the benchmarks locally, execute: `bundle exec rake bench`
 
 ```
@@ -132,10 +134,10 @@ push git commits and tags, and push the `.gem` file to
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at
-https://github.com/[USERNAME]/mini_phone. This project is intended to be a
+https://github.com/ianks/mini_phone. This project is intended to be a
 safe, welcoming space for collaboration, and contributors are expected to
 adhere to the [code of
-conduct](https://github.com/[USERNAME]/mini_phone/blob/master/CODE_OF_CONDUCT.md).
+conduct](https://github.com/ianks/mini_phone/blob/master/CODE_OF_CONDUCT.md).
 
 ## License
 
@@ -146,4 +148,4 @@ License](https://opensource.org/licenses/MIT).
 
 Everyone interacting in the MiniPhone project's codebases, issue trackers,
 chat rooms and mailing lists is expected to follow the [code of
-conduct](https://github.com/[USERNAME]/mini_phone/blob/master/CODE_OF_CONDUCT.md).
+conduct](https://github.com/ianks/mini_phone/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -32,6 +32,11 @@ task :lint do
   sh 'bundle exec rubocop'
 end
 
+task :format do
+  sh 'bundle exec rubocop -A'
+  sh 'clang-format -i ext/**/*.{h,cc}'
+end
+
 task deploy: :default do
   sh 'code -w ./lib/mini_phone/version.rb'
   version = `ruby -r ./lib/mini_phone/version.rb -e 'print MiniPhone::VERSION'`.strip
@@ -71,3 +76,21 @@ namespace :publish do
     push_to_github_registry(g)
   end
 end
+
+desc 'Run valgrind test'
+
+namespace :debug do
+  desc 'Plot memory'
+  task :memory do
+    sh 'debug/memory_plot/plot.sh'
+  end
+
+  task :valgrind do
+    sh 'docker build --tag mini_phone_dev -f Dockerfile.dev .'
+    args = '--tool=memcheck --num-callers=15 --partial-loads-ok=yes --undef-value-errors=no'
+    script = 'ruby debug/memory_plot/memory.rb --once'
+    cmd = "docker run -it --rm -v #{Dir.pwd}:/app -w /app mini_phone_dev valgrind #{args} #{script}"
+    puts cmd
+    system cmd
+  end
+end

data/debug/memory_plot/memory.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'mini_phone'
+require 'get_process_mem'
+
+10.times do
+  GC.start
+  GC.compact
+end
+
+$stdout.sync = true
+
+loop do
+  10_000.times do
+    pn = MiniPhone::PhoneNumber.new('+1 404 388 1299')
+    pn.e164
+    pn.valid?
+    pn.possible?
+    pn.raw_national
+    pn.international
+    pn.country_code
+    pn.area_code
+  end
+
+  4.times { GC.start }
+
+  memory_mb = GetProcessMem.new.mb
+
+  $stdout.puts memory_mb
+
+  break if ARGV.first == '--once'
+end

data/debug/memory_plot/plot.sh

@@ -0,0 +1,6 @@
+#!/bin/bash
+
+set -euo pipefail
+
+bundle exec rake compile
+exec ruby "$(dirname "$0")/memory.rb" | ttyplot

data/ext/mini_phone/mini_phone.cc

@@ -12,23 +12,47 @@ static VALUE rb_mMiniPhone;
 static VALUE rb_cPhoneNumber;
 
 static RepeatedPtrField<NumberFormat> raw_national_format;
+static RepeatedPtrField<NumberFormat> dasherized_national_format;
 
-extern "C" struct PhoneNumberInfo {
-  PhoneNumber phone_number;
-  std::string raw_phone_number;
-  std::string raw_country_code;
+extern "C" struct PhoneNumberInfo { PhoneNumber *phone_number; };
+
+extern "C" size_t phone_number_info_size(const void *data) { return sizeof(PhoneNumberInfo) + sizeof(PhoneNumber); }
+
+extern "C" void phone_number_info_free(void *data) {
+  PhoneNumberInfo *phone_number_info = static_cast<PhoneNumberInfo *>(data);
+  phone_number_info->phone_number->~PhoneNumber();
+  xfree(phone_number_info->phone_number);
+  phone_number_info->~PhoneNumberInfo();
+  xfree(data);
+}
+
+extern "C" const rb_data_type_t phone_number_info_type = {
+    .wrap_struct_name = "MiniPhone/PhoneNumberInfo",
+    .function =
+        {
+            .dmark = NULL,
+            .dfree = phone_number_info_free,
+            .dsize = phone_number_info_size,
+        },
+    .parent = NULL,
+    .data = NULL,
+    .flags = RUBY_TYPED_FREE_IMMEDIATELY,
 };
 
 static inline VALUE is_phone_number_valid(VALUE self, VALUE str, VALUE cc) {
+  if (NIL_P(str) || NIL_P(cc)) {
+    return Qfalse;
+  }
+
   PhoneNumber parsed_number;
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
   std::string phone_number(RSTRING_PTR(str), RSTRING_LEN(str));
   std::string country_code(RSTRING_PTR(cc), RSTRING_LEN(cc));
 
-  auto result = phone_util->ParseAndKeepRawInput(phone_number, country_code, &parsed_number);
+  auto result = phone_util.ParseAndKeepRawInput(phone_number, country_code, &parsed_number);
 
-  if (result == PhoneNumberUtil::NO_PARSING_ERROR && phone_util->IsValidNumber(parsed_number)) {
+  if (result == PhoneNumberUtil::NO_PARSING_ERROR && phone_util.IsValidNumber(parsed_number)) {
     return Qtrue;
   } else {
     return Qfalse;
@@ -41,6 +65,20 @@ extern "C" VALUE rb_is_phone_number_valid(VALUE self, VALUE str) {
   return is_phone_number_valid(self, str, def_cc);
 }
 
+extern "C" VALUE rb_normalize_digits_only(VALUE self, VALUE str) {
+  if (NIL_P(str)) {
+    return Qnil;
+  }
+
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
+
+  std::string phone_number(RSTRING_PTR(str), RSTRING_LEN(str));
+
+  phone_util.NormalizeDigitsOnly(&phone_number);
+
+  return rb_str_new(phone_number.c_str(), phone_number.size());
+}
+
 extern "C" VALUE rb_is_phone_number_valid_for_country(VALUE self, VALUE str, VALUE cc) {
   return is_phone_number_valid(self, str, cc);
 }
@@ -54,16 +92,20 @@ extern "C" VALUE rb_is_phone_number_invalid_for_country(VALUE self, VALUE str, V
 }
 
 extern "C" VALUE rb_is_phone_number_possible(VALUE self, VALUE str) {
+  if (NIL_P(str)) {
+    return Qnil;
+  }
+
   PhoneNumber parsed_number;
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
   VALUE def_cc = rb_iv_get(rb_mMiniPhone, "@default_country");
   std::string phone_number(RSTRING_PTR(str), RSTRING_LEN(str));
   std::string country_code(RSTRING_PTR(def_cc), RSTRING_LEN(def_cc));
 
-  auto result = phone_util->Parse(phone_number, country_code, &parsed_number);
+  auto result = phone_util.Parse(phone_number, country_code, &parsed_number);
 
-  if (result == PhoneNumberUtil::NO_PARSING_ERROR && phone_util->IsPossibleNumber(parsed_number)) {
+  if (result == PhoneNumberUtil::NO_PARSING_ERROR && phone_util.IsPossibleNumber(parsed_number)) {
     return Qtrue;
   } else {
     return Qfalse;
@@ -75,28 +117,36 @@ extern "C" VALUE rb_is_phone_number_impossible(VALUE self, VALUE str) {
 }
 
 extern "C" VALUE rb_set_default_country(VALUE self, VALUE str_code) {
+  if (NIL_P(str_code)) {
+    str_code = rb_str_new("ZZ", 2);
+  }
+
   return rb_iv_set(self, "@default_country", str_code);
 }
 
 extern "C" VALUE rb_get_default_country(VALUE self) { return rb_iv_get(self, "@default_country"); }
 
-extern "C" void rb_phone_number_dealloc(PhoneNumberInfo *phone_number_info) { delete phone_number_info; }
-
 extern "C" VALUE rb_phone_number_parse(int argc, VALUE *argv, VALUE self) {
   return rb_class_new_instance(argc, argv, rb_cPhoneNumber);
 }
 
 extern "C" VALUE rb_phone_number_alloc(VALUE self) {
-  PhoneNumberInfo *phone_number_info = new PhoneNumberInfo();
+  void *phone_number_data = ALLOC(PhoneNumber);
+  void *data = ALLOC(PhoneNumberInfo);
+  PhoneNumberInfo *phone_number_info = new (data) PhoneNumberInfo();
+  PhoneNumber *phone_number = new (phone_number_data) PhoneNumber();
+  phone_number_info->phone_number = phone_number;
 
-  /* wrap */
-  return Data_Wrap_Struct(self, NULL, &rb_phone_number_dealloc, phone_number_info);
+  return TypedData_Wrap_Struct(self, &phone_number_info_type, phone_number_info);
 }
 
 static inline VALUE rb_phone_number_nullify_ivars(VALUE self) {
   rb_iv_set(self, "@national", Qnil);
   rb_iv_set(self, "@raw_national", Qnil);
+  rb_iv_set(self, "@dasherized_national", Qnil);
   rb_iv_set(self, "@international", Qnil);
+  rb_iv_set(self, "@raw_international", Qnil);
+  rb_iv_set(self, "@dasherized_international", Qnil);
   rb_iv_set(self, "@e164", Qnil);
   rb_iv_set(self, "@country_code", Qnil);
   rb_iv_set(self, "@region_code", Qnil);
@@ -104,6 +154,7 @@ static inline VALUE rb_phone_number_nullify_ivars(VALUE self) {
   rb_iv_set(self, "@type", Qnil);
   rb_iv_set(self, "@valid", Qfalse);
   rb_iv_set(self, "@possible", Qfalse);
+  rb_iv_set(self, "@area_code", Qnil);
 
   return Qtrue;
 }
@@ -129,19 +180,19 @@ extern "C" VALUE rb_phone_number_initialize(int argc, VALUE *argv, VALUE self) {
   PhoneNumberInfo *phone_number_info;
   PhoneNumber parsed_number;
 
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
 
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
   std::string phone_number(RSTRING_PTR(str), RSTRING_LEN(str));
   std::string country_code(RSTRING_PTR(def_cc), RSTRING_LEN(def_cc));
 
-  auto result = phone_util->Parse(phone_number, country_code, &parsed_number);
+  auto result = phone_util.Parse(phone_number, country_code, &parsed_number);
 
   if (result != PhoneNumberUtil::NO_PARSING_ERROR) {
     rb_phone_number_nullify_ivars(self);
   } else {
-    phone_number_info->phone_number = parsed_number;
+    phone_number_info->phone_number->Swap(&parsed_number);
   }
 
   return self;
@@ -150,11 +201,11 @@ extern "C" VALUE rb_phone_number_initialize(int argc, VALUE *argv, VALUE self) {
 static inline VALUE rb_phone_number_format(VALUE self, PhoneNumberUtil::PhoneNumberFormat fmt) {
   std::string formatted_number;
   PhoneNumberInfo *phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
 
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
-  PhoneNumber parsed_number = phone_number_info->phone_number;
-  phone_util->Format(parsed_number, fmt, &formatted_number);
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
+  PhoneNumber *parsed_number = phone_number_info->phone_number;
+  phone_util.Format(*parsed_number, fmt, &formatted_number);
 
   return rb_str_new(formatted_number.c_str(), formatted_number.size());
 }
@@ -192,22 +243,76 @@ extern "C" VALUE rb_phone_number_rfc3966(VALUE self) {
   return rb_iv_set(self, "@rfc3966", rb_phone_number_format(self, PhoneNumberUtil::PhoneNumberFormat::RFC3966));
 }
 
+VALUE format_by_pattern_national(VALUE self, RepeatedPtrField<NumberFormat> format) {
+  std::string formatted_number;
+  PhoneNumberInfo *phone_number_info;
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
+
+  phone_util.FormatByPattern(*phone_number_info->phone_number, PhoneNumberUtil::NATIONAL, format, &formatted_number);
+
+  return rb_str_new(formatted_number.c_str(), formatted_number.size());
+}
+
 extern "C" VALUE rb_phone_number_raw_national(VALUE self) {
   if (rb_ivar_defined(self, rb_intern("@raw_national"))) {
     return rb_iv_get(self, "@raw_national");
   }
 
-  std::string formatted_number;
+  VALUE result = format_by_pattern_national(self, raw_national_format);
+
+  return rb_iv_set(self, "@raw_national", result);
+}
+
+extern "C" VALUE rb_phone_number_dasherized_national(VALUE self) {
+  if (rb_ivar_defined(self, rb_intern("@dasherized_national"))) {
+    return rb_iv_get(self, "@dasherized_national");
+  }
+
+  VALUE result = format_by_pattern_national(self, dasherized_national_format);
+
+  return rb_iv_set(self, "@dasherized_national", result);
+}
+
+extern "C" VALUE rb_phone_number_country_code(VALUE self) {
+  if (rb_ivar_defined(self, rb_intern("@country_code"))) {
+    return rb_iv_get(self, "@country_code");
+  }
+
   PhoneNumberInfo *phone_number_info;
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
 
-  phone_util->FormatByPattern(phone_number_info->phone_number, PhoneNumberUtil::NATIONAL, raw_national_format,
-                              &formatted_number);
+  int code = phone_number_info->phone_number->country_code();
 
-  VALUE result = rb_str_new(formatted_number.c_str(), formatted_number.size());
+  VALUE result = INT2NUM(code);
 
-  return rb_iv_set(self, "@raw_national", result);
+  return rb_iv_set(self, "@country_code", result);
+}
+
+extern "C" VALUE rb_phone_number_dasherized_international(VALUE self) {
+  if (rb_ivar_defined(self, rb_intern("@dasherized_international"))) {
+    return rb_iv_get(self, "@dasherized_international");
+  }
+
+  VALUE national = rb_phone_number_dasherized_national(self);
+  VALUE cc = rb_fix2str(rb_phone_number_country_code(self), 10);
+  VALUE dash = rb_str_new("-", 1);
+  VALUE prefix = rb_str_concat(cc, dash);
+  VALUE result = rb_str_concat(prefix, national);
+
+  return rb_iv_set(self, "@dasherized_international", result);
+}
+
+extern "C" VALUE rb_phone_number_raw_international(VALUE self) {
+  if (rb_ivar_defined(self, rb_intern("@raw_international"))) {
+    return rb_iv_get(self, "@raw_international");
+  }
+
+  VALUE national = rb_phone_number_raw_national(self);
+  VALUE cc = rb_fix2str(rb_phone_number_country_code(self), 10);
+  VALUE result = rb_str_concat(cc, national);
+
+  return rb_iv_set(self, "@raw_international", result);
 }
 
 extern "C" VALUE rb_phone_number_valid_eh(VALUE self) {
@@ -217,11 +322,11 @@ extern "C" VALUE rb_phone_number_valid_eh(VALUE self) {
 
   std::string formatted_number;
   PhoneNumberInfo *phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
 
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
-  if (phone_util->IsValidNumber(phone_number_info->phone_number)) {
+  if (phone_util.IsValidNumber(*phone_number_info->phone_number)) {
     return rb_iv_set(self, "@valid", Qtrue);
   } else {
     return rb_iv_set(self, "@valid", Qfalse);
@@ -239,11 +344,11 @@ extern "C" VALUE rb_phone_number_possible_eh(VALUE self) {
 
   std::string formatted_number;
   PhoneNumberInfo *phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
 
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
-  if (phone_util->IsPossibleNumber(phone_number_info->phone_number)) {
+  if (phone_util.IsPossibleNumber(*phone_number_info->phone_number)) {
     return rb_iv_set(self, "@possible", Qtrue);
   } else {
     return rb_iv_set(self, "@possible", Qfalse);
@@ -261,44 +366,30 @@ extern "C" VALUE rb_phone_number_region_code(VALUE self) {
 
   PhoneNumberInfo *phone_number_info;
   std::string code;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
-  phone_util->GetRegionCodeForCountryCode(phone_number_info->phone_number.country_code(), &code);
+  phone_util.GetRegionCodeForCountryCode(phone_number_info->phone_number->country_code(), &code);
 
   VALUE result = rb_str_new(code.c_str(), code.size());
 
   return rb_iv_set(self, "@region_code", result);
 }
 
-extern "C" VALUE rb_phone_number_country_code(VALUE self) {
-  if (rb_ivar_defined(self, rb_intern("@country_code"))) {
-    return rb_iv_get(self, "@country_code");
-  }
-
-  PhoneNumberInfo *phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
-
-  int code = phone_number_info->phone_number.country_code();
-
-  VALUE result = INT2NUM(code);
-
-  return rb_iv_set(self, "@country_code", result);
-}
-
 extern "C" VALUE rb_phone_number_eql_eh(VALUE self, VALUE other) {
   if (!rb_obj_is_instance_of(other, rb_cPhoneNumber)) {
     return Qfalse;
   }
 
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
   PhoneNumberInfo *self_phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, self_phone_number_info);
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, self_phone_number_info);
 
   PhoneNumberInfo *other_phone_number_info;
-  Data_Get_Struct(other, PhoneNumberInfo, other_phone_number_info);
-  if (phone_util->IsNumberMatch(other_phone_number_info->phone_number, self_phone_number_info->phone_number)) {
+  TypedData_Get_Struct(other, PhoneNumberInfo, &phone_number_info_type, other_phone_number_info);
+
+  if (phone_util.IsNumberMatch(*other_phone_number_info->phone_number, *self_phone_number_info->phone_number)) {
     return Qtrue;
   } else {
     return Qfalse;
@@ -311,14 +402,14 @@ extern "C" VALUE rb_phone_number_type(VALUE self) {
   }
 
   PhoneNumberInfo *phone_number_info;
-  Data_Get_Struct(self, PhoneNumberInfo, phone_number_info);
-  PhoneNumberUtil *phone_util = PhoneNumberUtil::GetInstance();
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
 
   VALUE result;
 
   // @see
   // https://github.com/google/libphonenumber/blob/4e9954edea7cf263532c5dd3861a801104c3f012/cpp/src/phonenumbers/phonenumberutil.h#L91
-  switch (phone_util->GetNumberType(phone_number_info->phone_number)) {
+  switch (phone_util.GetNumberType(*phone_number_info->phone_number)) {
   case PhoneNumberUtil::PREMIUM_RATE:
     result = rb_intern("premium_rate");
     break;
@@ -360,7 +451,52 @@ extern "C" VALUE rb_phone_number_type(VALUE self) {
   return rb_iv_set(self, "@type", ID2SYM(result));
 }
 
+extern "C" VALUE rb_phone_number_area_code(VALUE self) {
+  if (rb_ivar_defined(self, rb_intern("@area_code"))) {
+    return rb_iv_get(self, "@area_code");
+  }
+
+  const PhoneNumberUtil &phone_util(*PhoneNumberUtil::GetInstance());
+  PhoneNumberInfo *phone_number_info;
+  TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
+
+  PhoneNumber *number = phone_number_info->phone_number;
+  string national_significant_number;
+  phone_util.GetNationalSignificantNumber(*number, &national_significant_number);
+  string area_code;
+  string subscriber_number;
+
+  int area_code_length = phone_util.GetLengthOfGeographicalAreaCode(*number);
+  if (area_code_length > 0) {
+    area_code = national_significant_number.substr(0, area_code_length);
+    subscriber_number = national_significant_number.substr(area_code_length, string::npos);
+  } else {
+    area_code = "";
+    subscriber_number = national_significant_number;
+  }
+
+  VALUE result = rb_str_new(area_code.c_str(), area_code.size());
+
+  return rb_iv_set(self, "@area_code", result);
+}
+
+extern "C" VALUE rb_phone_number_to_s(VALUE self) { return rb_iv_get(self, "@input"); }
+
+static inline void setup_formats() {
+  // Raw
+  NumberFormat *raw_fmt = raw_national_format.Add();
+  raw_fmt->set_pattern("(\\d{3})(\\d{3})(\\d{4})");
+  raw_fmt->set_format("$1$2$3");
+
+  // Dasherized
+  NumberFormat *dsh_fmt = dasherized_national_format.Add();
+  dsh_fmt->set_pattern("(\\d{3})(\\d{3})(\\d{4})");
+  dsh_fmt->set_format("$1-$2-$3");
+}
+
 extern "C" void Init_mini_phone(void) {
+  setup_formats();
+
   rb_mMiniPhone = rb_define_module("MiniPhone");
 
   // Unknown
@@ -380,6 +516,8 @@ extern "C" void Init_mini_phone(void) {
   rb_define_module_function(rb_mMiniPhone, "default_country", reinterpret_cast<VALUE (*)(...)>(rb_get_default_country),
                             0);
   rb_define_module_function(rb_mMiniPhone, "parse", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_parse), -1);
+  rb_define_module_function(rb_mMiniPhone, "normalize_digits_only",
+                            reinterpret_cast<VALUE (*)(...)>(rb_normalize_digits_only), 1);
 
   rb_cPhoneNumber = rb_define_class_under(rb_mMiniPhone, "PhoneNumber", rb_cObject);
 
@@ -393,15 +531,21 @@ extern "C" void Init_mini_phone(void) {
   rb_define_method(rb_cPhoneNumber, "e164", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_e164), 0);
   rb_define_method(rb_cPhoneNumber, "national", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_national), 0);
 
-  // Raw National
-  raw_national_format.Add()->set_format("$1$2$3");
-
   rb_define_method(rb_cPhoneNumber, "raw_national", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_raw_national), 0);
+  rb_define_method(rb_cPhoneNumber, "raw_international",
+                   reinterpret_cast<VALUE (*)(...)>(rb_phone_number_raw_international), 0);
+  rb_define_method(rb_cPhoneNumber, "dasherized_international",
+                   reinterpret_cast<VALUE (*)(...)>(rb_phone_number_dasherized_international), 0);
+  rb_define_method(rb_cPhoneNumber, "dasherized_national",
+                   reinterpret_cast<VALUE (*)(...)>(rb_phone_number_dasherized_national), 0);
   rb_define_method(rb_cPhoneNumber, "international", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_international),
                    0);
   rb_define_method(rb_cPhoneNumber, "rfc3966", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_rfc3966), 0);
   rb_define_method(rb_cPhoneNumber, "region_code", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_region_code), 0);
+  rb_define_method(rb_cPhoneNumber, "country", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_region_code), 0);
   rb_define_method(rb_cPhoneNumber, "country_code", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_country_code), 0);
   rb_define_method(rb_cPhoneNumber, "type", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_type), 0);
+  rb_define_method(rb_cPhoneNumber, "area_code", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_area_code), 0);
+  rb_define_method(rb_cPhoneNumber, "to_s", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_to_s), 0);
   rb_define_method(rb_cPhoneNumber, "eql?", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_eql_eh), 1);
 }

data/lib/mini_phone/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MiniPhone
-  VERSION = '1.0.3'
+  VERSION = '1.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_phone
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.1
 platform: ruby
 authors:
 - Ian Ker-Seymer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-08 00:00:00.000000000 Z
+date: 2021-01-19 00:00:00.000000000 Z
 dependencies: []
 description: Plugs directly in the the Google's native C++ [libphonenumber](https://github.com/google/libphonenumber)
   for extemely _fast_ and _robust_ phone number parsing, validation, and formatting.
@@ -22,10 +22,13 @@ extra_rdoc_files: []
 files:
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
+- Dockerfile.dev
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- debug/memory_plot/memory.rb
+- debug/memory_plot/plot.sh
 - ext/mini_phone/extconf.rb
 - ext/mini_phone/mini_phone.cc
 - ext/mini_phone/mini_phone.h